)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"28da0ef1cefa764c91824242c5987151806c6d27","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Not duplicate grub defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GRUB_TIMEOUT was duplicated in"},{"line_number":10,"context_line":"the /etc/grub/defaults."},{"line_number":11,"context_line":"Changing the DIB_GRUB_TIMEOUT default to the base"},{"line_number":12,"context_line":"image typical default."},{"line_number":13,"context_line":"Note: Hold shift if you want to interact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfc0c979_ceccb501","line":10,"updated":"2024-08-01 14:18:15.000000000","message":"Can you explain the motivation for this change? As far as I know these are shell environment var files and redefining variables is perfectly functional and valid.","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0340529a5ec453841d35c52b563ec6ab76694c03","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Not duplicate grub defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GRUB_TIMEOUT was duplicated in"},{"line_number":10,"context_line":"the /etc/grub/defaults."},{"line_number":11,"context_line":"Changing the DIB_GRUB_TIMEOUT default to the base"},{"line_number":12,"context_line":"image typical default."},{"line_number":13,"context_line":"Note: Hold shift if you want to interact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"937b2d06_239298c6","line":10,"in_reply_to":"29464798_bb6627cd","updated":"2024-08-05 17:36:04.000000000","message":"I believe this is the source code of grub2-mkconfig that loads vars from /etc/default/grub: https://github.com/rhboot/grub2/blob/fedora-41/util/grub-mkconfig.in#L179 it does so using `.` so it should be fine to override variables later in the file.","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77583dacd44937d740b026e59a839f7e033ddb1f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Not duplicate grub defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GRUB_TIMEOUT was duplicated in"},{"line_number":10,"context_line":"the /etc/grub/defaults."},{"line_number":11,"context_line":"Changing the DIB_GRUB_TIMEOUT default to the base"},{"line_number":12,"context_line":"image typical default."},{"line_number":13,"context_line":"Note: Hold shift if you want to interact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"29464798_bb6627cd","line":10,"in_reply_to":"8fba426b_d68e0755","updated":"2024-08-05 17:23:57.000000000","message":"This still doesn\u0027t explain why this is needed. Is it a bug to override entries in `/etc/defaults/grub` or is the bug in software elsewhere not properly interpreting the variables. Additionally that issue doesn\u0027t seem to explain the inconsistent behavior so it is really hard to understand what is actually broken.\n\nMostly want to make sure we aren\u0027t papering over a bug somewhere else. Though this workaround may still be valuable while other thing get fixed (if they need to be fixed at all).","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c4b9f15894d7041038a2a781f54c6052685e4dac","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Not duplicate grub defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GRUB_TIMEOUT was duplicated in"},{"line_number":10,"context_line":"the /etc/grub/defaults."},{"line_number":11,"context_line":"Changing the DIB_GRUB_TIMEOUT default to the base"},{"line_number":12,"context_line":"image typical default."},{"line_number":13,"context_line":"Note: Hold shift if you want to interact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"19767282_990da19e","line":10,"in_reply_to":"937b2d06_239298c6","updated":"2024-08-07 01:04:49.000000000","message":"The problem is that some base images (for example centos[1]) already have values for GRUB_TIMEOUT, so always appending results in multiple values with duplicate variable names. This has proven confusing to at least one end user.\n\n[1] virt-cat -a CentOS-Stream-GenericCloud-x86_64-9-latest.x86_64.qcow2 /etc/default/grub\n\n    GRUB_TIMEOUT\u003d1\n    GRUB_DISTRIBUTOR\u003d\"$(sed \u0027s, release .*$,,g\u0027 /etc/system-release)\"\n    GRUB_DEFAULT\u003dsaved\n    GRUB_DISABLE_SUBMENU\u003dtrue\n    GRUB_TERMINAL_OUTPUT\u003d\"console\"\n    GRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0,115200n8 no_timer_check net.ifnames\u003d0 crashkernel\u003d1G-4G:192M,4G-64G:256M,64G-:512M\"\n    GRUB_DISABLE_RECOVERY\u003d\"true\"\n    GRUB_ENABLE_BLSCFG\u003dtrue","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"5ef5e354af7710e6c6cd8a568c2d5f405a0a158b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Not duplicate grub defaults"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The GRUB_TIMEOUT was duplicated in"},{"line_number":10,"context_line":"the /etc/grub/defaults."},{"line_number":11,"context_line":"Changing the DIB_GRUB_TIMEOUT default to the base"},{"line_number":12,"context_line":"image typical default."},{"line_number":13,"context_line":"Note: Hold shift if you want to interact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8fba426b_d68e0755","line":10,"in_reply_to":"bfc0c979_ceccb501","updated":"2024-08-02 07:06:58.000000000","message":"Originally requested from https://bugzilla.redhat.com/show_bug.cgi?id\u003d2299923 .","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"52095853e38489140552814c4230230b35e97ff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fa779a2_3c891538","updated":"2024-08-01 13:38:43.000000000","message":"I\u0027m kind of okay with the the fundimental reduction of the wait time for the grub prompt, but down to 1 does seem like a bit aggressive of a change unrelated to the change not to duplicate. As such, I think it would be good to add a release note.","commit_id":"5afc067bb0281c457ee50b9b247ff622cc73c424"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0ac53462cdcef19eb807df24af13887418c2a206","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff74a636_cb27f75d","updated":"2024-08-04 22:06:44.000000000","message":"LGTM, this may well fix other duplicates also","commit_id":"be4ff60d9c022ebf1d010da8fd06f187dc40c3d9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8506e7a18c035853a5b097d62282ec70febc016b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bbaeae08_d52a5577","updated":"2024-08-16 16:23:04.000000000","message":"This appears to work as expected. One aspect I think we should do, and in another patch most likely, is re-tool all appends into this sort of form, specifically because using stock upstream images, we get a duplicated GRUB_CMDLINE_LINUX, which we don\u0027t explicitly handle in this patch.\n\nMy main driver for thinking this is because we do see end users leveraging DIB to modify existing disk images which have been previously generated, on top of confusion over use/order and \"which line to change\" when they are not experts in grub.","commit_id":"be4ff60d9c022ebf1d010da8fd06f187dc40c3d9"}]}