)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35260,"name":"Tyler","email":"tyler@stackhpc.com","username":"scrungus"},"change_message_id":"52f1d285e12a697c29f93ea6c0a7b7394633e7cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"20122981_c31c8821","updated":"2024-09-17 12:45:11.000000000","message":"CI failures seem unrelated..\ne.g. see:\nhttps://zuul.opendev.org/t/openstack/build/c066edbda8ec410b9e3773ed8790fd66/log/logs/openeuler-minimal_22.03-LTS-build-succeeds.FAIL.log#2340-2344\n\nhttps://zuul.opendev.org/t/openstack/build/2ac52475b7154b878eee5c15b3421059/log/nodepool/builds/test-image-222bd243f57b4ebcb1bfe91abe10c368.log#1946","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":35260,"name":"Tyler","email":"tyler@stackhpc.com","username":"scrungus"},"change_message_id":"5b60db89d7548f178f865d97d8c4856e2c11adaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"931270db_6266c7ee","updated":"2024-09-25 10:43:59.000000000","message":"Can we push this through?","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"41e8caf0c80c23f2022b911ae5093ae975965771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae4b4170_8eed2bce","updated":"2024-11-13 22:07:26.000000000","message":"Fair enough","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ee685d6659a2c26a331cb4216477ba4b6453ac36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af3b53ac_ef983a93","updated":"2024-11-20 23:51:17.000000000","message":"Upgrading vote since no other core with more familiarity has chimed in, and I don\u0027t wanna make this wait.","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":35260,"name":"Tyler","email":"tyler@stackhpc.com","username":"scrungus"},"change_message_id":"6c8dcd9cc58db86cc581313c91052055eca066f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf59b32d_9fd0cd0b","updated":"2024-10-16 10:14:12.000000000","message":"ready for review","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5a5789eea39ab9de8b41e2f514f36a63259fbdf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30a9aaad_08daae38","updated":"2024-09-17 20:54:26.000000000","message":"recheck nodepool was updated to deal with git permission issues that broke the integration jobs","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"}],"diskimage_builder/elements/ubuntu/root.d/10-cache-ubuntu-tarball":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"defa9f0b3d7176f7af71836117d951efd0fa688e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":55,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":56,"context_line":"    if [ \"$DIB_RELEASE\" !\u003d \"trusty\" ] ; then"},{"line_number":57,"context_line":"            # If image is local, it may not be squashfs. "},{"line_number":58,"context_line":"            # Fall back to extract-image."},{"line_number":59,"context_line":"            {"},{"line_number":60,"context_line":"                sudo unsquashfs -f -d $TARGET_ROOT $IMAGE_PATH"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"05b929d7_93254e3b","line":57,"updated":"2024-09-03 04:58:11.000000000","message":"trailing whitespace","commit_id":"371f8a056528d7c78686e0934ff2caf57f7087ec"},{"author":{"_account_id":35260,"name":"Tyler","email":"tyler@stackhpc.com","username":"scrungus"},"change_message_id":"52f1d285e12a697c29f93ea6c0a7b7394633e7cb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    # Extract the base image (use --numeric-owner to avoid UID/GID mismatch between"},{"line_number":55,"context_line":"    # image tarball and host OS e.g. when building Ubuntu image on an openSUSE host)"},{"line_number":56,"context_line":"    if [ \"$DIB_RELEASE\" !\u003d \"trusty\" ] ; then"},{"line_number":57,"context_line":"            # If image is local, it may not be squashfs. "},{"line_number":58,"context_line":"            # Fall back to extract-image."},{"line_number":59,"context_line":"            {"},{"line_number":60,"context_line":"                sudo unsquashfs -f -d $TARGET_ROOT $IMAGE_PATH"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8617b8ec_d368d02d","line":57,"in_reply_to":"05b929d7_93254e3b","updated":"2024-09-17 12:45:11.000000000","message":"Done","commit_id":"371f8a056528d7c78686e0934ff2caf57f7087ec"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0a97a9f36c3b9a6729302b1b8897c168a57a6fec","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                sudo unsquashfs -f -d $TARGET_ROOT $IMAGE_PATH"},{"line_number":61,"context_line":"            } ||"},{"line_number":62,"context_line":"            {"},{"line_number":63,"context_line":"                BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":64,"context_line":"                $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_PATH $CACHED_FILE"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8e2e0761_13b3f3cb","line":63,"updated":"2024-11-07 23:09:59.000000000","message":"I\u0027m not super familiar with the ubuntu element, so not putting a -1 on this, but this seems a little strange to me? Is it OK that we\u0027re going to assume the file is a tgz even if the image path doesn\u0027t indicate it?","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":35260,"name":"Tyler","email":"tyler@stackhpc.com","username":"scrungus"},"change_message_id":"f3531aa2fbecd20f6fd4367c9b3c35485da7b4bb","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                sudo unsquashfs -f -d $TARGET_ROOT $IMAGE_PATH"},{"line_number":61,"context_line":"            } ||"},{"line_number":62,"context_line":"            {"},{"line_number":63,"context_line":"                BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":64,"context_line":"                $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_PATH $CACHED_FILE"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"df135c31_c901a599","line":63,"in_reply_to":"8e2e0761_13b3f3cb","updated":"2024-11-13 12:09:18.000000000","message":"I\u0027m not sure what the right call is here. We can\u0027t guarantee it\u0027s a tarball, but every other image extract dib does assume it is: \n\n- https://github.com/openstack/diskimage-builder/blob/fd8fae299e8de8a4765dfb030ea94dcefd55b00c/diskimage_builder/elements/rhel/root.d/10-rhel-cloud-image#L26-L33\n- https://github.com/openstack/diskimage-builder/blob/fd8fae299e8de8a4765dfb030ea94dcefd55b00c/diskimage_builder/elements/centos/root.d/10-centos-cloud-image#L31-L37\n- https://github.com/openstack/diskimage-builder/blob/fd8fae299e8de8a4765dfb030ea94dcefd55b00c/diskimage_builder/elements/fedora/root.d/10-fedora-cloud-image#L21-L27\n\na refactor to try detect file type is probably the right call, but maybe it belongs in a separate patch?","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"41e8caf0c80c23f2022b911ae5093ae975965771","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                sudo unsquashfs -f -d $TARGET_ROOT $IMAGE_PATH"},{"line_number":61,"context_line":"            } ||"},{"line_number":62,"context_line":"            {"},{"line_number":63,"context_line":"                BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":64,"context_line":"                $TMP_HOOKS_PATH/bin/extract-image $BASE_IMAGE_FILE $BASE_IMAGE_TAR $IMAGE_PATH $CACHED_FILE"},{"line_number":65,"context_line":"            }"},{"line_number":66,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"08df5a2d_60c2686b","line":63,"in_reply_to":"df135c31_c901a599","updated":"2024-11-13 22:07:26.000000000","message":"Thanks for the pointer, this makes sense with that context.","commit_id":"7dc0c82bd691ac487a483ab8cea0c0b5036693e7"}]}