)]}'
{"id":"openstack%2Fdiskimage-builder~928312","triplet_id":"openstack%2Fdiskimage-builder~master~Idd5cac19ec6f10103495bbe217cc5fe41c48e91b","project":"openstack/diskimage-builder","branch":"master","topic":"hashbangbye","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2024-09-09 10:03:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idd5cac19ec6f10103495bbe217cc5fe41c48e91b","subject":"Fix hashbang of non-executed bash libs","status":"MERGED","created":"2024-09-06 03:05:37.000000000","updated":"2024-09-09 10:04:33.000000000","submitted":"2024-09-09 10:03:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"928312-hashbangbye","meta_rev_id":"c249b874c77c38a521c5a6eb7e6a1a3f0e9ada2c","_number":928312,"virtual_id_number":928312,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-09-09 10:03:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"recommended":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"all":[{"value":1,"date":"2024-09-06 11:24:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":2,"date":"2024-09-09 09:05:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-09-06 05:50:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"all":[{"value":0,"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},{"value":1,"date":"2024-09-09 09:05:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-06 04:02:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-09-06 04:12:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-09-06 05:50:44.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2024-09-06 11:24:06.000000000","updated_by":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"reviewer":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"state":"REVIEWER"},{"updated":"2024-09-09 09:05:22.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"REVIEWER"}],"messages":[{"id":"33ef1252a6061e8f9d88296f97601839814b491a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2024-09-06 03:05:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5e94f742387fb23399c9b39c7fdd28c8f932e79e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-06 04:02:01.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bbd95fef19184db1a0a508fa606466c5\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/9ee8978ae683404e80a3a9bec7af9c5a : SUCCESS in 54m 48s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/9b56f965df394d43852ba576227bb1ac : FAILURE in 28m 32s","accounts_in_message":[],"_revision_number":1},{"id":"adfcf80ec123ba755969b826cc8dc2a123df5062","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-06 04:12:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8b28505e75a14c31b273acc852a14e7c\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4da95ea0fa554f039ab4a46b94509be2 : SUCCESS in 5m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bd186f606b294b05a41b5beacf9adb30 : SUCCESS in 4m 28s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/f89bc5c236a1418b82008a87dccf3169 : SUCCESS in 6m 08s\n- tox-py36 https://zuul.opendev.org/t/openstack/build/73d4a065a978479f81110102226b81b7 : SUCCESS in 3m 15s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/67d8d8369a994a0689e1410c6a1faea1 : SUCCESS in 3m 34s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/8fc91139e9614e7896a35aec2390d261 : SUCCESS in 4m 12s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/3a35f720f70648cf83228ead0eded158 : SUCCESS in 4m 35s\n- tox-py311 https://zuul.opendev.org/t/openstack/build/8a08275f0f124a35aa06ea8654b3a7e7 : SUCCESS in 4m 23s\n- tox-py312 https://zuul.opendev.org/t/openstack/build/c71ac06cc574448a978547e47f8a5e8c : SUCCESS in 6m 58s\n- dib-functests https://zuul.opendev.org/t/openstack/build/9bf96ff248e54ac5917fbd8715676f30 : SUCCESS in 36m 35s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/22933c8713c0403b8952493b3a1b0c7e : SUCCESS in 1h 05m 09s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/afe70573f9254312b0fec8369f582b05 : SUCCESS in 13m 56s\n- dib-nodepool-functional-openstack-almalinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/62101443d7fa41e1b88084a45217a421 : SUCCESS in 36m 23s (non-voting)\n- dib-nodepool-functional-openstack-almalinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/5622adf970d143c6bbbdd51a054131da : SUCCESS in 34m 21s (non-voting)\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/29ee98ea31e74af5a276baaa09265ad6 : SUCCESS in 33m 15s\n- dib-nodepool-functional-openstack-fedora-37-containerfile-src https://zuul.opendev.org/t/openstack/build/c49745abb14b4db7a6a9840e77f5b8ff : SUCCESS in 39m 24s (non-voting)\n- dib-nodepool-functional-openstack-rockylinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/ede8816966014371b97b03e838d7dd1c : SUCCESS in 41m 15s (non-voting)\n- dib-nodepool-functional-openstack-rockylinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/a7cb7016ef7a43ed9b6e3cb5b4a091fb : SUCCESS in 36m 16s (non-voting)\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/201583e701664633a2cf0720f57239f3 : SUCCESS in 33m 49s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/55e41827b4ce4e2b9724e4511dd741b6 : SUCCESS in 36m 11s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/7afaa74e2fbc485f81eeaccb8e51c56a : SUCCESS in 40m 31s\n- dib-nodepool-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/d454ecf97cc64faf83ab8ae6df983c5e : SUCCESS in 41m 14s\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/babb67ae56ac48e4abb0f0f34ef4f0b1 : SUCCESS in 35m 25s\n- dib-nodepool-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/422ad2c2dff24d41b7e22706a0ddcd5d : FAILURE in 23m 30s (non-voting)\n- dib-nodepool-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/26e642f7587543aa9b83c0b980dec2f1 : FAILURE in 24m 11s (non-voting)\n- dib-nodepool-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/070f96964cee48fea4622ac035fcda75 : SUCCESS in 38m 27s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/707d0270c2a6431885fec0239c713900 : SUCCESS in 8m 29s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/c4e5554d70be413bb6579c891b473ea0 : SUCCESS in 1h 00m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"796782704f99ba89912cb20dc343de0c006d199c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2024-09-06 05:50:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"002467045f934c5d8ffd0198a360fcad8ef1e202","author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"date":"2024-09-06 11:24:06.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"db8b9c96720bd84c2362b1f254198b957ca0049f","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2024-09-09 09:05:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f7983764c0136a2ea447b3e396fab926281857fd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-09 09:05:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a5e12ab77db65cf9d826f06214835cede2a101be","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-09 10:03:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e305516c04644d66b56a058ae8ddfde0\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/900ffab0b72742179b00a0b8cd3e6dcd : SUCCESS in 4m 45s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/67d1d0187e5441ab875c40672b1d3872 : SUCCESS in 4m 22s\n- tox-py36 https://zuul.opendev.org/t/openstack/build/3b0813342644403ba0d3c7c6315fcd1d : SUCCESS in 4m 14s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/90da41ddd4574e3c88d937f52d90e9ca : SUCCESS in 3m 11s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/28e70dd3a62644a8a96a2ada362a45cc : SUCCESS in 3m 14s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/2c1e1132987b4b3d982932333be9a76d : SUCCESS in 3m 42s\n- tox-py311 https://zuul.opendev.org/t/openstack/build/ec7bd3943a404d1a8d1402c3bd380e30 : SUCCESS in 3m 55s\n- tox-py312 https://zuul.opendev.org/t/openstack/build/6540ec30ac5149aeb2408312a5512036 : SUCCESS in 4m 41s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/f3352232e2b44b239374625662cf8d61 : SUCCESS in 57m 26s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/5049a9e6967949a5b4b80d22bcba8901 : SUCCESS in 16m 53s\n- dib-nodepool-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/7dbd54d3a82d42d196edca80d4506eaf : SUCCESS in 31m 08s\n- dib-nodepool-functional-openstack-ubuntu-xenial-src https://zuul.opendev.org/t/openstack/build/a89294cdce4d49f79451a4a6f445032b : SUCCESS in 26m 52s\n- dib-nodepool-functional-openstack-ubuntu-bionic-src https://zuul.opendev.org/t/openstack/build/b6c7cc3c18d44af2a5f0f99c21743689 : SUCCESS in 30m 45s\n- dib-nodepool-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/c1333ed355ea45ff930bd2c0e4b971b8 : SUCCESS in 29m 42s\n- dib-nodepool-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/7260a9ffdd2f45b7a1bc661f64c89a4f : SUCCESS in 33m 38s\n- dib-nodepool-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/adf17c6d6ab9423aa1f4db2e6e6e7d4f : SUCCESS in 36m 44s\n- dib-functests https://zuul.opendev.org/t/openstack/build/667cbf7c04214d67ab516ed053607c0b : SUCCESS in 37m 19s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/d98ef8f8f83844f998a9a5a1e373f5d5 : SUCCESS in 6m 54s","accounts_in_message":[],"_revision_number":1},{"id":"c51ce42f472d0ad53f6e46de71ab1f94a918ef84","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-09 10:03:18.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"c249b874c77c38a521c5a6eb7e6a1a3f0e9ada2c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-09 10:04:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/14a23656f83546b7bcb9bc43659b1e59\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae7f6c1acf66459aa40c422d6feee7c1 : SUCCESS in 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e4062e35dbe85ea4b2ba30ce1d2b752c6d5894f","revisions":{"3e4062e35dbe85ea4b2ba30ce1d2b752c6d5894f":{"kind":"REWORK","_number":1,"created":"2024-09-06 03:05:37.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/12/928312/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/12/928312/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/12/928312/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/12/928312/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/12/928312/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/12/928312/1"}}},"commit":{"parents":[{"commit":"6632aaa80eecc2cf4a8f3ad4888f1e5a9293a37a","subject":"Merge \"New elements replace-partition(-redhat)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6632aaa80eecc2cf4a8f3ad4888f1e5a9293a37a"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2024-09-06 02:55:15.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2024-09-06 02:55:15.000000000","tz":720},"subject":"Fix hashbang of non-executed bash libs","message":"Fix hashbang of non-executed bash libs\n\nThese files have #!/bin/bash but do not have the execute bit set, and\nare never run directly, only sourced. This has triggered RDO packaging\nlinting. Also outfilter.py can be run directly but does not have an\nexecute bit set.\n\nThis change fixes these issues.\n\nChange-Id: Idd5cac19ec6f10103495bbe217cc5fe41c48e91b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3e4062e35dbe85ea4b2ba30ce1d2b752c6d5894f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3e4062e35dbe85ea4b2ba30ce1d2b752c6d5894f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
