)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"f18b3d805278f277fc0a3556d3ded786f3e90aab","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a DIB_TIDY_IMAGE environment variable to request tidied disk images."},{"line_number":10,"context_line":"Manifest and source-repositories updated to clean out manifests and git data"},{"line_number":11,"context_line":"if DIB_TIDY_IMAGE is non zero."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5bb16dde3b7d6160d8249ff864dc570d39f339b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba7be1f8_4f1c5e78","line":11,"updated":"2015-02-26 22:57:34.000000000","message":"This commit message is severely lacking. I don\u0027t really know why I want a tidied disk image, or even what the definition of tidied is.","commit_id":"ae06e399619cca3eb405865c4ccb4a1b1108295b"}],"README.md":[{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"128ff27ee4ecae152e15cea34e7facc25caae8c1","unresolved":false,"context_lines":[{"line_number":375,"context_line":""},{"line_number":376,"context_line":"* DIB\\_TIDY\\_IMAGE: this can be set to nonzero in order to indicate extra"},{"line_number":377,"context_line":"  cleanup steps should be taken to tidy built images. e.g. remove git refs."},{"line_number":378,"context_line":"  "},{"line_number":379,"context_line":"Structure of an element"},{"line_number":380,"context_line":"-----------------------"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7adec928_a82722b5","line":378,"updated":"2014-05-14 16:36:08.000000000","message":"whitespace","commit_id":"81083820593a4651fab9111b90207ef1b9062a92"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"f18b3d805278f277fc0a3556d3ded786f3e90aab","unresolved":false,"context_lines":[{"line_number":374,"context_line":"  cache able to keep the operation functional."},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"* DIB\\_TIDY\\_IMAGE: this can be set to nonzero in order to indicate extra"},{"line_number":377,"context_line":"  cleanup steps should be taken to tidy built images. e.g. remove git refs."},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"Structure of an element"},{"line_number":380,"context_line":"-----------------------"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"ba7be1f8_6f11225d","line":377,"updated":"2015-02-26 22:57:34.000000000","message":"This barely scratches the surface on what tidied disk images are. A better explanation would be great here.","commit_id":"ae06e399619cca3eb405865c4ccb4a1b1108295b"}],"elements/manifests/cleanup.d/01-copy-manifests-dir":[{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"e7f861da535f8aae4c49de72d3c8eac4e3c5a4d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cp --no-preserve\u003downership -rv $TMP_MOUNT_PATH/${DIB_MANIFEST_IMAGE_DIR} \\"},{"line_number":34,"context_line":"        ${DIB_MANIFEST_SAVE_DIR}"},{"line_number":35,"context_line":"elif [ $DIB_TIDY_IMAGE !\u003d \"0\" ]; then"},{"line_number":36,"context_line":"    rm -rf $TMP_MOUNT_PATH/etc/dib_arguments \\"},{"line_number":37,"context_line":"        $TMP_MOUNT_PATH/etc/dib_environment \\"},{"line_number":38,"context_line":"        $TMP_MOUNT_PATH/${DIB_MANIFEST_IMAGE_DIR} \u0026\u0026 true"},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1ae5cdf2_f572aa7a","line":36,"updated":"2014-06-12 11:39:37.000000000","message":"We need sudo in front of this","commit_id":"349cc04b83be2c37f3330374b20b7b5cecaed3c5"}],"elements/source-repositories/cleanup.d/98-source-repositories":[{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"128ff27ee4ecae152e15cea34e7facc25caae8c1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ \"$DIB_TIDY_IMAGE\" !\u003d \"0\" ]; then"},{"line_number":25,"context_line":"    echo \"Tidying out hidden git structures\""},{"line_number":26,"context_line":"    $(awk \u0027{ if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") { "},{"line_number":27,"context_line":"                    print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]$3\"/.git*\" }"},{"line_number":28,"context_line":"                }\u0027 $TMP_HOOKS_PATH/source-repository-* )"},{"line_number":29,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7adec928_88ed06f2","line":26,"updated":"2014-05-14 16:36:08.000000000","message":"whitespace\n\nAnd I\u0027m not sure I\u0027m able to understand the indentations here.  I think this could be made a lot clearer.  I also added a slash between $3 and the environ - you can\u0027t be too careful.\n\n    # Use awk to generate the command to run, which is then executed within the subshell\n    $(awk \u0027\n        {\n            if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") {\n                print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]/$3\"/.git*\"\n            }\n        }\u0027 $TMP_HOOKS_PATH/source-repository-* )","commit_id":"81083820593a4651fab9111b90207ef1b9062a92"},{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"ba378b5ea0911f1491ce6f31668480ae1fdf233c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") {"},{"line_number":30,"context_line":"            print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]/$3\"/.git*\""},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":"    }\u0027 $TMP_HOOKS_PATH/source-repository-* )"},{"line_number":33,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_b534ebde","line":32,"updated":"2014-05-23 16:14:40.000000000","message":"I suppose really the curly braces should be indented 1 extra level, as per the original comment.\n\nI really hate nit-picking over it though, and I think it is plenty readable as it is, but if you start to let standards slip in one place...","commit_id":"49560bdff54a3a4de6386c2847178e06f1542ea8"},{"author":{"_account_id":5639,"name":"Coleman Corrigan","email":"coleman.corrigan@hp.com","username":"coleman-corrigan"},"change_message_id":"578823a2ea0170184b390e16ec5f94ad2d92f72b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") {"},{"line_number":30,"context_line":"            print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]/$3\"/.git*\""},{"line_number":31,"context_line":"        }"},{"line_number":32,"context_line":"    }\u0027 $TMP_HOOKS_PATH/source-repository-* )"},{"line_number":33,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5adbc538_b1445a75","line":32,"in_reply_to":"7adec928_b534ebde","updated":"2014-05-26 08:44:49.000000000","message":"Fair Point, though I\u0027ll stick with one four space indent rather than align with the quote.","commit_id":"49560bdff54a3a4de6386c2847178e06f1542ea8"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"e7f861da535f8aae4c49de72d3c8eac4e3c5a4d5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    $(awk \u0027"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") {"},{"line_number":30,"context_line":"                print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]/$3\"/.git*\""},{"line_number":31,"context_line":"            }"},{"line_number":32,"context_line":"        }\u0027 $TMP_HOOKS_PATH/source-repository-* )"},{"line_number":33,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1ae5cdf2_7ba209af","line":30,"updated":"2014-06-12 11:39:37.000000000","message":"I had to change this line to:\nprint \"sudo rm -rf \" ENVIRON[\"TMP_MOUNT_PATH\"] $3 \"/.git*\"\nto get around this error message\n++ awk \u0027\n        {   \n            if ( NF \u003e 3 \u0026\u0026 substr($1,1,1) !\u003d \"#\" \u0026\u0026 $2 \u003d\u003d \"git\") {\n                print \"rm -rf \"ENVIRON[\"TMP_MOUNT_PATH\"]/$3\"/.git*\"\n            }\n        }\u0027 /tmp/image.bI1h5ilE/hooks/source-repository-clients /tmp/image.bI1h5ilE/hooks/source-repository-cloud-init /tmp/image.bI1h5ilE/hooks/source-repository-glance /tmp/image.bI1h5ilE/hooks/source-repository-heat /tmp/image.bI1h5ilE/hooks/source-repository-keystone /tmp/image.bI1h5ilE/hooks/source-repository-neutron /tmp/image.bI1h5ilE/hooks/source-repository-nova /tmp/image.bI1h5ilE/hooks/source-repository-novnc /tmp/image.bI1h5ilE/hooks/source-repository-pip-and-virtualenv /tmp/image.bI1h5ilE/hooks/source-repository-swift\nawk: cmd. line:4: (FILENAME\u003d/tmp/image.bI1h5ilE/hooks/source-repository-clients FNR\u003d1) fatal: division by zero attempted\n\nAnd it needed the sudo","commit_id":"349cc04b83be2c37f3330374b20b7b5cecaed3c5"}]}