)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2773c1b6c6d6cf4db8b26f1d4f0c44984aaaa85f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-13 14:53:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent from overwriting grub defaults if no variables are set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c4b99bb0_403ff115","line":7,"updated":"2024-12-13 15:49:44.000000000","message":"Can you provide the motivation for this? In particular the grub timeout tends to be at odds with dib built images because you build the image you know you want to boot and time spent waiting for user interaction to select something else that doesn\u0027t exist as an option is time wasted.","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ba19eaf0c5e7c0073660b72129719fc52799e815","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-13 14:53:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent from overwriting grub defaults if no variables are set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"69f33257_bc00b973","line":7,"in_reply_to":"136b46c6_a59fde7b","updated":"2024-12-18 11:09:33.000000000","message":"Acknowledged","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ad5e2d36e97c1eaf673f9ede7781dc6cecab82e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-13 14:53:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent from overwriting grub defaults if no variables are set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5faf86c1_3bff3d44","line":7,"in_reply_to":"69f33257_bc00b973","updated":"2024-12-18 15:57:10.000000000","message":"Ok that should be captured int he commit then. I strongly disagree with this viewpoint because we boot tens of thousands of VMs from dib images a week and adding 5 seconds of boot time for each by default is a measurable significant cost. The frequency of needing to debug things on the other hand is extremely infrequent and dib allows you to change the settings for debugging purposes.\n\nHowever, I\u0027m willing to be overridden on this if other reviewers disagree, but that absolutely needs to be captured in the commit message justifying why this is the case.","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4a603a95efb1506219d04f94578fbd9d407eeffd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-13 14:53:36 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent from overwriting grub defaults if no variables are set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"136b46c6_a59fde7b","line":7,"in_reply_to":"c4b99bb0_403ff115","updated":"2024-12-16 10:44:56.000000000","message":"I do not think DIB should be overriding grub project defaults. Especially when it takes away basic debugging tools.","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8556e09fce7263b7c17725e3a22e7c1cd0466d35","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-20 09:55:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change grub variables for style and timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2211a58c_59a0ce55","line":7,"updated":"2025-01-29 14:42:20.000000000","message":"nit: Adding a bit more verbosity and detail would be good to help reviewers understand the motivation.","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"bc293e4ba389080718a807c583a97605f960017a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rafal Lewandowski \u003crafal@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-20 09:55:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change grub variables for style and timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08155152b63f629c4eaf72d29ff931e92d7e4b33"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"825eb51a_22789075","line":7,"in_reply_to":"2211a58c_59a0ce55","updated":"2025-01-29 16:02:28.000000000","message":"Done","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ad5e2d36e97c1eaf673f9ede7781dc6cecab82e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b473007_ef9443be","updated":"2024-12-18 15:57:10.000000000","message":"-1 because I think the release note needs to be updated and the commit message needs to provide motivation/justification for this behavior change.\n\nI\u0027m personally not convinced by the argument for changing this. I think defaults that safe users time and money make sense for DIB particularly since they can be overridden for debugging. However, as mentioned inline I am happy to be overridden if consensus is the other direction.","commit_id":"9f58db0300134adeca267b571edf67f633c26b26"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"cb9ada00ca5fe14954821c7099b909878e31b817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5dde67e3_0a46aeab","in_reply_to":"5e08db64_f51ba3fd","updated":"2024-12-20 09:00:02.000000000","message":"Changed approach and values accordingly.","commit_id":"9f58db0300134adeca267b571edf67f633c26b26"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf75416d087d9ddfede813a6ccb0fedb5c19e680","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e08db64_f51ba3fd","in_reply_to":"8b473007_ef9443be","updated":"2024-12-19 08:22:43.000000000","message":"I can understand the rationale behind making VMs boot fast - and that\u0027s probably how current defaults got in.\nIf we assume DIB is mainly for VMs that\u0027s fine - but I think a lot of users use that also for Ironic whole disk images - and that\u0027s where debugging some hardware-related boot failures is complicated.\nI think switching from hidden to menu is not a problem (or whatever the distro default is) - but extending 1s to 5s might be complicated for envs like OpenDev CI - maybe we can compromise on something like 2 seconds - which should be enough to hit space and interrupt the boot?","commit_id":"9f58db0300134adeca267b571edf67f633c26b26"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8556e09fce7263b7c17725e3a22e7c1cd0466d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aff62e52_ffa7d874","updated":"2025-01-29 14:42:20.000000000","message":"The included docs are wrong. Please fix it.","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"907e9bbb45857198d7d4d9a04bdc10f12b6044b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"99c92bac_e69e24e7","updated":"2025-02-17 16:35:10.000000000","message":"-1 from the incorrect documentation called out inline and the ask for a comment in the code.","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b2eede7447ae2e4bedb0f1df093d3e84692860fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3cecec83_e5815e3b","updated":"2025-02-17 16:11:32.000000000","message":"I\u0027m not going to block this change, but I share similar concerns to Clark with an additional thought; I wonder how much operator time will be lost troubleshooting longer system boots. I live in the baremetal world where the POST takes longer than everyone else (generally), but in VM world this could be a significant % of boot time.\n\nI\u0027m not sure how to balance this against the arguments made by OP -- but I think this is a case where I favor no churn.\n\nFor every default we change the value of; we\u0027re adding work to someones\u0027 plate to change it back if they wanted the old behavior; especially when it\u0027s not clearly better, just different.","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2a68f58a98259805d055f448a02af6ec0416dc7f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"909495cd_f3fde280","in_reply_to":"3cecec83_e5815e3b","updated":"2025-02-17 16:37:58.000000000","message":"This concern is moot after conversations in #diskimage-builder (and detailed by Clark in here) about how this is closer to restoring an old default than creating a new one.","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9f98142155c4f52c0f6b859ebcbfaf98e25e4ac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"64c6cc66_5f9fb9d6","in_reply_to":"909495cd_f3fde280","updated":"2025-02-18 08:12:52.000000000","message":"Acknowledged","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"}],"diskimage_builder/elements/bootloader/README.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8556e09fce7263b7c17725e3a22e7c1cd0466d35","unresolved":true,"context_lines":[{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"* ``DIB_GRUB_TIMEOUT`` sets the ``grub`` menu timeout.  It defaults to"},{"line_number":11,"context_line":"  2 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_GRUB_TIMEOUT_STYLE`` sets the visibility of the ``grub`` menu."},{"line_number":14,"context_line":"  It defaults to ``menu``. Set this to   ``hidden`` (or ``countdown`` as an alias)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fb34a4e1_1480bc2e","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":4},"updated":"2025-01-29 14:42:20.000000000","message":"s/2/5/. This is incorrect compared to the actual change in the content.","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"bc293e4ba389080718a807c583a97605f960017a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"* ``DIB_GRUB_TIMEOUT`` sets the ``grub`` menu timeout.  It defaults to"},{"line_number":11,"context_line":"  2 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_GRUB_TIMEOUT_STYLE`` sets the visibility of the ``grub`` menu."},{"line_number":14,"context_line":"  It defaults to ``menu``. Set this to   ``hidden`` (or ``countdown`` as an alias)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"73bb1bc0_a64e4bb4","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":4},"in_reply_to":"fb34a4e1_1480bc2e","updated":"2025-01-29 16:02:28.000000000","message":"Done","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"907e9bbb45857198d7d4d9a04bdc10f12b6044b7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_GRUB_TIMEOUT_STYLE`` sets the visibility of the ``grub`` menu."},{"line_number":14,"context_line":"  It defaults to ``menu``. Set this to   ``hidden`` (or ``countdown`` as an alias)"},{"line_number":15,"context_line":"  to display the menu and then wait for the timeout set by ``DIB_GRUB_TIMEOUT``"},{"line_number":16,"context_line":"  to expire before booting the default entry."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":19,"context_line":"  to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"b92e131c_090c1b60","line":16,"range":{"start_line":14,"start_character":27,"end_line":16,"end_character":45},"updated":"2025-02-17 16:35:10.000000000","message":"This is no longer accurate. When set to hidden or countdown no menu is shown unless there is interaction from the user. Without interaction the system waits for the timeout to complete then the default boot option is selected.","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4af85afe951c0c4f3e8761a50e34e40565a0bf64","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  5 seconds.  Set this to 0 (no timeout) for fast boot times."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* ``DIB_GRUB_TIMEOUT_STYLE`` sets the visibility of the ``grub`` menu."},{"line_number":14,"context_line":"  It defaults to ``menu``. Set this to   ``hidden`` (or ``countdown`` as an alias)"},{"line_number":15,"context_line":"  to display the menu and then wait for the timeout set by ``DIB_GRUB_TIMEOUT``"},{"line_number":16,"context_line":"  to expire before booting the default entry."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* ``DIB_BOOTLOADER_DEFAULT_CMDLINE`` sets parameters that are appended"},{"line_number":19,"context_line":"  to the ``GRUB_CMDLINE_LINUX_DEFAULT`` values in ``grub.cfg``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"070c0dfb_1886e1bb","line":16,"range":{"start_line":14,"start_character":27,"end_line":16,"end_character":45},"in_reply_to":"b92e131c_090c1b60","updated":"2025-02-17 16:50:25.000000000","message":"Done","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"}],"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8a80413833cc17a068796ae6fcd32a3dcde1b315","unresolved":true,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"if [[ -n ${DIB_GRUB_TIMEOUT} ]]; then"},{"line_number":120,"context_line":"    sed -i \"a DIB_GRUB_TIMEOUT\u003d$DIB_GRUB_TIMEOUT\" /etc/default/grub"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":"if [[ -n ${DIB_GRUB_TIMEOUT_STYLE} ]]; then"},{"line_number":123,"context_line":"    sed -i \"a DIB_GRUB_TIMEOUT_STYLE\u003d$DIB_GRUB_TIMEOUT_STYLE\" /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"037d9a05_62f645df","line":120,"updated":"2024-12-17 14:27:07.000000000","message":"any reason for not using append_or_replace inside the if statement?","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ba19eaf0c5e7c0073660b72129719fc52799e815","unresolved":false,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"if [[ -n ${DIB_GRUB_TIMEOUT} ]]; then"},{"line_number":120,"context_line":"    sed -i \"a DIB_GRUB_TIMEOUT\u003d$DIB_GRUB_TIMEOUT\" /etc/default/grub"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":"if [[ -n ${DIB_GRUB_TIMEOUT_STYLE} ]]; then"},{"line_number":123,"context_line":"    sed -i \"a DIB_GRUB_TIMEOUT_STYLE\u003d$DIB_GRUB_TIMEOUT_STYLE\" /etc/default/grub"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"88d782cf_36ac7d34","line":120,"in_reply_to":"037d9a05_62f645df","updated":"2024-12-18 11:09:33.000000000","message":"Fair point, fixed.","commit_id":"b96e70dc51f655ae80d9148ac4650c157ca84daf"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8556e09fce7263b7c17725e3a22e7c1cd0466d35","unresolved":true,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT \"${DIB_GRUB_TIMEOUT:-5}\""},{"line_number":120,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT_STYLE \"${DIB_GRUB_TIMEOUT_STYLE:-menu}\""},{"line_number":121,"context_line":"if [[ \"True\" \u003d\u003d \"${DIB_BOOTLOADER_USE_SERIAL_CONSOLE:-True}\" ]]; then"},{"line_number":122,"context_line":"    append_or_replace /etc/default/grub GRUB_TERMINAL \\\"\"serial console\"\\\""},{"line_number":123,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"450d03b2_90df0571","line":120,"updated":"2025-01-29 14:42:20.000000000","message":"We\u0027ve seen a few complaints and whole groups of people, not understanding how to interact with hidden, so I think this makes sense.","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"bc293e4ba389080718a807c583a97605f960017a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT \"${DIB_GRUB_TIMEOUT:-5}\""},{"line_number":120,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT_STYLE \"${DIB_GRUB_TIMEOUT_STYLE:-menu}\""},{"line_number":121,"context_line":"if [[ \"True\" \u003d\u003d \"${DIB_BOOTLOADER_USE_SERIAL_CONSOLE:-True}\" ]]; then"},{"line_number":122,"context_line":"    append_or_replace /etc/default/grub GRUB_TERMINAL \\\"\"serial console\"\\\""},{"line_number":123,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"8dc99ee9_a5cafbf5","line":120,"in_reply_to":"450d03b2_90df0571","updated":"2025-01-29 16:02:28.000000000","message":"Thank you for understanding.","commit_id":"e6dcb80d8d9dcb67d8c978e5457b063605a14d29"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"907e9bbb45857198d7d4d9a04bdc10f12b6044b7","unresolved":true,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT \"${DIB_GRUB_TIMEOUT:-5}\""},{"line_number":120,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT_STYLE \"${DIB_GRUB_TIMEOUT_STYLE:-menu}\""},{"line_number":121,"context_line":"if [[ \"True\" \u003d\u003d \"${DIB_BOOTLOADER_USE_SERIAL_CONSOLE:-True}\" ]]; then"},{"line_number":122,"context_line":"    append_or_replace /etc/default/grub GRUB_TERMINAL \\\"\"serial console\"\\\""},{"line_number":123,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"5b9402ee_5dfdf6b0","line":120,"updated":"2025-02-17 16:35:10.000000000","message":"mnasiadka pointed out that my assumptions around the history for the changes behind these two options was wrong.\n\nWhen we first started setting the GRUB_TIMEOUT value we defaulted it to 5. Then in 2024 it got updated to 1 here: https://review.opendev.org/c/openstack/diskimage-builder/+/925451.\n\nThe timeout style was not set (which meant we would use the GRUB default of menu unless the distros further overrode thingss) until 2023 when we started setting it to a default of \"hidden\" here https://review.opendev.org/c/openstack/diskimage-builder/+/895486.\n\nConsidering the recent back and forth around this I think relying on GRUB defaults of 5 second timeout and menu style of menu is reasonable. We\u0027re following upstream defaults and people who need something different can override with these variables.\n\nThat said GRUB defaults may change over time. I think we should either stop setting these variables entirely unless we explicitly override (thus falling through to GRUB\u0027s actual defaults) or make a note here that we shouldn\u0027t deviate because the back and forth is more problematic than sticking to something. Can we add a comment here that these values are based on upstream defaults and shouldn\u0027t be changed unless we stop setting them entirely by default?","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4af85afe951c0c4f3e8761a50e34e40565a0bf64","unresolved":false,"context_lines":[{"line_number":117,"context_line":"append_or_replace /etc/default/grub GRUB_DEVICE \"LABEL\u003d${DIB_ROOT_LABEL}\""},{"line_number":118,"context_line":"append_or_replace /etc/default/grub GRUB_DISABLE_LINUX_UUID true"},{"line_number":119,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT \"${DIB_GRUB_TIMEOUT:-5}\""},{"line_number":120,"context_line":"append_or_replace /etc/default/grub GRUB_TIMEOUT_STYLE \"${DIB_GRUB_TIMEOUT_STYLE:-menu}\""},{"line_number":121,"context_line":"if [[ \"True\" \u003d\u003d \"${DIB_BOOTLOADER_USE_SERIAL_CONSOLE:-True}\" ]]; then"},{"line_number":122,"context_line":"    append_or_replace /etc/default/grub GRUB_TERMINAL \\\"\"serial console\"\\\""},{"line_number":123,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"34a3ce51_196b257a","line":120,"in_reply_to":"5b9402ee_5dfdf6b0","updated":"2025-02-17 16:50:25.000000000","message":"Done","commit_id":"dd2dc004a1b9e18ea5be2fd51cb01da8dda424f6"}],"releasenotes/notes/grub_style-dfafe48d719f5579.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ad5e2d36e97c1eaf673f9ede7781dc6cecab82e7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality which prevents overwriting image default grub options"},{"line_number":5,"context_line":"    ``DIB_GRUB_TIMEOUT_STYLE`` and ``DIB_GRUB_TIMEOUT`` if those variables"},{"line_number":6,"context_line":"    are not set. The default value for ``DIB_GRUB_TIMEOUT_STYLE`` will be"},{"line_number":7,"context_line":"    ``menu`` and for ``DIB_GRUB_TIMEOUT`` will be ``5`` as per"},{"line_number":8,"context_line":"    [Grub](https://www.gnu.org/software/grub/manual/grub/html_node/Simple-configuration.html) project documentation."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f520399_3bfb724b","line":9,"range":{"start_line":6,"start_character":17,"end_line":9,"end_character":1},"updated":"2024-12-18 15:57:10.000000000","message":"I don\u0027t think this is accurate. We are not setting DIB_GRUB_TIMEOUT to 5 or DIB_GRUB_TIMEOUT_STYLE toe menu. We are simply letting grub use whatever defaults it has which may vary distro to distro. I would rewrite this and avoid the implication dib is setting anything and instead indicate grub defaults for the distro packaging will be used.","commit_id":"9f58db0300134adeca267b571edf67f633c26b26"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"cb9ada00ca5fe14954821c7099b909878e31b817","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add functionality which prevents overwriting image default grub options"},{"line_number":5,"context_line":"    ``DIB_GRUB_TIMEOUT_STYLE`` and ``DIB_GRUB_TIMEOUT`` if those variables"},{"line_number":6,"context_line":"    are not set. The default value for ``DIB_GRUB_TIMEOUT_STYLE`` will be"},{"line_number":7,"context_line":"    ``menu`` and for ``DIB_GRUB_TIMEOUT`` will be ``5`` as per"},{"line_number":8,"context_line":"    [Grub](https://www.gnu.org/software/grub/manual/grub/html_node/Simple-configuration.html) project documentation."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"edd6c141_c031c543","line":9,"range":{"start_line":6,"start_character":17,"end_line":9,"end_character":1},"in_reply_to":"1f520399_3bfb724b","updated":"2024-12-20 09:00:02.000000000","message":"Changed approach and values accordingly.","commit_id":"9f58db0300134adeca267b571edf67f633c26b26"}]}