)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"b5e68f51c5a94f7c8e1bb9efa27fd17ce989153b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da85afe3_944f1d2a","updated":"2025-03-06 02:20:53.000000000","message":"Also, now that I figured how to add comments, I should probably link my original PR which goes over what this does and shows the tests I ran: https://github.com/openstack/diskimage-builder/pull/37","commit_id":"a9a4ceb97030f0183bb8a41dc23977761ed3636f"},{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"ecbe70f3ff199d6dc029f634479cd4e96f19ac2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33771614_a1a86893","updated":"2025-03-06 02:19:04.000000000","message":"docker pull limits:\n\n```\nTrying to pull docker.io/opendevorg/python-base:3.11-bookworm...\ntime\u003d\"2025-03-06T01:33:16Z\" level\u003dwarning msg\u003d\"Failed, retrying in 2s ... (1/3). Error: initializing source docker://opendevorg/python-base:3.11-bookworm: (Mirrors also failed: [zuul-jobs.buildset-registry:5000/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in zuul-jobs.buildset-registry:5000/opendevorg/python-base: StatusCode: 404, \\\"\u003c!DOCTYPE html PUBLIC\\\\n\\\\\\\"-//W3C//DTD XHTML 1.0 Trans...\\\"]\\n[docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit]): docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit\"\ntime\u003d\"2025-03-06T01:34:19Z\" level\u003dwarning msg\u003d\"Failed, retrying in 2s ... (2/3). Error: initializing source docker://opendevorg/python-base:3.11-bookworm: (Mirrors also failed: [zuul-jobs.buildset-registry:5000/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in zuul-jobs.buildset-registry:5000/opendevorg/python-base: StatusCode: 404, \\\"\u003c!DOCTYPE html PUBLIC\\\\n\\\\\\\"-//W3C//DTD XHTML 1.0 Trans...\\\"]\\n[docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit]): docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit\"\ntime\u003d\"2025-03-06T01:35:21Z\" level\u003dwarning msg\u003d\"Failed, retrying in 2s ... (3/3). Error: initializing source docker://opendevorg/python-base:3.11-bookworm: (Mirrors also failed: [zuul-jobs.buildset-registry:5000/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in zuul-jobs.buildset-registry:5000/opendevorg/python-base: StatusCode: 404, \\\"\u003c!DOCTYPE html PUBLIC\\\\n\\\\\\\"-//W3C//DTD XHTML 1.0 Trans...\\\"]\\n[docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit]): docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit\"\nError: creating build container: initializing source docker://opendevorg/python-base:3.11-bookworm: (Mirrors also failed: [zuul-jobs.buildset-registry:5000/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in zuul-jobs.buildset-registry:5000/opendevorg/python-base: StatusCode: 404, \"\u003c!DOCTYPE html PUBLIC\\n\\\"-//W3C//DTD XHTML 1.0 Trans...\"]\n[docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit]): docker.io/opendevorg/python-base:3.11-bookworm: reading manifest 3.11-bookworm in docker.io/opendevorg/python-base: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit\n```\n\nIs there a way to restart the build?","commit_id":"a9a4ceb97030f0183bb8a41dc23977761ed3636f"},{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"50a3cab9feb1e19c0f03cfe2baf203d40f988b1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aed94fab_960532cb","in_reply_to":"33771614_a1a86893","updated":"2025-03-06 16:36:41.000000000","message":"I added a new patchset with `git commit --allow-empty --amend`.  This is probably bad so I won\u0027t do it if the build fails again","commit_id":"a9a4ceb97030f0183bb8a41dc23977761ed3636f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c51d825c7f2f6be98d98fa1fb5a6a8543c3ae203","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fe449794_19af8db8","updated":"2025-03-11 20:32:20.000000000","message":"Thanks Stephen, good start.\n\nAs a note: the gentoo CI job is flakey, if it\u0027s timing out now it\u0027s likely broken. You can try to fix it if you want (usually means a required migration hasn\u0027t been reflected here), but otherwise I won\u0027t judge your patch on if that CI passes.","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"},{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"91e10e61ec069720f091662436525def9a86b330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ac45a4f7_9f977fbd","updated":"2025-03-17 12:47:28.000000000","message":"I also clean up some other things related to circular dependencies and debug output.  Let me know if anything needs to be split out into a separate review","commit_id":"b7d139afe03f24fae72b6fa48a8e818d02592eb4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b883a682fab39e4ffb756b97816c69c2a5718bef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ef1f8550_75767fa5","updated":"2025-04-30 21:20:19.000000000","message":"Very close. Sorry for the latency on the review; you can ping me (JayF) in a gentoo or openstack channel as a prod for a re-review if I let it sit this long again.","commit_id":"08e0fc9ccdb71c07403364dc7077e2a9f9c827e6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"e5a0bfd877b3f44066bac5d89e9707ee06f4cc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c1cb9c12_e598cfca","updated":"2025-05-06 20:07:31.000000000","message":"if CI is happy, I am","commit_id":"93e7761b51104cb4e3bc6d061ae9965a38971e21"}],"diskimage_builder/elements/gentoo/bin/install-packages":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c51d825c7f2f6be98d98fa1fb5a6a8543c3ae203","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#             unset the environment to ensure default behavior."},{"line_number":27,"context_line":"unset YACC LEX"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export GENTOO_ACCEPT_KEYWORDS\u003d${GENTOO_ACCEPT_KEYWORDS:-\"${ARCH}\"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# env is not sourced with user specified package inclusions"},{"line_number":32,"context_line":"# set the default bash array if GENTOO_EMERGE_ENV is not defined as an array"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ebd1c2b0_cf61d70f","line":29,"updated":"2025-03-11 20:32:20.000000000","message":"Please move this to environment.d/00-gentoo-envvars.bash -- also we should note in the commit message/release note that we\u0027ve added support for setting keywords,\n\nI also wonder if maybe a better interface for this would be a boolean to enable testing packages; but that would prevent use of ** for unkeyworded packages...","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"},{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"91e10e61ec069720f091662436525def9a86b330","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#             unset the environment to ensure default behavior."},{"line_number":27,"context_line":"unset YACC LEX"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export GENTOO_ACCEPT_KEYWORDS\u003d${GENTOO_ACCEPT_KEYWORDS:-\"${ARCH}\"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# env is not sourced with user specified package inclusions"},{"line_number":32,"context_line":"# set the default bash array if GENTOO_EMERGE_ENV is not defined as an array"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"d975a9d8_9ef27611","line":29,"in_reply_to":"ebd1c2b0_cf61d70f","updated":"2025-03-17 12:47:28.000000000","message":"Acknowledged","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c51d825c7f2f6be98d98fa1fb5a6a8543c3ae203","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# set the default bash array if GENTOO_EMERGE_ENV is not defined as an array"},{"line_number":33,"context_line":"if ! declare -p GENTOO_EMERGE_ENV  2\u003e /dev/null | grep -q \u0027^declare \\-a\u0027; then"},{"line_number":34,"context_line":"    declare -a GENTOO_EMERGE_ENV"},{"line_number":35,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"USE\u003d\\\"-build dist-kernel\\\"\")"},{"line_number":36,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"FEATURES\u003d\\\"binpkg-multi-instance buildpkg parallel-fetch parallel-install\\\"\")"},{"line_number":37,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":38,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"8d742977_feaa999b","line":35,"updated":"2025-03-11 20:32:20.000000000","message":"as a note for non-gentoo folks: all this does is add a trigger to rebuild modules/initramfs when certain kernel-module-providing packages are installed or upgrade; it\u0027s fairly safe to set even if not using a dist-kernel.","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"015b1396b3f84729ca44c1ef57cc6bab4b2117d1","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            install_gentoo_packages --update --deep --changed-use @world"},{"line_number":87,"context_line":"            if [[ \"${GENTOO_PORTAGE_CLEANUP}\" !\u003d \"False\" ]]; then"},{"line_number":88,"context_line":"                # remove unneeded packages"},{"line_number":89,"context_line":"                emerge --verbose\u003dn --depclean"},{"line_number":90,"context_line":"            fi"},{"line_number":91,"context_line":"            install_gentoo_packages --usepkg\u003dn @preserved-rebuild"},{"line_number":92,"context_line":"            etc-update --automode -5"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"41343b86_e3042c1b","line":89,"updated":"2025-03-17 19:48:54.000000000","message":"Why stop using the helper?","commit_id":"b7d139afe03f24fae72b6fa48a8e818d02592eb4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b883a682fab39e4ffb756b97816c69c2a5718bef","unresolved":true,"context_lines":[{"line_number":35,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":36,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":37,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"},{"line_number":38,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"ACCEPT_KEYWORDS\u003d\\\"${GENTOO_ACCEPT_KEYWORDS}\\\"\")"},{"line_number":39,"context_line":"    export GENTOO_EMERGE_ENV"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":"# iterate over the array, exporting each \u0027line\u0027"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7826435b_9d6e3a4f","line":38,"updated":"2025-04-30 21:20:19.000000000","message":"similar to 00-environment, this should only be set if explicitly set","commit_id":"08e0fc9ccdb71c07403364dc7077e2a9f9c827e6"}],"diskimage_builder/elements/gentoo/environment.d/00-gentoo-envars.bash":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"015b1396b3f84729ca44c1ef57cc6bab4b2117d1","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PKGDIR\u003d\\\"/tmp/portage-pkgdir\\\"\")"},{"line_number":24,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"DISTDIR\u003d\\\"/tmp/portage-distdir\\\"\")"},{"line_number":25,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"PORTDIR\u003d\\\"/tmp/portage-portdir\\\"\")"},{"line_number":26,"context_line":"    GENTOO_EMERGE_ENV+\u003d(\"ACCEPT_KEYWORDS\u003d\\\"${GENTOO_ACCEPT_KEYWORDS}\\\"\")"},{"line_number":27,"context_line":"    export GENTOO_EMERGE_ENV"},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":"# iterate over the array, exporting each \u0027line\u0027"}],"source_content_type":"text/x-sh","patch_set":6,"id":"82a9334c_920cb8a9","line":26,"updated":"2025-03-17 19:48:54.000000000","message":"Shouldn\u0027t we just leave this unset until explicitly set? I don\u0027t think we should override profile defaults with the default value.","commit_id":"b7d139afe03f24fae72b6fa48a8e818d02592eb4"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"b883a682fab39e4ffb756b97816c69c2a5718bef","unresolved":true,"context_lines":[{"line_number":7,"context_line":"export GENTOO_OVERLAYS\u003d${GENTOO_OVERLAYS:-\u0027\u0027}"},{"line_number":8,"context_line":"export GENTOO_CUSTOM_OVERLAYS\u003d${GENTOO_CUSTOM_OVERLAYS:-\u0027\u0027}"},{"line_number":9,"context_line":"export GENTOO_EMERGE_DEFAULT_OPTS\u003d${GENTOO_EMERGE_DEFAULT_OPTS:-\"--binpkg-respect-use --rebuilt-binaries\u003dy --usepkg\u003dy --with-bdeps\u003dy --binpkg-changed-deps\u003dy --quiet --jobs\u003d2 --autounmask\u003dn\"}"},{"line_number":10,"context_line":"export GENTOO_ACCEPT_KEYWORDS\u003d${GENTOO_ACCEPT_KEYWORDS:-\"${ARCH}\"}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# NOTE(JayF): This defines the base gentoo profile version supported"},{"line_number":13,"context_line":"# in DIB. As gentoo is a rolling release distro, the older profiles"}],"source_content_type":"text/x-sh","patch_set":7,"id":"cf34a316_036000d8","line":10,"updated":"2025-04-30 21:20:19.000000000","message":"Please do not set this unless explicitly set by a user.","commit_id":"08e0fc9ccdb71c07403364dc7077e2a9f9c827e6"}],"diskimage_builder/elements/gentoo/post-install.d/99-cleanup":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c51d825c7f2f6be98d98fa1fb5a6a8543c3ae203","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if [[ ${GENTOO_OVERLAYS} !\u003d \u0027\u0027 ]]; then"},{"line_number":40,"context_line":"        for OVERLAY in ${GENTOO_OVERLAYS}; do"},{"line_number":41,"context_line":"            eselect repository remove \"${OVERLAY}\""},{"line_number":42,"context_line":"        done"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"    if [[ ${GENTOO_CUSTOM_OVERLAY} !\u003d \u0027\u0027 ]]; then"},{"line_number":45,"context_line":"        for OVERLAY in ${GENTOO_CUSTOM_OVERLAYS}; do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ab1b3eb2_a58c0f57","line":42,"updated":"2025-03-11 20:32:20.000000000","message":"++ but it seems to me like we should be adding eselect-respisitory (and removing layman) from a list of pacakges somewhere","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"},{"author":{"_account_id":37793,"name":"Stephen Reaves","display_name":"Stephen Reaves","email":"reaves735@gmail.com","username":"reavessm"},"change_message_id":"91e10e61ec069720f091662436525def9a86b330","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    if [[ ${GENTOO_OVERLAYS} !\u003d \u0027\u0027 ]]; then"},{"line_number":40,"context_line":"        for OVERLAY in ${GENTOO_OVERLAYS}; do"},{"line_number":41,"context_line":"            eselect repository remove \"${OVERLAY}\""},{"line_number":42,"context_line":"        done"},{"line_number":43,"context_line":"    fi"},{"line_number":44,"context_line":"    if [[ ${GENTOO_CUSTOM_OVERLAY} !\u003d \u0027\u0027 ]]; then"},{"line_number":45,"context_line":"        for OVERLAY in ${GENTOO_CUSTOM_OVERLAYS}; do"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"62fe9a64_0a0d3903","line":42,"in_reply_to":"ab1b3eb2_a58c0f57","updated":"2025-03-17 12:47:28.000000000","message":"I\u0027ve added this to `package-install.yaml`, but we also emerge it via --oneshot in `pre-install.d/02-gentoo-03-enable-overlays`","commit_id":"3afc5f2b9ae8e03db23d648f21a8f571eb5af5f5"}]}