)]}'
{".zuul.d/jobs.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a5c65ea6c0cbfea5b49bf6ce8e1a10b30db5547d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/opendev/glean"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":90,"context_line":"    irrelevant-files:"},{"line_number":91,"context_line":"      - ^.*\\.rst$"},{"line_number":92,"context_line":"      - ^doc/.*$"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"809cec2a_da078249","line":89,"updated":"2025-06-11 16:15:33.000000000","message":"I think that we should add diskimage-builder to this list so that when this job runs against glean we pull in dib too.","commit_id":"b0f80c91f7742a447806f286ae4906c6301d3b2c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7655bb7810ea32f5d24ee12cf6c777e91d65b8a5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/opendev/glean"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":90,"context_line":"    irrelevant-files:"},{"line_number":91,"context_line":"      - ^.*\\.rst$"},{"line_number":92,"context_line":"      - ^doc/.*$"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"b67973bb_a3946bc6","line":89,"in_reply_to":"809cec2a_da078249","updated":"2025-06-16 15:42:38.000000000","message":"Done","commit_id":"b0f80c91f7742a447806f286ae4906c6301d3b2c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f54af9c0b73f9a5ef8543f10f09a161ef07993bd","unresolved":true,"context_lines":[{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib, openstacksdk and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/node-information.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"},{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"76e3468b_a90117d1","line":84,"updated":"2025-06-12 17:52:18.000000000","message":"Note this playbook runs commands that get installed by devstack which doesn\u0027t actually run until the run playbook. We may need to move things around to get working node information output. I think it would be ok to install devstack in pre-run since we\u0027re not testing openstack. Then collect node information in pre-run and finally do the dib stuff in run.","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7655bb7810ea32f5d24ee12cf6c777e91d65b8a5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib, openstacksdk and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/node-information.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"},{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5718b9b9_0bc4b757","line":84,"in_reply_to":"76e3468b_a90117d1","updated":"2025-06-16 15:42:38.000000000","message":"Done","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Base job for DIB functional tests, which build and boot an image"},{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib, openstacksdk and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"201169ab_55c744f7","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":33},"updated":"2025-06-20 08:08:32.000000000","message":"I don\u0027t see this in required-projects, so a depends-on on it likely wouldn\u0027t work?","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Base job for DIB functional tests, which build and boot an image"},{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib, openstacksdk and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5c44bfb5_c7c809a7","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":33},"in_reply_to":"201169ab_55c744f7","updated":"2025-06-20 14:31:57.000000000","message":"Nodepool depends on openstacksdk which is why the old nodepool job had the ability to test openstacksdk from source. DIB itself does not depend on openstacksdk just this test harness. I think we can remove the openstacksdk project from the projects list safeuly and just clean up this description.\n\nThe new job will be focused on dib and glean. Devstack and openstacksdk are just implementation details.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Base job for DIB functional tests, which build and boot an image"},{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib, openstacksdk and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ed4cd0c8_5a284b21","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":33},"in_reply_to":"5c44bfb5_c7c809a7","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"},{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/diskimage-builder"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"cca00170_62b7b3f3","line":86,"updated":"2025-06-20 08:08:32.000000000","message":"I don\u0027t actually see the files from this in the job results? instead there are the \"usual\" devstack job results in place, so maybe this isn\u0027t even needed?","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"},{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/diskimage-builder"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"e8bf8c89_0b9ad7f6","line":86,"in_reply_to":"8249bed6_26ec3403","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"},{"line_number":86,"context_line":"    post-run: playbooks/dib-devstack/collect-openstack-logs.yaml"},{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/diskimage-builder"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"8249bed6_26ec3403","line":86,"in_reply_to":"cca00170_62b7b3f3","updated":"2025-06-20 14:31:57.000000000","message":"https://zuul.opendev.org/t/openstack/build/db841015fc6e4ec9bcafe4340e7067d6/console#7/0/1/controller the playbook is running but I think beacuse it writes out to /var/log/nodepool we\u0027re no longer collecting that log dir for log files. But as mentioned this doesn\u0027t seem necessary so maybe we can drop that playbook entirely.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/diskimage-builder"},{"line_number":90,"context_line":"      - name: opendev.org/opendev/glean"},{"line_number":91,"context_line":"      - name: opendev.org/openstack/requirements"},{"line_number":92,"context_line":"    irrelevant-files:"},{"line_number":93,"context_line":"      - ^.*\\.rst$"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3883895b_09ce1382","line":90,"updated":"2025-06-20 08:08:32.000000000","message":"nit: I would prefer to sort by the full name instead of just the repo name (last component), that would place this entry first in the list","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    required-projects:"},{"line_number":88,"context_line":"      - name: opendev.org/openstack/devstack"},{"line_number":89,"context_line":"      - name: opendev.org/openstack/diskimage-builder"},{"line_number":90,"context_line":"      - name: opendev.org/opendev/glean"},{"line_number":91,"context_line":"      - name: opendev.org/openstack/requirements"},{"line_number":92,"context_line":"    irrelevant-files:"},{"line_number":93,"context_line":"      - ^.*\\.rst$"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"eb09cd7c_5ec00c6d","line":90,"in_reply_to":"3883895b_09ce1382","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            + default_elements"},{"line_number":112,"context_line":"            + diskimage.additional_elements|default([]) ) | flatten }}"},{"line_number":113,"context_line":"      default_diskimage_environment:"},{"line_number":114,"context_line":"        TMPDIR: \"/{{ ansible_user_dir }}/dib_tmp\""},{"line_number":115,"context_line":"        ELEMENTS_PATH: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/diskimage-builder\u0027].src_dir }}/diskimage_builder/elements\""},{"line_number":116,"context_line":"        DIB_RELEASE: \"{{ diskimage.release }}\""},{"line_number":117,"context_line":"        ROOT_LABEL: \u0027gate-rootfs\u0027"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"1fa8afd3_6eb6095a","line":114,"range":{"start_line":114,"start_character":17,"end_line":114,"end_character":18},"updated":"2025-06-20 08:08:32.000000000","message":"```suggestion\n        TMPDIR: \"{{ ansible_user_dir }}/dib_tmp\"\n```\nnot actually wrong, but redundant and confusing","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            + default_elements"},{"line_number":112,"context_line":"            + diskimage.additional_elements|default([]) ) | flatten }}"},{"line_number":113,"context_line":"      default_diskimage_environment:"},{"line_number":114,"context_line":"        TMPDIR: \"/{{ ansible_user_dir }}/dib_tmp\""},{"line_number":115,"context_line":"        ELEMENTS_PATH: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/openstack/diskimage-builder\u0027].src_dir }}/diskimage_builder/elements\""},{"line_number":116,"context_line":"        DIB_RELEASE: \"{{ diskimage.release }}\""},{"line_number":117,"context_line":"        ROOT_LABEL: \u0027gate-rootfs\u0027"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"17f7e759_d24629aa","line":114,"range":{"start_line":114,"start_character":17,"end_line":114,"end_character":18},"in_reply_to":"1fa8afd3_6eb6095a","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":121,"context_line":"        DIB_REPOLOCATION_glean: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].src_dir }}\""},{"line_number":122,"context_line":"        DIB_REPOREF_glean: \"{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].checkout }}\""},{"line_number":123,"context_line":"      build_diskimage_environment: \"{{ default_diskimage_environment|combine(diskimage[\u0027env-vars\u0027]|default({})) }}\""},{"line_number":124,"context_line":"      # NOTE(tonyb):  For the time being we need to disable this as the cli-server always uses the \u0027devstack\u0027"},{"line_number":125,"context_line":"      #               cloud and therefore the private network ends in the wrong tennant and causes failures"},{"line_number":126,"context_line":"      devstack_services:"},{"line_number":127,"context_line":"        openstack-cli-server: false"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"99b6280d_399d15b1","line":124,"range":{"start_line":124,"start_character":100,"end_line":124,"end_character":108},"updated":"2025-06-20 08:08:32.000000000","message":"```suggestion\n      # NOTE(tonyb):  For the time being we need to disable this as the cli-server always uses the \u0027devstack-admin\u0027\n```","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        DIB_REPOLOCATION_glean: \"{{ ansible_user_dir }}/{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].src_dir }}\""},{"line_number":122,"context_line":"        DIB_REPOREF_glean: \"{{ zuul.projects[\u0027opendev.org/opendev/glean\u0027].checkout }}\""},{"line_number":123,"context_line":"      build_diskimage_environment: \"{{ default_diskimage_environment|combine(diskimage[\u0027env-vars\u0027]|default({})) }}\""},{"line_number":124,"context_line":"      # NOTE(tonyb):  For the time being we need to disable this as the cli-server always uses the \u0027devstack\u0027"},{"line_number":125,"context_line":"      #               cloud and therefore the private network ends in the wrong tennant and causes failures"},{"line_number":126,"context_line":"      devstack_services:"},{"line_number":127,"context_line":"        openstack-cli-server: false"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3a789c56_9685ffc2","line":124,"range":{"start_line":124,"start_character":100,"end_line":124,"end_character":108},"in_reply_to":"99b6280d_399d15b1","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":true,"context_lines":[{"line_number":124,"context_line":"      # NOTE(tonyb):  For the time being we need to disable this as the cli-server always uses the \u0027devstack\u0027"},{"line_number":125,"context_line":"      #               cloud and therefore the private network ends in the wrong tennant and causes failures"},{"line_number":126,"context_line":"      devstack_services:"},{"line_number":127,"context_line":"        openstack-cli-server: false"},{"line_number":128,"context_line":"      devstack_localrc:"},{"line_number":129,"context_line":"        SWIFT_MAX_FILE_SIZE: 5368709122 # 5G + 2 bytes (swift default)"},{"line_number":130,"context_line":"        SWIFT_LOOPBACK_DISK_SIZE: \"6G\"  # Alittle more than ^^"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"b3b3513f_a6eaaade","line":127,"updated":"2025-06-20 14:31:57.000000000","message":"One option here may be to install openstackclient into a venv for the test framework. Then devstack can do its optimized openstack client work (which should help with job runtime) and we can run openstack client specifically for testing against the cloud using the optimized version for the few things we need in testing.\n\nTotally fine with that being a followup improvement though. Getting things working is step one.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"29e50f000309ecdb7fdb1495f3c11f271042acba","unresolved":true,"context_lines":[{"line_number":124,"context_line":"      # NOTE(tonyb):  For the time being we need to disable this as the cli-server always uses the \u0027devstack\u0027"},{"line_number":125,"context_line":"      #               cloud and therefore the private network ends in the wrong tennant and causes failures"},{"line_number":126,"context_line":"      devstack_services:"},{"line_number":127,"context_line":"        openstack-cli-server: false"},{"line_number":128,"context_line":"      devstack_localrc:"},{"line_number":129,"context_line":"        SWIFT_MAX_FILE_SIZE: 5368709122 # 5G + 2 bytes (swift default)"},{"line_number":130,"context_line":"        SWIFT_LOOPBACK_DISK_SIZE: \"6G\"  # Alittle more than ^^"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5de67b6a_2b74c880","line":127,"in_reply_to":"b3b3513f_a6eaaade","updated":"2025-06-20 15:10:07.000000000","message":"well the issue is with how devstack uses osc internally, in particular any resources that devstack itself intends to create in the demo tenant instead get created in the admin tenant, like the \"private\" neutron network. the client is still installed into the devstack global venv and can be used from there without issues, but we need this workaround until devstack is fixed","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba9bf75a8a0680013cbbe94a95afbc22c03f92d1","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Base job for DIB functional tests, which build and boot an image"},{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib (or course) and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"db1f0144_69b2f6e1","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":23},"updated":"2025-06-24 09:04:22.000000000","message":"nit\n```suggestion\n      devstack, dib (of course) and glean.\n```","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09e7ac0627be5aa447e0b34a26001b1f73841f03","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    description: |"},{"line_number":80,"context_line":"      Base job for DIB functional tests, which build and boot an image"},{"line_number":81,"context_line":"      under devstack, using source versions of dependencies such as"},{"line_number":82,"context_line":"      devstack, dib (or course) and glean."},{"line_number":83,"context_line":"    parent: devstack"},{"line_number":84,"context_line":"    pre-run: playbooks/dib-devstack/pre.yaml"},{"line_number":85,"context_line":"    run: playbooks/dib-devstack/build-boot-run.yaml"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"d81509e5_cadebc97","line":82,"range":{"start_line":82,"start_character":21,"end_line":82,"end_character":23},"in_reply_to":"db1f0144_69b2f6e1","updated":"2025-06-24 15:12:24.000000000","message":"Fix applied.","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c0bf506362173431cbbe89dab152256356b8bc28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"495221f4_429c7b8a","updated":"2025-06-20 14:48:08.000000000","message":"Just a couple updates on potential task timeout values based on observed runtimes.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"64558d693c89aa912b653bc706a6e537618b00df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"465d7d3f_63325142","updated":"2025-06-20 08:08:44.000000000","message":"check experimental","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"26db2feb_37a14484","updated":"2025-06-20 08:08:32.000000000","message":"some nits, some questions","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09e7ac0627be5aa447e0b34a26001b1f73841f03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"2c1ec742_621b93b2","updated":"2025-06-24 15:12:24.000000000","message":"Took the liberty to apply @frickler@offenerstapel.de suggestions","commit_id":"3ae0f24d9f8941b370f0a92912de0fb0d646c67b"}],"playbooks/dib-devstack/build-boot-run.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b2fc01d3b3894b9ab3ce1bda59e0c07301f2ec1d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    - name: run-devstack"},{"line_number":13,"context_line":"  tasks:"},{"line_number":14,"context_line":"  - name: Ensure additional packages are available"},{"line_number":15,"context_line":"    package:"},{"line_number":16,"context_line":"      name: jq"},{"line_number":17,"context_line":"      state: present"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3719423e_2da4c384","line":15,"updated":"2025-06-11 09:49:41.000000000","message":"needs become here","commit_id":"481b3f92c48f46f439638df56fdcaf51b85351be"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4e4a3c56f70fb105343938bf72bb73003931d4a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    - name: run-devstack"},{"line_number":13,"context_line":"  tasks:"},{"line_number":14,"context_line":"  - name: Ensure additional packages are available"},{"line_number":15,"context_line":"    package:"},{"line_number":16,"context_line":"      name: jq"},{"line_number":17,"context_line":"      state: present"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"339b8235_905987d4","line":15,"in_reply_to":"3719423e_2da4c384","updated":"2025-06-11 14:59:40.000000000","message":"Done","commit_id":"481b3f92c48f46f439638df56fdcaf51b85351be"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"71f8aa60e45701519150567f036d0339708916fd","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    dib_src_path: \"/home/zuul/src/opendev.org/openstack/diskimage-builder\""},{"line_number":6,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":7,"context_line":"    DIB_SSH_KEY: \"$HOME/.ssh/id_dib\""},{"line_number":8,"context_line":"    DIB_SSH_PUBKEY: \"$HOME/.ssh/id_dib.pub\""},{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - name: ensure-dib"},{"line_number":11,"context_line":"    - name: build-diskimage"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e899e6fb_bd5c4bdf","line":8,"updated":"2025-06-12 02:44:52.000000000","message":"There are a few other things I think we need from https://opendev.org/zuul/nodepool/src/branch/master/playbooks/nodepool-functional-container-openstack/templates/nodepool.yaml.j2#L70 to get this going\n\n- the `DIB_REPOREF` bits for glean/simple-init to install glean from the zuul checkout for co-testing\n- the root label probably (for the functional test to work, which looks for that alternative label)\n- I *think* probably the devuser stuff can go away -- seeing as we\u0027re not trying to get nodepool to log into the host probably the keypair that glean installs from openstack metadata should be enough","commit_id":"3a05a7c98daca7d59a879083e04732204adda8e9"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    dib_src_path: \"/home/zuul/src/opendev.org/openstack/diskimage-builder\""},{"line_number":6,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":7,"context_line":"    DIB_SSH_KEY: \"$HOME/.ssh/id_dib\""},{"line_number":8,"context_line":"    DIB_SSH_PUBKEY: \"$HOME/.ssh/id_dib.pub\""},{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - name: ensure-dib"},{"line_number":11,"context_line":"    - name: build-diskimage"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"182e7c35_5be713b3","line":8,"in_reply_to":"e899e6fb_bd5c4bdf","updated":"2025-06-24 03:54:08.000000000","message":"Done in the base/parent job.","commit_id":"3a05a7c98daca7d59a879083e04732204adda8e9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"42b293392a571617e73d23684acac02081a00665","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    dib_src_path: \"/home/zuul/src/opendev.org/openstack/diskimage-builder\""},{"line_number":6,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":7,"context_line":"    DIB_SSH_KEY: \"$HOME/.ssh/id_dib\""},{"line_number":8,"context_line":"    DIB_SSH_PUBKEY: \"$HOME/.ssh/id_dib.pub\""},{"line_number":9,"context_line":"  roles:"},{"line_number":10,"context_line":"    - name: ensure-dib"},{"line_number":11,"context_line":"    - name: build-diskimage"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9f7cde23_43e1b933","line":8,"in_reply_to":"e899e6fb_bd5c4bdf","updated":"2025-06-20 05:03:54.000000000","message":"this all looks good in the job definition","commit_id":"3a05a7c98daca7d59a879083e04732204adda8e9"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"82e1fb6e169e53805e04e9dc8cfadf173985b09e","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        --network public \\"},{"line_number":52,"context_line":"        test-server"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  # It could take a while for nova to convert the qcow2 into raw \"behinds the scene\""},{"line_number":55,"context_line":"  - name: Pause for a minute to allow for image conversion."},{"line_number":56,"context_line":"    pause:"},{"line_number":57,"context_line":"      minutes: 1"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"f77e3a9a_35559bce","line":54,"updated":"2025-06-12 17:42:12.000000000","message":"As an alternative we can instruct dib to build a raw image instaed of a qcow2 then upload that. This may be faster or slower depending on whether or not the raw upload is faster/slower than the qcow2-\u003eraw conversion.\n\nHowever, even if it is slower reducing the total moving parts on the openstack side of things is probably a good idea. We\u0027re trying to test dib not necessarily nova image management.","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        --network public \\"},{"line_number":52,"context_line":"        test-server"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  # It could take a while for nova to convert the qcow2 into raw \"behinds the scene\""},{"line_number":55,"context_line":"  - name: Pause for a minute to allow for image conversion."},{"line_number":56,"context_line":"    pause:"},{"line_number":57,"context_line":"      minutes: 1"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"fb638f8c_a703f90a","line":54,"in_reply_to":"f77e3a9a_35559bce","updated":"2025-06-20 14:31:57.000000000","message":"Done","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        --network public \\"},{"line_number":52,"context_line":"        test-server"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  # It could take a while for nova to convert the qcow2 into raw \"behinds the scene\""},{"line_number":55,"context_line":"  - name: Pause for a minute to allow for image conversion."},{"line_number":56,"context_line":"    pause:"},{"line_number":57,"context_line":"      minutes: 1"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"616eb69c_0f8ca119","line":54,"in_reply_to":"f77e3a9a_35559bce","updated":"2025-06-24 03:54:08.000000000","message":"Switched to raw, as the QCOW2 format was just wasting gate cycles.","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"82e1fb6e169e53805e04e9dc8cfadf173985b09e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    register: server_status"},{"line_number":63,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") !\u003d \"BUILD\""},{"line_number":64,"context_line":"    retries: 10"},{"line_number":65,"context_line":"    delay: 3"},{"line_number":66,"context_line":"    failed_when: server_status.stdout|from_json|json_query(\"status\") !\u003d \"ACTIVE\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  - name: Convert test-server details to JSON"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7ca92909_6c011ce0","line":65,"updated":"2025-06-12 17:42:12.000000000","message":"Thinking out loud here: Maybe while we\u0027re bootstrapping this tooling we should go ahead and set timeouts to ridiculous values so that we can see what if any steps are failing and for those that succeed get a rough estimate for how long they will take.\n\nAs is we\u0027re constraining things and may just be running up against these artificial walls we\u0027ve built.","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d42383b52436e94bd4fc2bbdbd33e21f21c63158","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    register: server_status"},{"line_number":63,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") !\u003d \"BUILD\""},{"line_number":64,"context_line":"    retries: 10"},{"line_number":65,"context_line":"    delay: 3"},{"line_number":66,"context_line":"    failed_when: server_status.stdout|from_json|json_query(\"status\") !\u003d \"ACTIVE\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  - name: Convert test-server details to JSON"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3a6f63e9_40df920d","line":65,"in_reply_to":"51535f02_d5335c43","updated":"2025-06-24 15:16:33.000000000","message":"Acknowledged","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    register: server_status"},{"line_number":63,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") !\u003d \"BUILD\""},{"line_number":64,"context_line":"    retries: 10"},{"line_number":65,"context_line":"    delay: 3"},{"line_number":66,"context_line":"    failed_when: server_status.stdout|from_json|json_query(\"status\") !\u003d \"ACTIVE\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  - name: Convert test-server details to JSON"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"51535f02_d5335c43","line":65,"in_reply_to":"7ca92909_6c011ce0","updated":"2025-06-24 03:54:08.000000000","message":"Acknowledged","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    register: server_status"},{"line_number":63,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") !\u003d \"BUILD\""},{"line_number":64,"context_line":"    retries: 10"},{"line_number":65,"context_line":"    delay: 3"},{"line_number":66,"context_line":"    failed_when: server_status.stdout|from_json|json_query(\"status\") !\u003d \"ACTIVE\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  - name: Convert test-server details to JSON"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"43fe4a28_7b8f98d6","line":65,"in_reply_to":"7ca92909_6c011ce0","updated":"2025-06-20 14:31:57.000000000","message":"Done","commit_id":"6d444cf3ce022b0d7159fe5128366d936fe21164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"$HOME/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"$HOME/.ssh/id_dib.pub\""},{"line_number":8,"context_line":"  roles:"},{"line_number":9,"context_line":"    - name: ensure-dib"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5d4c6c9e_271b722f","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":23},"updated":"2025-06-20 08:08:32.000000000","message":"why is this not `ansible_user_dir` as above?","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"$HOME/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"$HOME/.ssh/id_dib.pub\""},{"line_number":8,"context_line":"  roles:"},{"line_number":9,"context_line":"    - name: ensure-dib"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"39e91fee_73485a06","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":23},"in_reply_to":"5d4c6c9e_271b722f","updated":"2025-06-24 03:54:08.000000000","message":"Mostly because lines 5-7 were borrowed, from the matching spot in the nodepool repo, where as line 4 was written by me.  Similar to the case of the var name.\n\nI also kinda like that the $HOME / DIB_ variants are passed to/used by the shell module of ansible and the {{ ansible_user_dir }} / dib_ are are passed to/used by the command module.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        --network private \\"},{"line_number":51,"context_line":"        test-server"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Give it, up to, another 30 seconds to boot or fail"},{"line_number":54,"context_line":"  # TODO(clarkb) fixup retries"},{"line_number":55,"context_line":"  - name: Wait for server to boot or fail"},{"line_number":56,"context_line":"    command: openstack --os-cloud devstack server show -f json test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"43713e2a_37aa0b59","line":53,"updated":"2025-06-20 08:08:32.000000000","message":"if I read it correctly, the timeout is 30 minutes now?","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"29e50f000309ecdb7fdb1495f3c11f271042acba","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        --network private \\"},{"line_number":51,"context_line":"        test-server"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Give it, up to, another 30 seconds to boot or fail"},{"line_number":54,"context_line":"  # TODO(clarkb) fixup retries"},{"line_number":55,"context_line":"  - name: Wait for server to boot or fail"},{"line_number":56,"context_line":"    command: openstack --os-cloud devstack server show -f json test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"565cc1bb_6066ef4d","line":53,"in_reply_to":"05f37589_bbd1ed65","updated":"2025-06-20 15:10:07.000000000","message":"either way works for me, just let\u0027s make sure the comment matches the code","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        --network private \\"},{"line_number":51,"context_line":"        test-server"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Give it, up to, another 30 seconds to boot or fail"},{"line_number":54,"context_line":"  # TODO(clarkb) fixup retries"},{"line_number":55,"context_line":"  - name: Wait for server to boot or fail"},{"line_number":56,"context_line":"    command: openstack --os-cloud devstack server show -f json test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"05f37589_bbd1ed65","line":53,"in_reply_to":"43713e2a_37aa0b59","updated":"2025-06-20 14:31:57.000000000","message":"I was the one who edited the retries and delay values below but didn\u0027t edit the comments. I did that because it wasn\u0027t clear how long we should expect each task to take on a reasonable system. Now that we have test results I think we should look at them see what typical runtime is then double that and encode that in the retries/delay and comment above.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        --network private \\"},{"line_number":51,"context_line":"        test-server"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  # Give it, up to, another 30 seconds to boot or fail"},{"line_number":54,"context_line":"  # TODO(clarkb) fixup retries"},{"line_number":55,"context_line":"  - name: Wait for server to boot or fail"},{"line_number":56,"context_line":"    command: openstack --os-cloud devstack server show -f json test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"3165732a_6396f17d","line":53,"in_reply_to":"565cc1bb_6066ef4d","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c0bf506362173431cbbe89dab152256356b8bc28","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    register: server_status"},{"line_number":58,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") \u003d\u003d \"ACTIVE\""},{"line_number":59,"context_line":"    retries: 600"},{"line_number":60,"context_line":"    delay: 3"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - name: Convert test-server details to JSON"},{"line_number":63,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"31562522_8a140c83","line":60,"updated":"2025-06-20 14:48:08.000000000","message":"In the test jobs run for patchset 40 I see 6-17 retries on this task. Given that range maybe we set the \"timeout\" to either 300 seconds or 600 seconds here? That would be retries: 100 delay 3 or retries: 200 delay: 3","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    register: server_status"},{"line_number":58,"context_line":"    until: server_status.stdout|from_json|json_query(\"status\") \u003d\u003d \"ACTIVE\""},{"line_number":59,"context_line":"    retries: 600"},{"line_number":60,"context_line":"    delay: 3"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - name: Convert test-server details to JSON"},{"line_number":63,"context_line":"    set_fact:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ba38f5e8_9b92b449","line":60,"in_reply_to":"31562522_8a140c83","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    retries: 600"},{"line_number":60,"context_line":"    delay: 3"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - name: Convert test-server details to JSON"},{"line_number":63,"context_line":"    set_fact:"},{"line_number":64,"context_line":"      server_status: \"{{ server_status.stdout|from_json }}\""},{"line_number":65,"context_line":"      floating_ip: \"{{ floating_ip.stdout|from_json }}\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"1c3cbf78_4a836465","line":62,"range":{"start_line":62,"start_character":38,"end_line":62,"end_character":40},"updated":"2025-06-20 08:08:32.000000000","message":"```suggestion\n  - name: Convert test-server details from JSON\n```","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    retries: 600"},{"line_number":60,"context_line":"    delay: 3"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  - name: Convert test-server details to JSON"},{"line_number":63,"context_line":"    set_fact:"},{"line_number":64,"context_line":"      server_status: \"{{ server_status.stdout|from_json }}\""},{"line_number":65,"context_line":"      floating_ip: \"{{ floating_ip.stdout|from_json }}\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"a8272187_ae6e680b","line":62,"range":{"start_line":62,"start_character":38,"end_line":62,"end_character":40},"in_reply_to":"1c3cbf78_4a836465","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - name: Check for ssh connectivity with log collection on failure"},{"line_number":89,"context_line":"    block:"},{"line_number":90,"context_line":"      # Wait a total of 10 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG"},{"line_number":91,"context_line":"      # TODO(clarkb) fixup retries"},{"line_number":92,"context_line":"      - name: Wait for SSH to come online"},{"line_number":93,"context_line":"        command: ssh-keyscan -4 test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"7f9b97ae_f9787b54","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":31},"updated":"2025-06-20 08:08:32.000000000","message":"```suggestion\n      # Wait a total of 30 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG\n```","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"186ce17f0bf0c70b073167b961be907cddffd253","unresolved":true,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - name: Check for ssh connectivity with log collection on failure"},{"line_number":89,"context_line":"    block:"},{"line_number":90,"context_line":"      # Wait a total of 10 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG"},{"line_number":91,"context_line":"      # TODO(clarkb) fixup retries"},{"line_number":92,"context_line":"      - name: Wait for SSH to come online"},{"line_number":93,"context_line":"        command: ssh-keyscan -4 test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"e664cf39_2951a86b","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":31},"in_reply_to":"7f9b97ae_f9787b54","updated":"2025-06-20 14:31:57.000000000","message":"See above.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - name: Check for ssh connectivity with log collection on failure"},{"line_number":89,"context_line":"    block:"},{"line_number":90,"context_line":"      # Wait a total of 10 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG"},{"line_number":91,"context_line":"      # TODO(clarkb) fixup retries"},{"line_number":92,"context_line":"      - name: Wait for SSH to come online"},{"line_number":93,"context_line":"        command: ssh-keyscan -4 test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"1fbc8090_9d3c3c63","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":31},"in_reply_to":"e664cf39_2951a86b","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":90,"context_line":"      # Wait a total of 10 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG"},{"line_number":91,"context_line":"      # TODO(clarkb) fixup retries"},{"line_number":92,"context_line":"      - name: Wait for SSH to come online"},{"line_number":93,"context_line":"        command: ssh-keyscan -4 test-server"},{"line_number":94,"context_line":"        register: keyscan"},{"line_number":95,"context_line":"        until: keyscan.rc \u003d\u003d 0"},{"line_number":96,"context_line":"        retries: 180"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"be03d3bc_e30344d3","line":93,"updated":"2025-06-20 08:08:32.000000000","message":"side-note: it would be nice if we could also verify IPv6 connectivity, maybe add a todo comment for that?","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      # Wait a total of 10 mins, this is fairly high as we\u0027re probably running in \"usermode emulation\" QEMU+TCG"},{"line_number":91,"context_line":"      # TODO(clarkb) fixup retries"},{"line_number":92,"context_line":"      - name: Wait for SSH to come online"},{"line_number":93,"context_line":"        command: ssh-keyscan -4 test-server"},{"line_number":94,"context_line":"        register: keyscan"},{"line_number":95,"context_line":"        until: keyscan.rc \u003d\u003d 0"},{"line_number":96,"context_line":"        retries: 180"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"e6469baa_69d64ffb","line":93,"in_reply_to":"be03d3bc_e30344d3","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c0bf506362173431cbbe89dab152256356b8bc28","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        register: keyscan"},{"line_number":95,"context_line":"        until: keyscan.rc \u003d\u003d 0"},{"line_number":96,"context_line":"        retries: 180"},{"line_number":97,"context_line":"        delay: 10"},{"line_number":98,"context_line":"    rescue:"},{"line_number":99,"context_line":"      - name: Print console logs"},{"line_number":100,"context_line":"        command: openstack --os-cloud devstack console log show test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"68147b53_9a898ef4","line":97,"updated":"2025-06-20 14:48:08.000000000","message":"In the test jobs run for patchset 40 I see 10-49 retries on this task. Given that range maybe we set the \"timeout\" to 1200 seconds? That would be retries: 120 delay: 10.","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        register: keyscan"},{"line_number":95,"context_line":"        until: keyscan.rc \u003d\u003d 0"},{"line_number":96,"context_line":"        retries: 180"},{"line_number":97,"context_line":"        delay: 10"},{"line_number":98,"context_line":"    rescue:"},{"line_number":99,"context_line":"      - name: Print console logs"},{"line_number":100,"context_line":"        command: openstack --os-cloud devstack console log show test-server"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"6ba7074b_09643f2a","line":97,"in_reply_to":"68147b53_9a898ef4","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"238adf45a7cdac8b936f26cc185cf08502945921","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    rescue:"},{"line_number":99,"context_line":"      - name: Print console logs"},{"line_number":100,"context_line":"        command: openstack --os-cloud devstack console log show test-server"},{"line_number":101,"context_line":"      - name: Force failure now that were in the rescue block"},{"line_number":102,"context_line":"        fail:"},{"line_number":103,"context_line":"          msg: SSH connectivity failed"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"142745a4_0d46a06e","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":41},"updated":"2025-06-20 08:08:32.000000000","message":"```suggestion\n      - name: Force failure now that we\u0027re in the rescue block\n```","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    rescue:"},{"line_number":99,"context_line":"      - name: Print console logs"},{"line_number":100,"context_line":"        command: openstack --os-cloud devstack console log show test-server"},{"line_number":101,"context_line":"      - name: Force failure now that were in the rescue block"},{"line_number":102,"context_line":"        fail:"},{"line_number":103,"context_line":"          msg: SSH connectivity failed"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"b1f9e599_43036830","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":41},"in_reply_to":"142745a4_0d46a06e","updated":"2025-06-24 03:54:08.000000000","message":"Done","commit_id":"73934e7b23e9dd17077f7e917b37b05e93e27635"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba9bf75a8a0680013cbbe94a95afbc22c03f92d1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  gather_facts: false"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"{{ ansible_user_dir}}/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"{{ ansible_user_dir}}/.ssh/id_dib.pub\""}],"source_content_type":"text/x-yaml","patch_set":42,"id":"6b3195ac_993765b2","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":38},"updated":"2025-06-24 09:04:22.000000000","message":"```suggestion\n    dib_src_path: \"{{ ansible_user_dir }}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\"\n```","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09e7ac0627be5aa447e0b34a26001b1f73841f03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  gather_facts: false"},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"{{ ansible_user_dir}}/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"{{ ansible_user_dir}}/.ssh/id_dib.pub\""}],"source_content_type":"text/x-yaml","patch_set":42,"id":"5131f74c_7625754e","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":38},"in_reply_to":"6b3195ac_993765b2","updated":"2025-06-24 15:12:24.000000000","message":"Fix applied.","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba9bf75a8a0680013cbbe94a95afbc22c03f92d1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"{{ ansible_user_dir}}/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"{{ ansible_user_dir}}/.ssh/id_dib.pub\""},{"line_number":8,"context_line":"  roles:"},{"line_number":9,"context_line":"    - name: ensure-dib"},{"line_number":10,"context_line":"    - name: build-diskimage"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"2acfe054_65026865","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":59},"updated":"2025-06-24 09:04:22.000000000","message":"```suggestion\n    DIB_SSH_KEY: \"{{ ansible_user_dir }}/.ssh/id_dib\"\n    DIB_SSH_PUBKEY: \"{{ ansible_user_dir }}/.ssh/id_dib.pub\"\n```","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09e7ac0627be5aa447e0b34a26001b1f73841f03","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    dib_src_path: \"{{ ansible_user_dir}}/{{ zuul[\u0027projects\u0027][\u0027opendev.org/openstack/diskimage-builder\u0027][\u0027src_dir\u0027] }}\""},{"line_number":5,"context_line":"    DIB_KEY_NAME: \"root\""},{"line_number":6,"context_line":"    DIB_SSH_KEY: \"{{ ansible_user_dir}}/.ssh/id_dib\""},{"line_number":7,"context_line":"    DIB_SSH_PUBKEY: \"{{ ansible_user_dir}}/.ssh/id_dib.pub\""},{"line_number":8,"context_line":"  roles:"},{"line_number":9,"context_line":"    - name: ensure-dib"},{"line_number":10,"context_line":"    - name: build-diskimage"}],"source_content_type":"text/x-yaml","patch_set":42,"id":"1848e9e0_58a70e42","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":59},"in_reply_to":"2acfe054_65026865","updated":"2025-06-24 15:12:24.000000000","message":"Fix applied.","commit_id":"908d6a41e8d43b1bad366cb3f18d5df1e951c4cb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b69365d7926db8e40b40abae01bf69b14eb35d8c","unresolved":true,"context_lines":[{"line_number":104,"context_line":"  - name: Run functional tests"},{"line_number":105,"context_line":"    command: \"{{ dib_src_path }}/tools/functional-test-check.sh\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  # - name: Force failure"},{"line_number":108,"context_line":"  #   fail:"},{"line_number":109,"context_line":"  #      msg: Force failure for debugging"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"78caf35e_d0e0d1a7","line":107,"updated":"2025-06-24 17:00:52.000000000","message":"Should that be removed?","commit_id":"3ae0f24d9f8941b370f0a92912de0fb0d646c67b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0c2ee94e8cceae3dde82e69cb11e7dc8a32d678b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  - name: Run functional tests"},{"line_number":105,"context_line":"    command: \"{{ dib_src_path }}/tools/functional-test-check.sh\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  # - name: Force failure"},{"line_number":108,"context_line":"  #   fail:"},{"line_number":109,"context_line":"  #      msg: Force failure for debugging"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"e3489198_aa0214b3","line":107,"in_reply_to":"78caf35e_d0e0d1a7","updated":"2025-06-24 17:04:56.000000000","message":"Done","commit_id":"3ae0f24d9f8941b370f0a92912de0fb0d646c67b"}],"playbooks/roles/dib-install/tasks/main.yaml":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c43b8ea5c34d92fd7a863f0136aae133f5251366","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":38,"id":"30f7fbba_58f57e18","updated":"2025-06-24 03:54:08.000000000","message":"No longer used","commit_id":"fbfd8878c5d818e533497f273a7f5b2a3696f994"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d42383b52436e94bd4fc2bbdbd33e21f21c63158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"10545785_0f3d0940","in_reply_to":"30f7fbba_58f57e18","updated":"2025-06-24 15:16:33.000000000","message":"Acknowledged","commit_id":"fbfd8878c5d818e533497f273a7f5b2a3696f994"}]}