)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"34f21280c70107702c75f71be295613d687e3bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b4a5f56_119d366d","updated":"2025-08-19 21:44:58.000000000","message":"Some thoughts inline. Then for failing CI tests the python36 job is failing because our CI platform doesn\u0027t support ubuntu bionic and its python3.6 version by default anymore (as of Monday). I\u0027ll push a change up to drop that test from diskimage-builder. The dib-functest does capture a potential issue with this change: https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-x86_64-9-latest.x86_64.qcow2.SHA256SUM is an empty 0 byte file and shas256sum rightfully complains about that.\n\nSince we don\u0027t have control over these files upstream of us I\u0027m not sure what we want to do about that. We could try to track down the right person to fix that in centos. We could emit a big warning if the sha256sum file is empty and proceed anyway. Maybe we disable hash checking by default if upstream isn\u0027t going to keep those files up to date but allow it to work and enforce the results if turned on? I\u0027m not sure what the best approach would be.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cc30a08e3d08ce0319e5141acab444c65f99c848","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"530b1ead_23a734f9","in_reply_to":"1407a00a_fae6e94e","updated":"2025-08-20 16:40:55.000000000","message":"https://issues.redhat.com/browse/CS-2983 this issue is apparently tracking the problem upstream of us. It is about a week old and the problem persists. Not sure if there is any followup we should do at this point though.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"0635aeb017084af0979815dc9414317399643419","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1407a00a_fae6e94e","in_reply_to":"3b4a5f56_119d366d","updated":"2025-08-20 13:57:07.000000000","message":"I do think we want to bug someone in CentOS land about fixing their mirror. Not keeping up to date sums around for their images seems like glaring issue. I don\u0027t feel great about proceeding if the hash is missing. Maybe we could gracefully fall back to an image that *does* have a hash available?","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7b4a4e7ad86cfeb4ce31574ce191c96f27967539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7eed4f8c_e54564f7","in_reply_to":"530b1ead_23a734f9","updated":"2025-09-03 19:05:41.000000000","message":"Done","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"a12fad91bf271312aec5bd6bef16c09e863e953e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30e0bf5e_3d5fe88d","updated":"2025-09-02 15:20:22.000000000","message":"recheck upstream mirror supposedly fixed","commit_id":"ed145a9a6d247bfccb7691bf4a462c4020ffbe3f"}],"diskimage_builder/elements/centos/root.d/10-centos-cloud-image":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"34f21280c70107702c75f71be295613d687e3bdd","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        dib_release_path\u003d${DIB_RELEASE}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-$(head -1 \u003c \u003c(curl -s https://cloud.centos.org/centos/${dib_release_path}/${ARCH}/images/ | grep -o \"CentOS-.[^\u003e]*${DIB_FLAVOR}-.[^\u003e]*.qcow2\" | sort -r))}"},{"line_number":46,"context_line":"    echo $BASE_IMAGE_FILE"},{"line_number":47,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":48,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"},{"line_number":49,"context_line":"    CACHED_IMAGE\u003d$DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a9fe5936_abe7fb31","line":46,"updated":"2025-08-19 21:44:58.000000000","message":"This change adds three new echo outputs. Of the three this one feels like its already covered by setting DIB_DEBUG_TRACE (or running diskimage-builder with the -x flag iirc). I don\u0027t think we need this extra debug info.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"bdd914bc47c65e04bbb579f9438ddae3536a4184","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        dib_release_path\u003d${DIB_RELEASE}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-$(head -1 \u003c \u003c(curl -s https://cloud.centos.org/centos/${dib_release_path}/${ARCH}/images/ | grep -o \"CentOS-.[^\u003e]*${DIB_FLAVOR}-.[^\u003e]*.qcow2\" | sort -r))}"},{"line_number":46,"context_line":"    echo $BASE_IMAGE_FILE"},{"line_number":47,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":48,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"},{"line_number":49,"context_line":"    CACHED_IMAGE\u003d$DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3e4c6f94_dfe03484","line":46,"in_reply_to":"263fabe9_15452a2d","updated":"2025-08-20 13:53:06.000000000","message":"Done","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fed9aa773fa543e0af0ab5a9d3c6a91a8248e1c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        dib_release_path\u003d${DIB_RELEASE}"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"    BASE_IMAGE_FILE\u003d${BASE_IMAGE_FILE:-$(head -1 \u003c \u003c(curl -s https://cloud.centos.org/centos/${dib_release_path}/${ARCH}/images/ | grep -o \"CentOS-.[^\u003e]*${DIB_FLAVOR}-.[^\u003e]*.qcow2\" | sort -r))}"},{"line_number":46,"context_line":"    echo $BASE_IMAGE_FILE"},{"line_number":47,"context_line":"    BASE_IMAGE_TAR\u003d$BASE_IMAGE_FILE.tgz"},{"line_number":48,"context_line":"    IMAGE_LOCATION\u003d$DIB_CLOUD_IMAGES/$BASE_IMAGE_FILE"},{"line_number":49,"context_line":"    CACHED_IMAGE\u003d$DIB_IMAGE_CACHE/$BASE_IMAGE_FILE"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"263fabe9_15452a2d","line":46,"in_reply_to":"a9fe5936_abe7fb31","updated":"2025-08-19 22:36:26.000000000","message":"I concur.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"34f21280c70107702c75f71be295613d687e3bdd","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    IMAGE_SUM_LOCATION\u003d$IMAGE_LOCATION.SHA256SUM"},{"line_number":53,"context_line":"    CACHED_SUM\u003d$DIB_IMAGE_CACHE/$IMAGE_SUM_FILE"},{"line_number":54,"context_line":"    echo \"Fetching image and image sum\""},{"line_number":55,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_LOCATION $CACHED_IMAGE"},{"line_number":56,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_SUM_LOCATION $CACHED_SUM"},{"line_number":57,"context_line":"    pushd $DIB_IMAGE_CACHE"},{"line_number":58,"context_line":"    if ! sha256sum --check $CACHED_SUM ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"629699a4_56ab91d4","line":55,"updated":"2025-08-19 21:44:58.000000000","message":"It might be worth a comment here before we run the two cache-url commands that extract-image below typically runs cache-url to fetch the image and we\u0027re short circuiting in order to do hashsum verification.\n\nI think that updating extract-image to handle this case is probably idea, but I know implementations for hashing vary between distros and it may be more straightforward to do distro specific implementations like this first then see how common they are and roll them up later. All that to say I don\u0027t think you need to update extra-image in this change. I just want to make it known that would be a bit more ideal and something I would review as well.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"bdd914bc47c65e04bbb579f9438ddae3536a4184","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    IMAGE_SUM_LOCATION\u003d$IMAGE_LOCATION.SHA256SUM"},{"line_number":53,"context_line":"    CACHED_SUM\u003d$DIB_IMAGE_CACHE/$IMAGE_SUM_FILE"},{"line_number":54,"context_line":"    echo \"Fetching image and image sum\""},{"line_number":55,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_LOCATION $CACHED_IMAGE"},{"line_number":56,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_SUM_LOCATION $CACHED_SUM"},{"line_number":57,"context_line":"    pushd $DIB_IMAGE_CACHE"},{"line_number":58,"context_line":"    if ! sha256sum --check $CACHED_SUM ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4c9a7a2e_9b514bfe","line":55,"in_reply_to":"0a271518_caa850d1","updated":"2025-08-20 13:53:06.000000000","message":"Acknowledged","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9fed9aa773fa543e0af0ab5a9d3c6a91a8248e1c","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    IMAGE_SUM_LOCATION\u003d$IMAGE_LOCATION.SHA256SUM"},{"line_number":53,"context_line":"    CACHED_SUM\u003d$DIB_IMAGE_CACHE/$IMAGE_SUM_FILE"},{"line_number":54,"context_line":"    echo \"Fetching image and image sum\""},{"line_number":55,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_LOCATION $CACHED_IMAGE"},{"line_number":56,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_SUM_LOCATION $CACHED_SUM"},{"line_number":57,"context_line":"    pushd $DIB_IMAGE_CACHE"},{"line_number":58,"context_line":"    if ! sha256sum --check $CACHED_SUM ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0a271518_caa850d1","line":55,"in_reply_to":"629699a4_56ab91d4","updated":"2025-08-19 22:36:26.000000000","message":"I think in a perfect world, we would hand extract image a checksum file as well and it would just figure it out. I guess on a plus side, you can figure out the algorithm based upon the length, and sha256sum or even sha512sum is sort of a standard approach. The key is going to be \"is it a file with many files checksums\", or not. Perhaps the pattern is something along the lines of identify length of checksum via a fingerprint, and then go from there.\n\nIn any event, in the mean time, centos specific checksums make sense to me.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"34f21280c70107702c75f71be295613d687e3bdd","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_SUM_LOCATION $CACHED_SUM"},{"line_number":57,"context_line":"    pushd $DIB_IMAGE_CACHE"},{"line_number":58,"context_line":"    if ! sha256sum --check $CACHED_SUM ; then"},{"line_number":59,"context_line":"        echo \"ERROR: Image \u0027$CACHED_IMAGE\u0027 failed sha256sum check!\""},{"line_number":60,"context_line":"        exit 1"},{"line_number":61,"context_line":"    fi "},{"line_number":62,"context_line":"    popd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"13dc6e46_fab27d95","line":59,"updated":"2025-08-19 21:44:58.000000000","message":"You might want to consider using the `sha256sum --quiet` flag here as well so that the error message is produced by dib and not sha256sum.\n\nSeparately I wish that `sha256sum --check` emitted the calculated hash and the provided hash values but it doesn\u0027t look like it does and there is no flag to do so. Sometimes this is helpful if the files are in the middle of an update and you can verify the new stuff matches or to see if you hashed an empty file.","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"},{"author":{"_account_id":14228,"name":"Clif Houck","email":"me@clifhouck.com","username":"clif_h"},"change_message_id":"bdd914bc47c65e04bbb579f9438ddae3536a4184","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    $TMP_HOOKS_PATH/bin/cache-url $IMAGE_SUM_LOCATION $CACHED_SUM"},{"line_number":57,"context_line":"    pushd $DIB_IMAGE_CACHE"},{"line_number":58,"context_line":"    if ! sha256sum --check $CACHED_SUM ; then"},{"line_number":59,"context_line":"        echo \"ERROR: Image \u0027$CACHED_IMAGE\u0027 failed sha256sum check!\""},{"line_number":60,"context_line":"        exit 1"},{"line_number":61,"context_line":"    fi "},{"line_number":62,"context_line":"    popd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ec199708_77cfdf2f","line":59,"in_reply_to":"13dc6e46_fab27d95","updated":"2025-08-20 13:53:06.000000000","message":"Done","commit_id":"3ddbd2ae664a344106cfc4b0b04167f604ea8af3"}]}