)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9297ef84f62758119f82a969d40c2b634b47801","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f75cd0b_8440e532","updated":"2025-09-18 10:48:16.000000000","message":"Would be nice to add a release note, otherwise looks good","commit_id":"3d3755c29eeba5a05eea583ff04903721f0c9c04"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7d324a538e9fa04a5cdfe9e064b2f5a1dbd57a48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1b14affa_83b99c55","updated":"2025-09-18 22:33:52.000000000","message":"recheck the noble build failed ssh connectivity checks which should use ssh keys are not be affected by this update to the dynamic-login element.","commit_id":"6043889a782a02603e6f7e29e65cfda17176715b"}],"diskimage_builder/elements/dynamic-login/static/usr/local/bin/dynamic-login":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5460a2a72ee4e09fe9b14dd5ceead979dcb0f3e1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# it to the root user"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"?([^\\\"]+)\\\" ]] || \\"},{"line_number":24,"context_line":"    [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d([^\\\" ]+)( |$) ]]"},{"line_number":25,"context_line":"then"},{"line_number":26,"context_line":"    pwdhash\u003d\"${BASH_REMATCH[1]}\""},{"line_number":27,"context_line":"    if ! [[ $pwdhash \u003d~ ^\\$ ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9155ebe3_cdafaeec","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":50},"updated":"2025-09-18 16:26:30.000000000","message":"I guess this group is here because we\u0027re matching against the entire linux kernel command line so there may be another option after rootpwd or it will be the end. Mostly writing this down to help other reviewers understand the regex here, but let me know if I have interpreted this wrong.","commit_id":"6043889a782a02603e6f7e29e65cfda17176715b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c01e4dac8b45c57ef65c2bcc897fb117b5ee5f82","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# it to the root user"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d\\\"?([^\\\"]+)\\\" ]] || \\"},{"line_number":24,"context_line":"    [[ $(\u003c/proc/cmdline) \u003d~ rootpwd\u003d([^\\\" ]+)( |$) ]]"},{"line_number":25,"context_line":"then"},{"line_number":26,"context_line":"    pwdhash\u003d\"${BASH_REMATCH[1]}\""},{"line_number":27,"context_line":"    if ! [[ $pwdhash \u003d~ ^\\$ ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"eca8e572_50171d32","line":24,"range":{"start_line":24,"start_character":45,"end_line":24,"end_character":50},"in_reply_to":"9155ebe3_cdafaeec","updated":"2025-09-18 16:34:34.000000000","message":"That makes sense, especially that we support the old mode as well.","commit_id":"6043889a782a02603e6f7e29e65cfda17176715b"}]}
