)]}'
{"id":"openstack%2Fdiskimage-builder~981961","triplet_id":"openstack%2Fdiskimage-builder~master~I59a0777833658b2c1c9f61e00b3dc5bcc64e93ae","project":"openstack/diskimage-builder","branch":"master","topic":"fix-dead-code-osprh-27817","attention_set":{},"removed_from_attention_set":{"34373":{"account":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"last_update":"2026-03-26 15:26:32.000000000","reason":"Change was abandoned"},"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2026-03-26 15:26:32.000000000","reason":"Change was abandoned"},"14200":{"account":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"last_update":"2026-03-26 13:16:30.000000000","reason":"\u003cGERRIT_ACCOUNT_14200\u003e replied on the change","reason_account":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"}},"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2026-03-26 15:26:32.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I59a0777833658b2c1c9f61e00b3dc5bcc64e93ae","subject":"Fix dead code in MBR module","status":"ABANDONED","created":"2026-03-24 18:14:52.000000000","updated":"2026-03-26 15:26:32.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ba6c6396c12ed28588e94ddd9da8ee7c8a847d2b","_number":981961,"virtual_id_number":981961,"owner":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-03-24 19:57:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2026-03-25 07:55:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-24 19:16:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-24 19:57:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-24 20:18:16.000000000","updated_by":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2026-03-24 20:18:16.000000000","updated_by":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2026-03-25 07:55:39.000000000","updated_by":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"reviewer":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"state":"REVIEWER"}],"messages":[{"id":"6bfb22188c72595643fd528e432bfeeda1533ca5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"date":"2026-03-24 18:14:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fd83eef93fc13f944a10d998476f315f30c884fd","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-24 19:16:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a9b86f28e90946fd864f50aaae599a2d\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/aeea0adba91e4b4a9fe553a3d1eaaa4b : SUCCESS in 46m 11s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/9cd16894ec8f406e817c744e3bee120d : SUCCESS in 51m 02s","accounts_in_message":[],"_revision_number":1},{"id":"d65bd4da819a4267df16d0b9992a1112b6151640","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-24 19:57:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4f8a18df3c4c4f2cb69c3ba9c9031c01\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9d2a69a62524d77b465618ad6babb93 : SUCCESS in 4m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ece0fb3ebbd54db78b1cdbb3a6dd9fa5 : SUCCESS in 7m 03s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/ab93c1b0b29e42239aa5bb4200bf02e1 : SUCCESS in 5m 56s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/5b1abeae82da4b33bcc794bf69f1d5ee : SUCCESS in 3m 30s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/7076e1921d4d46a78112f9559ce56b69 : SUCCESS in 2m 47s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/fa700f220d1246e5af6dbc314e77b1a4 : SUCCESS in 7m 00s\n- tox-py311 https://zuul.opendev.org/t/openstack/build/efd597c839c3482a84f22bc97e3bf907 : SUCCESS in 4m 29s\n- tox-py312 https://zuul.opendev.org/t/openstack/build/e916ec8c4843413eb0a7b814e8248645 : SUCCESS in 3m 34s\n- tox-py313 https://zuul.opendev.org/t/openstack/build/62e2ca627cdf421ea20f78a2fc2d1779 : SUCCESS in 4m 32s\n- dib-functests https://zuul.opendev.org/t/openstack/build/a764a38dbed54b588bbed08bce3eb259 : SUCCESS in 44m 12s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/3d0873d99f3944f88c219df5c349d044 : SUCCESS in 4m 27s\n- dib-devstack-functional-openstack-almalinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/32bab5a3e13948e99897a1427edd11f8 : SUCCESS in 51m 14s (non-voting)\n- dib-devstack-functional-openstack-almalinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/c51d0acc5d3d4377aff2e432ca049797 : SUCCESS in 47m 52s (non-voting)\n- dib-devstack-functional-openstack-almalinux-10-v2-containerfile-src https://zuul.opendev.org/t/openstack/build/cc5b5718e76441e5a57b0e7faacadbbd : SUCCESS in 52m 34s (non-voting)\n- dib-devstack-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/2fffe62f69f94618a7cd8906016242d4 : SUCCESS in 55m 20s\n- dib-devstack-functional-openstack-centos-10-stream-src https://zuul.opendev.org/t/openstack/build/1cbaf01cd2e94e34990691ab2c8f42c1 : SUCCESS in 27m 36s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/31b7ed34ddb64fc5a955ffdc6fdc941b : SUCCESS in 45m 50s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/533370d4e66647aa9ec459cad49a08a1 : SUCCESS in 38m 34s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-10-containerfile-src https://zuul.opendev.org/t/openstack/build/0f4766017937442ebbae249907528e31 : SUCCESS in 30m 11s (non-voting)\n- dib-devstack-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/5eb4b61b88cf48ada018f4941172061e : SUCCESS in 20m 13s\n- dib-devstack-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/abee322c5c924c48ab00e7c2b3549fd5 : SUCCESS in 37m 08s\n- dib-devstack-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/4516a075555947f9b844f5184a968373 : SUCCESS in 18m 15s\n- dib-devstack-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/25157a525937414ba983c2a9efb5001e : FAILURE in 32m 39s (non-voting)\n- dib-devstack-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/63a0dc0e4d8d479686e2f9067e007f95 : FAILURE in 1h 36m 53s (non-voting)\n- dib-devstack-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/d9f3a986a35049b3b9886ab0e0dd745f : SUCCESS in 44m 21s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/38c2e6ca42d34edc9237626665c514a1 : SUCCESS in 5m 38s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/c071265f781c4b028f5a06c091f4ed72 : SUCCESS in 1h 10m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8e0ffc4c04ee35c465833bb3d52514604edcc9bb","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2026-03-25 07:55:39.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8bbcbadc322e6cab3d654ae0bcbec1f6bf5c4d88","author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"date":"2026-03-26 13:08:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7273da573617017807fca5f8bac1082100c336ad","author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"date":"2026-03-26 13:16:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ba6c6396c12ed28588e94ddd9da8ee7c8a847d2b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"date":"2026-03-26 15:26:32.000000000","message":"Abandoned\n\nchange is here now: https://review.opendev.org/c/openstack/diskimage-builder/+/982098","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"10f4665a111f726223165edf581695b7ef39ca1e","revisions":{"10f4665a111f726223165edf581695b7ef39ca1e":{"kind":"REWORK","_number":1,"created":"2026-03-24 18:14:52.000000000","uploader":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"ref":"refs/changes/61/981961/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/61/981961/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/61/981961/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/61/981961/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/61/981961/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/61/981961/1"}}},"commit":{"parents":[{"commit":"0315af0ee64ccd485c925df054c84862ecb7485d","subject":"mellanox: remove qperf package from element","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0315af0ee64ccd485c925df054c84862ecb7485d"}]}],"author":{"name":"Jason Paroly","email":"jparoly@redhat.com","date":"2026-03-24 18:03:49.000000000","tz":-240},"committer":{"name":"Jason Paroly","email":"jparoly@redhat.com","date":"2026-03-24 18:14:00.000000000","tz":-240},"subject":"Fix dead code in MBR module","message":"Fix dead code in MBR module\n\nPrefix unused context manager parameters with underscore in __exit__\nmethod and remove unreachable return statement in test helper.\n\nFixes: OSPRH-27817\n\nCo-Authored-By: Claude Sonnet 4.5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I59a0777833658b2c1c9f61e00b3dc5bcc64e93ae\nSigned-off-by: Jason Paroly \u003cjparoly@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/10f4665a111f726223165edf581695b7ef39ca1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/10f4665a111f726223165edf581695b7ef39ca1e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
