)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"db51aa57_56cebfac","updated":"2026-03-26 21:15:32.000000000","message":"About half of the changes here have the risk of breaking calls to those functions. The effort to flag unused function arguments is laudable but any change that modifies the function signature of a \"public\" function has the risk of breaking something which may not be caught by unit tests.\n\nThe more I think about it the more I question the benefit vs risk of these changes.","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/block_device/level1/lvm.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":351,"context_line":"    def _config_error(self, msg):"},{"line_number":352,"context_line":"        raise BlockDeviceSetupException(msg)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def __init__(self, config, _defaults, state):"},{"line_number":355,"context_line":"        \"\"\"Build LVM nodes"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        This reads the \"lvm:\" config stanza, validates it and produces"}],"source_content_type":"text/x-python","patch_set":2,"id":"70a866b5_917a8648","line":354,"updated":"2026-03-26 21:15:32.000000000","message":"This changes the documented interface for creating an LVMPlugin, so this will break any caller which uses named arguments.","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/block_device/level1/mbr.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            \u003d self.partition_abs_start"},{"line_number":174,"context_line":"        return self"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def __exit__(self, _exc_type, _exc_value, _traceback):"},{"line_number":177,"context_line":"        self.image_fd.flush()"},{"line_number":178,"context_line":"        os.fsync(self.image_fd.fileno())"},{"line_number":179,"context_line":"        self.image_fd.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"277139c4_78c4142e","line":176,"updated":"2026-03-26 21:15:32.000000000","message":"I think this needs to conform to the __exit__ function signature so shouldn\u0027t change https://docs.python.org/3/reference/datamodel.html#object.__exit__","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/block_device/level1/partitioning.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class Partitioning(PluginBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, config, _default_config, state):"},{"line_number":35,"context_line":"        logger.debug(\"Creating Partitioning object; config [%s]\", config)"},{"line_number":36,"context_line":"        super(Partitioning, self).__init__()"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2f6ab721_e1d2cc6a","line":34,"updated":"2026-03-26 21:15:32.000000000","message":"See comment in lvm.py","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/block_device/level2/mkfs.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":150,"context_line":"    systems."},{"line_number":151,"context_line":"    \"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def __init__(self, config, _defaults, state):"},{"line_number":154,"context_line":"        super(Mkfs, self).__init__()"},{"line_number":155,"context_line":"        self.filesystems \u003d {}"},{"line_number":156,"context_line":"        fs \u003d FilesystemNode(config, state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"625952a4_687611e8","line":153,"updated":"2026-03-26 21:15:32.000000000","message":"See comment in lvm.py","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/block_device/level4/fstab.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Fstab(PluginBase):"},{"line_number":56,"context_line":"    def __init__(self, config, _defaults, state):"},{"line_number":57,"context_line":"        super(Fstab, self).__init__()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.node \u003d FstabNode(config, state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"11ff83a2_74cb83ba","line":56,"updated":"2026-03-26 21:15:32.000000000","message":"See comment in lvm.py","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}],"diskimage_builder/diskimage_builder.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e9523f529b38973c677cac03f345867c903c2248","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    def __init__(self, key, description):"},{"line_number":98,"context_line":"        super(Flag, self).__init__(key, description, schema_type\u003d\"boolean\")"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def to_argument(self, _value\u003dNone):"},{"line_number":101,"context_line":"        return []"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def type_help(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dade1135_5b915b4b","line":100,"updated":"2026-03-26 21:15:32.000000000","message":"Flag is a subclass of Arg, so the value argument cannot be renamed as it will no longer be conforming with the function signature of Arg.to_argument","commit_id":"8f08362055d2ee8b5b3a095e17cb1bcbed44074c"}]}