)]}'
{"id":"openstack%2Fdiskimage-builder~982639","triplet_id":"openstack%2Fdiskimage-builder~master~I38d2ef3ea3dd912d6ed2e7631c89c652ba2f7acc","project":"openstack/diskimage-builder","branch":"master","topic":"remove-return","attention_set":{},"removed_from_attention_set":{"34373":{"account":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"last_update":"2026-03-30 20:23:54.000000000","reason":"Change was submitted"},"11655":{"account":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"last_update":"2026-03-30 20:23:54.000000000","reason":"Change was submitted"},"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2026-03-30 19:09:20.000000000","reason":"\u003cGERRIT_ACCOUNT_4571\u003e replied on the change","reason_account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}}},"hashtags":[],"change_id":"I38d2ef3ea3dd912d6ed2e7631c89c652ba2f7acc","subject":"Remove unnecessary return statement","status":"MERGED","created":"2026-03-30 12:29:39.000000000","updated":"2026-03-30 20:25:31.000000000","submitted":"2026-03-30 20:23:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"982639-remove-return","meta_rev_id":"c362b34a7dccd35a41aee5b4f9a6f1c10b604da9","_number":982639,"virtual_id_number":982639,"owner":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-03-30 20:23:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":2,"date":"2026-03-30 19:09:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2026-03-30 16:47:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":1,"date":"2026-03-30 19:09:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-03-30 13:50:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-03-30 14:22:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-03-30 16:41:40.000000000","updated_by":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2026-03-30 16:41:40.000000000","updated_by":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2026-03-30 16:47:01.000000000","updated_by":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"reviewer":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"state":"REVIEWER"}],"messages":[{"id":"528ee008576e9813ac84d833d3f5912b59c4eaa7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"date":"2026-03-30 12:29:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5740a2fe202e7650ec65813eb3700745bc93f52e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 13:50:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/289d0ec8046749ae81cb530bd1d19424\n\n- dib-functests-arm64-deb https://zuul.opendev.org/t/openstack/build/fae38f47f91547ae9b8045721f3288c1 : SUCCESS in 52m 45s\n- dib-functests-arm64-rpm https://zuul.opendev.org/t/openstack/build/15413a06acf44e4798f4395f04d3db8b : SUCCESS in 45m 51s","accounts_in_message":[],"_revision_number":1},{"id":"cf5dbef7d7144adc7c8b0ef6ea5b73fa145c9871","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 14:22:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/20d31753e3a44208883f1de1ee1059fe\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/50f7f847e9e647eaab2b73cab82225d9 : SUCCESS in 5m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e56f92e244404a7ea13dcd92856e385c : SUCCESS in 5m 17s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/fe4cc2217bd549b1a29a972c36db6619 : SUCCESS in 6m 01s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/9a417562c4a24db2bbefbbfd7848fc7d : SUCCESS in 4m 16s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/8e855f3aa5f44802bc12b14d470ec358 : SUCCESS in 3m 57s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/e50a3433f7814920b4c0cf7b478924cf : SUCCESS in 4m 34s\n- tox-py311 https://zuul.opendev.org/t/openstack/build/426edf34cead42558c09973909cdc869 : SUCCESS in 5m 06s\n- tox-py312 https://zuul.opendev.org/t/openstack/build/cd5497219aca4779b7556bd49a562eac : SUCCESS in 4m 26s\n- tox-py313 https://zuul.opendev.org/t/openstack/build/c5bdbd2250d74355bf8ad6bb91ebfcb4 : SUCCESS in 2m 47s\n- dib-functests https://zuul.opendev.org/t/openstack/build/7f9ea91ae91d4ba1862fa6046725aec5 : SUCCESS in 45m 34s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/ee532ec7102f47b19353effcee2a8d67 : SUCCESS in 3m 51s\n- dib-devstack-functional-openstack-almalinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/1c08f918e73e4f779730b8cce826d7c3 : SUCCESS in 55m 44s (non-voting)\n- dib-devstack-functional-openstack-almalinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/2e92d994ad4349a2b4a14439612d4242 : SUCCESS in 55m 15s (non-voting)\n- dib-devstack-functional-openstack-almalinux-10-v2-containerfile-src https://zuul.opendev.org/t/openstack/build/66429ee1da994336b16796cb97799717 : SUCCESS in 46m 44s (non-voting)\n- dib-devstack-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/bdcfcf5f9e5a43f5a6f3b1c1fd798dc9 : SUCCESS in 48m 03s\n- dib-devstack-functional-openstack-centos-10-stream-src https://zuul.opendev.org/t/openstack/build/2d7486730933406f92d2d92f4f6d3f40 : SUCCESS in 30m 12s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-8-containerfile-src https://zuul.opendev.org/t/openstack/build/6d83d311df9a493d883d5d92763eac68 : SUCCESS in 55m 48s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-9-containerfile-src https://zuul.opendev.org/t/openstack/build/4fef91bd16b7406abb94036e57075c6f : FAILURE in 1h 22m 07s (non-voting)\n- dib-devstack-functional-openstack-rockylinux-10-containerfile-src https://zuul.opendev.org/t/openstack/build/497d69706cab40b09e596dac25f49a13 : SUCCESS in 40m 06s (non-voting)\n- dib-devstack-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/34529d1aa8924447b428075c2d36e79c : SUCCESS in 40m 30s\n- dib-devstack-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/a9cedc32aedf4ef9a4a6eb5c94a55d93 : SUCCESS in 42m 44s\n- dib-devstack-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/d0506e3b7aa04b9a944eac3f085210ae : SUCCESS in 43m 48s\n- dib-devstack-functional-openstack-opensuse-15-src https://zuul.opendev.org/t/openstack/build/69c69bb38814496bb92996b0ecd9c784 : FAILURE in 32m 41s (non-voting)\n- dib-devstack-functional-openstack-gentoo-src https://zuul.opendev.org/t/openstack/build/33adf65f21f5405baaec20e273f25b87 : FAILURE in 1h 47m 24s (non-voting)\n- dib-devstack-functional-openstack-debian-bullseye-src https://zuul.opendev.org/t/openstack/build/ebc16f5bd40d4382b8448ed54f6b8531 : SUCCESS in 41m 09s (non-voting)\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/c99eda16330044098681fb218dc904d3 : SUCCESS in 10m 35s\n- ipa-tempest-bios-ipmi-direct-src https://zuul.opendev.org/t/openstack/build/b10f60b8b2c4459f97095fc8492ef4e3 : SUCCESS in 35m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"977df0d0bb5c6be73974233d489a32da20816ac6","author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"date":"2026-03-30 16:47:01.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e168af817a87df2f1d361ba89969c24e4ade17bb","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2026-03-30 19:09:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"79b1741bb75f8c43569ea4f039db500fc8d75c72","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 19:09:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"7dc345810417600cc33e98863724883f74ffda71","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 20:23:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6bd721ea55074636a3383b7533e41669\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0221c9b37d54cff87d8696799953cc1 : SUCCESS in 6m 07s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/83e5c94cd18e4d79ba8d24b29524968b : SUCCESS in 4m 39s\n- tox-py38 https://zuul.opendev.org/t/openstack/build/a2be65f7f88843d0a270e77eacaf156e : SUCCESS in 3m 30s\n- tox-py39 https://zuul.opendev.org/t/openstack/build/3138e0c23c154ec8beaa226b88211981 : SUCCESS in 3m 51s\n- tox-py310 https://zuul.opendev.org/t/openstack/build/6cc47ca213214dc28895640dc3f8a2eb : SUCCESS in 2m 51s\n- tox-py311 https://zuul.opendev.org/t/openstack/build/66224098ef2e4a49b82cb62edbb46b8b : SUCCESS in 4m 19s\n- tox-py312 https://zuul.opendev.org/t/openstack/build/70905457a82d460a8e8475366a0e0fec : SUCCESS in 4m 07s\n- tox-py313 https://zuul.opendev.org/t/openstack/build/515ce7115c09497fb40b9aa45770084a : SUCCESS in 3m 49s\n- opendev-buildset-registry https://zuul.opendev.org/t/openstack/build/82d9035e84bf42759d8377e816884cb7 : SUCCESS in 21m 07s\n- nodepool-build-image-siblings https://zuul.opendev.org/t/openstack/build/4c3776c3c931430d99838c6484e66154 : SUCCESS in 12m 41s\n- dib-devstack-functional-openstack-centos-9-stream-src https://zuul.opendev.org/t/openstack/build/f6a9eb86532147ddbae38fe84992553a : SUCCESS in 29m 41s\n- dib-devstack-functional-openstack-ubuntu-focal-src https://zuul.opendev.org/t/openstack/build/c342ae5773ff4322af5fed5bef0bd2a9 : SUCCESS in 39m 09s\n- dib-devstack-functional-openstack-ubuntu-jammy-src https://zuul.opendev.org/t/openstack/build/e6e04490e00840229f67e379e9cac9c0 : SUCCESS in 1h 10m 47s\n- dib-devstack-functional-openstack-ubuntu-noble-src https://zuul.opendev.org/t/openstack/build/dadc1d8b3dbf4c0e8f0eb235e267cd10 : SUCCESS in 46m 51s\n- dib-functests https://zuul.opendev.org/t/openstack/build/21e1e8e84c0640ecb4563fe06ee3ad7c : SUCCESS in 43m 26s\n- ironic-python-agent-check-image-dib-centos9 https://zuul.opendev.org/t/openstack/build/91c9292b46244f1885709b3aef35aedb : SUCCESS in 9m 44s","accounts_in_message":[],"_revision_number":1},{"id":"5463d5922a456e8ddbf56f4b548d12ad90d2db30","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 20:23:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"c362b34a7dccd35a41aee5b4f9a6f1c10b604da9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-03-30 20:25:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/809c780e2c0946969ff6bef7444abb62\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4cf9f115deb14a2caf8e7c3f04c8e7d5 : SUCCESS in 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eee6b6d627e263ef579e6d647c7270025558159f","revisions":{"eee6b6d627e263ef579e6d647c7270025558159f":{"kind":"REWORK","_number":1,"created":"2026-03-30 12:29:39.000000000","uploader":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"ref":"refs/changes/39/982639/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/39/982639/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/39/982639/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/39/982639/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/39/982639/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/39/982639/1"}}},"commit":{"parents":[{"commit":"0315af0ee64ccd485c925df054c84862ecb7485d","subject":"mellanox: remove qperf package from element","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0315af0ee64ccd485c925df054c84862ecb7485d"}]}],"author":{"name":"Jason Paroly","email":"jparoly@redhat.com","date":"2026-03-30 12:24:42.000000000","tz":-240},"committer":{"name":"Jason Paroly","email":"jparoly@redhat.com","date":"2026-03-30 12:28:40.000000000","tz":-240},"subject":"Remove unnecessary return statement","message":"Remove unnecessary return statement\n\nRemove unreachable return statement after a return in the\npartx path detection loop.\n\nChange-Id: I38d2ef3ea3dd912d6ed2e7631c89c652ba2f7acc\nSigned-off-by: Jason Paroly \u003cjparoly@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/eee6b6d627e263ef579e6d647c7270025558159f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/eee6b6d627e263ef579e6d647c7270025558159f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}