)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4a0371034b9fe302e5ce2a5fb1ab6f05c9179c6c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"debootstrap: add DIB_MMDEBSTRAP_EXTRA_ARGS support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow mmdebstrap to be used with custom arguments while preserving"},{"line_number":10,"context_line":"compatibility with debootstrap-specific options. This change introduces"},{"line_number":11,"context_line":"a new DIB_MMDEBSTRAP_EXTRA_ARGS variable and automatically converts"},{"line_number":12,"context_line":"incompatible debootstrap arguments to their mmdebstrap equivalents."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Key changes:"},{"line_number":15,"context_line":"- Add DIB_MMDEBSTRAP_EXTRA_ARGS variable for mmdebstrap-specific options"},{"line_number":16,"context_line":"- Remove KEYRING_OPT and DIB_DEBOOTSTRAP_EXTRA_ARGS restrictions that"},{"line_number":17,"context_line":"  prevented mmdebstrap usage"},{"line_number":18,"context_line":"- Automatically convert --no-check-gpg to --skip\u003dcheck/signed-by for"},{"line_number":19,"context_line":"  mmdebstrap compatibility"},{"line_number":20,"context_line":"- Use DIB_BOOTSTRAP_EXTRA_ARGS as a unified variable that holds the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e4b89b62_c59527f9","line":17,"range":{"start_line":10,"start_character":49,"end_line":17,"end_character":28},"updated":"2026-08-31 19:37:40.000000000","message":"Isn\u0027t this supposed to be added to the documentation? release notes?","commit_id":"a3bc4ed524cc00c0157dd4b1136080de46b90225"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bec4777bdf5b6925e9e034f66e46abef082ddd8e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"debootstrap: add DIB_MMDEBSTRAP_EXTRA_ARGS support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow mmdebstrap to be used with custom arguments while preserving"},{"line_number":10,"context_line":"compatibility with debootstrap-specific options. This change introduces"},{"line_number":11,"context_line":"a new DIB_MMDEBSTRAP_EXTRA_ARGS variable and automatically converts"},{"line_number":12,"context_line":"incompatible debootstrap arguments to their mmdebstrap equivalents."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Key changes:"},{"line_number":15,"context_line":"- Add DIB_MMDEBSTRAP_EXTRA_ARGS variable for mmdebstrap-specific options"},{"line_number":16,"context_line":"- Remove KEYRING_OPT and DIB_DEBOOTSTRAP_EXTRA_ARGS restrictions that"},{"line_number":17,"context_line":"  prevented mmdebstrap usage"},{"line_number":18,"context_line":"- Automatically convert --no-check-gpg to --skip\u003dcheck/signed-by for"},{"line_number":19,"context_line":"  mmdebstrap compatibility"},{"line_number":20,"context_line":"- Use DIB_BOOTSTRAP_EXTRA_ARGS as a unified variable that holds the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"77e7b914_4bb3fdb9","line":17,"range":{"start_line":10,"start_character":49,"end_line":17,"end_character":28},"in_reply_to":"4520a9b5_5b426208","updated":"2026-08-31 21:17:03.000000000","message":"thanks","commit_id":"a3bc4ed524cc00c0157dd4b1136080de46b90225"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"99a8c333f3834e18d11de782c18fa3c3f6f33721","unresolved":false,"context_lines":[{"line_number":7,"context_line":"debootstrap: add DIB_MMDEBSTRAP_EXTRA_ARGS support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Allow mmdebstrap to be used with custom arguments while preserving"},{"line_number":10,"context_line":"compatibility with debootstrap-specific options. This change introduces"},{"line_number":11,"context_line":"a new DIB_MMDEBSTRAP_EXTRA_ARGS variable and automatically converts"},{"line_number":12,"context_line":"incompatible debootstrap arguments to their mmdebstrap equivalents."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Key changes:"},{"line_number":15,"context_line":"- Add DIB_MMDEBSTRAP_EXTRA_ARGS variable for mmdebstrap-specific options"},{"line_number":16,"context_line":"- Remove KEYRING_OPT and DIB_DEBOOTSTRAP_EXTRA_ARGS restrictions that"},{"line_number":17,"context_line":"  prevented mmdebstrap usage"},{"line_number":18,"context_line":"- Automatically convert --no-check-gpg to --skip\u003dcheck/signed-by for"},{"line_number":19,"context_line":"  mmdebstrap compatibility"},{"line_number":20,"context_line":"- Use DIB_BOOTSTRAP_EXTRA_ARGS as a unified variable that holds the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4520a9b5_5b426208","line":17,"range":{"start_line":10,"start_character":49,"end_line":17,"end_character":28},"in_reply_to":"e4b89b62_c59527f9","updated":"2026-08-31 20:03:23.000000000","message":"Not sure if we need a new release cut/notes for mmdebstrap, but will update the debootstrap documentation.","commit_id":"a3bc4ed524cc00c0157dd4b1136080de46b90225"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"76b68a6027869ed651c4f27b93403b6b30bf0b88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6337881_5d75437b","updated":"2026-08-18 14:04:51.000000000","message":"recheck due to transient failures","commit_id":"c2bb31a23dd9e0e94e9f53e3ed2b20dddf7953cd"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"fe5ad60d628d2f39b33b3bdcd227ea0a5af7321a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb364b81_fc13bdae","updated":"2026-08-24 15:24:05.000000000","message":"recheck rebased","commit_id":"c2bb31a23dd9e0e94e9f53e3ed2b20dddf7953cd"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"8cf6b748ec17d6360700626da6b1136d8fee1c35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d33020f1_3f0c58c5","updated":"2026-08-31 14:35:13.000000000","message":"recheck pipeline fix","commit_id":"5033a96e17d1f1d16d9d3d546d314f3877c7164b"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"42666bc62a95890e8fabb715377f57ef71d13af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0955484d_f583ab8b","updated":"2026-09-02 15:05:50.000000000","message":"Not sure if the gated workflow checks have been kicked off, could someone please help me with that?","commit_id":"b6dbb2c1a0cb40b45e51179d24402fceab13f1a8"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"99a8c333f3834e18d11de782c18fa3c3f6f33721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"84fff3e6_2c8b7ba7","updated":"2026-08-31 20:03:23.000000000","message":"recheck, Zuul review voted out due to documentation update","commit_id":"b6dbb2c1a0cb40b45e51179d24402fceab13f1a8"}],"diskimage_builder/elements/debootstrap/root.d/08-debootstrap":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"58288d61f11e1f87bd5c815a2fbe123c4785f8d2","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                    DIB_MMDEBSTRAP_EXTRA_ARGS+\u003d\" --skip\u003dcheck/signed-by\""},{"line_number":73,"context_line":"                fi"},{"line_number":74,"context_line":"            fi"},{"line_number":75,"context_line":"            DIB_BOOTSTRAP_EXTRA_ARGS\u003d${DIB_MMDEBSTRAP_EXTRA_ARGS}"},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"a2c55157_3579c4bc","line":75,"updated":"2026-08-18 21:50:14.000000000","message":"Previously all of the edits to DIB_DEBOOTSTRAP_EXTRA_ARGS were additive. Now if you are using mmdebstrap we will always override the value of DIB_BOOSTRAP_EXTRA_ARGS here. This doesn\u0027t make for a great user interface (it is confusing and doesn\u0027t do what you\u0027d expect if you read the top of this file).\n\nI think if we want to keep that behavior we should treat DIB_BOOSTRAP_EXTRA_ARGS as an internal variable and don\u0027t bother allowing the user to set it (just set it to the value of DIB_DEBOOTSTRAP_EXTRA_ARGS without any override).\n\nAlternatively we could try to treat this new DIB_BOOTSTRAP_EXTRA_ARGS as the top level var that everything else descends/inherits from. In that case we would set DIB_DEBOOTSTRAP_EXTRA_ARGS and DIB_MMDEBSTRAP_EXTRA_ARGS to the value of DIB_BOOTSTRAP_EXTRA_ARGS if set otherwise default to the existing variable values. Then process the variables and apply them ot the bootstrap command below using internal variables as necessary.\n\nThe downside to this approach is it represents a bit more work to get the backward compatibility right and plumb everything through. I think if we want to keep things simple we can keep the two externally facing vars (DIB_DEBOOTSTRAP_EXTRA_ARGS and DIB_MMDEBSTRAP_EXTRA_ARGS) and then use internal variables for the final bootstrap command extra args value.","commit_id":"c2bb31a23dd9e0e94e9f53e3ed2b20dddf7953cd"},{"author":{"_account_id":39117,"name":"Roja Eswaran","display_name":"reswaran","email":"rojaeswaran@gmail.com","username":"reswaran"},"change_message_id":"fe5ad60d628d2f39b33b3bdcd227ea0a5af7321a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    DIB_MMDEBSTRAP_EXTRA_ARGS+\u003d\" --skip\u003dcheck/signed-by\""},{"line_number":73,"context_line":"                fi"},{"line_number":74,"context_line":"            fi"},{"line_number":75,"context_line":"            DIB_BOOTSTRAP_EXTRA_ARGS\u003d${DIB_MMDEBSTRAP_EXTRA_ARGS}"},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":"    fi"},{"line_number":78,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f10e67dd_11e5d20b","line":75,"in_reply_to":"a2c55157_3579c4bc","updated":"2026-08-24 15:24:05.000000000","message":"Acknowledged","commit_id":"c2bb31a23dd9e0e94e9f53e3ed2b20dddf7953cd"}]}