)]}'
{"openstack_auth/tests/tests.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"67759b8b57a706d0c0c26b2e5c8c8624c71ebc40","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        user \u003d self.data.user"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        form_data \u003d self.get_form_data(user)"},{"line_number":223,"context_line":"        form_data[\u0027password\u0027] \u003d \"invalid\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        exc \u003d keystone_exceptions.Unauthorized(401)"},{"line_number":226,"context_line":"        self._mock_client_password_auth_failure(user.name, \"invalid\", exc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_ca77f99d","line":223,"updated":"2014-10-14 13:58:45.000000000","message":"nit: I\u0027m always confused by the single/double quotes thing, maybe should keep the same over the file?","commit_id":"6cc5d50deca432ec9c7a132e1526e090e6567062"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b0014fd45843ad240db0a02606e2afdc1997d258","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        user \u003d self.data.user"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        form_data \u003d self.get_form_data(user)"},{"line_number":223,"context_line":"        form_data[\u0027password\u0027] \u003d \"invalid\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        exc \u003d keystone_exceptions.Unauthorized(401)"},{"line_number":226,"context_line":"        self._mock_client_password_auth_failure(user.name, \"invalid\", exc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_c9221501","line":223,"in_reply_to":"baa201ad_ca77f99d","updated":"2014-10-18 19:33:14.000000000","message":"I agree It is better but we already have similar things. I don\u0027t think it is a blocker of approving.","commit_id":"6cc5d50deca432ec9c7a132e1526e090e6567062"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"67759b8b57a706d0c0c26b2e5c8c8624c71ebc40","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        form_data[\u0027password\u0027] \u003d \"invalid\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        exc \u003d keystone_exceptions.Unauthorized(401)"},{"line_number":226,"context_line":"        self._mock_client_password_auth_failure(user.name, \"invalid\", exc)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self.mox.ReplayAll()"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_6a936dfa","line":226,"updated":"2014-10-14 13:58:45.000000000","message":"maybe use like:\n\nself._mock_client_password_auth_failure(username\u003duser.name,                                                                   password\u003d\u0027invalid\u0027,\n                                                                   exc\u003dexc)\n\n Since they are pretty simple methods, would avoid anyone who is reading the code for the first time to try to figure out what each argument means.","commit_id":"6cc5d50deca432ec9c7a132e1526e090e6567062"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b0014fd45843ad240db0a02606e2afdc1997d258","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        form_data[\u0027password\u0027] \u003d \"invalid\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        exc \u003d keystone_exceptions.Unauthorized(401)"},{"line_number":226,"context_line":"        self._mock_client_password_auth_failure(user.name, \"invalid\", exc)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self.mox.ReplayAll()"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_a925d10b","line":226,"in_reply_to":"baa201ad_6a936dfa","updated":"2014-10-18 19:33:14.000000000","message":"I don\u0027t think we need to always use keyword arguments as you suggested. It is a simple method and defined in a same module (just one hundred lines above).","commit_id":"6cc5d50deca432ec9c7a132e1526e090e6567062"}]}