)]}'
{"openstack_auth/user.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"8f2604bebe0ce8c1254a49d4f527d27fa7b1f025","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    request.session[\u0027user_id\u0027] \u003d user.id"},{"line_number":34,"context_line":"    request.session[\u0027endpoint_url\u0027] \u003d user.endpoint"},{"line_number":35,"context_line":"    # FIXME(tsufiev): remove the next line as soon as"},{"line_number":36,"context_line":"    # https://review.openstack.org/#/c/222132 is merged"},{"line_number":37,"context_line":"    request.session[\u0027region_endpoint\u0027] \u003d user.endpoint"},{"line_number":38,"context_line":"    request.session[\u0027services_region\u0027] \u003d user.services_region"},{"line_number":39,"context_line":"    # Update the user object cached in the request"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_e1cf0727","line":36,"updated":"2016-03-31 00:18:15.000000000","message":"It looks like the references to this review should be changed to https://review.openstack.org/#/c/224759/, since 222132 was abandoned.","commit_id":"a72e133c3609abf2fad0727e3a42d3e9b9df8637"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2e4e16f167a67f384c419500323831138745bea6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    request.session[\u0027user_id\u0027] \u003d user.id"},{"line_number":34,"context_line":"    request.session[\u0027endpoint_url\u0027] \u003d user.endpoint"},{"line_number":35,"context_line":"    # FIXME(tsufiev): remove the next line as soon as"},{"line_number":36,"context_line":"    # https://review.openstack.org/#/c/222132 is merged"},{"line_number":37,"context_line":"    request.session[\u0027region_endpoint\u0027] \u003d user.endpoint"},{"line_number":38,"context_line":"    request.session[\u0027services_region\u0027] \u003d user.services_region"},{"line_number":39,"context_line":"    # Update the user object cached in the request"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_f54819b5","line":36,"in_reply_to":"ba0121b8_e1cf0727","updated":"2016-04-20 19:59:27.000000000","message":"Nice catch, will do!","commit_id":"a72e133c3609abf2fad0727e3a42d3e9b9df8637"}],"openstack_auth/utils.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"8f2604bebe0ce8c1254a49d4f527d27fa7b1f025","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":130,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":131,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":132,"context_line":"        LOG.warn(\u0027AVAILABLE_REGIONS setting becomes deprecated in Newton \u0027 +"},{"line_number":133,"context_line":"                 \u0027release and will be removed in some future release. The new \u0027"},{"line_number":134,"context_line":"                 \u0027name for the same setting is KEYSTONE_ENDPOINTS.\u0027)"},{"line_number":135,"context_line":"        return settings.AVAILABLE_REGIONS"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_418fd3cb","line":132,"updated":"2016-03-31 00:18:15.000000000","message":"Suggest changing this line to:\n\n\nAVAILABLE_REGIONS setting has been deprecated in the Newton","commit_id":"a72e133c3609abf2fad0727e3a42d3e9b9df8637"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2e4e16f167a67f384c419500323831138745bea6","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":130,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":131,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":132,"context_line":"        LOG.warn(\u0027AVAILABLE_REGIONS setting becomes deprecated in Newton \u0027 +"},{"line_number":133,"context_line":"                 \u0027release and will be removed in some future release. The new \u0027"},{"line_number":134,"context_line":"                 \u0027name for the same setting is KEYSTONE_ENDPOINTS.\u0027)"},{"line_number":135,"context_line":"        return settings.AVAILABLE_REGIONS"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_35cd7131","line":132,"in_reply_to":"ba0121b8_418fd3cb","updated":"2016-04-20 19:59:27.000000000","message":"Done","commit_id":"a72e133c3609abf2fad0727e3a42d3e9b9df8637"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d3deab5a87e48166cdbcdb55024b34608d12d6bd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":130,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":131,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":132,"context_line":"        LOG.warn(\u0027AVAILABLE_REGIONS setting has been deprecated in Newton \u0027 +"},{"line_number":133,"context_line":"                 \u0027release and will be removed in some future release. The new \u0027"},{"line_number":134,"context_line":"                 \u0027name for the same setting is KEYSTONE_ENDPOINTS.\u0027)"},{"line_number":135,"context_line":"        return settings.AVAILABLE_REGIONS"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_7d0499bf","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":16},"updated":"2016-05-09 06:33:33.000000000","message":"warn() is deprecated. warning() is preferred.","commit_id":"bda93982d21707951d6cc6df83397ac4fcebe899"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"a5a83849597816c9fa4a1d59715ac993daae6707","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":130,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":131,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":132,"context_line":"        LOG.warn(\u0027AVAILABLE_REGIONS setting has been deprecated in Newton \u0027 +"},{"line_number":133,"context_line":"                 \u0027release and will be removed in some future release. The new \u0027"},{"line_number":134,"context_line":"                 \u0027name for the same setting is KEYSTONE_ENDPOINTS.\u0027)"},{"line_number":135,"context_line":"        return settings.AVAILABLE_REGIONS"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_a34cd2c8","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":16},"in_reply_to":"dab17558_7d0499bf","updated":"2016-05-10 15:01:23.000000000","message":"Done","commit_id":"bda93982d21707951d6cc6df83397ac4fcebe899"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"1eb58aceab105a5b73d86826f228c04ec32e68de","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":131,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":132,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":133,"context_line":"        LOG.warning("},{"line_number":134,"context_line":"            \u0027AVAILABLE_REGIONS setting has been deprecated in Newton release \u0027"},{"line_number":135,"context_line":"            \u0027and will be removed in some future release. The new name for \u0027"},{"line_number":136,"context_line":"            \u0027the same setting is KEYSTONE_ENDPOINTS.\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7aa08908_6be4320c","line":133,"updated":"2016-06-14 20:12:01.000000000","message":"When I use this patch and still use AVAILABLE_REGIONS in the settings file, I get a huge amount of these log entries when going to the Projects dashboard - I think 1 entry per project.\n\n\nCan this be logged so that it\u0027s only output on login? Or maybe this should be just a debug log entry?","commit_id":"cb9e08e5b6d408ffaee7377d8a0283d2d695f688"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"4ad8365f10e949c22abb4c07e74d318d0e0b3ba7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if hasattr(settings, \u0027KEYSTONE_ENDPOINTS\u0027):"},{"line_number":131,"context_line":"        return settings.KEYSTONE_ENDPOINTS"},{"line_number":132,"context_line":"    elif hasattr(settings, \u0027AVAILABLE_REGIONS\u0027):"},{"line_number":133,"context_line":"        LOG.warning("},{"line_number":134,"context_line":"            \u0027AVAILABLE_REGIONS setting has been deprecated in Newton release \u0027"},{"line_number":135,"context_line":"            \u0027and will be removed in some future release. The new name for \u0027"},{"line_number":136,"context_line":"            \u0027the same setting is KEYSTONE_ENDPOINTS.\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7aa08908_715cd5f0","line":133,"in_reply_to":"7aa08908_6be4320c","updated":"2016-06-16 08:16:09.000000000","message":"I\u0027ve added a boolean flag that is False for most of the calls, should solve the problem of deprecation warning spam.","commit_id":"cb9e08e5b6d408ffaee7377d8a0283d2d695f688"}],"openstack_auth/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d3deab5a87e48166cdbcdb55024b34608d12d6bd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if utils.is_websso_enabled() and auth_type !\u003d \u0027credentials\u0027:"},{"line_number":64,"context_line":"            auth_url \u003d request.POST.get(\u0027endpoint\u0027)"},{"line_number":65,"context_line":"            # FIXME(tsufiev): remove 2 next lines as soon as"},{"line_number":66,"context_line":"            # https://review.openstack.org/#/c/222132 is merged"},{"line_number":67,"context_line":"            if auth_url is None:"},{"line_number":68,"context_line":"                auth_url \u003d request.POST.get(\u0027region\u0027)"},{"line_number":69,"context_line":"            url \u003d utils.get_websso_url(request, auth_url, auth_type)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_fd0c0996","line":66,"updated":"2016-05-09 06:33:33.000000000","message":"question: what I am not sure is whether we can remove the next two lines as soon as 222132 is merged.\nLet\u0027s assume a case where three horizon nodes are upgrade in a rolling upgrade way and session information is stored in memcached. Can an upgraded server handle a session stored by non-upgraded server properly? Can a non-upgraded server handle a session info set by an upgraded server?","commit_id":"bda93982d21707951d6cc6df83397ac4fcebe899"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"a5a83849597816c9fa4a1d59715ac993daae6707","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if utils.is_websso_enabled() and auth_type !\u003d \u0027credentials\u0027:"},{"line_number":64,"context_line":"            auth_url \u003d request.POST.get(\u0027endpoint\u0027)"},{"line_number":65,"context_line":"            # FIXME(tsufiev): remove 2 next lines as soon as"},{"line_number":66,"context_line":"            # https://review.openstack.org/#/c/222132 is merged"},{"line_number":67,"context_line":"            if auth_url is None:"},{"line_number":68,"context_line":"                auth_url \u003d request.POST.get(\u0027region\u0027)"},{"line_number":69,"context_line":"            url \u003d utils.get_websso_url(request, auth_url, auth_type)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab17558_c3663650","line":66,"in_reply_to":"dab17558_fd0c0996","updated":"2016-05-10 15:01:23.000000000","message":"Sharing a common session info by 2 versions of Horizon code is a valid concern, which IMO is thing difficult to fix. \n\nHowever, here and at line 85 session is not used, but instead the required values are extracted from POST / GET which are provided by browser and eventually come from https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_region_selector.html#L10","commit_id":"bda93982d21707951d6cc6df83397ac4fcebe899"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"1eb58aceab105a5b73d86826f228c04ec32e68de","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if utils.is_websso_enabled() and auth_type !\u003d \u0027credentials\u0027:"},{"line_number":62,"context_line":"            auth_url \u003d request.POST.get(\u0027endpoint\u0027)"},{"line_number":63,"context_line":"            # FIXME(tsufiev): remove 2 next lines as soon as"},{"line_number":64,"context_line":"            # https://review.openstack.org/#/c/222132 is merged"},{"line_number":65,"context_line":"            if auth_url is None:"},{"line_number":66,"context_line":"                auth_url \u003d request.POST.get(\u0027region\u0027)"},{"line_number":67,"context_line":"            url \u003d utils.get_websso_url(request, auth_url, auth_type)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7aa08908_cb53a6e0","line":64,"updated":"2016-06-14 20:12:01.000000000","message":"Suggest changing the link here to https://review.openstack.org/#/c/224759/\n(applies to a few of these below in comments also)","commit_id":"cb9e08e5b6d408ffaee7377d8a0283d2d695f688"}]}
