)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Authenticate with K2K Federation at Login Time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables a drop down on the login screen that"},{"line_number":10,"context_line":"selects a service provider for KeyStone to Keystone federation."},{"line_number":11,"context_line":"The user enters their local identity provider user/pass, selects a"},{"line_number":12,"context_line":"service provider, and will then be authenticated"},{"line_number":13,"context_line":"into the remote service provider."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_4d2017f8","line":10,"range":{"start_line":10,"start_character":31,"end_line":10,"end_character":39},"updated":"2016-07-23 07:44:44.000000000","message":"Keystone*","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"service provider, and will then be authenticated"},{"line_number":13,"context_line":"into the remote service provider."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Once authenticated, horizon will be able to use services on"},{"line_number":16,"context_line":"the service providers on behalf of the user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The k2k auth plugin has been added to the list of available"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_2d1de3bd","line":15,"range":{"start_line":15,"start_character":20,"end_line":15,"end_character":27},"updated":"2016-07-23 07:44:44.000000000","message":"Horizon*","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The k2k auth plugin has been added to the list of available"},{"line_number":19,"context_line":"openstack_auth plugins."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The horizon admin will be able to configure the list of service providers"},{"line_number":22,"context_line":"in the dropdown by configuring local_settings.py"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"example:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_8d784ffa","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":11},"updated":"2016-07-23 07:44:44.000000000","message":"A Horizon*","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"}],"openstack_auth/backend.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def authenticate(self, auth_url\u003dNone, **kwargs):"},{"line_number":87,"context_line":"        \"\"\"Authenticates a user via the Keystone Identity API.\"\"\""},{"line_number":88,"context_line":"        LOG.debug(\u0027Beginning user authentication\u0027)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if not auth_url:"},{"line_number":91,"context_line":"            auth_url \u003d settings.OPENSTACK_KEYSTONE_URL"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_6d16bba8","side":"PARENT","line":89,"updated":"2016-07-23 07:44:44.000000000","message":"unrelated change","commit_id":"0afe75fabc4b3a1c9e9482099fad220008370167"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        session \u003d utils.get_session()"},{"line_number":114,"context_line":"        keystone_client_class \u003d utils.get_keystone_client().Client"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            unscoped_auth_ref \u003d unscoped_auth.get_access(session)"},{"line_number":118,"context_line":"        except keystone_exceptions.ConnectFailure as exc:"},{"line_number":119,"context_line":"            LOG.error(str(exc))"},{"line_number":120,"context_line":"            msg \u003d _(\u0027Unable to establish connection to keystone endpoint.\u0027)"},{"line_number":121,"context_line":"            raise exceptions.KeystoneAuthException(msg)"},{"line_number":122,"context_line":"        except (keystone_exceptions.Unauthorized,"},{"line_number":123,"context_line":"                keystone_exceptions.Forbidden,"},{"line_number":124,"context_line":"                keystone_exceptions.NotFound) as exc:"},{"line_number":125,"context_line":"            LOG.debug(str(exc))"},{"line_number":126,"context_line":"            raise exceptions.KeystoneAuthException(_(\u0027Invalid credentials.\u0027))"},{"line_number":127,"context_line":"        except (keystone_exceptions.ClientException,"},{"line_number":128,"context_line":"                keystone_exceptions.AuthorizationFailure) as exc:"},{"line_number":129,"context_line":"            msg \u003d _(\"An error occurred authenticating. \""},{"line_number":130,"context_line":"                    \"Please try again later.\")"},{"line_number":131,"context_line":"            LOG.debug(str(exc))"},{"line_number":132,"context_line":"            raise exceptions.KeystoneAuthException(msg)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Check expiry for our unscoped auth ref."},{"line_number":135,"context_line":"        self.check_auth_expiry(unscoped_auth_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_6d7d1be7","side":"PARENT","line":132,"range":{"start_line":116,"start_character":8,"end_line":132,"end_character":55},"updated":"2016-07-23 07:44:44.000000000","message":"this is a weird refactor, why was it done? It looks exactly the same as before?","commit_id":"0afe75fabc4b3a1c9e9482099fad220008370167"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"a80f524bf7dbc39c66803e6c1b8fa144bbecdc30","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        session \u003d utils.get_session()"},{"line_number":114,"context_line":"        keystone_client_class \u003d utils.get_keystone_client().Client"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            unscoped_auth_ref \u003d unscoped_auth.get_access(session)"},{"line_number":118,"context_line":"        except keystone_exceptions.ConnectFailure as exc:"},{"line_number":119,"context_line":"            LOG.error(str(exc))"},{"line_number":120,"context_line":"            msg \u003d _(\u0027Unable to establish connection to keystone endpoint.\u0027)"},{"line_number":121,"context_line":"            raise exceptions.KeystoneAuthException(msg)"},{"line_number":122,"context_line":"        except (keystone_exceptions.Unauthorized,"},{"line_number":123,"context_line":"                keystone_exceptions.Forbidden,"},{"line_number":124,"context_line":"                keystone_exceptions.NotFound) as exc:"},{"line_number":125,"context_line":"            LOG.debug(str(exc))"},{"line_number":126,"context_line":"            raise exceptions.KeystoneAuthException(_(\u0027Invalid credentials.\u0027))"},{"line_number":127,"context_line":"        except (keystone_exceptions.ClientException,"},{"line_number":128,"context_line":"                keystone_exceptions.AuthorizationFailure) as exc:"},{"line_number":129,"context_line":"            msg \u003d _(\"An error occurred authenticating. \""},{"line_number":130,"context_line":"                    \"Please try again later.\")"},{"line_number":131,"context_line":"            LOG.debug(str(exc))"},{"line_number":132,"context_line":"            raise exceptions.KeystoneAuthException(msg)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # Check expiry for our unscoped auth ref."},{"line_number":135,"context_line":"        self.check_auth_expiry(unscoped_auth_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_5fefcc86","side":"PARENT","line":132,"range":{"start_line":116,"start_character":8,"end_line":132,"end_character":55},"in_reply_to":"dada55a8_6d7d1be7","updated":"2016-08-04 15:03:09.000000000","message":"This code gets used again in the plugin so I created a utility function to use it.","commit_id":"0afe75fabc4b3a1c9e9482099fad220008370167"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        for plugin in plugins:"},{"line_number":102,"context_line":"            unscoped_auth \u003d plugin.get_plugin("},{"line_number":103,"context_line":"                auth_url\u003dauth_url, plugins\u003dplugins, **kwargs)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            if unscoped_auth:"},{"line_number":106,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0d261f16","line":103,"range":{"start_line":103,"start_character":35,"end_line":103,"end_character":50},"updated":"2016-07-23 07:44:44.000000000","message":"maybe add a comment as to why you are doing this, it\u0027ll help both the reviewer and future developers","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                        \"Keystone endpoint, but v3 is specified as the API \""},{"line_number":98,"context_line":"                        \"version to use by Horizon. Using v3 endpoint for \""},{"line_number":99,"context_line":"                        \"authentication.\")"},{"line_number":100,"context_line":"        # The k2k plugin will try to use other plugins to authenticate"},{"line_number":101,"context_line":"        plugins \u003d self.auth_plugins"},{"line_number":102,"context_line":"        for plugin in plugins:"},{"line_number":103,"context_line":"            unscoped_auth \u003d plugin.get_plugin("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_71ea7edc","line":100,"updated":"2016-10-16 02:34:42.000000000","message":"Add the \"NOTE:\" syntax, this is a special case and not the norm.","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                        \"Keystone endpoint, but v3 is specified as the API \""},{"line_number":98,"context_line":"                        \"version to use by Horizon. Using v3 endpoint for \""},{"line_number":99,"context_line":"                        \"authentication.\")"},{"line_number":100,"context_line":"        # The k2k plugin will try to use other plugins to authenticate"},{"line_number":101,"context_line":"        plugins \u003d self.auth_plugins"},{"line_number":102,"context_line":"        for plugin in plugins:"},{"line_number":103,"context_line":"            unscoped_auth \u003d plugin.get_plugin("}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_76fb82c1","line":100,"in_reply_to":"fa6399be_71ea7edc","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        session \u003d utils.get_session()"},{"line_number":118,"context_line":"        keystone_client_class \u003d utils.get_keystone_client().Client"},{"line_number":119,"context_line":"        unscoped_auth_ref \u003d current_plugin.get_access_info(unscoped_auth)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # k2k federation changes the auth_url"},{"line_number":122,"context_line":"        auth_url \u003d unscoped_auth.auth_url"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_7198be78","line":119,"updated":"2016-10-16 02:34:42.000000000","message":"Do we wanna at any point LOG the plugin being used?","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        session \u003d utils.get_session()"},{"line_number":118,"context_line":"        keystone_client_class \u003d utils.get_keystone_client().Client"},{"line_number":119,"context_line":"        unscoped_auth_ref \u003d current_plugin.get_access_info(unscoped_auth)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # k2k federation changes the auth_url"},{"line_number":122,"context_line":"        auth_url \u003d unscoped_auth.auth_url"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_b98eed76","line":119,"in_reply_to":"fa6399be_7198be78","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        unscoped_auth_ref \u003d current_plugin.get_access_info(unscoped_auth)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # k2k federation changes the auth_url"},{"line_number":122,"context_line":"        auth_url \u003d unscoped_auth.auth_url"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Check expiry for our unscoped auth ref."},{"line_number":125,"context_line":"        self.check_auth_expiry(unscoped_auth_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_11a782bd","line":122,"updated":"2016-10-16 02:34:42.000000000","message":"Wouldn\u0027t this only be the case if k2k is being used? Here it seems as though its always set.","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        unscoped_auth_ref \u003d current_plugin.get_access_info(unscoped_auth)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # k2k federation changes the auth_url"},{"line_number":122,"context_line":"        auth_url \u003d unscoped_auth.auth_url"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Check expiry for our unscoped auth ref."},{"line_number":125,"context_line":"        self.check_auth_expiry(unscoped_auth_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_96af3629","line":122,"in_reply_to":"fa6399be_11a782bd","updated":"2016-11-03 20:23:29.000000000","message":"I think this is fine because for other non k2k plugins the auth_url is the same.","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}],"openstack_auth/forms.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            msg \u003d (\"Websso is enabled but horizon is not configured to work \" +"},{"line_number":103,"context_line":"                   \"with keystone version 3 or above.\")"},{"line_number":104,"context_line":"            LOG.warning(msg)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        self.fields \u003d collections.OrderedDict("},{"line_number":107,"context_line":"            (key, self.fields[key]) for key in fields_ordering)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0d6d7f32","line":105,"updated":"2016-07-23 07:44:44.000000000","message":"unrelated change","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Login(django_auth_forms.AuthenticationForm):"},{"line_number":32,"context_line":"    \"\"\"Form used for logging in a user."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Handles authentication with Keystone by providing the domain name, username"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_f1bccedd","line":31,"updated":"2016-10-16 02:34:42.000000000","message":"Maybe you can add a small note on how K2K federation is used in this Form.","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Login(django_auth_forms.AuthenticationForm):"},{"line_number":32,"context_line":"    \"\"\"Form used for logging in a user."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Handles authentication with Keystone by providing the domain name, username"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_193ef98b","line":31,"in_reply_to":"fa6399be_f1bccedd","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}],"openstack_auth/plugin/k2k.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d12682afb7a20011eb2adc21810cd817b423af5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from openstack_auth.plugin import base"},{"line_number":21,"context_line":"from openstack_auth import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from django.conf import settings"},{"line_number":24,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_c85db448","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":55},"updated":"2016-11-01 15:57:44.000000000","message":"these should be with the other 3rd party lib (keystoneauth)","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from openstack_auth.plugin import base"},{"line_number":21,"context_line":"from openstack_auth import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from django.conf import settings"},{"line_number":24,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_b96a6d7f","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":55},"in_reply_to":"ba5da102_c85db448","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    provider"},{"line_number":37,"context_line":"    \"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_plugin(self, service_provider\u003dNone, auth_url\u003dNone,"},{"line_number":40,"context_line":"                   plugins\u003d[], **kwargs):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # service_provider being None prevents infinite recursion"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_d1998a7a","line":39,"updated":"2016-10-16 02:34:42.000000000","message":"add the params and return","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            service_provider\u003dservice_provider)"},{"line_number":75,"context_line":"        return unscoped_auth"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _scope_the_unscoped_idp_auth(self, unscoped_idp_auth, auth_url,"},{"line_number":78,"context_line":"                                     idp_plugin):"},{"line_number":79,"context_line":"        \"\"\"Scope the unscoped token"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_b19ed660","line":77,"updated":"2016-10-16 02:34:42.000000000","message":"add the params and return","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                                      project_id\u003dproject.id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                scoped_auth_ref \u003d scoped_auth.get_access(session)  # noqa"},{"line_number":105,"context_line":"            except (keystone_exceptions.ClientException,"},{"line_number":106,"context_line":"                    keystone_exceptions.AuthorizationFailure):"},{"line_number":107,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_717fde14","line":104,"range":{"start_line":104,"start_character":65,"end_line":104,"end_character":67},"updated":"2016-10-16 02:34:42.000000000","message":"extra space","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                                      project_id\u003dproject.id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                scoped_auth_ref \u003d scoped_auth.get_access(session)  # noqa"},{"line_number":105,"context_line":"            except (keystone_exceptions.ClientException,"},{"line_number":106,"context_line":"                    keystone_exceptions.AuthorizationFailure):"},{"line_number":107,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_d91ba1c8","line":104,"range":{"start_line":104,"start_character":65,"end_line":104,"end_character":67},"in_reply_to":"ba5da102_28339015","updated":"2016-11-03 20:23:29.000000000","message":"oops good catch, I put it there initially because scoped_auth_ref doesn\u0027t get used at all. I\u0027ll remove it.","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d12682afb7a20011eb2adc21810cd817b423af5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                                                      project_id\u003dproject.id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            try:"},{"line_number":104,"context_line":"                scoped_auth_ref \u003d scoped_auth.get_access(session)  # noqa"},{"line_number":105,"context_line":"            except (keystone_exceptions.ClientException,"},{"line_number":106,"context_line":"                    keystone_exceptions.AuthorizationFailure):"},{"line_number":107,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_28339015","line":104,"range":{"start_line":104,"start_character":65,"end_line":104,"end_character":67},"in_reply_to":"fa6399be_717fde14","updated":"2016-11-01 15:57:44.000000000","message":"why are we doing noqa here anyway?","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        return scoped_auth"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def get_access_info(self, unscoped_auth):"},{"line_number":113,"context_line":"        \"\"\"Get the access info object"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        We attempt to get the auth ref from the service provider. If it fails"},{"line_number":116,"context_line":"        we will prepend a message saying that he error was on the service"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_9193925a","line":113,"updated":"2016-10-16 02:34:42.000000000","message":"add the param and return","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}],"openstack_auth/tests/data_v3.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":66,"context_line":"        \u0027endpoints\u0027: ["},{"line_number":67,"context_line":"            {"},{"line_number":68,"context_line":"                \u0027url\u0027: \u0027http://admin.\u0027+endpoint+\u0027:35357/v3\u0027,"},{"line_number":69,"context_line":"                \u0027region\u0027: \u0027RegionOne\u0027,"},{"line_number":70,"context_line":"                \u0027interface\u0027: \u0027admin\u0027,"},{"line_number":71,"context_line":"                \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_4ca89b77","line":68,"updated":"2016-10-16 02:34:42.000000000","message":"There is a better way of formatting this. You can do something like:\n\u0027http://admin.{endpoint}:35357/v3\u0027.format(endpoint\u003dendpoint)","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027id\u0027: uuid.uuid4().hex,"},{"line_number":66,"context_line":"        \u0027endpoints\u0027: ["},{"line_number":67,"context_line":"            {"},{"line_number":68,"context_line":"                \u0027url\u0027: \u0027http://admin.\u0027+endpoint+\u0027:35357/v3\u0027,"},{"line_number":69,"context_line":"                \u0027region\u0027: \u0027RegionOne\u0027,"},{"line_number":70,"context_line":"                \u0027interface\u0027: \u0027admin\u0027,"},{"line_number":71,"context_line":"                \u0027id\u0027: uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_597071dc","line":68,"in_reply_to":"fa6399be_4ca89b77","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    sp_list \u003d None"},{"line_number":223,"context_line":"    if service_providers:"},{"line_number":224,"context_line":"        test_data.sp_auth_url \u003d \u0027http://sp_endp:5000/v3\u0027"},{"line_number":225,"context_line":"        test_data.service_provider_id \u003d \u0027k2kserviceprovider\u0027"},{"line_number":226,"context_line":"        # The access info for the identity provider"},{"line_number":227,"context_line":"        # should return a list of service providers"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_71d19e22","line":224,"range":{"start_line":224,"start_character":40,"end_line":224,"end_character":47},"updated":"2016-10-16 02:34:42.000000000","message":"Can you chose a better name for this \"sp_endpoint\"?","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    sp_list \u003d None"},{"line_number":223,"context_line":"    if service_providers:"},{"line_number":224,"context_line":"        test_data.sp_auth_url \u003d \u0027http://sp_endp:5000/v3\u0027"},{"line_number":225,"context_line":"        test_data.service_provider_id \u003d \u0027k2kserviceprovider\u0027"},{"line_number":226,"context_line":"        # The access info for the identity provider"},{"line_number":227,"context_line":"        # should return a list of service providers"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_9901293b","line":224,"range":{"start_line":224,"start_character":40,"end_line":224,"end_character":47},"in_reply_to":"fa6399be_71d19e22","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}],"openstack_auth/tests/tests.py":[{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                \u0027username\u0027: user.name}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class OpenStackAuthTestsV3Mixin(OpenStackAuthTestsMixin):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _mock_unscoped_federated_list_projects(self, client, projects):"},{"line_number":110,"context_line":"        client.federation \u003d self.mox.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_d170aa42","line":107,"updated":"2016-10-16 02:34:42.000000000","message":"Are there any tests for the exceptions?","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                \u0027username\u0027: user.name}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class OpenStackAuthTestsV3Mixin(OpenStackAuthTestsMixin):"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _mock_unscoped_federated_list_projects(self, client, projects):"},{"line_number":110,"context_line":"        client.federation \u003d self.mox.CreateMockAnything()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_5ccdbfb5","line":107,"in_reply_to":"fa6399be_d170aa42","updated":"2016-11-03 20:23:29.000000000","message":"I\u0027ll add some","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}],"openstack_auth/utils.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"04a95a15481ae5e4368eee98697668068883e5e5","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    K2K_INITIAL_CHOICE \u003d k2kf-idp"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    #Service Provider choices, value return should be SP ID"},{"line_number":191,"context_line":"    K2K_CHOICES \u003d ("},{"line_number":192,"context_line":"        (\"k2kf-idp\", _(\"Keystone Authentication\")),"},{"line_number":193,"context_line":"        (\"k2kf-sp\", _(\"Service_Provider k2kf-sp\"))"},{"line_number":194,"context_line":"    )"},{"line_number":195,"context_line":"    \"\"\""},{"line_number":196,"context_line":"    k2k_enabled \u003d getattr(settings, \u0027K2K_SELECTION_AT_LOGIN_ENABLED\u0027, False)"},{"line_number":197,"context_line":"    keystonev3_plus \u003d (get_keystone_version() \u003e\u003d 3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_2de203a0","line":194,"range":{"start_line":191,"start_character":0,"end_line":194,"end_character":5},"updated":"2016-07-23 07:44:44.000000000","message":"is there a corresponding change to the horizon config file?","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"a80f524bf7dbc39c66803e6c1b8fa144bbecdc30","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    K2K_INITIAL_CHOICE \u003d k2kf-idp"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    #Service Provider choices, value return should be SP ID"},{"line_number":191,"context_line":"    K2K_CHOICES \u003d ("},{"line_number":192,"context_line":"        (\"k2kf-idp\", _(\"Keystone Authentication\")),"},{"line_number":193,"context_line":"        (\"k2kf-sp\", _(\"Service_Provider k2kf-sp\"))"},{"line_number":194,"context_line":"    )"},{"line_number":195,"context_line":"    \"\"\""},{"line_number":196,"context_line":"    k2k_enabled \u003d getattr(settings, \u0027K2K_SELECTION_AT_LOGIN_ENABLED\u0027, False)"},{"line_number":197,"context_line":"    keystonev3_plus \u003d (get_keystone_version() \u003e\u003d 3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bfaec82b","line":194,"range":{"start_line":191,"start_character":0,"end_line":194,"end_character":5},"in_reply_to":"dada55a8_2de203a0","updated":"2016-08-04 15:03:09.000000000","message":"yes","commit_id":"cc1f5d60a11f1e63c0b828dde3c5f064a99ed2df"},{"author":{"_account_id":16046,"name":"Fernando Diaz","email":"diazjf@us.ibm.com","username":"diazjf"},"change_message_id":"55b98dfde8c60c31f402e81b417b186890b938cf","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    \"\"\"Check if K2K federation selection list at login is enabled."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    Here are the example settings:"},{"line_number":161,"context_line":"    # Feature Flag, default is false"},{"line_number":162,"context_line":"    K2K_SELECTION_AT_LOGIN_ENABLED \u003d True"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Initial choice, should be the idp id."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_b1c7b662","line":161,"updated":"2016-10-16 02:34:42.000000000","message":"Wont need #","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"},{"author":{"_account_id":17579,"name":"Elvin Tubillara","email":"edtubill@us.ibm.com","username":"edtubill"},"change_message_id":"5eec749d28cc8356280e25c9b71ffa3730e8f848","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    \"\"\"Check if K2K federation selection list at login is enabled."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    Here are the example settings:"},{"line_number":161,"context_line":"    # Feature Flag, default is false"},{"line_number":162,"context_line":"    K2K_SELECTION_AT_LOGIN_ENABLED \u003d True"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Initial choice, should be the idp id."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5da102_fc4e936d","line":161,"in_reply_to":"fa6399be_b1c7b662","updated":"2016-11-03 20:23:29.000000000","message":"Done","commit_id":"682bc67f2fd03a19ff4626c7d562cc6e0df4dd56"}]}
