)]}'
{"id":"openstack%2Fdjango_openstack_auth~330131","triplet_id":"openstack%2Fdjango_openstack_auth~master~I3a04d838a707465c8c6e81e0e6e2fcf918b7b059","project":"openstack/django_openstack_auth","branch":"master","topic":"330131","hashtags":[],"change_id":"I3a04d838a707465c8c6e81e0e6e2fcf918b7b059","subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","status":"MERGED","created":"2016-06-15 18:19:31.000000000","updated":"2016-06-20 18:39:38.000000000","submitted":"2016-06-20 18:39:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c9c18adfdc32042ce6fe507ab5f511420fb79d37","_number":330131,"virtual_id_number":330131,"owner":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-06-20 18:39:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":0,"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},{"value":0,"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-16 18:00:57.000000000","_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":2,"date":"2016-06-20 17:17:48.000000000","_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},{"value":0,"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"value":1,"date":"2016-06-20 17:17:48.000000000","_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},{"value":0,"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-16 18:00:57.000000000","updated_by":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"reviewer":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"state":"REVIEWER"},{"updated":"2016-06-20 17:17:48.000000000","updated_by":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"reviewer":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"state":"REVIEWER"},{"updated":"2016-06-20 18:39:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dd9b514bcb813ec722fe23b6c572e920ae13e937","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-15 18:19:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a979cec81017bc4093fcc5ff58dc7a3b98b5bb74","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-15 18:23:15.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"82205463ef4e8ee764aa813cad025a7be2cc2c07","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-15 19:26:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-django_openstack_auth-docs http://docs-draft.openstack.org/31/330131/2/check/gate-django_openstack_auth-docs/55f4ad4//doc/build/html/ : SUCCESS in 3m 11s\n- gate-django_openstack_auth-pep8 http://logs.openstack.org/31/330131/2/check/gate-django_openstack_auth-pep8/646d963/ : SUCCESS in 1m 53s\n- gate-django_openstack_auth-python27 http://logs.openstack.org/31/330131/2/check/gate-django_openstack_auth-python27/f1e9cf3/ : SUCCESS in 1m 32s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/31/330131/2/check/gate-django_openstack_auth-python34/ce8b339/ : SUCCESS in 2m 12s\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/31/330131/2/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/fb35ed9/ : SUCCESS in 1h 01m 02s\n- gate-django_openstack_auth-tox-py27dj18 http://logs.openstack.org/31/330131/2/check/gate-django_openstack_auth-tox-py27dj18/5ecc30e/ : SUCCESS in 1m 54s\n- gate-django_openstack_auth-tox-py27dj19 http://logs.openstack.org/31/330131/2/check/gate-django_openstack_auth-tox-py27dj19/1aee362/ : SUCCESS in 1m 31s","accounts_in_message":[],"_revision_number":2},{"id":"3188efac86945126103025d6da3c538797b23e92","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2016-06-15 22:29:52.000000000","message":"Patch Set 2: Code-Review-1\n\nI think a new method is required to transition as we will break the references in Horizon to this method. I think this is a better route, but I think we need to not break existing horizon.","accounts_in_message":[],"_revision_number":2},{"id":"6711a78838e447cd98dc4954e6a56d0970dc4286","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-16 07:49:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"39fca76a4d6ffa9564e73ed4e0e022041f297c9a","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-16 07:58:25.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"0845738a65df62c996f84bd8c26122836d98e200","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 08:54:15.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-django_openstack_auth-docs http://docs-draft.openstack.org/31/330131/4/check/gate-django_openstack_auth-docs/d220cd6//doc/build/html/ : SUCCESS in 1m 54s\n- gate-django_openstack_auth-pep8 http://logs.openstack.org/31/330131/4/check/gate-django_openstack_auth-pep8/025e41f/ : FAILURE in 1m 27s\n- gate-django_openstack_auth-python27 http://logs.openstack.org/31/330131/4/check/gate-django_openstack_auth-python27/121e694/ : FAILURE in 3m 02s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/31/330131/4/check/gate-django_openstack_auth-python34/6c00e09/ : FAILURE in 2m 11s\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/31/330131/4/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/53a702d/ : SUCCESS in 52m 48s\n- gate-django_openstack_auth-tox-py27dj18 http://logs.openstack.org/31/330131/4/check/gate-django_openstack_auth-tox-py27dj18/ea29c4b/ : FAILURE in 2m 11s\n- gate-django_openstack_auth-tox-py27dj19 http://logs.openstack.org/31/330131/4/check/gate-django_openstack_auth-tox-py27dj19/ff5b74c/ : FAILURE in 3m 05s","accounts_in_message":[],"_revision_number":4},{"id":"695d7caacfc66b57b7fccea53c7f5e79cb12a0e8","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-16 10:08:13.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7451288ee1ceee8462eef870f93a1a19234517c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 12:46:25.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-django_openstack_auth-docs http://docs-draft.openstack.org/31/330131/5/check/gate-django_openstack_auth-docs/1b78d01//doc/build/html/ : SUCCESS in 2m 57s\n- gate-django_openstack_auth-pep8 http://logs.openstack.org/31/330131/5/check/gate-django_openstack_auth-pep8/a0f374f/ : SUCCESS in 2m 02s\n- gate-django_openstack_auth-python27 http://logs.openstack.org/31/330131/5/check/gate-django_openstack_auth-python27/7323192/ : SUCCESS in 1m 48s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/31/330131/5/check/gate-django_openstack_auth-python34/3c2ecb2/ : SUCCESS in 1m 41s\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/31/330131/5/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/7878421/ : SUCCESS in 1h 09m 10s\n- gate-django_openstack_auth-tox-py27dj18 http://logs.openstack.org/31/330131/5/check/gate-django_openstack_auth-tox-py27dj18/fadae53/ : SUCCESS in 4m 10s\n- gate-django_openstack_auth-tox-py27dj19 http://logs.openstack.org/31/330131/5/check/gate-django_openstack_auth-tox-py27dj19/206d8d0/ : SUCCESS in 3m 10s","accounts_in_message":[],"_revision_number":5},{"id":"2273cf0db5e75d8495111975ca359a4966964f4a","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2016-06-16 17:32:15.000000000","message":"Patch Set 5: Code-Review-1\n\n(3 comments)\n\nThis is looking a lot better, I have a couple more questions/comments.","accounts_in_message":[],"_revision_number":5},{"id":"4b60fe0319d795ebed490d15d458da4b047c3da9","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-16 17:47:02.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"5b662f895f5cf77b97a1c0aaec5aa1c46dc13ca0","author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"date":"2016-06-16 17:47:17.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"6579eca821861039c3bdf7420dbcd617cbd11983","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2016-06-16 18:00:57.000000000","message":"Patch Set 6: Code-Review+2\n\nLGTM, thanks.","accounts_in_message":[],"_revision_number":6},{"id":"fd042414c0abe08d07247c81a6f3e752ea80171a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 19:49:25.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-django_openstack_auth-docs http://docs-draft.openstack.org/31/330131/6/check/gate-django_openstack_auth-docs/b14893c//doc/build/html/ : SUCCESS in 3m 09s\n- gate-django_openstack_auth-pep8 http://logs.openstack.org/31/330131/6/check/gate-django_openstack_auth-pep8/07bec1e/ : SUCCESS in 1m 34s\n- gate-django_openstack_auth-python27 http://logs.openstack.org/31/330131/6/check/gate-django_openstack_auth-python27/3b82df6/ : SUCCESS in 2m 10s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/31/330131/6/check/gate-django_openstack_auth-python34/5b3d587/ : SUCCESS in 2m 26s\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/31/330131/6/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/719c2b1/ : SUCCESS in 45m 22s\n- gate-django_openstack_auth-tox-py27dj18 http://logs.openstack.org/31/330131/6/check/gate-django_openstack_auth-tox-py27dj18/b528e10/ : SUCCESS in 2m 19s\n- gate-django_openstack_auth-tox-py27dj19 http://logs.openstack.org/31/330131/6/check/gate-django_openstack_auth-tox-py27dj19/8519299/ : SUCCESS in 3m 12s","accounts_in_message":[],"_revision_number":6},{"id":"0747791309d97ad92f2f775366cb2311c45d5cc9","author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"date":"2016-06-20 17:17:48.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"2d98b602eee7a96a3903e6a65f795f10d5c8c522","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 17:17:59.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"89e7bdfbd8f2b91aa9d35d304f058d8dfb9f49c2","date":"2016-06-20 18:39:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":6},{"id":"a9405d2878a6778118d433b9c8eb3d7a61f9364a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 18:39:38.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-django_openstack_auth-docs http://docs-draft.openstack.org/31/330131/6/gate/gate-django_openstack_auth-docs/f7df2a2//doc/build/html/ : SUCCESS in 6m 59s\n- gate-django_openstack_auth-pep8 http://logs.openstack.org/31/330131/6/gate/gate-django_openstack_auth-pep8/1b12b0e/ : SUCCESS in 8m 17s\n- gate-django_openstack_auth-python27 http://logs.openstack.org/31/330131/6/gate/gate-django_openstack_auth-python27/970101a/ : SUCCESS in 9m 16s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/31/330131/6/gate/gate-django_openstack_auth-python34/4b338e8/ : SUCCESS in 9m 41s\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/31/330131/6/gate/gate-tempest-dsvm-neutron-src-django_openstack_auth/9e50f77/ : SUCCESS in 1h 21m 03s\n- gate-django_openstack_auth-tox-py27dj18 http://logs.openstack.org/31/330131/6/gate/gate-django_openstack_auth-tox-py27dj18/65304e2/ : SUCCESS in 10m 43s\n- gate-django_openstack_auth-tox-py27dj19 http://logs.openstack.org/31/330131/6/gate/gate-django_openstack_auth-tox-py27dj19/aa8df36/ : SUCCESS in 9m 42s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"c40b265c3bd8d4ae29df020d216f261cec411831","revisions":{"78740885e9f1115c72318846e6eae70cee7c3267":{"kind":"REWORK","_number":1,"created":"2016-06-15 18:19:31.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/1"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:18.000000000","tz":180},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/78740885e9f1115c72318846e6eae70cee7c3267"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/78740885e9f1115c72318846e6eae70cee7c3267"}]},"branch":"refs/heads/master"},"2f98c045000ffd7caacaf4e24cc335b8b70ff3b0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-06-15 18:23:15.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/2"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:23:13.000000000","tz":0},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nNeeded-By: I6c6a35b1c460e22dadf39634fce1bdfa257b8c63\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/2f98c045000ffd7caacaf4e24cc335b8b70ff3b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/2f98c045000ffd7caacaf4e24cc335b8b70ff3b0"}]},"branch":"refs/heads/master"},"ebb970c5959fd03eed02f63675c1d7232affd9cd":{"kind":"REWORK","_number":3,"created":"2016-06-16 07:49:39.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/3"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-16 07:49:24.000000000","tz":180},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nNeeded-By: I6c6a35b1c460e22dadf39634fce1bdfa257b8c63\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/ebb970c5959fd03eed02f63675c1d7232affd9cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/ebb970c5959fd03eed02f63675c1d7232affd9cd"}]},"branch":"refs/heads/master"},"f4c0a39c54884776adbebeecf6c94e4ddb3a0448":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2016-06-16 07:58:25.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/4"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-16 07:58:22.000000000","tz":0},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nAlso a small refactoring was made to fix_auth_url_version() (which\npreviously was edited in haste) - to reuse existing helper functions,\nthis makes the code a bit cleaner.\n\nNeeded-By: I6c6a35b1c460e22dadf39634fce1bdfa257b8c63\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/f4c0a39c54884776adbebeecf6c94e4ddb3a0448"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/f4c0a39c54884776adbebeecf6c94e4ddb3a0448"}]},"branch":"refs/heads/master"},"a5ad815233e8af029add2cc4c89a955515817c20":{"kind":"REWORK","_number":5,"created":"2016-06-16 10:08:13.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/5"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-16 10:08:02.000000000","tz":180},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nAlso a small refactoring was made to fix_auth_url_version() (which\npreviously was edited in haste) - to reuse existing helper functions,\nthis makes the code a bit cleaner.\n\nNeeded-By: I6c6a35b1c460e22dadf39634fce1bdfa257b8c63\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/a5ad815233e8af029add2cc4c89a955515817c20"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/a5ad815233e8af029add2cc4c89a955515817c20"}]},"branch":"refs/heads/master"},"c40b265c3bd8d4ae29df020d216f261cec411831":{"kind":"REWORK","_number":6,"created":"2016-06-16 17:47:02.000000000","uploader":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"ref":"refs/changes/31/330131/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/31/330131/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/31/330131/6"}}},"commit":{"parents":[{"commit":"4d078045f2ce0ea7eebb83421bea6dfb0e33aa18","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/4d078045f2ce0ea7eebb83421bea6dfb0e33aa18"}]}],"author":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-15 18:19:12.000000000","tz":180},"committer":{"name":"Timur Sufiev","email":"tsufiev@mirantis.com","date":"2016-06-16 17:46:49.000000000","tz":180},"subject":"Make fix_auth_url_version() delegate emitting the warning up the stack","message":"Make fix_auth_url_version() delegate emitting the warning up the stack\n\nThis makes sense because usually only the caller of\nfix_auth_url_version() has enough context to decide what warning\nmessage should be emitted (where did the wrong url come from? service\ncatalog or openstack_dashboard/settings.py?). This also will help to\nreduce the number of redundant warnings, emitting them only when user\nlogs in or a value from service catalog was fixed.\n\nThe necessity of this change became obvious after discussion in\nhttps://review.openstack.org/#/c/323786 comments.\n\nAlso a small refactoring was made to fix_auth_url_version() (which\npreviously was edited in haste) - to reuse existing helper functions,\nthis makes the code a bit cleaner.\n\nNeeded-By: I6c6a35b1c460e22dadf39634fce1bdfa257b8c63\nChange-Id: I3a04d838a707465c8c6e81e0e6e2fcf918b7b059\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/c40b265c3bd8d4ae29df020d216f261cec411831"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/c40b265c3bd8d4ae29df020d216f261cec411831"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
