)]}'
{"id":"openstack%2Fdjango_openstack_auth~393480","triplet_id":"openstack%2Fdjango_openstack_auth~master~I03653495d133dc463503dd4916a3bf1c877bcbef","project":"openstack/django_openstack_auth","branch":"master","topic":"domain_id_not_name","hashtags":[],"change_id":"I03653495d133dc463503dd4916a3bf1c877bcbef","subject":"Use domain ID instead of domain name for auth","status":"ABANDONED","created":"2016-11-03 20:38:14.000000000","updated":"2016-11-28 11:34:31.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a00b717c936c36f6612aadb384a0748da3beb4b","_number":393480,"virtual_id_number":393480,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":1,"date":"2016-11-03 21:43:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-11-03 23:39:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":-1,"date":"2016-11-04 00:03:07.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-03 21:43:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-03 23:39:11.000000000","updated_by":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"reviewer":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"state":"REVIEWER"}],"messages":[{"id":"bb833cdfda8d2f4301623ac5aed4a21329cd317b","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2016-11-03 20:38:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c637ca776e0243666b8540f6efec159b887009e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-03 21:43:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-django_openstack_auth-docs-ubuntu-xenial http://docs-draft.openstack.org/80/393480/1/check/gate-django_openstack_auth-docs-ubuntu-xenial/cf92766//doc/build/html/ : SUCCESS in 2m 12s\n- gate-django_openstack_auth-pep8-ubuntu-xenial http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-pep8-ubuntu-xenial/5cb815a/ : SUCCESS in 1m 42s\n- gate-django_openstack_auth-python27-ubuntu-xenial http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-python27-ubuntu-xenial/32581be/ : SUCCESS in 1m 48s\n- gate-django_openstack_auth-python34 http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-python34/c1dd1c5/ : SUCCESS in 1m 42s\n- gate-django_openstack_auth-python35-nv http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-python35-nv/6adea69/ : SUCCESS in 3m 18s (non-voting)\n- gate-tempest-dsvm-neutron-src-django_openstack_auth http://logs.openstack.org/80/393480/1/check/gate-tempest-dsvm-neutron-src-django_openstack_auth/55632e3/ : SUCCESS in 1h 04m 45s\n- gate-django_openstack_auth-tox-py27dj18-ubuntu-xenial http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-tox-py27dj18-ubuntu-xenial/fc093b0/ : SUCCESS in 1m 42s\n- gate-django_openstack_auth-tox-py27dj19-ubuntu-xenial http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-tox-py27dj19-ubuntu-xenial/d4ce81f/ : SUCCESS in 1m 51s\n- gate-django_openstack_auth-tox-py27dj110-ubuntu-xenial http://logs.openstack.org/80/393480/1/check/gate-django_openstack_auth-tox-py27dj110-ubuntu-xenial/1c62567/ : SUCCESS in 1m 46s","accounts_in_message":[],"_revision_number":1},{"id":"689a85c3c80b697961986896d3f2f6dc7e88e299","author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"date":"2016-11-03 23:39:11.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI don\u0027t think users specifying UUIDs on the login form is not a workable solution. So, we may need to reconsider the previous change.","accounts_in_message":[],"_revision_number":1},{"id":"c03abbf9e02f10cb7ef9e7cc002dd3d9efda4f96","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2016-11-04 00:03:07.000000000","message":"Patch Set 1: Workflow-1\n\nGood point, will have to rethink it a bit.","accounts_in_message":[],"_revision_number":1},{"id":"5152c6b8277b215e5bd5a0beafc2133ad0caeb17","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2016-11-28 11:34:31.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8c4cbcf800f56d6d041cedfe2e14f65156fe108e","revisions":{"8c4cbcf800f56d6d041cedfe2e14f65156fe108e":{"kind":"REWORK","_number":1,"created":"2016-11-03 20:38:14.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/80/393480/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/django_openstack_auth","ref":"refs/changes/80/393480/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/80/393480/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/80/393480/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/django_openstack_auth refs/changes/80/393480/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/django_openstack_auth refs/changes/80/393480/1"}}},"commit":{"parents":[{"commit":"42fd5c8acfdfa5a20f75a71403aa819fa9ddb0b1","subject":"Allow federated users to auth with domain scope","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/42fd5c8acfdfa5a20f75a71403aa819fa9ddb0b1"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2016-11-03 20:30:22.000000000","tz":60},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2016-11-03 20:30:22.000000000","tz":60},"subject":"Use domain ID instead of domain name for auth","message":"Use domain ID instead of domain name for auth\n\nThe comment for OPENSTACK_KEYSTONE_DEFAULT_DOMAIN states that the value\nshould contain the ID of a domain[1], yet it is being used for the\nuser_domain_name value for password authentication. If the user tries\nto set this variable to the ID of any domain besides keystone\u0027s own\nDefault domain, login will fail with \"Could not find domain:\n\u003cdomain ID\u003e\" in the keystone logs. The easiest fix would have been to\njust change the comment, but the value is being used as an ID in other\nparts of horizon[2], so best to instead assume the documentation is\ncorrect and bring the code into conformity.k\n\n[1] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/local/local_settings.py.example?h\u003d10.0.0#n71\n[2] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/api/keystone.py?h\u003d10.0.0#n288\n\nChange-Id: I03653495d133dc463503dd4916a3bf1c877bcbef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/8c4cbcf800f56d6d041cedfe2e14f65156fe108e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/django_openstack_auth/commit/8c4cbcf800f56d6d041cedfe2e14f65156fe108e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
