)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a05a5cd672821e1f04fe868db73a765bb2089d47","unresolved":false,"context_lines":[{"line_number":292,"context_line":"function start_pubsub_service {"},{"line_number":293,"context_line":"    echo \"Starting Dragonflow publisher service\""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":296,"context_line":"        run_process df-publisher-service \"python $DF_PUBLISHER_SERVICE --config-file $NEUTRON_CONF\""},{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"dab17558_52fbe0c0","line":295,"updated":"2016-05-17 20:00:15.000000000","message":"Why was this changed back to df-l3-agent? Shouldn\u0027t it be df-publisher-service?","commit_id":"5e3ea62ba9c786e71389ab8cae3803573e7f56f4"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"2adb64d6d137f6b83baabecaa41cd86514efc9ef","unresolved":false,"context_lines":[{"line_number":292,"context_line":"function start_pubsub_service {"},{"line_number":293,"context_line":"    echo \"Starting Dragonflow publisher service\""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":296,"context_line":"        run_process df-publisher-service \"python $DF_PUBLISHER_SERVICE --config-file $NEUTRON_CONF\""},{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"bab6814e_c5e89819","line":295,"in_reply_to":"dab17558_52fbe0c0","updated":"2016-05-18 06:40:54.000000000","message":"Done","commit_id":"5e3ea62ba9c786e71389ab8cae3803573e7f56f4"}],"dragonflow/cmd/eventlet/df_local_controller.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a227d6e63ac8c279a701e2aaaad31df17c23bf3e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_local_controller.main()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":20,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_eb48e42f","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":11},"updated":"2016-03-02 03:17:06.000000000","message":"do we still need this?","commit_id":"fc616744731332d37d1542eb997c8d671f519392"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c3ab53d1820f94f19d986073c85605c435a38f50","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_local_controller.main()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":20,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_33a35751","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":11},"in_reply_to":"7af24918_eb48e42f","updated":"2016-03-02 09:21:46.000000000","message":"I don\u0027t think it hurts, and if anyone wants to import this code, it won\u0027t automatically start the df controller (which is probably not what the importer would want).","commit_id":"fc616744731332d37d1542eb997c8d671f519392"}],"dragonflow/cmd/eventlet/df_publisher_service.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e5e73817e5364d82a706048b83f321140f6abdd5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_publisher_service.main()"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_0d3e89c0","line":17,"updated":"2016-05-11 06:34:10.000000000","message":"I think you need to add an explicit call to main (if name \u003d\u003d \u0027__main__\u0027: main()\u0027, or call the generated script /usr/bin/df-publisher-service.","commit_id":"1836a64f2ebc3d93ede33368c4251bb2fdb69556"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"98815bf1b4f1c81742bfd0333b993ccfb0a23292","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_publisher_service.main()"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_2db9cd15","line":17,"in_reply_to":"dab17558_0d3e89c0","updated":"2016-05-11 06:41:35.000000000","message":"Done","commit_id":"1836a64f2ebc3d93ede33368c4251bb2fdb69556"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e2b16efbec95d237799ba06d6a4c750357788635","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_publisher_service.main()"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_e218c277","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":24},"updated":"2016-05-14 14:31:10.000000000","message":"it is different from https://review.openstack.org/#/c/257838/13/dragonflow/cmd/eventlet/df_local_controller.py, where it has \"if __name__ \u003d\u003d xxx\"","commit_id":"8251ecd2eb40060ceb68f3fd890bb539b138143a"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"3393da9c60e3cf65b3f22a70227057a0bf5f1cce","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    df_publisher_service.main()"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_8aad7f86","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":24},"in_reply_to":"dab17558_e218c277","updated":"2016-05-16 01:14:42.000000000","message":"Done","commit_id":"8251ecd2eb40060ceb68f3fd890bb539b138143a"}],"dragonflow/cmd/eventlet/ovs_dragonflow_neutron_agent.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"afa523e739745a620de26fe127df25af2f47ad11","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    ovs_dragonflow_neutron_agent.main()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":20,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_11822301","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":11},"updated":"2016-01-21 03:30:09.000000000","message":"Do we need this part?","commit_id":"7ae153a0c69e3a36a8c4a1c643ad19d04f7a5467"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"8388f7c8de51263480379bbe297a40191e794b13","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    ovs_dragonflow_neutron_agent.main()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":20,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_defb2e46","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":11},"in_reply_to":"9a68dd71_11822301","updated":"2016-01-27 02:44:58.000000000","message":"Thanks for your review. Yes, we need it. Currently, DF doesn\u0027t take advantage of PBR to generate scripts files. As a result, we run it directly. I\u0027ll propose the PBR scripts, but it is not of high priority.","commit_id":"7ae153a0c69e3a36a8c4a1c643ad19d04f7a5467"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"a9983e6e680ab43483f52bf8b0ee6efed13c787b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"def main():"},{"line_number":17,"context_line":"    ovs_dragonflow_neutron_agent.main()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":20,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_2d86deb9","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":11},"in_reply_to":"9a68dd71_defb2e46","updated":"2016-01-27 06:21:48.000000000","message":"wow, the codebase is updated. I\u0027ll remove it in the next patchset.","commit_id":"7ae153a0c69e3a36a8c4a1c643ad19d04f7a5467"}],"dragonflow/controller/df_publisher_service.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e5e73817e5364d82a706048b83f321140f6abdd5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from dragonflow.db import db_common"},{"line_number":32,"context_line":"from dragonflow.db import pub_sub_api"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"eventlet.monkey_patch()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_6da115f8","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":23},"updated":"2016-05-11 06:34:10.000000000","message":"Is this line still needed?","commit_id":"1836a64f2ebc3d93ede33368c4251bb2fdb69556"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"98815bf1b4f1c81742bfd0333b993ccfb0a23292","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from dragonflow.db import db_common"},{"line_number":32,"context_line":"from dragonflow.db import pub_sub_api"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"eventlet.monkey_patch()"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_adcc9dbb","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":23},"in_reply_to":"dab17558_6da115f8","updated":"2016-05-11 06:41:35.000000000","message":"Done","commit_id":"1836a64f2ebc3d93ede33368c4251bb2fdb69556"}]}