)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"84e74e72669325aaf1fba342f82e3b069ab49683","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        iniset $NEUTRON_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    if is_service_enabled q-dhcp ; then"},{"line_number":98,"context_line":"        iniset $NEUTRON_CONF df use_centralized_ipv6_DHCP \"True\""},{"line_number":99,"context_line":"    else"},{"line_number":100,"context_line":"        iniset $NEUTRON_CONF DEFAULT dhcp_agent_notification \"False\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa69d971_e1b448f3","line":97,"range":{"start_line":97,"start_character":7,"end_line":97,"end_character":25},"updated":"2016-01-01 06:51:30.000000000","message":"These setting are only used by the neutron plugin.\n\nI think that we should move this section into the\n    if is_service_enabled q-svc","commit_id":"ee6afcabf9e0be490efecfd631b817f2ec7ac40a"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"defc6f766eb6d64678eac504c499a5aad6cc4df4","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        iniset $NEUTRON_CONF df apps_list \"$DF_APPS_LIST\""},{"line_number":95,"context_line":"    fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    if is_service_enabled q-dhcp ; then"},{"line_number":98,"context_line":"        iniset $NEUTRON_CONF df use_centralized_ipv6_DHCP \"True\""},{"line_number":99,"context_line":"    else"},{"line_number":100,"context_line":"        iniset $NEUTRON_CONF DEFAULT dhcp_agent_notification \"False\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa69d971_a796604a","line":97,"in_reply_to":"fa69d971_e1b448f3","updated":"2016-01-01 15:55:19.000000000","message":"I agree, I\u0027ll do that now and re-submit.","commit_id":"ee6afcabf9e0be490efecfd631b817f2ec7ac40a"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"95a60faa70ea1489e44deb816a007c87c5e868d0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        #       is normally done by a call to _configure_neutron_common in"},{"line_number":95,"context_line":"        #       neutron-lib, but we don\u0027t call that for compute nodes here."},{"line_number":96,"context_line":"        # Uses oslo config generator to generate core sample configuration files"},{"line_number":97,"context_line":"        (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa69d971_b942083d","line":97,"updated":"2016-01-01 17:26:59.000000000","message":"won\u0027t it be safer to save pwd, and return to it (as you cd to NEUTRON DIR)","commit_id":"4a40b5c34d1606a70014f70b75235f11d3facd1f"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"1db3f64686e27db0802a1abdaffd3cd4cce2b201","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        #       is normally done by a call to _configure_neutron_common in"},{"line_number":95,"context_line":"        #       neutron-lib, but we don\u0027t call that for compute nodes here."},{"line_number":96,"context_line":"        # Uses oslo config generator to generate core sample configuration files"},{"line_number":97,"context_line":"        (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa69d971_b9cbe852","line":97,"in_reply_to":"fa69d971_b942083d","updated":"2016-01-01 19:00:37.000000000","message":"Possibly, but this is how it\u0027s done in the devstack code itself. I can do that however, let me re-spin it later today.","commit_id":"4a40b5c34d1606a70014f70b75235f11d3facd1f"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"1a8910012daeb6658cbaa91e26cbe23f9167d84f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":99,"context_line":"        cd $_pwd"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        NEUTRON_CONF\u003d/etc/neutron/neutron.conf"},{"line_number":104,"context_line":"        iniset $NEUTRON_CONF df remote_db_ip \"$REMOTE_DB_IP\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_adc4fe5e","line":101,"range":{"start_line":101,"start_character":49,"end_line":101,"end_character":61},"updated":"2016-01-02 09:55:54.000000000","message":"The $NEUTRON_CONF variable is not set yet, it will be set in the next line.\n\nI think that we can set it as a global variable \nNEUTRON_CONF\u003d/etc/neutron/neutron.conf","commit_id":"77bcaad087450d66fde7e1a30a6059d0ea71068c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f5173acb31d90124133592cac0c059670efc322e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        (cd $NEUTRON_DIR \u0026\u0026 exec ./tools/generate_config_file_samples.sh)"},{"line_number":99,"context_line":"        cd $_pwd"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        NEUTRON_CONF\u003d/etc/neutron/neutron.conf"},{"line_number":104,"context_line":"        iniset $NEUTRON_CONF df remote_db_ip \"$REMOTE_DB_IP\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_282a3c2d","line":101,"in_reply_to":"fa69d971_adc4fe5e","updated":"2016-01-02 13:57:06.000000000","message":"Done","commit_id":"77bcaad087450d66fde7e1a30a6059d0ea71068c"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"1a8910012daeb6658cbaa91e26cbe23f9167d84f","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        NEUTRON_CONF\u003d/etc/neutron/neutron.conf"},{"line_number":104,"context_line":"        iniset $NEUTRON_CONF df remote_db_ip \"$REMOTE_DB_IP\""},{"line_number":105,"context_line":"        iniset $NEUTRON_CONF df remote_db_port $REMOTE_DB_PORT"},{"line_number":106,"context_line":"        iniset $NEUTRON_CONF df nb_db_class \"$NB_DRIVER_CLASS\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_6da5a6b3","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":20},"updated":"2016-01-02 09:55:54.000000000","message":"Should be moved before the copy or set as a global var","commit_id":"77bcaad087450d66fde7e1a30a6059d0ea71068c"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"f5173acb31d90124133592cac0c059670efc322e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        cp $NEUTRON_DIR/etc/neutron.conf.sample $NEUTRON_CONF"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        NEUTRON_CONF\u003d/etc/neutron/neutron.conf"},{"line_number":104,"context_line":"        iniset $NEUTRON_CONF df remote_db_ip \"$REMOTE_DB_IP\""},{"line_number":105,"context_line":"        iniset $NEUTRON_CONF df remote_db_port $REMOTE_DB_PORT"},{"line_number":106,"context_line":"        iniset $NEUTRON_CONF df nb_db_class \"$NB_DRIVER_CLASS\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa69d971_c821204f","line":103,"in_reply_to":"fa69d971_6da5a6b3","updated":"2016-01-02 13:57:06.000000000","message":"Done","commit_id":"77bcaad087450d66fde7e1a30a6059d0ea71068c"}]}