)]}'
{"dragonflow/neutron/plugin.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"29673c727c0200e21d874c0043a4fa05bfae50b6","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def update_network(self, context, network_id, network):"},{"line_number":299,"context_line":"        pnet._raise_if_updates_provider_attributes(network[\u0027network\u0027])"},{"line_number":300,"context_line":"        # TODO(gsagie) rollback needed"},{"line_number":301,"context_line":"        if \u0027name\u0027 in network[\u0027network\u0027]:"},{"line_number":302,"context_line":"            self._set_network_name(network_id, network[\u0027network\u0027][\u0027name\u0027])"},{"line_number":303,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":304,"context_line":"            result \u003d super(DFPlugin, self).update_network(context, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_3d7c751e","line":301,"range":{"start_line":301,"start_character":21,"end_line":301,"end_character":28},"updated":"2016-01-05 10:56:30.000000000","message":"Please move this call to after we call _process_l3_update in case it will raise exception \n\nAfter we merge autonested_transaction the SQl DB will be roled back in case of an exception","commit_id":"b7048b4054db5219e9e81383d4d7d8421ba4dae5"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"5eb9eddb305e00f47a5d92c10f1dfd37ec9cf5c4","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def update_network(self, context, network_id, network):"},{"line_number":299,"context_line":"        pnet._raise_if_updates_provider_attributes(network[\u0027network\u0027])"},{"line_number":300,"context_line":"        # TODO(gsagie) rollback needed"},{"line_number":301,"context_line":"        if \u0027name\u0027 in network[\u0027network\u0027]:"},{"line_number":302,"context_line":"            self._set_network_name(network_id, network[\u0027network\u0027][\u0027name\u0027])"},{"line_number":303,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":304,"context_line":"            result \u003d super(DFPlugin, self).update_network(context, network_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_5fc25a35","line":301,"range":{"start_line":301,"start_character":21,"end_line":301,"end_character":28},"in_reply_to":"fa69d971_3d7c751e","updated":"2016-01-06 03:41:11.000000000","message":"Thanks very much for review and explanation.","commit_id":"b7048b4054db5219e9e81383d4d7d8421ba4dae5"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"29673c727c0200e21d874c0043a4fa05bfae50b6","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":304,"context_line":"            result \u003d super(DFPlugin, self).update_network(context, network_id,"},{"line_number":305,"context_line":"                                                          network)"},{"line_number":306,"context_line":"            self._process_l3_update(context, result, network[\u0027network\u0027])"},{"line_number":307,"context_line":"            return result"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def update_port(self, context, id, port):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_fd501dd6","line":306,"range":{"start_line":306,"start_character":17,"end_line":306,"end_character":35},"updated":"2016-01-05 10:56:30.000000000","message":"This is checking the EXTERNAL value \nIf it is set to FALSE make sure we do not have FIP.\n\n\nDO we need to update the DF DB with this data, currently  we just update the network name ?","commit_id":"b7048b4054db5219e9e81383d4d7d8421ba4dae5"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"5eb9eddb305e00f47a5d92c10f1dfd37ec9cf5c4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":304,"context_line":"            result \u003d super(DFPlugin, self).update_network(context, network_id,"},{"line_number":305,"context_line":"                                                          network)"},{"line_number":306,"context_line":"            self._process_l3_update(context, result, network[\u0027network\u0027])"},{"line_number":307,"context_line":"            return result"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def update_port(self, context, id, port):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_70d66bf2","line":306,"range":{"start_line":306,"start_character":17,"end_line":306,"end_character":35},"in_reply_to":"fa69d971_fd501dd6","updated":"2016-01-06 03:41:11.000000000","message":"Now we support create external network in L259, and not support update the provider. But router:external can not update even use client specified external and return update successful. This operation of update external not hold up by the code. So if user need use another ext-net instead of original one , user must delete the original and recreate new. Should we refuse or accept this kind request now?","commit_id":"b7048b4054db5219e9e81383d4d7d8421ba4dae5"}]}