)]}'
{"devstack/zookeeper_driver":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"34107c9885d1e441622fea27a5128321018587f5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"function nb_db_driver_start_server {"},{"line_number":71,"context_line":"    if is_service_enabled df-zookeeper ; then"},{"line_number":72,"context_line":"        $ZOOKEEPER_BIN_DIR/zkServer.sh restart"},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_408c6235","line":72,"range":{"start_line":71,"start_character":7,"end_line":72,"end_character":46},"updated":"2016-01-16 08:53:43.000000000","message":"We are trying to move all databases and ovs daemons to use services so if possible to run it as a service in fedora and in ubuntu.\nPlease look at the example in the etcd driver.\n\nI will move RamCloud and  RethinkDb soon i hope","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e9c9a4ce753f205c03285dfd74fdaa53f2b6eec6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"function nb_db_driver_start_server {"},{"line_number":71,"context_line":"    if is_service_enabled df-zookeeper ; then"},{"line_number":72,"context_line":"        $ZOOKEEPER_BIN_DIR/zkServer.sh restart"},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da6ed579_8871fde2","line":72,"range":{"start_line":71,"start_character":7,"end_line":72,"end_character":46},"in_reply_to":"da6ed579_408c6235","updated":"2016-01-18 09:28:17.000000000","message":"ok, i will figure it out and fix it in the next patch.","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"}],"dragonflow/db/db_api.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"34107c9885d1e441622fea27a5128321018587f5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :type key:         string"},{"line_number":79,"context_line":"        :param value:      value to set for the created key"},{"line_number":80,"context_line":"        :type value:       string"},{"line_number":81,"context_line":"        :raises:           DragonflowException.DBValueOutOfBounds"},{"line_number":82,"context_line":"        :returns:          None"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_8b4a7b26","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":57},"updated":"2016-01-16 08:53:43.000000000","message":"Maybe we should introduce the exceptions in another patch \nAnd make sure they are handled in the upper layers\nin the Df controller and in the Plugin","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e9c9a4ce753f205c03285dfd74fdaa53f2b6eec6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :type key:         string"},{"line_number":79,"context_line":"        :param value:      value to set for the created key"},{"line_number":80,"context_line":"        :type value:       string"},{"line_number":81,"context_line":"        :raises:           DragonflowException.DBValueOutOfBounds"},{"line_number":82,"context_line":"        :returns:          None"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_68b5a97c","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":57},"in_reply_to":"da6ed579_8b4a7b26","updated":"2016-01-18 09:28:17.000000000","message":"good suggestion. i\u0027ll fix it in the next patch.","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"}],"dragonflow/db/drivers/zookeeper_db_driver.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"34107c9885d1e441622fea27a5128321018587f5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.db_port \u003d db_port"},{"line_number":56,"context_line":"        self.config \u003d args[\u0027config\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _lazy_initialize(self):"},{"line_number":59,"context_line":"        if not self.client:"},{"line_number":60,"context_line":"            hosts \u003d _parse_hosts(self.config.remote_db_hosts)"},{"line_number":61,"context_line":"            _handler \u003d SequentialEventletHandler()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_8b711b7a","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":24},"updated":"2016-01-16 08:53:43.000000000","message":"Good idea with the lazy loading \n\nIt mean that we have a client per process on the same machine \n\nDoes zookeeper know how to handle that ?","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e9c9a4ce753f205c03285dfd74fdaa53f2b6eec6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.db_port \u003d db_port"},{"line_number":56,"context_line":"        self.config \u003d args[\u0027config\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _lazy_initialize(self):"},{"line_number":59,"context_line":"        if not self.client:"},{"line_number":60,"context_line":"            hosts \u003d _parse_hosts(self.config.remote_db_hosts)"},{"line_number":61,"context_line":"            _handler \u003d SequentialEventletHandler()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_2889f1ca","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":24},"in_reply_to":"da6ed579_8b711b7a","updated":"2016-01-18 09:28:17.000000000","message":"yes, one client per process means one connection to zk server per process. if we set multiple hosts, it will randomize and select one of the hosts servicing each client instance per process.","commit_id":"3a98b26295658616cde30750e5e856fb4a151bef"}]}