)]}'
{"dragonflow/controller/df_local_controller.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"d59d7a4853ac0002d15203a8eef0afbb099d0038","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                LOG.info(_LI(\"Logical Local Port %s was not created yet \") %"},{"line_number":184,"context_line":"                         lport.__str__())"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            ofport \u003d chassis_to_ofport.get(lport.get_chassis(), 0)"},{"line_number":187,"context_line":"            if ofport !\u003d 0:"},{"line_number":188,"context_line":"                lport.set_external_value(\u0027ofport\u0027, ofport)"},{"line_number":189,"context_line":"                lport.set_external_value(\u0027is_local\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_4e65d0b2","line":186,"updated":"2016-01-24 06:32:49.000000000","message":"You need this here as well for the remote port, but good catch","commit_id":"48bd446617b5040d0e60dbe1163f48cf3e419f70"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"c6892b171e65f3c85a741134a6acdf10dead7cd0","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                LOG.info(_LI(\"Logical Local Port %s was not created yet \") %"},{"line_number":184,"context_line":"                         lport.__str__())"},{"line_number":185,"context_line":"        else:"},{"line_number":186,"context_line":"            ofport \u003d chassis_to_ofport.get(lport.get_chassis(), 0)"},{"line_number":187,"context_line":"            if ofport !\u003d 0:"},{"line_number":188,"context_line":"                lport.set_external_value(\u0027ofport\u0027, ofport)"},{"line_number":189,"context_line":"                lport.set_external_value(\u0027is_local\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_0e127809","line":186,"in_reply_to":"9a68dd71_4e65d0b2","updated":"2016-01-24 06:36:23.000000000","message":"Will Do","commit_id":"48bd446617b5040d0e60dbe1163f48cf3e419f70"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"796224bb40552efe952bfab61649aa5179a922d0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                         lport.__str__())"},{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            ofport \u003d chassis_to_ofport.get(lport.get_chassis(), 0)"},{"line_number":188,"context_line":"            self.db_store.set_port(lport.get_id(), lport, False)"},{"line_number":189,"context_line":"            if ofport !\u003d 0:"},{"line_number":190,"context_line":"                lport.set_external_value(\u0027ofport\u0027, ofport)"},{"line_number":191,"context_line":"                lport.set_external_value(\u0027is_local\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4ec15053","line":188,"updated":"2016-01-24 06:47:22.000000000","message":"I think this scenario is a bit problematic in a second thought, maybe we should raise an exception here for now.","commit_id":"4bf6c94dfbf3a4e6495e5c28b04f953a01cc4352"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"b2b5b23d3911799ac1b9b2e1f6ce2e336d107dfd","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                         lport.__str__())"},{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            ofport \u003d chassis_to_ofport.get(lport.get_chassis(), 0)"},{"line_number":188,"context_line":"            self.db_store.set_port(lport.get_id(), lport, False)"},{"line_number":189,"context_line":"            if ofport !\u003d 0:"},{"line_number":190,"context_line":"                lport.set_external_value(\u0027ofport\u0027, ofport)"},{"line_number":191,"context_line":"                lport.set_external_value(\u0027is_local\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_ae7ecc16","line":188,"in_reply_to":"9a68dd71_4ec15053","updated":"2016-01-24 06:58:05.000000000","message":"I agree this should never happen for now, the neutron plugin should all ways set the port chassis.\n\n\nBut when we move to containers support, will it not set the host id from the compute node in that case we could get two messages one without the chassis and the second with.\n\n\nI suggest to leave it like this in this patch and think about the no chassis handling in another patch to avoid all the dependencies update","commit_id":"4bf6c94dfbf3a4e6495e5c28b04f953a01cc4352"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"78c2a1cb29a934a4b88f4a1f179a6a1d8da61006","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                         lport.__str__())"},{"line_number":194,"context_line":"                self.dispatcher.dispatch(\u0027add_remote_port\u0027, lport\u003dlport)"},{"line_number":195,"context_line":"                self.db_store.set_port(lport.get_id(), lport, False)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def logical_port_deleted(self, lport_id):"},{"line_number":198,"context_line":"        lport \u003d self.db_store.get_port(lport_id)"},{"line_number":199,"context_line":"        if lport is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_31847d5c","line":196,"updated":"2016-01-24 08:14:24.000000000","message":"In any case, if the port does not exist, maybe an info (or error) log should be added, as in the case above?","commit_id":"4bf6c94dfbf3a4e6495e5c28b04f953a01cc4352"}]}
