)]}'
{"dragonflow/controller/l2_app.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"8f1415886bb47217d81a26336f165948f4eb64fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DF_L2_APP_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt("},{"line_number":30,"context_line":"        \u0027df_arp_responder\u0027,"},{"line_number":31,"context_line":"        default\u003dTrue,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Install OVS flows to respond to ARP requests.\u0027))"},{"line_number":33,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_7dba06c2","line":30,"range":{"start_line":30,"start_character":9,"end_line":30,"end_character":25},"updated":"2016-01-29 09:05:44.000000000","message":"The term all ready used by Neutron ML2 is l2_population \n\ni think that it will be easier to understand if we use the same terminology. df_l2_population\n\nWhy you think it is best to put the option here and not in the common parameters file ?","commit_id":"4e1dd04119f59f9859a87249a12ed9909f8b9488"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ad59e39c4df3bd2f395b327a0a3423f5f117f364","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DF_L2_APP_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt("},{"line_number":30,"context_line":"        \u0027df_arp_responder\u0027,"},{"line_number":31,"context_line":"        default\u003dTrue,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Install OVS flows to respond to ARP requests.\u0027))"},{"line_number":33,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_ab71df45","line":30,"range":{"start_line":30,"start_character":9,"end_line":30,"end_character":25},"in_reply_to":"7a5de9d1_7dba06c2","updated":"2016-01-31 06:19:44.000000000","message":"Will change the option name to df_l2_population.\n\nThe location of the option declaration is taken from the example in dhcp_app. Additionally, this option only affects this module, so I don\u0027t think it should be made global.","commit_id":"4e1dd04119f59f9859a87249a12ed9909f8b9488"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"1faf4eb5cd8e7f35b6b40a102c674575f7d5693a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                const.PRIORITY_MEDIUM,"},{"line_number":66,"context_line":"                const.ARP_TABLE, match\u003dmatch)"},{"line_number":67,"context_line":"        self._install_flows_on_switch_up()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def add_arp_responder(self, lport):"},{"line_number":70,"context_line":"        if not self.is_install_arp_responder:"},{"line_number":71,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_273e70c1","line":68,"updated":"2016-02-01 08:47:51.000000000","message":"As local methods, I suggest to rename them to \u0027_add_arp_responder\u0027 and \u0027_remove_arp_responder\u0027.","commit_id":"d8a61ac63a1b04262fdd494128f8e6ecbadae2a3"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"5972861a78f94eb9d7b9db72d5f632000ba7a405","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DF_L2_APP_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt("},{"line_number":30,"context_line":"        \u0027df_l2_responder\u0027,"},{"line_number":31,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_6bb2bc4d","line":28,"updated":"2016-02-02 07:31:48.000000000","message":"Do we want this as a configuration in the local.conf as well? if yes we need to add support for it.\nOtherwise its pretty hard to use this argument without actually changing the code","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b39531ae4bfe0e96db141bba804b457d2338bd44","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"DF_L2_APP_OPTS \u003d ["},{"line_number":29,"context_line":"    cfg.BoolOpt("},{"line_number":30,"context_line":"        \u0027df_l2_responder\u0027,"},{"line_number":31,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_83acb136","line":28,"in_reply_to":"7a5de9d1_6bb2bc4d","updated":"2016-02-02 12:06:54.000000000","message":"Will do.","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"f0e95abdb38483f228499ae69791d83d60960b37","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                const.ARP_TABLE, match\u003dmatch)"},{"line_number":67,"context_line":"        self._install_flows_on_switch_up()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def add_arp_responder(self, lport):"},{"line_number":70,"context_line":"        if not self.is_install_arp_responder:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        ip \u003d lport.get_ip()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_dcd15124","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":25},"updated":"2016-02-01 19:52:41.000000000","message":"Please change this method to be private _add_","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b39531ae4bfe0e96db141bba804b457d2338bd44","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                const.ARP_TABLE, match\u003dmatch)"},{"line_number":67,"context_line":"        self._install_flows_on_switch_up()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def add_arp_responder(self, lport):"},{"line_number":70,"context_line":"        if not self.is_install_arp_responder:"},{"line_number":71,"context_line":"            return"},{"line_number":72,"context_line":"        ip \u003d lport.get_ip()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_ccce63b7","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":25},"in_reply_to":"7a5de9d1_dcd15124","updated":"2016-02-02 12:06:54.000000000","message":"Done","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"}],"dragonflow/controller/l3_app.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"004066dba92d8539d3d571208e16efee14de4171","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                self.add_router_port(lrouter, router_port,"},{"line_number":379,"context_line":"                        local_network_id)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def add_port(self, lport):"},{"line_number":382,"context_line":"        if not self.is_arp_responder:"},{"line_number":383,"context_line":"            return"},{"line_number":384,"context_line":"        ip \u003d lport.get_ip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_5275fac8","line":381,"updated":"2016-01-28 08:52:45.000000000","message":"i personally think that the correct way to do it, is add the ARP responder from the L2 application","commit_id":"dd9bfaff85d411d867204b6a5a28ba9845825042"}],"dragonflow/tests/fullstack/test_ovs_flows.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"5972861a78f94eb9d7b9db72d5f632000ba7a405","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        full_args \u003d [\"ovs-ofctl\", \"dump-flows\", \u0027br-int\u0027, \u0027-O Openflow13\u0027]"},{"line_number":27,"context_line":"        flows \u003d utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":28,"context_line":"                              process_input\u003dNone)"},{"line_number":29,"context_line":"        print \"TestOVSFlows: {}\".format(flows)"},{"line_number":30,"context_line":"        return flows"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_number_of_flows(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_abc8b4a8","line":29,"updated":"2016-02-02 07:31:48.000000000","message":"We want this ? if yes maybe we should consider using log to print it","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"234cdb748831a8fd5a647393ce7563c00bebf1ad","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        full_args \u003d [\"ovs-ofctl\", \"dump-flows\", \u0027br-int\u0027, \u0027-O Openflow13\u0027]"},{"line_number":27,"context_line":"        flows \u003d utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":28,"context_line":"                              process_input\u003dNone)"},{"line_number":29,"context_line":"        print \"TestOVSFlows: {}\".format(flows)"},{"line_number":30,"context_line":"        return flows"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_number_of_flows(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_c67157aa","line":29,"in_reply_to":"7a5de9d1_4c4a7329","updated":"2016-02-02 13:09:07.000000000","message":"This file was deleted. (I thought it was just moved).","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b39531ae4bfe0e96db141bba804b457d2338bd44","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        full_args \u003d [\"ovs-ofctl\", \"dump-flows\", \u0027br-int\u0027, \u0027-O Openflow13\u0027]"},{"line_number":27,"context_line":"        flows \u003d utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":28,"context_line":"                              process_input\u003dNone)"},{"line_number":29,"context_line":"        print \"TestOVSFlows: {}\".format(flows)"},{"line_number":30,"context_line":"        return flows"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_number_of_flows(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_4c4a7329","line":29,"in_reply_to":"7a5de9d1_abc8b4a8","updated":"2016-02-02 12:06:54.000000000","message":"We definitely want this. It will use oslo_log.","commit_id":"980800ae253c25229d51ac4bc4e409714046422a"}]}