)]}'
{"dragonflow/controller/common/arp_responder.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"24cabd1903464c95b61f956f9fa4b7818fe8a8b6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.interface_ip \u003d interface_ip"},{"line_number":37,"context_line":"        self.mac_address \u003d interface_mac"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_match(self):"},{"line_number":40,"context_line":"        parser \u003d self.datapath.ofproto_parser"},{"line_number":41,"context_line":"        match \u003d parser.OFPMatch()"},{"line_number":42,"context_line":"        match.set_dl_type(ether.ETH_TYPE_ARP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_24eca38e","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":17},"updated":"2016-01-28 15:11:41.000000000","message":"could be private unless you have a use case in mind that we need it as public \n\n\n\n_get_match","commit_id":"b6a4ed183dd6ea6af6b8021b76b85a603946344b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e2ef85307c3ba758334a6b01f833a40573441582","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.interface_ip \u003d interface_ip"},{"line_number":37,"context_line":"        self.mac_address \u003d interface_mac"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_match(self):"},{"line_number":40,"context_line":"        parser \u003d self.datapath.ofproto_parser"},{"line_number":41,"context_line":"        match \u003d parser.OFPMatch()"},{"line_number":42,"context_line":"        match.set_dl_type(ether.ETH_TYPE_ARP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_1fd534b8","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":17},"in_reply_to":"7a5de9d1_24eca38e","updated":"2016-01-28 15:26:27.000000000","message":"Done","commit_id":"b6a4ed183dd6ea6af6b8021b76b85a603946344b"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"24cabd1903464c95b61f956f9fa4b7818fe8a8b6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        match.set_metadata(self.network_id)"},{"line_number":46,"context_line":"        return match"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_instructions(self):"},{"line_number":49,"context_line":"        ofproto \u003d self.datapath.ofproto"},{"line_number":50,"context_line":"        parser \u003d self.datapath.ofproto_parser"},{"line_number":51,"context_line":"        actions \u003d [parser.OFPActionSetField(arp_op\u003darp.ARP_REPLY),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_04a08742","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":24},"updated":"2016-01-28 15:11:41.000000000","message":"ditto","commit_id":"b6a4ed183dd6ea6af6b8021b76b85a603946344b"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e2ef85307c3ba758334a6b01f833a40573441582","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        match.set_metadata(self.network_id)"},{"line_number":46,"context_line":"        return match"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_instructions(self):"},{"line_number":49,"context_line":"        ofproto \u003d self.datapath.ofproto"},{"line_number":50,"context_line":"        parser \u003d self.datapath.ofproto_parser"},{"line_number":51,"context_line":"        actions \u003d [parser.OFPActionSetField(arp_op\u003darp.ARP_REPLY),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_bfdc20e5","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":24},"in_reply_to":"7a5de9d1_04a08742","updated":"2016-01-28 15:26:27.000000000","message":"Done","commit_id":"b6a4ed183dd6ea6af6b8021b76b85a603946344b"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"caf0f839eb9250656a1d8937a9c0b6dcd6131bd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        msg \u003d parser.OFPFlowMod(datapath\u003dself.datapath,"},{"line_number":84,"context_line":"                                cookie\u003d0,"},{"line_number":85,"context_line":"                                cookie_mask\u003d0,"},{"line_number":86,"context_line":"                                table_id\u003dconst.ARP_TABLE,"},{"line_number":87,"context_line":"                                command\u003dofproto.OFPFC_DELETE,"},{"line_number":88,"context_line":"                                priority\u003dconst.PRIORITY_MEDIUM,"},{"line_number":89,"context_line":"                                out_port\u003dofproto.OFPP_ANY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_0bfcb370","line":86,"updated":"2016-01-31 06:47:53.000000000","message":"table should be parameter as well i think","commit_id":"9c511812eb2af1bd6daa4bcdbb5057290b88e0a5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c516352bbc00d88ef26149a6dbb87ef2760abf57","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        msg \u003d parser.OFPFlowMod(datapath\u003dself.datapath,"},{"line_number":84,"context_line":"                                cookie\u003d0,"},{"line_number":85,"context_line":"                                cookie_mask\u003d0,"},{"line_number":86,"context_line":"                                table_id\u003dconst.ARP_TABLE,"},{"line_number":87,"context_line":"                                command\u003dofproto.OFPFC_DELETE,"},{"line_number":88,"context_line":"                                priority\u003dconst.PRIORITY_MEDIUM,"},{"line_number":89,"context_line":"                                out_port\u003dofproto.OFPP_ANY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_8bfae341","line":86,"in_reply_to":"7a5de9d1_0bfcb370","updated":"2016-01-31 07:07:34.000000000","message":"Agreed. Will send in as another patch (unless there will be something blocking in this one.)","commit_id":"9c511812eb2af1bd6daa4bcdbb5057290b88e0a5"}],"dragonflow/controller/df_base_app.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"caf0f839eb9250656a1d8937a9c0b6dcd6131bd9","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        ofp_parser \u003d datapath.ofproto_parser"},{"line_number":104,"context_line":"        req \u003d ofp_parser.OFPPortDescStatsRequest(datapath, 0)"},{"line_number":105,"context_line":"        datapath.send_msg(req)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # TODO(oanson) Move somewhere else"},{"line_number":108,"context_line":"    def ipv4_text_to_int(self, ip_text):"},{"line_number":109,"context_line":"        if ip_text \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_ab1b1fc9","side":"PARENT","line":106,"updated":"2016-01-31 06:47:53.000000000","message":"This is really a \"general\" method, i would have a \"general utility\" class and ARP responder can inherit from it with this method in it.\n\nBut its not urgent, can wait when we have other user.","commit_id":"9ac65acb4cc631c2c72c06021b7e42d48c0be5ba"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c516352bbc00d88ef26149a6dbb87ef2760abf57","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        ofp_parser \u003d datapath.ofproto_parser"},{"line_number":104,"context_line":"        req \u003d ofp_parser.OFPPortDescStatsRequest(datapath, 0)"},{"line_number":105,"context_line":"        datapath.send_msg(req)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # TODO(oanson) Move somewhere else"},{"line_number":108,"context_line":"    def ipv4_text_to_int(self, ip_text):"},{"line_number":109,"context_line":"        if ip_text \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_cb045b4b","side":"PARENT","line":106,"in_reply_to":"7a5de9d1_ab1b1fc9","updated":"2016-01-31 07:07:34.000000000","message":"I agree that this is a general method. But it shouldn\u0027t be in the responder\u0027s parent class - it doesn\u0027t fullfil the \u0027is-a\u0027 condition. It should be moved to a utility library.","commit_id":"9ac65acb4cc631c2c72c06021b7e42d48c0be5ba"}]}