)]}'
{"dragonflow/tests/fullstack/test_objects.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"f06377071afe3ee6ca14e6f89e79149290e39350","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.nova \u003d novaclient.Client(\u00272\u0027, creds[\u0027username\u0027],"},{"line_number":154,"context_line":"                        creds[\u0027password\u0027], \u0027demo\u0027, auth_url)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create(self, script\u003dNone):"},{"line_number":157,"context_line":"        image \u003d self.nova.images.find(name\u003d\"cirros-0.3.4-x86_64-uec\")"},{"line_number":158,"context_line":"        self.parent.assertIsNotNone(image)"},{"line_number":159,"context_line":"        flavor \u003d self.nova.flavors.find(name\u003d\"m1.tiny\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_616209af","line":156,"updated":"2016-02-27 17:14:39.000000000","message":"how about we also add the network name/id as an argument here","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d5faaf2f8ad0333b0fd471983645246c17855646","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.nova \u003d novaclient.Client(\u00272\u0027, creds[\u0027username\u0027],"},{"line_number":154,"context_line":"                        creds[\u0027password\u0027], \u0027demo\u0027, auth_url)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create(self, script\u003dNone):"},{"line_number":157,"context_line":"        image \u003d self.nova.images.find(name\u003d\"cirros-0.3.4-x86_64-uec\")"},{"line_number":158,"context_line":"        self.parent.assertIsNotNone(image)"},{"line_number":159,"context_line":"        flavor \u003d self.nova.flavors.find(name\u003d\"m1.tiny\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_99a05d45","line":156,"in_reply_to":"9aed3d3a_616209af","updated":"2016-02-28 06:08:35.000000000","message":"I think this definitely belongs in another patch.","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"05f28f07ea95d552b5272e93681240586402081c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.nova \u003d novaclient.Client(\u00272\u0027, creds[\u0027username\u0027],"},{"line_number":154,"context_line":"                        creds[\u0027password\u0027], \u0027demo\u0027, auth_url)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create(self, script\u003dNone):"},{"line_number":157,"context_line":"        image \u003d self.nova.images.find(name\u003d\"cirros-0.3.4-x86_64-uec\")"},{"line_number":158,"context_line":"        self.parent.assertIsNotNone(image)"},{"line_number":159,"context_line":"        flavor \u003d self.nova.flavors.find(name\u003d\"m1.tiny\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f9540922","line":156,"in_reply_to":"9aed3d3a_99a05d45","updated":"2016-02-28 06:24:47.000000000","message":"you can do it on another patch if you want, i dont see why but ok :)","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"083b96fc10e328cb57a6dc7bfc9b6e000d670c59","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.nova \u003d novaclient.Client(\u00272\u0027, creds[\u0027username\u0027],"},{"line_number":154,"context_line":"                        creds[\u0027password\u0027], \u0027demo\u0027, auth_url)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def create(self, script\u003dNone):"},{"line_number":157,"context_line":"        image \u003d self.nova.images.find(name\u003d\"cirros-0.3.4-x86_64-uec\")"},{"line_number":158,"context_line":"        self.parent.assertIsNotNone(image)"},{"line_number":159,"context_line":"        flavor \u003d self.nova.flavors.find(name\u003d\"m1.tiny\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f43090ea","line":156,"in_reply_to":"9aed3d3a_f9540922","updated":"2016-02-28 06:38:36.000000000","message":"Because my patches tend to reach hundreds of lines of code, and I was told that was Bad :).","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"f06377071afe3ee6ca14e6f89e79149290e39350","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return self.server.id"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _find_first_network(self, **kwargs):"},{"line_number":172,"context_line":"        networks \u003d self.nova.networks.findall(**kwargs)"},{"line_number":173,"context_line":"        networks_count \u003d len(networks)"},{"line_number":174,"context_line":"        if networks_count \u003d\u003d 0:"},{"line_number":175,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_0174dd65","line":172,"updated":"2016-02-27 17:14:39.000000000","message":"i dont understand why we use nova client for this, we should convert to using Neutron client","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"d5faaf2f8ad0333b0fd471983645246c17855646","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return self.server.id"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _find_first_network(self, **kwargs):"},{"line_number":172,"context_line":"        networks \u003d self.nova.networks.findall(**kwargs)"},{"line_number":173,"context_line":"        networks_count \u003d len(networks)"},{"line_number":174,"context_line":"        if networks_count \u003d\u003d 0:"},{"line_number":175,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_59bd3567","line":172,"in_reply_to":"9aed3d3a_0174dd65","updated":"2016-02-28 06:08:35.000000000","message":"I think this belongs in another patch.\nThe goal of this patch is to deal with that one specific exception. It\u0027s atomic as it is, and doesn\u0027t include multiple elements.","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"4ec25b63d8d7dd1f80996202a76a8e39345aced9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return self.server.id"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _find_first_network(self, **kwargs):"},{"line_number":172,"context_line":"        networks \u003d self.nova.networks.findall(**kwargs)"},{"line_number":173,"context_line":"        networks_count \u003d len(networks)"},{"line_number":174,"context_line":"        if networks_count \u003d\u003d 0:"},{"line_number":175,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_dff92582","line":172,"in_reply_to":"9aed3d3a_3451580f","updated":"2016-02-28 09:13:20.000000000","message":"This change is up for review: https://review.openstack.org/#/c/285762/","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"05f28f07ea95d552b5272e93681240586402081c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return self.server.id"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _find_first_network(self, **kwargs):"},{"line_number":172,"context_line":"        networks \u003d self.nova.networks.findall(**kwargs)"},{"line_number":173,"context_line":"        networks_count \u003d len(networks)"},{"line_number":174,"context_line":"        if networks_count \u003d\u003d 0:"},{"line_number":175,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_7948f987","line":172,"in_reply_to":"9aed3d3a_59bd3567","updated":"2016-02-28 06:24:47.000000000","message":"The problem starts with the use of nova to do what should have been done with neutron","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"083b96fc10e328cb57a6dc7bfc9b6e000d670c59","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return self.server.id"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _find_first_network(self, **kwargs):"},{"line_number":172,"context_line":"        networks \u003d self.nova.networks.findall(**kwargs)"},{"line_number":173,"context_line":"        networks_count \u003d len(networks)"},{"line_number":174,"context_line":"        if networks_count \u003d\u003d 0:"},{"line_number":175,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_3451580f","line":172,"in_reply_to":"9aed3d3a_7948f987","updated":"2016-02-28 06:38:36.000000000","message":"I agree it\u0027s a problem. But I haven\u0027t changed the API library used here, just the specific method called.\n\nChanging to neutron API has a few more changes due to API differences (I will have a patch ready very soon).","commit_id":"a0af83eff460db19a2103630d982055ead8547a2"}]}