)]}'
{"devstack/ovs_manager.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"befad71c94a59b4abbc240c6fb0506e7f2354fc8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            fi"},{"line_number":90,"context_line":"        done"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"           if is_ubuntu; then"},{"line_number":93,"context_line":"            _neutron_ovs_install_ovs_ubuntu"},{"line_number":94,"context_line":"        elif is_fedora; then"},{"line_number":95,"context_line":"            _neutron_ovs_install_ovs_fedora"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1af94dfe_75ce35b5","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":13},"updated":"2016-03-17 09:05:15.000000000","message":"indent it to the left","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c0f458255787116291f22ad4a91f9534acd4536b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            fi"},{"line_number":90,"context_line":"        done"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"           if is_ubuntu; then"},{"line_number":93,"context_line":"            _neutron_ovs_install_ovs_ubuntu"},{"line_number":94,"context_line":"        elif is_fedora; then"},{"line_number":95,"context_line":"            _neutron_ovs_install_ovs_fedora"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_a0ed9e27","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":13},"in_reply_to":"1af94dfe_75ce35b5","updated":"2016-03-20 07:58:42.000000000","message":"Done","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"befad71c94a59b4abbc240c6fb0506e7f2354fc8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            install_package $(get_packages \"openvswitch\")"},{"line_number":99,"context_line":"        fi"},{"line_number":100,"context_line":"    else"},{"line_number":101,"context_line":"        echo \"Installing OVS and dependent packages via package manager\""},{"line_number":102,"context_line":"        install_package $(get_packages \"openvswitch\")"},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":"}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1af94dfe_d5de296c","line":102,"range":{"start_line":101,"start_character":7,"end_line":102,"end_character":53},"updated":"2016-03-17 09:05:15.000000000","message":"You fall back to the stable package install that is missing teh SG feature\n\nIt make more sense to fall back to the compile with out RPM that we have now (what do you think ?)","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c0f458255787116291f22ad4a91f9534acd4536b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            install_package $(get_packages \"openvswitch\")"},{"line_number":99,"context_line":"        fi"},{"line_number":100,"context_line":"    else"},{"line_number":101,"context_line":"        echo \"Installing OVS and dependent packages via package manager\""},{"line_number":102,"context_line":"        install_package $(get_packages \"openvswitch\")"},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":"}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_00f3aa0b","line":102,"range":{"start_line":101,"start_character":7,"end_line":102,"end_character":53},"in_reply_to":"1af94dfe_d5de296c","updated":"2016-03-20 07:58:42.000000000","message":"This solution is more stable, and I have no way to test it (I only have fedora and ubuntu VMs).\n\nI considered also failing the installation if the distro was unknown, to make sure whoever runs into will provide us with a proper testing scenario.\n\nIt\u0027s up to you guys.","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"9196dc02673acb21c515cb6d0a58075efe219720","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    OVS_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file openvswitch`"},{"line_number":56,"context_line":"    OVS_PY_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file python-openvswitch`"},{"line_number":57,"context_line":"    OVS_KMOD_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file openvswitch-kmod ../rhel/openvswitch-kmod-fedora.spec`"},{"line_number":58,"context_line":"    sudo dnf install -y $OVS_RPM_BASENAME $OVS_PY_RPM_BASENAME $OVS_KMOD_RPM_BASENAME"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    popd"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_a32ac87c","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":21},"updated":"2016-03-20 11:19:43.000000000","message":"this will work only with fedora \u003d\u003e 22\nI think we need to support older fedora versions as well\n\nYou could use $os_RELEASE -ge \"22\"","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"edc99f0debb2dc78a07da2b27efbe274cc86ea18","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    OVS_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file openvswitch`"},{"line_number":56,"context_line":"    OVS_PY_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file python-openvswitch`"},{"line_number":57,"context_line":"    OVS_KMOD_RPM_BASENAME\u003d`_neutron_ovs_get_rpm_file openvswitch-kmod ../rhel/openvswitch-kmod-fedora.spec`"},{"line_number":58,"context_line":"    sudo dnf install -y $OVS_RPM_BASENAME $OVS_PY_RPM_BASENAME $OVS_KMOD_RPM_BASENAME"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    popd"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_94f1bcd0","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":21},"in_reply_to":"fa0719c6_a32ac87c","updated":"2016-03-20 18:34:00.000000000","message":"Will do, although I thought we only supported fedora 22-23.","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"}],"devstack/plugin.sh":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"5a7a1e1476c549158e5ac8dbf01e7e8361919fd8","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # If OVS is already installed, remove it, because we\u0027re about to re-install"},{"line_number":189,"context_line":"    # it from source."},{"line_number":190,"context_line":"    install_package openvswitch"},{"line_number":191,"context_line":"    install_package python-openvswitch"},{"line_number":192,"context_line":"}"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9aed3d3a_41a632c2","line":190,"range":{"start_line":190,"start_character":20,"end_line":190,"end_character":31},"updated":"2016-02-26 05:43:30.000000000","message":"Do all the distributions support openvswitch 2.5?\nFor example, Fedora, Ubuntu, CentOS, RHEL and SUSE.","commit_id":"327a66d627477fc9d00ee2743d07f359c096bc31"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"befad71c94a59b4abbc240c6fb0506e7f2354fc8","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"function stop_ovs"},{"line_number":203,"context_line":"{"},{"line_number":204,"context_line":"    start_service openvswitch stop"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# The following returns \"0\" when service is live."}],"source_content_type":"text/x-sh","patch_set":3,"id":"1af94dfe_f5688589","line":204,"range":{"start_line":204,"start_character":18,"end_line":204,"end_character":29},"updated":"2016-03-17 09:05:15.000000000","message":"if is_fedora; then\n        SERVICE_NAME\u003dopenvswitch\n    elif is_ubuntu; then\n        SERVICE_NAME\u003dopenvswitch-switch\n    fi","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c0f458255787116291f22ad4a91f9534acd4536b","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"function stop_ovs"},{"line_number":203,"context_line":"{"},{"line_number":204,"context_line":"    start_service openvswitch stop"},{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# The following returns \"0\" when service is live."}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_e0f796f3","line":204,"range":{"start_line":204,"start_character":18,"end_line":204,"end_character":29},"in_reply_to":"1af94dfe_f5688589","updated":"2016-03-20 07:58:42.000000000","message":"Done","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"befad71c94a59b4abbc240c6fb0506e7f2354fc8","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        load_module_if_not_loaded vport_geneve || true"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        _neutron_ovs_base_setup_bridge br-int"},{"line_number":262,"context_line":"        sudo ovs-vsctl --no-wait set bridge br-int fail-mode\u003dsecure other-config:disable-in-band\u003dtrue"},{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    cd $_pwd"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1af94dfe_75b8f5e5","line":262,"range":{"start_line":262,"start_character":81,"end_line":262,"end_character":96},"updated":"2016-03-17 09:05:15.000000000","message":"I think this will disable the OVSDB assess unless we call set manger","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c0f458255787116291f22ad4a91f9534acd4536b","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        load_module_if_not_loaded vport_geneve || true"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        _neutron_ovs_base_setup_bridge br-int"},{"line_number":262,"context_line":"        sudo ovs-vsctl --no-wait set bridge br-int fail-mode\u003dsecure other-config:disable-in-band\u003dtrue"},{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    cd $_pwd"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_a0d47e47","line":262,"range":{"start_line":262,"start_character":81,"end_line":262,"end_character":96},"in_reply_to":"1af94dfe_75b8f5e5","updated":"2016-03-20 07:58:42.000000000","message":"From what I understand from the docs, this only disables in-band configuration. It was like this when I got here, so I figured I wouldn\u0027t change it.","commit_id":"6e41b09c31c6600bd6fed84458e237bde55675fc"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"9196dc02673acb21c515cb6d0a58075efe219720","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        SERVICE_NAME\u003dopenvswitch-switch"},{"line_number":209,"context_line":"    fi"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    start_service $SERVICE_NAME stop"},{"line_number":212,"context_line":"}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# The following returns \"0\" when service is live."}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_e30de038","line":211,"range":{"start_line":211,"start_character":4,"end_line":211,"end_character":17},"updated":"2016-03-20 11:19:43.000000000","message":"i think it should be stop_service","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"edc99f0debb2dc78a07da2b27efbe274cc86ea18","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        SERVICE_NAME\u003dopenvswitch-switch"},{"line_number":209,"context_line":"    fi"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    start_service $SERVICE_NAME stop"},{"line_number":212,"context_line":"}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# The following returns \"0\" when service is live."}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_f4b8f8e7","line":211,"range":{"start_line":211,"start_character":4,"end_line":211,"end_character":17},"in_reply_to":"fa0719c6_e30de038","updated":"2016-03-20 18:34:00.000000000","message":"Will fix.","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"9196dc02673acb21c515cb6d0a58075efe219720","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        SERVICE_NAME\u003dopenvswitch-switch"},{"line_number":248,"context_line":"    fi"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    start_service $SERVICE_NAME start"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":253,"context_line":"    cd $DATA_DIR/ovs"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_831d0469","line":250,"range":{"start_line":250,"start_character":32,"end_line":250,"end_character":37},"updated":"2016-03-20 11:19:43.000000000","message":"i do not think  you need the extra param","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"edc99f0debb2dc78a07da2b27efbe274cc86ea18","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        SERVICE_NAME\u003dopenvswitch-switch"},{"line_number":248,"context_line":"    fi"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    start_service $SERVICE_NAME start"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":253,"context_line":"    cd $DATA_DIR/ovs"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_34cb9074","line":250,"range":{"start_line":250,"start_character":32,"end_line":250,"end_character":37},"in_reply_to":"fa0719c6_831d0469","updated":"2016-03-20 18:34:00.000000000","message":"Will fix.","commit_id":"82f1f190ab90a2d7ec0700b9c5e075c57451a6f0"}]}