)]}'
{"devstack/settings":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"62b0e5e4d60f611734b1c4b7cc8984cc0e1b493b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"DF_IS_MONITOR_TABLES\u003d${DF_IS_MONITOR_TABLES:-\"$DF_PUB_SUB\"}"},{"line_number":22,"context_line":"MONITOR_TABLES\u003d${MONITOR_TABLES:-\"chassis\"}"},{"line_number":23,"context_line":"DF_MONITOR_TABLE_POLL_TIME\u003d${DF_MONITOR_TABLE_POLL_TIME:-30}"},{"line_number":24,"context_line":"DF_PUB_SUB_NO_MULTIPROC\u003d${DF_PUB_SUB_NO_MULTIPROC:-\"False\"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aed3d3a_714904b7","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":23},"updated":"2016-02-29 15:28:40.000000000","message":"Please use enable_inproc_pubsub and not double negative","commit_id":"1cb22125a1a5d83d00c6c546e2bbaf8ebb4e3a29"}],"dragonflow/controller/df_publisher_service.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0819334237afcb4438c828c912361e4f206ce1d3","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_multiproc_subscriber(self):"},{"line_number":47,"context_line":"        if not cfg.CONF.df.pub_sub_use_multiproc:"},{"line_number":48,"context_line":"            # not needed"},{"line_number":49,"context_line":"            return None"},{"line_number":50,"context_line":"        pub_sub_driver \u003d df_utils.load_driver("},{"line_number":51,"context_line":"                                    cfg.CONF.df.pub_sub_multiproc_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_df1f0e59","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":24},"updated":"2016-03-01 06:57:46.000000000","message":"what does it mean?","commit_id":"b77f2c4fad90ae1712d02fbf9f7b2c5683a776a3"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"e2c710c150364047117da538b9180cfac8750cbf","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_multiproc_subscriber(self):"},{"line_number":47,"context_line":"        if not cfg.CONF.df.pub_sub_use_multiproc:"},{"line_number":48,"context_line":"            # not needed"},{"line_number":49,"context_line":"            return None"},{"line_number":50,"context_line":"        pub_sub_driver \u003d df_utils.load_driver("},{"line_number":51,"context_line":"                                    cfg.CONF.df.pub_sub_multiproc_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_1e92ed57","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":24},"in_reply_to":"9aed3d3a_53cc92ba","updated":"2016-03-01 10:43:26.000000000","message":"@Omer I agree with @Li Ma, we should add comment only if needed in this case I do not see the added value for this comment\n\nPlease consider adding doc string for the method and explain the return values","commit_id":"b77f2c4fad90ae1712d02fbf9f7b2c5683a776a3"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"6995eaae73f889f1d720b51ab6f8f1bf23953afe","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_multiproc_subscriber(self):"},{"line_number":47,"context_line":"        if not cfg.CONF.df.pub_sub_use_multiproc:"},{"line_number":48,"context_line":"            # not needed"},{"line_number":49,"context_line":"            return None"},{"line_number":50,"context_line":"        pub_sub_driver \u003d df_utils.load_driver("},{"line_number":51,"context_line":"                                    cfg.CONF.df.pub_sub_multiproc_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_53cc92ba","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":24},"in_reply_to":"9aed3d3a_556c7f9b","updated":"2016-03-01 10:11:21.000000000","message":"OK. This comment seems not friendly.","commit_id":"b77f2c4fad90ae1712d02fbf9f7b2c5683a776a3"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ada54e8c3fd2c8532bd18ff493c67f7e1b3cb63b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _get_multiproc_subscriber(self):"},{"line_number":47,"context_line":"        if not cfg.CONF.df.pub_sub_use_multiproc:"},{"line_number":48,"context_line":"            # not needed"},{"line_number":49,"context_line":"            return None"},{"line_number":50,"context_line":"        pub_sub_driver \u003d df_utils.load_driver("},{"line_number":51,"context_line":"                                    cfg.CONF.df.pub_sub_multiproc_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_556c7f9b","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":24},"in_reply_to":"9aed3d3a_df1f0e59","updated":"2016-03-01 07:54:49.000000000","message":"We don\u0027t need a multiproc subscriber, if multiproc pub/sub is not enabled. The comment is there to show it\u0027s not an error that we return None here.","commit_id":"b77f2c4fad90ae1712d02fbf9f7b2c5683a776a3"}]}