)]}'
{"doc/source/specs/vlan_networking.rst":[{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_1100faa9","line":17,"range":{"start_line":17,"start_character":36,"end_line":17,"end_character":43},"updated":"2016-03-06 06:50:04.000000000","message":"Vlan network also is overlay network.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_712b3e34","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":16},"updated":"2016-03-06 06:50:04.000000000","message":"illegal charecter","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed Change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_4da91cdf","line":21,"updated":"2016-03-08 12:43:59.000000000","message":"Please provide explanation on what VLAN L2 networking means in this context: Use VLAN to tunnel between compute nodes? Use VLAN to bridge virtual network with physical network? Add support for VLAN tags in virtual network?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Proposed Change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":26,"context_line":"In future, ML2 Plugin will replace Dragonflow Plugin to support vlan network."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":29,"context_line":"as overlay scenario does, and install flows to openvsiwtch."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":32,"context_line":"coordinate with existing flow items, so that all work fine together."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"What does dragonflow need to do for vlan  L2 networking"},{"line_number":35,"context_line":"is similar to overlay networking."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_edbf48f9","line":32,"range":{"start_line":25,"start_character":0,"end_line":32,"end_character":68},"updated":"2016-03-08 12:43:59.000000000","message":"This looks more like requirements, than the proposed solution.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":29,"context_line":"as overlay scenario does, and install flows to openvsiwtch."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":32,"context_line":"coordinate with existing flow items, so that all work fine together."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"What does dragonflow need to do for vlan  L2 networking"},{"line_number":35,"context_line":"is similar to overlay networking."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_f11f4e07","line":32,"updated":"2016-03-06 06:50:04.000000000","message":"they","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":32,"context_line":"coordinate with existing flow items, so that all work fine together."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"What does dragonflow need to do for vlan  L2 networking"},{"line_number":35,"context_line":"is similar to overlay networking."},{"line_number":36,"context_line":"The difference between them is what flow items should be installed."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_311a5618","line":34,"range":{"start_line":34,"start_character":45,"end_line":34,"end_character":55},"updated":"2016-03-06 06:50:04.000000000","message":"networks","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"What does dragonflow need to do for vlan  L2 networking"},{"line_number":35,"context_line":"is similar to overlay networking."},{"line_number":36,"context_line":"The difference between them is what flow items should be installed."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":39,"context_line":"it will handle them just as what vxlan does, and install flows."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_11175aee","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":46},"updated":"2016-03-06 06:50:04.000000000","message":"entries","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"What does dragonflow need to do for vlan  L2 networking"},{"line_number":35,"context_line":"is similar to overlay networking."},{"line_number":36,"context_line":"The difference between them is what flow items should be installed."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":39,"context_line":"it will handle them just as what vxlan does, and install flows."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_6db178e1","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":46},"in_reply_to":"7af24918_11175aee","updated":"2016-03-08 12:43:59.000000000","message":"Consider expanding this paragraph.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The difference between them is what flow items should be installed."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":39,"context_line":"it will handle them just as what vxlan does, and install flows."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":42,"context_line":"it will query port and network inforamton from memory db."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_b1dca647","line":39,"range":{"start_line":39,"start_character":28,"end_line":39,"end_character":32},"updated":"2016-03-06 06:50:04.000000000","message":"what it does for vxlan ports","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"The difference between them is what flow items should be installed."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":39,"context_line":"it will handle them just as what vxlan does, and install flows."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":42,"context_line":"it will query port and network inforamton from memory db."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_0d643447","line":39,"range":{"start_line":39,"start_character":28,"end_line":39,"end_character":32},"in_reply_to":"7af24918_b1dca647","updated":"2016-03-08 12:43:59.000000000","message":"Consider expanding. What does DF do for VXLAN? What flows are installed?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":39,"context_line":"it will handle them just as what vxlan does, and install flows."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":42,"context_line":"it will query port and network inforamton from memory db."},{"line_number":43,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":44,"context_line":"local controller will subscribe northbound events."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"When controller receive port deleted messages,"},{"line_number":47,"context_line":"it will delete correspongding flow items."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_8dd7a4be","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":50},"updated":"2016-03-08 12:43:59.000000000","message":"This is part of the pub/sub and db events mechanism. It is not related to VLAN.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"local controller will subscribe northbound events."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"When controller receive port deleted messages,"},{"line_number":47,"context_line":"it will delete correspongding flow items."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Packets from vms or outside such as tunnel and physical nics"},{"line_number":50,"context_line":"will be handled differently."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_2dc81022","line":47,"range":{"start_line":47,"start_character":15,"end_line":47,"end_character":29},"updated":"2016-03-08 12:43:59.000000000","message":"type: corresponding","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"Here we call from vms is outbound direction, from outside is inbound direction."},{"line_number":52,"context_line":"Two directions will be discussed separately."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"If destination ports reside in the same hosts with local controller,"},{"line_number":55,"context_line":"these are called local ports. Otherwise, those are called remote ports."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Currently there¡¯re several bridge topologies with different vendors."},{"line_number":58,"context_line":"Here we just talk about two mainly topologies."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_31c89674","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":71},"updated":"2016-03-06 06:50:04.000000000","message":"not clear. As far as I know, local ports are logical ports that there are corresponding ovs ports in the current host.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":55,"context_line":"these are called local ports. Otherwise, those are called remote ports."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Currently there¡¯re several bridge topologies with different vendors."},{"line_number":58,"context_line":"Here we just talk about two mainly topologies."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"One bridge per host"},{"line_number":61,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_b1aae683","line":58,"range":{"start_line":58,"start_character":28,"end_line":58,"end_character":34},"updated":"2016-03-06 06:50:04.000000000","message":"mainly mused","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":103,"context_line":"      |"},{"line_number":104,"context_line":"      |Remote/Broadcast"},{"line_number":105,"context_line":"      v"},{"line_number":106,"context_line":"This spec, we will discuss Vlan L2 networking with the second one."},{"line_number":107,"context_line":"With first one, it\u0027s similar to the second."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_7187be12","line":106,"updated":"2016-03-06 06:50:04.000000000","message":"In","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":126,"context_line":"When controller receives local port updated message,"},{"line_number":127,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":128,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":129,"context_line":"With unkown outside servers, thus will be tread as common broadcast."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Openflow items ike this:"},{"line_number":132,"context_line":"Table\u003dARP, Match: Arp Request, Actions: Arp Responders."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_11c11a2f","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":4},"updated":"2016-03-06 06:50:04.000000000","message":"what\u0027s the difference when processing a vlan port updated event, in comparing with vxlan port?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"When controller receives local port updated message,"},{"line_number":127,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":128,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":129,"context_line":"With unkown outside servers, thus will be tread as common broadcast."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Openflow items ike this:"},{"line_number":132,"context_line":"Table\u003dARP, Match: Arp Request, Actions: Arp Responders."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_2d32d010","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":4},"in_reply_to":"7af24918_11c11a2f","updated":"2016-03-08 12:43:59.000000000","message":"How is this different than current l2 app and ARP responder? Is this a case where the subnet spans both physical and virtual networks?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":129,"context_line":"With unkown outside servers, thus will be tread as common broadcast."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Openflow items ike this:"},{"line_number":132,"context_line":"Table\u003dARP, Match: Arp Request, Actions: Arp Responders."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"remote port"},{"line_number":135,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_51ba82c1","line":132,"range":{"start_line":132,"start_character":29,"end_line":132,"end_character":30},"updated":"2016-03-06 06:50:04.000000000","message":"Should condition \"arp_tpa \u003d Port_IP\" be included in the match section?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Openflow items ike this:"},{"line_number":132,"context_line":"Table\u003dARP, Match: Arp Request, Actions: Arp Responders."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"remote port"},{"line_number":135,"context_line":"--------------"},{"line_number":136,"context_line":"When controller receives remote port updated message,"},{"line_number":137,"context_line":"it will install flows as what local scenario does."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_cd2b6c93","line":134,"updated":"2016-03-08 12:43:59.000000000","message":"If both cases behave the same, why separate them?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Outbound-DHCP"},{"line_number":143,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":144,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":145,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_883dd2bd","line":145,"updated":"2016-03-08 12:43:59.000000000","message":"Is this the same behaviour the DF DHCP app gives? Or is there any addition?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote port and unkown outside servers belong to the same vlan."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":156,"context_line":"and forward packets to br-1(external)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_51e1e2cf","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":11},"updated":"2016-03-06 06:50:04.000000000","message":"ports and unknown","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote port and unkown outside servers belong to the same vlan."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":156,"context_line":"and forward packets to br-1(external)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_68104602","line":153,"range":{"start_line":153,"start_character":7,"end_line":153,"end_character":11},"in_reply_to":"7af24918_51e1e2cf","updated":"2016-03-08 12:43:59.000000000","message":"Consider stressing that exactly one broadcast packet will be sent to the physical VLAN network.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":156,"context_line":"and forward packets to br-1(external)."},{"line_number":157,"context_line":"Then br-1 will send packets to the physical nic"},{"line_number":158,"context_line":"according to the flows on br-1 \"table\u003d0, priority\u003d0, Actions\u003dNormal\"."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Outside forwarding behaviors depends on physical networks,"},{"line_number":161,"context_line":"which will not discussed here."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_48f74af5","line":158,"updated":"2016-03-08 12:43:59.000000000","message":"In this proposed solution, there is one interface per NIC, and the OVS is responsible for adding the VLAN tag? This is different from the alternative, where there is a network interface per VLAN, and that interface adds the tag.\n\n(The proposed solution is better, with one interface per NIC, but I thought it was worth mentioning.)","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":158,"context_line":"according to the flows on br-1 \"table\u003d0, priority\u003d0, Actions\u003dNormal\"."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Outside forwarding behaviors depends on physical networks,"},{"line_number":161,"context_line":"which will not discussed here."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"local port"},{"line_number":164,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_f1d0eef9","line":161,"updated":"2016-03-06 06:50:04.000000000","message":"be","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":173,"context_line":"  Match: metadata\u003dnetwork_id,"},{"line_number":174,"context_line":"  Actions:mod_vlan\u003d10,output:path_br_1"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"If this port is not the first one, controller only update the first flow above."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"remote port"},{"line_number":179,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_31db761d","line":176,"range":{"start_line":176,"start_character":51,"end_line":176,"end_character":57},"updated":"2016-03-06 06:50:04.000000000","message":"how to update? reinstall the flow entries?","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":179,"context_line":"-----------"},{"line_number":180,"context_line":"When controller receives remote port updated message,"},{"line_number":181,"context_line":"it will not update flows. Because with broadcast,"},{"line_number":182,"context_line":"ovs needs to forward it to patch. Thus has been done when local port updated."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Outbound-Unicast"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_a896ce49","line":182,"updated":"2016-03-08 12:43:59.000000000","message":"Could you please explain this paragraph? I don\u0027t understand it.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"300f52f6b88ee3b2304bf4a4d881a5ffcd9d3fc1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":197,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":198,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":199,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003d10,output:path_br_1"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_164e3b96","line":199,"range":{"start_line":199,"start_character":57,"end_line":199,"end_character":59},"updated":"2016-03-05 07:46:04.000000000","message":"should be the network_id","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":196,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":197,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":198,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":199,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003d10,output:path_br_1"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_91024a6e","line":199,"range":{"start_line":199,"start_character":37,"end_line":199,"end_character":42},"updated":"2016-03-06 06:50:04.000000000","message":"the packet also need to be forwarded to ports in the same host.","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":203,"context_line":"Remote"},{"line_number":204,"context_line":"----------"},{"line_number":205,"context_line":"When controller receives remote ports updated messages,"},{"line_number":206,"context_line":"it will not install flow for unicast."},{"line_number":207,"context_line":"Because this has been done when first port updated."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_f1f74e8a","line":206,"range":{"start_line":206,"start_character":20,"end_line":206,"end_character":24},"updated":"2016-03-06 06:50:04.000000000","message":"any flow entries","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"485fd715ad07104b12b23f0ed1491ef3cc3049da","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Inbound-DHCP"},{"line_number":219,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":220,"context_line":"DHCP Request will be handled by controller that acts as dhcp server,"},{"line_number":221,"context_line":"so if inbound dhcp happends, nothing needs to do."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Inbound-Unicast"},{"line_number":224,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_712a1ee9","line":221,"updated":"2016-03-06 06:50:04.000000000","message":"be done","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e60796986b8e3997f05fd100ae6688feb0cef2f1","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Ported delete"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":240,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":241,"context_line":"flow items as above."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_e8f3b69c","line":240,"range":{"start_line":240,"start_character":62,"end_line":240,"end_character":76},"updated":"2016-03-08 12:43:59.000000000","message":"Typo: corresponding","commit_id":"49796579d8b2a567c2abd14c7ad4d8cda5907d37"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_e08796d5","line":18,"range":{"start_line":18,"start_character":50,"end_line":18,"end_character":56},"updated":"2016-03-21 19:22:27.000000000","message":"chosen","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_f97457fe","line":18,"range":{"start_line":18,"start_character":27,"end_line":18,"end_character":56},"updated":"2016-03-21 19:22:27.000000000","message":"the network type is always set to overlay network (VxLan, GRE...)","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."},{"line_number":22,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_b9d81ff1","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":31},"updated":"2016-03-21 19:22:27.000000000","message":"there is a demand","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."},{"line_number":22,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_59ee238c","line":19,"range":{"start_line":19,"start_character":50,"end_line":19,"end_character":54},"updated":"2016-03-21 19:22:27.000000000","message":"types","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."},{"line_number":22,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_b9749fcf","line":20,"range":{"start_line":20,"start_character":62,"end_line":20,"end_character":81},"updated":"2016-03-21 19:22:27.000000000","message":"added to","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."},{"line_number":22,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_d90cf344","line":21,"range":{"start_line":21,"start_character":32,"end_line":21,"end_character":38},"updated":"2016-03-21 19:22:27.000000000","message":"the host","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"When admin creates network,no network type can be chosed."},{"line_number":19,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":20,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":21,"context_line":"and fowarded to outside through host\u0027s physical nic."},{"line_number":22,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_3936cf03","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":23},"updated":"2016-03-21 19:22:27.000000000","message":"to the physical network","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Outbound-Common Broadcast/Multicast"},{"line_number":149,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote ports and unknown outside servers belong to the same vlan."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_c02a52e7","line":150,"range":{"start_line":150,"start_character":10,"end_line":150,"end_character":17},"updated":"2016-03-21 19:22:27.000000000","message":"except to","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Outbound-Common Broadcast/Multicast"},{"line_number":149,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote ports and unknown outside servers belong to the same vlan."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_403f6225","line":150,"range":{"start_line":150,"start_character":17,"end_line":150,"end_character":19},"updated":"2016-03-21 19:22:27.000000000","message":"extra space","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Outbound-Common Broadcast/Multicast"},{"line_number":149,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote ports and unknown outside servers belong to the same vlan."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_e0395643","line":150,"range":{"start_line":150,"start_character":33,"end_line":150,"end_character":38},"updated":"2016-03-21 19:22:27.000000000","message":"is","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Broadcast excepts  arp and dhcp, it¡¯s similar to multicast processing."},{"line_number":151,"context_line":"We just take broadcast for example."},{"line_number":152,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":153,"context_line":"remote ports and unknown outside servers belong to the same vlan."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":156,"context_line":"and forward packets to br-1(external)."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_c011b2b1","line":153,"range":{"start_line":153,"start_character":0,"end_line":153,"end_character":65},"updated":"2016-03-21 19:22:27.000000000","message":"i think that this line is unclear consider changing\n\nand all remote and unknown ports  memebre of the same VLAN","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"it will install flows for unicast forwarding."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"If it is the first port of the network locally,"},{"line_number":200,"context_line":"controller will install flow for remote and unkown servers."},{"line_number":201,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":202,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":203,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_d8fe9b6a","line":200,"range":{"start_line":200,"start_character":44,"end_line":200,"end_character":58},"updated":"2016-03-21 19:22:27.000000000","message":"unknown ports","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"fa896cb932da42ce9221b3bd21a5fabd7a6e3dd8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"Ported delete"},{"line_number":262,"context_line":"********************************************************************"},{"line_number":263,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":264,"context_line":"flow items as above."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa0719c6_9804237f","line":264,"range":{"start_line":264,"start_character":14,"end_line":264,"end_character":19},"updated":"2016-03-21 19:22:27.000000000","message":"On the last local port deleted of a network delete network flow for remote and unknown ports","commit_id":"a423c1c764aa7e4844264cd417d1679a10ea39e0"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61adb043c12bc96eb2ac724acf0f75188a699fa3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there¡¯re some demands for other network type, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_087668d6","line":20,"range":{"start_line":20,"start_character":50,"end_line":20,"end_character":54},"updated":"2016-03-24 11:15:11.000000000","message":"typo: types","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61adb043c12bc96eb2ac724acf0f75188a699fa3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The difference between them is what flow items should be installed."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":42,"context_line":"it will handle them just as what it does for does, and install flows."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network inforamton from memory db."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_e3407509","line":42,"range":{"start_line":42,"start_character":45,"end_line":42,"end_character":49},"updated":"2016-03-24 11:15:11.000000000","message":"I don\u0027t understand. Is it a typo?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"5865e5a1937ed05f123859455946026849e2cf65","unresolved":false,"context_lines":[{"line_number":42,"context_line":"it will handle them just as what it does for does, and install flows."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network inforamton from memory db."},{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_d9492fb9","line":45,"range":{"start_line":45,"start_character":31,"end_line":45,"end_character":42},"updated":"2016-03-24 02:54:48.000000000","message":"information","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"5865e5a1937ed05f123859455946026849e2cf65","unresolved":false,"context_lines":[{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"},{"line_number":50,"context_line":"it will delete corresponding flow items."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Packets from vms or outside such as tunnel and physical nics"},{"line_number":53,"context_line":"will be handled differently."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_b9043b4a","line":50,"range":{"start_line":50,"start_character":29,"end_line":50,"end_character":40},"updated":"2016-03-24 02:54:48.000000000","message":"whether is it better using ovs flow rules?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"5865e5a1937ed05f123859455946026849e2cf65","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Packets from vms or outside such as tunnel and physical nics"},{"line_number":53,"context_line":"will be handled differently."},{"line_number":54,"context_line":"Here we call from vms is outbound direction, from outside is inbound direction."},{"line_number":55,"context_line":"Two directions will be discussed separately."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Currently there\u0027re several bridge topologies with different vendors."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_b825195d","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":79},"updated":"2016-03-24 02:54:48.000000000","message":"Here we suppose that from VM to ovs bridge is outbound direction, and from outside network to ovs bridge is inbound direction?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61adb043c12bc96eb2ac724acf0f75188a699fa3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"      |"},{"line_number":77,"context_line":"      |Remote/Broadcast"},{"line_number":78,"context_line":"      |"},{"line_number":79,"context_line":"      v"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Two bridges per host"},{"line_number":82,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_03948940","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":7},"updated":"2016-03-24 11:15:11.000000000","message":"what is this link? should it be placed under \u0027nic\u0027?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61adb043c12bc96eb2ac724acf0f75188a699fa3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"VMs are connected to br-int,"},{"line_number":84,"context_line":"overlay tunnels connected to br-int, physical nic connected to br-1,"},{"line_number":85,"context_line":"Vlan Packets are transmited to/from br-1."},{"line_number":86,"context_line":"With this topology, we will add a flow table called \u0027ingress\u0027 to"},{"line_number":87,"context_line":"handle inbound packets."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"+---------------------------------+"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_06dbf41b","line":86,"range":{"start_line":86,"start_character":39,"end_line":86,"end_character":44},"updated":"2016-03-24 11:15:11.000000000","message":"To which bridge? br-int or br--1","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"61adb043c12bc96eb2ac724acf0f75188a699fa3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"With unkown outside servers, thus will be tread as common broadcast."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":131,"context_line":"Openflow items ike this:"},{"line_number":132,"context_line":"Table\u003dARP, Match: Arp Request, Actions: Arp Responders."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"remote port"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_467ccceb","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":18},"updated":"2016-03-24 11:15:11.000000000","message":"typo","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"5865e5a1937ed05f123859455946026849e2cf65","unresolved":false,"context_lines":[{"line_number":168,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":169,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":170,"context_line":"  Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":171,"context_line":"  Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":174,"context_line":"  Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_58183dd3","line":171,"range":{"start_line":171,"start_character":12,"end_line":171,"end_character":34},"updated":"2016-03-24 02:54:48.000000000","message":"There are two times same actions, is it redundant action?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"5865e5a1937ed05f123859455946026849e2cf65","unresolved":false,"context_lines":[{"line_number":252,"context_line":"it will install or update flow like this."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"1. Table\u003dDestination_Port_Classification,"},{"line_number":255,"context_line":"   Match:metadata\u003dnetwork_id, dl_dst\u003dport_mac,"},{"line_number":256,"context_line":"   Actions\u003d load_reg7\u003dport_key_1, goto \"Destination_Port_Dispatch\","},{"line_number":257,"context_line":"            load_reg7\u003dport_key_2, goto \"Destination_Port_Dispatch\""},{"line_number":258,"context_line":"2. Table\u003dDestination_Port_Dispatch,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_d80a8d25","line":255,"range":{"start_line":255,"start_character":37,"end_line":255,"end_character":45},"updated":"2016-03-24 02:54:48.000000000","message":"broadcast mac address, right?","commit_id":"df601c587b0c0c390424db6ffba4696239d05994"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":".."},{"line_number":3,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":4,"context_line":" License."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_5f9e1155","line":1,"updated":"2016-05-02 08:29:03.000000000","message":"Please verify that there are no restview syntax errors.\nYou can use e.g. https://mg.pov.lt/restview/ or rst.ninjs.org.","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed Change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":29,"context_line":"In future, ML2 Plugin will replace Dragonflow Plugin to support vlan network."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":32,"context_line":"as overlay scenario does, and install flows to openvsiwtch."}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_bfabe574","line":29,"range":{"start_line":29,"start_character":15,"end_line":29,"end_character":21},"updated":"2016-05-02 08:29:03.000000000","message":"Plugin -\u003e Mechanism Driver.","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Outbound"},{"line_number":91,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":92,"context_line":"Packets are divided into four types:"},{"line_number":93,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":94,"context_line":"For each type, drangonflow controller will handle differently."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Outbond-Arp"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_ffda7d1c","line":93,"updated":"2016-05-02 08:29:03.000000000","message":"That\u0027s only three types. Is the fourth type \u0027other\u0027?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":119,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":120,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":121,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":122,"context_line":"It\u0027s same as vxlan network."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_3f335564","line":122,"updated":"2016-05-02 08:29:03.000000000","message":"What happens in the case \u0027dhcp enable\u0027 option is off? Are DHCP packets treated like broadcast? Or are they dropped?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":144,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":145,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":146,"context_line":"  Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":147,"context_line":"  Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":150,"context_line":"  Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_5fabb11e","line":147,"updated":"2016-05-02 08:29:03.000000000","message":"One of the actions has to load the local port\u0027s id to reg7 and resubmit. What\u0027s the value of reg7 for packets that will be sent to br-1?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":150,"context_line":"  Match: metadata\u003dnetwork_id,"},{"line_number":151,"context_line":"  Actions:mod_vlan\u003d10,output:path_br_1"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"If this port is not the first one, controller only update the first flow above."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_3f6b55f3","line":151,"updated":"2016-05-02 08:29:03.000000000","message":"The vlan ID is provided by the controller during flow installation, correct?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf261c864a03e7da77b732868ddf4cff27438e75","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Inbound-Arp"},{"line_number":203,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":204,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":205,"context_line":"which will be discussed as follows ."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Inbound-DHCP"},{"line_number":208,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1a122d0e_ba181320","line":205,"updated":"2016-05-02 08:29:03.000000000","message":"Why not use the arp responder, if it is installed?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"3f4cde55d570faf1749fa8ba464585293fcb2f0c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"   Match: reg7\u003dport_key, Actions: output:ofport"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Ported delete"},{"line_number":239,"context_line":"********************************************************************"},{"line_number":240,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":241,"context_line":"flow items as above."}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a061dce_388f6ecd","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":13},"updated":"2016-04-06 15:48:03.000000000","message":"May be \"Port delete\" here ?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"3f4cde55d570faf1749fa8ba464585293fcb2f0c","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Ported delete"},{"line_number":239,"context_line":"********************************************************************"},{"line_number":240,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":241,"context_line":"flow items as above."},{"line_number":242,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":243,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9a061dce_78c3a6ed","line":240,"range":{"start_line":240,"start_character":24,"end_line":240,"end_character":36},"updated":"2016-04-06 15:48:03.000000000","message":"\"port delete\" ?","commit_id":"52265b80c2a94e0e88b78e871dbde05527a648b8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"10631d36655916111b57253364b6b6e408996b0f","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Outbound"},{"line_number":91,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":92,"context_line":"Packets are divided into four types:"},{"line_number":93,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":94,"context_line":"For thress types, drangonflow controller will handle differently."},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_c1edb3b8","line":92,"range":{"start_line":92,"start_character":25,"end_line":92,"end_character":29},"updated":"2016-05-15 16:47:07.000000000","message":"four -\u003e three?","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"10631d36655916111b57253364b6b6e408996b0f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":120,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":121,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":122,"context_line":"It\u0027s same as vxlan network."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_a1f86f7d","line":122,"updated":"2016-05-15 16:47:07.000000000","message":"What happens in the case \u0027dhcp enable\u0027 option is off? Are DHCP packets treated like broadcast? Or are they dropped?","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"a4bf39cc0a98c9a963d423bccac24ee566a8e388","unresolved":false,"context_lines":[{"line_number":119,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":120,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":121,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":122,"context_line":"It\u0027s same as vxlan network."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_0a750ff9","line":122,"in_reply_to":"dab17558_a1f86f7d","updated":"2016-05-16 02:08:27.000000000","message":"Currently, DHCP Broadcast packet are treated like broadcast when \u0027dhcp enable\u0027 options is off.\nIf neccessary, we can add a switch to treat dhcp like broadcast or drop it.","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"10631d36655916111b57253364b6b6e408996b0f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":145,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":146,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":147,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":150,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_61fe876c","line":147,"updated":"2016-05-15 16:47:07.000000000","message":"One of the actions has to load the local port\u0027s id to reg7 and resubmit. What\u0027s the value of reg7 for packets that will be sent to br-1? Or will that packet be recognised for all packets on that network_id? Then how to distinguish unicast packets?","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"a4bf39cc0a98c9a963d423bccac24ee566a8e388","unresolved":false,"context_lines":[{"line_number":144,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":145,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":146,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":147,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":150,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_153254f2","line":147,"in_reply_to":"dab17558_61fe876c","updated":"2016-05-16 02:08:27.000000000","message":"No value of reg7 will be sent to br-1, reg7 is just for local forwarding.\nVlan tag will be sent to br-1.\nIn br-1, do not need to distinguish unicast and broadcas, it just need to forward it with \"Normal\" action.","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"10631d36655916111b57253364b6b6e408996b0f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Inbound-Arp"},{"line_number":203,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":204,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":205,"context_line":"which will be discussed as follows ."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Inbound-DHCP"},{"line_number":208,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_81cc4b62","line":205,"updated":"2016-05-15 16:47:07.000000000","message":"If available, why not use the ARP responder?","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"a4bf39cc0a98c9a963d423bccac24ee566a8e388","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Inbound-Arp"},{"line_number":203,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":204,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":205,"context_line":"which will be discussed as follows ."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Inbound-DHCP"},{"line_number":208,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":21,"id":"dab17558_9506441a","line":205,"in_reply_to":"dab17558_81cc4b62","updated":"2016-05-16 02:08:27.000000000","message":"Arp request is always treated in outbound direction.\nOnly arp request from physical server will be handled in inbound direction.\nIf we use arp responder, we need to adjust openflow pipeline for arp.\nIf necessary, we can discuss it in detail.","commit_id":"1f7684fddc6780580069033bfad3193b26ca49bf"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"00b0ee4850b48420fc4b63a2f4a118086e4f5379","unresolved":false,"context_lines":[{"line_number":112,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":113,"context_line":"and forward packets to br-1(external)."},{"line_number":114,"context_line":"Then br-1 will send packets to the physical nic"},{"line_number":115,"context_line":"according to the flows on br-1 \"table\u003d0, priority\u003d0, Actions\u003dNormal\"."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Outside forwarding behaviors depends on physical networks,"},{"line_number":118,"context_line":"which will be not discussed here."}],"source_content_type":"text/x-rst","patch_set":26,"id":"bab6814e_b3677be9","line":115,"range":{"start_line":115,"start_character":32,"end_line":115,"end_character":69},"updated":"2016-05-24 12:53:47.000000000","message":"I am not sure I understand what other flows do you install on  br-1 ?\nIs this flow for inbound and outbound ?","commit_id":"c1490071d8393e0714dc090369e83db3ae591958"},{"author":{"_account_id":20960,"name":"wangyongben","email":"wangyongben@huawei.com","username":"wangyonben"},"change_message_id":"4903052cad903c899ed07a43ec6449884862d1ae","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there\u0027re some demands for other network typs, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bab6814e_8196f6ed","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":53},"updated":"2016-05-26 08:25:59.000000000","message":"types","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":18,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there\u0027re some demands for other network typs, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_810e6832","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":53},"in_reply_to":"bab6814e_8196f6ed","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20960,"name":"wangyongben","email":"wangyongben@huawei.com","username":"wangyonben"},"change_message_id":"4903052cad903c899ed07a43ec6449884862d1ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support vlan network."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":32,"context_line":"as overlay scenario does, and install flows to openvsiwtch."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":35,"context_line":"coordinate with existing flow items, so that all work fine together."}],"source_content_type":"text/x-rst","patch_set":29,"id":"bab6814e_e17542cb","line":32,"range":{"start_line":32,"start_character":47,"end_line":32,"end_character":58},"updated":"2016-05-26 08:25:59.000000000","message":"openvswitch","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support vlan network."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":32,"context_line":"as overlay scenario does, and install flows to openvsiwtch."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":35,"context_line":"coordinate with existing flow items, so that all work fine together."}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_e113ec5a","line":32,"range":{"start_line":32,"start_character":47,"end_line":32,"end_character":58},"in_reply_to":"bab6814e_e17542cb","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20960,"name":"wangyongben","email":"wangyongben@huawei.com","username":"wangyonben"},"change_message_id":"4903052cad903c899ed07a43ec6449884862d1ae","unresolved":false,"context_lines":[{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For thress types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bab6814e_6c530918","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":10},"updated":"2016-05-26 08:25:59.000000000","message":"these","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20960,"name":"wangyongben","email":"wangyongben@huawei.com","username":"wangyonben"},"change_message_id":"4903052cad903c899ed07a43ec6449884862d1ae","unresolved":false,"context_lines":[{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":84,"context_line":"With unkown outside servers, thus will be tread as common broadcast."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":87,"context_line":"Openflow items like this:"}],"source_content_type":"text/x-rst","patch_set":29,"id":"bab6814e_cca2f5fb","line":84,"range":{"start_line":84,"start_character":42,"end_line":84,"end_character":47},"updated":"2016-05-26 08:25:59.000000000","message":"treated","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20960,"name":"wangyongben","email":"wangyongben@huawei.com","username":"wangyonben"},"change_message_id":"4903052cad903c899ed07a43ec6449884862d1ae","unresolved":false,"context_lines":[{"line_number":91,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":92,"context_line":"When controller receives remote port updated message,"},{"line_number":93,"context_line":"it will install flows as what local scenario does."},{"line_number":94,"context_line":"If detination is unknown, arp request will be handled as common broadcast,"},{"line_number":95,"context_line":"which will be discussed as follows."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"bab6814e_0c987dbf","line":94,"range":{"start_line":94,"start_character":3,"end_line":94,"end_character":13},"updated":"2016-05-26 08:25:59.000000000","message":"destination","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":92,"context_line":"When controller receives remote port updated message,"},{"line_number":93,"context_line":"it will install flows as what local scenario does."},{"line_number":94,"context_line":"If detination is unknown, arp request will be handled as common broadcast,"},{"line_number":95,"context_line":"which will be discussed as follows."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_011b9873","line":94,"range":{"start_line":94,"start_character":3,"end_line":94,"end_character":13},"in_reply_to":"bab6814e_0c987dbf","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f37aeccdfba9a0d3d47f580aef1f5917a805d9bb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":102,"context_line":"It\u0027s same as vxlan network."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_03872b62","line":101,"range":{"start_line":101,"start_character":34,"end_line":101,"end_character":45},"updated":"2016-06-06 02:40:11.000000000","message":"respond","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":102,"context_line":"It\u0027s same as vxlan network."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_211e9463","line":101,"range":{"start_line":101,"start_character":34,"end_line":101,"end_character":45},"in_reply_to":"7aa08908_03872b62","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2f7385de680bd7d443588fdf910e952d313db790","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":102,"context_line":"It\u0027s same as vxlan network."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":29,"id":"9abb7d3a_100107af","line":102,"updated":"2016-05-29 16:37:07.000000000","message":"Consider mentioning the case where \u0027dhcp enable\u0027 option is off should be mentioned here (The response in patch set 21 is good, I just think it should be in the spec.).","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to reponse for dhcp request."},{"line_number":102,"context_line":"It\u0027s same as vxlan network."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_6126dcbb","line":102,"in_reply_to":"9abb7d3a_100107af","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2f7385de680bd7d443588fdf910e952d313db790","unresolved":false,"context_lines":[{"line_number":124,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":125,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":126,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":127,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":130,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":29,"id":"9abb7d3a_d0f65fd6","line":127,"updated":"2016-05-29 16:37:07.000000000","message":"If I recall correctly (I don\u0027t currently have an environment up), the egress table uses reg7 to select the output port, even if it is a patch port to another bridge (we don\u0027t currently have output to normal anywhere in the system).\n\nIt is very dangerous to say that if there is no reg7, output it to all ports (or always output it to bridge), since we may  have multiple tenants which must remain invisible to each other. (e.g. special vlan tag per tenant)\n\nI may have also completely missed something.","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d2d1752e4389133ab82ff6c42d0579181ae80ad9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":125,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":126,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":127,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":130,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_c609a633","line":127,"in_reply_to":"9abb7d3a_d0f65fd6","updated":"2016-06-06 09:27:49.000000000","message":"1. With vlan network, the egress table use reg7 to select the local output port, not include remote ports.\n2. If there\u0027s no reg7, local ports will not included in output ports, we just push vlan and forware it to patch port (which connects to br-1).\nVlan tag can guarantee the security.","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":125,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":126,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":127,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":130,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_412be082","line":127,"in_reply_to":"9abb7d3a_d0f65fd6","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f37aeccdfba9a0d3d47f580aef1f5917a805d9bb","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Inbound"},{"line_number":173,"context_line":"^^^^^^^^^^^"},{"line_number":174,"context_line":"With inbound, a flow item will be installed to talbe 0, which will strip vlan and set metadata"},{"line_number":175,"context_line":"for next table. Flow item like this:"},{"line_number":176,"context_line":"Table\u003d0,"},{"line_number":177,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_c3e4033d","line":174,"range":{"start_line":174,"start_character":47,"end_line":174,"end_character":52},"updated":"2016-06-06 02:40:11.000000000","message":"table","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Inbound"},{"line_number":173,"context_line":"^^^^^^^^^^^"},{"line_number":174,"context_line":"With inbound, a flow item will be installed to talbe 0, which will strip vlan and set metadata"},{"line_number":175,"context_line":"for next table. Flow item like this:"},{"line_number":176,"context_line":"Table\u003d0,"},{"line_number":177,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_e13acccc","line":174,"range":{"start_line":174,"start_character":47,"end_line":174,"end_character":52},"in_reply_to":"7aa08908_c3e4033d","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2f7385de680bd7d443588fdf910e952d313db790","unresolved":false,"context_lines":[{"line_number":182,"context_line":"Inbound-Arp"},{"line_number":183,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":184,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":185,"context_line":"which will be discussed as follows ."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Inbound-DHCP"},{"line_number":188,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":29,"id":"9abb7d3a_306d2b99","line":185,"updated":"2016-05-29 16:37:07.000000000","message":"I would like to review the ARP responder option in detail. Inbound ARP needs to be treated. ARP responder already modifies the OVS flow and already has reusable code to install it where necessary. I\u0027d rather avoid broadcasting it when not necessary.\n\nWe can also use learning flows to extend the internal ARP responder to learn which MAC contains which IP.","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"d721a5c4851fdb5aeb5d49221c51b5019acf5fbc","unresolved":false,"context_lines":[{"line_number":182,"context_line":"Inbound-Arp"},{"line_number":183,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":184,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":185,"context_line":"which will be discussed as follows ."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Inbound-DHCP"},{"line_number":188,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":29,"id":"7aa08908_c137d0e1","line":185,"in_reply_to":"9abb7d3a_306d2b99","updated":"2016-06-06 09:28:29.000000000","message":"Done","commit_id":"d4f803813a60ee4cc26fc1b815403245603700c0"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":6,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"Vlan Networking"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":12,"context_line":"This blueprint describes how to implement vlan L2 networking in Dragonflow."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9e930d5b","line":9,"updated":"2016-06-12 14:47:33.000000000","message":"Please fix the format and remove extra \u0027\u003d\u0027s","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"Vlan Networking"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":12,"context_line":"This blueprint describes how to implement vlan L2 networking in Dragonflow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_1e7a7d88","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":14},"updated":"2016-06-12 13:05:31.000000000","message":"create a blueprint and place the link here","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":"Vlan Networking"},{"line_number":11,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":12,"context_line":"This blueprint describes how to implement vlan L2 networking in Dragonflow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem Description"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c551b510","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":14},"in_reply_to":"7aa08908_1e7a7d88","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":18,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_5e7085a4","line":21,"range":{"start_line":21,"start_character":86,"end_line":21,"end_character":92},"updated":"2016-06-12 13:05:31.000000000","message":"this line is too long. Each line should have no more than 79 characters.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_453e65b9","line":21,"range":{"start_line":21,"start_character":86,"end_line":21,"end_character":92},"in_reply_to":"7aa08908_5e7085a4","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":20,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan, flat, etc."},{"line_number":21,"context_line":"If vm belongs to vlan network, a vlan header(802.1.Q) will be encapsulated within the packet,"},{"line_number":22,"context_line":"and fowarded to the physical network through the host physical nic."},{"line_number":23,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_fe5fb10c","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":12},"updated":"2016-06-12 13:05:31.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Proposed Change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":29,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support vlan network."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_5e84050a","line":27,"updated":"2016-06-12 14:47:33.000000000","message":"Please fix the formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":42,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network information from memory db."},{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9ee5cd0a","line":46,"range":{"start_line":45,"start_character":48,"end_line":46,"end_character":47},"updated":"2016-06-12 13:05:31.000000000","message":"db store","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network information from memory db."},{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_beb08944","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":46},"updated":"2016-06-12 13:05:31.000000000","message":"in that host","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network information from memory db."},{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_e57311b3","line":46,"range":{"start_line":45,"start_character":48,"end_line":46,"end_character":47},"in_reply_to":"7aa08908_9ee5cd0a","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":44,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":45,"context_line":"it will query port and network information from memory db."},{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"},{"line_number":50,"context_line":"it will delete corresponding flow items."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9eadcdeb","line":47,"range":{"start_line":47,"start_character":47,"end_line":47,"end_character":49},"updated":"2016-06-12 13:05:31.000000000","message":"of that tenant","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":46,"context_line":"If  this is the first port belongs to a tenant,"},{"line_number":47,"context_line":"local controller will subscribe northbound events."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"When controller receive port deleted messages,"},{"line_number":50,"context_line":"it will delete corresponding flow items."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Packets from vms or outside such as tunnel and physical nics"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_feaa1170","line":49,"updated":"2016-06-12 14:47:33.000000000","message":"s/receive/receives","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Packets from vms or outside such as tunnel and physical nics"},{"line_number":53,"context_line":"will be handled differently."},{"line_number":54,"context_line":"Here we call from vms is outbound direction, from outside is inbound direction."},{"line_number":55,"context_line":"Two directions will be discussed separately."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In this spec, the bridge topology is based on the following \u0027Two bridges per host\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_feb6913c","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":3},"updated":"2016-06-12 13:05:31.000000000","message":"These two","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Here we call from vms is outbound direction, from outside is inbound direction."},{"line_number":55,"context_line":"Two directions will be discussed separately."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In this spec, the bridge topology is based on the following \u0027Two bridges per host\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Two bridges per host"},{"line_number":60,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9ec82d57","line":57,"updated":"2016-06-12 14:47:33.000000000","message":"\u0027Two bridges per host\u0027 approach","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"Here we call from vms is outbound direction, from outside is inbound direction."},{"line_number":55,"context_line":"Two directions will be discussed separately."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"In this spec, the bridge topology is based on the following \u0027Two bridges per host\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Two bridges per host"},{"line_number":60,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_0573bdb2","line":57,"in_reply_to":"7aa08908_9ec82d57","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":57,"context_line":"In this spec, the bridge topology is based on the following \u0027Two bridges per host\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Two bridges per host"},{"line_number":60,"context_line":"----------------------"},{"line_number":61,"context_line":"VMs are connected to br-int,"},{"line_number":62,"context_line":"overlay tunnels connected to br-int, physical nic connected to br-1,"},{"line_number":63,"context_line":"Vlan Packets are transmited to/from br-1."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_bed249fe","line":60,"updated":"2016-06-12 14:47:33.000000000","message":"extra \u0027-\u0027","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Vlan Packets are transmited to/from br-1."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Port updated"},{"line_number":66,"context_line":"--------------------------------------"},{"line_number":67,"context_line":"When controller receive port updated messages, it will install flows."},{"line_number":68,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9ecf8d55","line":66,"updated":"2016-06-12 14:47:33.000000000","message":"formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Port updated"},{"line_number":66,"context_line":"--------------------------------------"},{"line_number":67,"context_line":"When controller receive port updated messages, it will install flows."},{"line_number":68,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Outbound"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_fed85120","line":67,"updated":"2016-06-12 14:47:33.000000000","message":"s/receive/receives","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":68,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Outbound"},{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_3e05b979","line":71,"updated":"2016-06-12 14:47:33.000000000","message":"formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Outbound"},{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_6568c1bb","line":71,"in_reply_to":"7aa08908_3e05b979","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Outbound"},{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_1e0a7d8a","line":73,"updated":"2016-06-12 14:47:33.000000000","message":"space missing after ,","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_bef9a982","line":74,"updated":"2016-06-12 14:47:33.000000000","message":"Rephrasing suggested. May be something like \"All three packet types, will be handled differently by dragonflow controller\"","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_7e790182","line":74,"range":{"start_line":74,"start_character":51,"end_line":74,"end_character":52},"updated":"2016-06-12 13:05:31.000000000","message":"them","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"^^^^^^^^^^^^^^^^^^^"},{"line_number":72,"context_line":"Packets are divided into three types:"},{"line_number":73,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_e59af1c4","line":74,"in_reply_to":"7aa08908_bef9a982","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"local port"},{"line_number":80,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_9ef66d8d","line":77,"updated":"2016-06-12 14:47:33.000000000","message":"formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"For three types, drangonflow controller will handle differently."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Outbond-Arp"},{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"local port"},{"line_number":80,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_a562a9d6","line":77,"in_reply_to":"7aa08908_9ef66d8d","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"local port"},{"line_number":80,"context_line":"~~~~~~~~~~~~"},{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_feefb1ae","line":80,"updated":"2016-06-12 14:47:33.000000000","message":"formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"local port"},{"line_number":80,"context_line":"~~~~~~~~~~~~"},{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c59ff5b2","line":80,"in_reply_to":"7aa08908_feefb1ae","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":80,"context_line":"~~~~~~~~~~~~"},{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":84,"context_line":"With unkown outside servers, thus will be treated as common broadcast."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For arp responder, vlan is same as vxlan."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_fe8df17c","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":30},"updated":"2016-06-12 13:05:31.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"~~~~~~~~~~~~"},{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":84,"context_line":"With unkown outside servers, thus will be treated as common broadcast."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For arp responder, vlan is same as vxlan."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_a5b90931","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":30},"in_reply_to":"7aa08908_fe8df17c","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":84,"context_line":"With unkown outside servers, thus will be treated as common broadcast."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":87,"context_line":"Openflow items like this:"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_3eead90f","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":11},"updated":"2016-06-12 13:05:31.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"When controller receives local port updated message,"},{"line_number":82,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":83,"context_line":"Thus can eliminate arp brocast for known ports."},{"line_number":84,"context_line":"With unkown outside servers, thus will be treated as common broadcast."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":87,"context_line":"Openflow items like this:"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c586d564","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":11},"in_reply_to":"7aa08908_3eead90f","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_3e2c9901","line":99,"updated":"2016-06-12 14:47:33.000000000","message":"formatting","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_257cf971","line":99,"in_reply_to":"7aa08908_3e2c9901","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_1e31dd5a","line":100,"updated":"2016-06-12 14:47:33.000000000","message":"s/chosed/chosen","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_65960196","line":100,"in_reply_to":"7aa08908_1e31dd5a","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_5e37e54c","line":101,"updated":"2016-06-12 14:47:33.000000000","message":"s/repond/respond","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"Outbound-DHCP"},{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c5ed3527","line":101,"in_reply_to":"7aa08908_5e37e54c","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_be4089a6","line":102,"updated":"2016-06-12 14:47:33.000000000","message":"s/enable  \nspace after ,","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_e5e83119","line":102,"in_reply_to":"7aa08908_be4089a6","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_be27e910","line":103,"updated":"2016-06-12 14:47:33.000000000","message":"how about rephrasing to \"... same as what is done for vxlan networks.\"","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":100,"context_line":"If \u0027dhcp enable\u0027 option is chosed with vlan network,"},{"line_number":101,"context_line":"controller acts as dhcp server to repond for dhcp request."},{"line_number":102,"context_line":"If \u0027dhcp enalbe\u0027 option is off,dhcp broadcast is treated as common broadcast."},{"line_number":103,"context_line":"Actually it\u0027s same as what vxlan network does."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Outbound-Common Broadcast/Multicast"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_45dae579","line":103,"in_reply_to":"7aa08908_be27e910","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":111,"context_line":"remote ports and unknown outside servers belong to the same vlan."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":114,"context_line":"and forward packets to br-1(external)."},{"line_number":115,"context_line":"Then br-1 will send packets to the physical nic"},{"line_number":116,"context_line":"according to the flows on br-1 \"table\u003d0, priority\u003d0, Actions\u003dNormal\"."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_7e6aa1ee","line":114,"updated":"2016-06-12 14:47:33.000000000","message":"Just to confirm, external(internet) connectivity will be provided using another, vtep, bridge. Am i correct?\nIf yes, using \u0027external\u0027 with br-1 may sound confusing.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":111,"context_line":"remote ports and unknown outside servers belong to the same vlan."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"For remote and unkown outside ports, controller just needs to push vlan header"},{"line_number":114,"context_line":"and forward packets to br-1(external)."},{"line_number":115,"context_line":"Then br-1 will send packets to the physical nic"},{"line_number":116,"context_line":"according to the flows on br-1 \"table\u003d0, priority\u003d0, Actions\u003dNormal\"."},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c5d41549","line":114,"in_reply_to":"7aa08908_7e6aa1ee","updated":"2016-06-20 03:02:44.000000000","message":"br-1 is just an example. It\u0027s a bridge that conneted to physical network.\nI have make description at the begin of the spec.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":121,"context_line":"local port"},{"line_number":122,"context_line":"~~~~~~~~~~~~"},{"line_number":123,"context_line":"When controller receives local port updated messages,"},{"line_number":124,"context_line":"if this port is the first port of the network,"},{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_1e50bd31","line":124,"updated":"2016-06-12 14:47:33.000000000","message":"on this host.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":121,"context_line":"local port"},{"line_number":122,"context_line":"~~~~~~~~~~~~"},{"line_number":123,"context_line":"When controller receives local port updated messages,"},{"line_number":124,"context_line":"if this port is the first port of the network,"},{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_2541990c","line":124,"in_reply_to":"7aa08908_1e50bd31","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":128,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_c142d43d","line":128,"updated":"2016-06-12 14:47:33.000000000","message":"Can you please help me understanding \u0027load_reg7\u003dtunnel_id\u0027? Which tunnel_id is this? Where it will be used?","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":128,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_22c19481","line":128,"range":{"start_line":128,"start_character":43,"end_line":128,"end_character":56},"updated":"2016-06-19 14:53:17.000000000","message":"tunnel_id,1? do you mean tunnel_id_1?","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":128,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_85696d8e","line":128,"range":{"start_line":128,"start_character":43,"end_line":128,"end_character":56},"in_reply_to":"5a9d85d2_22c19481","updated":"2016-06-20 03:02:44.000000000","message":"I have corrected it.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":126,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":127,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":128,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_456f8592","line":128,"in_reply_to":"7aa08908_c142d43d","updated":"2016-06-20 03:02:44.000000000","message":"I have corrected it.\n\u0027load_reg7\u003dtunnel_key\u0027 tunnel_key means the unique port key.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":128,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"},{"line_number":132,"context_line":"Actions:mod_vlan\u003dvlan_id,output:path_br_1"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"If this port is not the first one, controller only update the first flow above."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_0299f86e","line":131,"updated":"2016-06-19 14:53:17.000000000","message":"I think this flow is more like a L2 lookup flow, if we can move this work to a flow of L2_Lookup table? for example, in first flow, we can change actions to \"mod_vlan\u003dvlan_id, load_reg7\u003dbr1_patch_port, resubmit(, EGRESSTABLE), load_reg7\u003dtunnel_id_1, resubmit(, EGRESSTABLE)\", and the last flow will be changed to \"Match: reg7\u003dbr1_patch_port, Actions:output:patch_br_1\". If we do this change, we don\u0027t check if this port is the first port of this network, because the second flow don\u0027t be copied for each network.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"},{"line_number":132,"context_line":"Actions:mod_vlan\u003dvlan_id,output:path_br_1"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"If this port is not the first one, controller only update the first flow above."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"remote port"},{"line_number":137,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_fe69718d","line":134,"range":{"start_line":134,"start_character":62,"end_line":134,"end_character":67},"updated":"2016-06-12 13:05:31.000000000","message":"which flow? it\u0027s not clear","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"Match: metadata\u003dnetwork_id,"},{"line_number":132,"context_line":"Actions:mod_vlan\u003dvlan_id,output:path_br_1"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"If this port is not the first one, controller only update the first flow above."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"remote port"},{"line_number":137,"context_line":"~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_a503c9b7","line":134,"range":{"start_line":134,"start_character":62,"end_line":134,"end_character":67},"in_reply_to":"7aa08908_fe69718d","updated":"2016-06-20 03:02:44.000000000","message":"L2_Lookup_table","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":138,"context_line":"When controller receives remote port updated message,"},{"line_number":139,"context_line":"it will not update broadcast flows. Because with broadcast,"},{"line_number":140,"context_line":"ovs just needs to forward it to br-1. Thus has been done when local port updated.like this."},{"line_number":141,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":142,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":143,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_22923458","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":80},"updated":"2016-06-19 14:53:17.000000000","message":"Maybe it isn\u0027t needed to write down all of the specific flow, because this flow was not installed here. Just describing the flows installed in local port updated will work also on this condition will be better:)","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":140,"context_line":"ovs just needs to forward it to br-1. Thus has been done when local port updated.like this."},{"line_number":141,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":142,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":143,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_be73697f","line":143,"range":{"start_line":143,"start_character":44,"end_line":143,"end_character":53},"updated":"2016-06-12 13:05:31.000000000","message":"this is no longer needed, right?","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":143,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Outbound-Unicast"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_1e0b9dd7","line":145,"range":{"start_line":145,"start_character":72,"end_line":145,"end_character":79},"updated":"2016-06-12 13:05:31.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":158,"context_line":"controller will install flow for remote and unkown ports."},{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c27890fb","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":41},"updated":"2016-06-19 14:53:17.000000000","message":"maybe you can aggregate the multicast/broadcast flows and the unknown/remote unicast flows by installing local port unicast flows with a higher priority, and installing a lower priority flow of which the match is \"metadata\u003dnetwork_id\" and the actions is sending packets to br1_patch_port and all local ports in this network.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":158,"context_line":"controller will install flow for remote and unkown ports."},{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_65260118","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":41},"in_reply_to":"5a9d85d2_c27890fb","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_defd95b2","line":162,"range":{"start_line":162,"start_character":80,"end_line":162,"end_character":89},"updated":"2016-06-12 13:05:31.000000000","message":"you also need to output the packet to local ports.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_25dd1943","line":162,"range":{"start_line":162,"start_character":80,"end_line":162,"end_character":89},"in_reply_to":"7aa08908_c1a494a7","updated":"2016-06-20 03:02:44.000000000","message":"Inbound and outbound have different pipelines.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_c1a494a7","line":162,"range":{"start_line":162,"start_character":80,"end_line":162,"end_character":89},"in_reply_to":"7aa08908_defd95b2","updated":"2016-06-12 14:47:33.000000000","message":"I think that has been added later in the doc under \u0027Inbound Unicast\u0027 section.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":159,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":160,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":161,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":162,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,output:path_br_1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"If this is not the first one, only the first flow above will be installed."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c5d7f521","line":162,"range":{"start_line":162,"start_character":80,"end_line":162,"end_character":89},"in_reply_to":"7aa08908_defd95b2","updated":"2016-06-20 03:02:44.000000000","message":"This is for local port:\n\u0027Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport\u0027","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":175,"context_line":"With inbound, a flow item will be installed to table 0, which will strip vlan and set metadata"},{"line_number":176,"context_line":"for next table. Flow item like this:"},{"line_number":177,"context_line":"Table\u003d0,"},{"line_number":178,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"},{"line_number":179,"context_line":"Actions:metadata\u003dnetwork_id, strip_vlan, goto \"Destination Port Classification\"."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"For simplicity, I will omit some flow tables that are not so directly concerns with vlan networking."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_e11430ea","line":178,"updated":"2016-06-12 14:47:33.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":175,"context_line":"With inbound, a flow item will be installed to table 0, which will strip vlan and set metadata"},{"line_number":176,"context_line":"for next table. Flow item like this:"},{"line_number":177,"context_line":"Table\u003d0,"},{"line_number":178,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"},{"line_number":179,"context_line":"Actions:metadata\u003dnetwork_id, strip_vlan, goto \"Destination Port Classification\"."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"For simplicity, I will omit some flow tables that are not so directly concerns with vlan networking."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_e5b951ee","line":178,"in_reply_to":"7aa08908_e11430ea","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"},{"line_number":179,"context_line":"Actions:metadata\u003dnetwork_id, strip_vlan, goto \"Destination Port Classification\"."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"For simplicity, I will omit some flow tables that are not so directly concerns with vlan networking."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Inbound-Arp"},{"line_number":184,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_7e23c158","line":181,"range":{"start_line":181,"start_character":70,"end_line":181,"end_character":78},"updated":"2016-06-12 13:05:31.000000000","message":"related","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Match:dl_vlan\u003dnetowrk_vla_id,"},{"line_number":179,"context_line":"Actions:metadata\u003dnetwork_id, strip_vlan, goto \"Destination Port Classification\"."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"For simplicity, I will omit some flow tables that are not so directly concerns with vlan networking."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Inbound-Arp"},{"line_number":184,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_25b4f9f0","line":181,"range":{"start_line":181,"start_character":70,"end_line":181,"end_character":78},"in_reply_to":"7aa08908_7e23c158","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Inbound-DHCP"},{"line_number":189,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":190,"context_line":"DHCP Request will be handled by controller that acts as dhcp server,"},{"line_number":191,"context_line":"so if inbound dhcp happends, nothing needs to be done."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Inbound-Unicast"}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_de1475ea","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":60},"updated":"2016-06-12 13:05:31.000000000","message":"consider using DHCP","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"Inbound-DHCP"},{"line_number":189,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":190,"context_line":"DHCP Request will be handled by controller that acts as dhcp server,"},{"line_number":191,"context_line":"so if inbound dhcp happends, nothing needs to be done."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Inbound-Unicast"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_65ce0185","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":60},"in_reply_to":"7aa08908_de1475ea","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aa39b880c892b0257dc78ff05b3d4a56a41b5f38","unresolved":false,"context_lines":[{"line_number":188,"context_line":"Inbound-DHCP"},{"line_number":189,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":190,"context_line":"DHCP Request will be handled by controller that acts as dhcp server,"},{"line_number":191,"context_line":"so if inbound dhcp happends, nothing needs to be done."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Inbound-Unicast"},{"line_number":194,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_3ed4991e","line":191,"range":{"start_line":191,"start_character":19,"end_line":191,"end_character":27},"updated":"2016-06-12 13:05:31.000000000","message":"typo","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"Inbound-DHCP"},{"line_number":189,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":190,"context_line":"DHCP Request will be handled by controller that acts as dhcp server,"},{"line_number":191,"context_line":"so if inbound dhcp happends, nothing needs to be done."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"Inbound-Unicast"},{"line_number":194,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c5a535b6","line":191,"range":{"start_line":191,"start_character":19,"end_line":191,"end_character":27},"in_reply_to":"7aa08908_3ed4991e","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Inbound-Broadcast/Multicast"},{"line_number":206,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":207,"context_line":"When controller receives remote port updated message,"},{"line_number":208,"context_line":"it will install or update flow like this."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"1. Table\u003dDestination_Port_Classification,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_62d8bc1e","line":207,"range":{"start_line":207,"start_character":24,"end_line":207,"end_character":31},"updated":"2016-06-19 14:53:17.000000000","message":"local? I think those flows mentioned below is only needed for a  local port.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Inbound-Broadcast/Multicast"},{"line_number":206,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":207,"context_line":"When controller receives remote port updated message,"},{"line_number":208,"context_line":"it will install or update flow like this."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"1. Table\u003dDestination_Port_Classification,"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_05b0ddf3","line":207,"range":{"start_line":207,"start_character":24,"end_line":207,"end_character":31},"in_reply_to":"5a9d85d2_62d8bc1e","updated":"2016-06-20 03:02:44.000000000","message":"yes ,local","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"3772b924181c378638831aa340e7693c6b2ecfec","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Port delete"},{"line_number":219,"context_line":"---------------------------"},{"line_number":220,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":221,"context_line":"flow items as above."},{"line_number":222,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":223,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c2037075","line":220,"updated":"2016-06-19 14:53:17.000000000","message":"corresponding? not \"correspongding\"","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Port delete"},{"line_number":219,"context_line":"---------------------------"},{"line_number":220,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":221,"context_line":"flow items as above."},{"line_number":222,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":223,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_c593754e","line":220,"in_reply_to":"5a9d85d2_c2037075","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":219,"context_line":"---------------------------"},{"line_number":220,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":221,"context_line":"flow items as above."},{"line_number":222,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":223,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"},{"line_number":224,"context_line":"should be deleted either."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_01efbce9","line":222,"updated":"2016-06-12 14:47:33.000000000","message":"This can be rephrased to something like below for better readability:\nThere is a special scenario if the deleted port is the last port on this host which belongs to this particular network.\n\nOR\n\nIf the port under deletion is the last one that belong to this network on this host, then it is a special case.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2cbb9082d8c4356ad9ecb1d6c3f5a04e58f233d7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"---------------------------"},{"line_number":220,"context_line":"When controller receive port deleted messages, it will delete correspongding"},{"line_number":221,"context_line":"flow items as above."},{"line_number":222,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":223,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"},{"line_number":224,"context_line":"should be deleted either."}],"source_content_type":"text/x-rst","patch_set":33,"id":"5a9d85d2_25823901","line":222,"in_reply_to":"7aa08908_01efbce9","updated":"2016-06-20 03:02:44.000000000","message":"Done","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":15967,"name":"vikas choudhary","email":"choudharyvikas16@gmail.com","username":"vikaschoudhary16"},"change_message_id":"33cf920a07f665d862d0af1a2b6136fa954e7e68","unresolved":false,"context_lines":[{"line_number":221,"context_line":"flow items as above."},{"line_number":222,"context_line":"What\u0027s more, there\u0027s some special scenario for the last port deleted of a network."},{"line_number":223,"context_line":"On the last local port deleted of a network, network flow items  for remote and unknown ports"},{"line_number":224,"context_line":"should be deleted either."}],"source_content_type":"text/x-rst","patch_set":33,"id":"7aa08908_a1cce889","line":224,"updated":"2016-06-12 14:47:33.000000000","message":"should also be deleted.","commit_id":"a77c3e3a1761c63e1db01cd6d048fc5a7b6a7a9a"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":19,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":20,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_77fe496c","line":19,"updated":"2016-06-29 10:52:38.000000000","message":"space","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem Description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Currently, Dragonflow only supports overlay network."},{"line_number":19,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":20,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_c7dbf44d","line":19,"in_reply_to":"3aaa91ec_77fe496c","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":19,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":20,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"},{"line_number":23,"context_line":"encapsulated within the packet, and forwarded to the physical network through"},{"line_number":24,"context_line":"the host physical nic."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_172ee5f9","line":22,"range":{"start_line":22,"start_character":14,"end_line":22,"end_character":16},"updated":"2016-06-29 10:52:38.000000000","message":"a VM","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":19,"context_line":"When admin creates network,no network type can be chosen."},{"line_number":20,"context_line":"The network type is always set to overlay network (VxLan, GRE...)."},{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"},{"line_number":23,"context_line":"encapsulated within the packet, and forwarded to the physical network through"},{"line_number":24,"context_line":"the host physical nic."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_a7e068fb","line":22,"range":{"start_line":22,"start_character":14,"end_line":22,"end_character":16},"in_reply_to":"3aaa91ec_172ee5f9","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"},{"line_number":23,"context_line":"encapsulated within the packet, and forwarded to the physical network through"},{"line_number":24,"context_line":"the host physical nic."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_d7445db8","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":21},"updated":"2016-06-29 10:52:38.000000000","message":"NIC","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Whereas, there\u0027re some demands for other network types, such as vlan,"},{"line_number":22,"context_line":"flat, etc. If vm belongs to vlan network, a vlan header(802.1.Q) will be"},{"line_number":23,"context_line":"encapsulated within the packet, and forwarded to the physical network through"},{"line_number":24,"context_line":"the host physical nic."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This spec just discusses how to support vlan L2 networking."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_e7e6f013","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":21},"in_reply_to":"3aaa91ec_d7445db8","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":32,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support"},{"line_number":33,"context_line":"vlan network."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_e882a5c7","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"updated":"2016-06-28 08:24:12.000000000","message":"Firstly","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":32,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support"},{"line_number":33,"context_line":"vlan network."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_47f0a4c9","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"3aaa91ec_ba541854","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed Change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":"First, Dragonflow plugin does not support to create vlan network."},{"line_number":32,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support"},{"line_number":33,"context_line":"vlan network."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_ba541854","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":5},"in_reply_to":"3aaa91ec_e882a5c7","updated":"2016-06-29 10:52:38.000000000","message":"I think First is OK","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"In future, ML2 Mechanism Driver will replace Dragonflow Plugin to support"},{"line_number":33,"context_line":"vlan network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":36,"context_line":"as overlay scenario does, and install flows to openvswitch."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Third, openflow tables and items for vlan network needs to"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_6877d502","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":6},"updated":"2016-06-28 08:24:12.000000000","message":"Secondly","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":33,"context_line":"vlan network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":36,"context_line":"as overlay scenario does, and install flows to openvswitch."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":39,"context_line":"coordinate with existing flow items, so that all work fine together."}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_97d655c1","line":36,"range":{"start_line":36,"start_character":38,"end_line":36,"end_character":43},"updated":"2016-06-29 10:52:38.000000000","message":"flow entries","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":36,"context_line":"as overlay scenario does, and install flows to openvswitch."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":39,"context_line":"coordinate with existing flow items, so that all work fine together."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"What does dragonflow need to do for vlan  L2 networks"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_487499fc","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":5},"updated":"2016-06-28 08:24:12.000000000","message":"Thirdly","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Second, Dragonflow Controller needs to handle port updated events"},{"line_number":36,"context_line":"as overlay scenario does, and install flows to openvswitch."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Third, openflow tables and items for vlan network needs to"},{"line_number":39,"context_line":"coordinate with existing flow items, so that all work fine together."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"What does dragonflow need to do for vlan  L2 networks"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_c7b2d405","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":5},"in_reply_to":"3aaa91ec_487499fc","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":42,"context_line":"is similar to overlay networking."},{"line_number":43,"context_line":"The difference between them is what flow items should be installed."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":46,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"When controller receive port online events from ovsdb monitor,"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_f7fcf93f","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":23},"updated":"2016-06-29 10:52:38.000000000","message":"receives","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":45,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":46,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":49,"context_line":"it will query port and network information from db store.."},{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_d7a57d47","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":23},"updated":"2016-06-29 10:52:38.000000000","message":"ditto","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"When controller receive port updated messages from dragonflow plugin,"},{"line_number":46,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":49,"context_line":"it will query port and network information from db store.."},{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_87a3acb1","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":23},"in_reply_to":"3aaa91ec_d7a57d47","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":46,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":49,"context_line":"it will query port and network information from db store.."},{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_776da903","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"updated":"2016-06-29 10:52:38.000000000","message":"DB","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":46,"context_line":"it will handle them just as what it does for vxlan, and install flows."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"When controller receive port online events from ovsdb monitor,"},{"line_number":49,"context_line":"it will query port and network information from db store.."},{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_47c38438","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":50},"in_reply_to":"3aaa91ec_776da903","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When controller receive port deleted messages,"},{"line_number":54,"context_line":"it will delete corresponding flow items."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Packets from vms or outside such as tunnel and physical nics"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_9759355e","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":23},"updated":"2016-06-29 10:52:38.000000000","message":"ditto","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":50,"context_line":"If  this is the first port belongs to a tenant in this host,"},{"line_number":51,"context_line":"local controller will subscribe northbound events."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"When controller receive port deleted messages,"},{"line_number":54,"context_line":"it will delete corresponding flow items."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Packets from vms or outside such as tunnel and physical nics"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_67e4c0e0","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":23},"in_reply_to":"3aaa91ec_9759355e","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Port updated"},{"line_number":68,"context_line":"-----------"},{"line_number":69,"context_line":"When controller receive port updated messages, it will install flows."},{"line_number":70,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Outbound"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_ba13785b","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":23},"updated":"2016-06-29 10:52:38.000000000","message":"ditto","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Port updated"},{"line_number":68,"context_line":"-----------"},{"line_number":69,"context_line":"When controller receive port updated messages, it will install flows."},{"line_number":70,"context_line":"With this, outbound and inbound will be discussed as follows."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Outbound"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_e7a27098","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":23},"in_reply_to":"3aaa91ec_ba13785b","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":75,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":76,"context_line":"These three types will be handled differently by the dragonflow controller."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Outbond-Arp"},{"line_number":79,"context_line":"\"\"\"\"\"\"\"\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"local port"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_9a3cbcc0","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":7},"updated":"2016-06-29 10:52:38.000000000","message":"Outbound","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":75,"context_line":"arp,dhcp, broadcast/multicast."},{"line_number":76,"context_line":"These three types will be handled differently by the dragonflow controller."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Outbond-Arp"},{"line_number":79,"context_line":"\"\"\"\"\"\"\"\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"local port"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_479ee463","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":7},"in_reply_to":"3aaa91ec_9a3cbcc0","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":82,"context_line":"~~~~~~~~~~"},{"line_number":83,"context_line":"When controller receives local port updated message,"},{"line_number":84,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":85,"context_line":"Thus can eliminate arp broadcast for known ports."},{"line_number":86,"context_line":"With unknown outside servers, thus will be treated as common broadcast."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For arp responder, vlan is same as vxlan."}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_da5da416","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":4},"updated":"2016-06-29 10:52:38.000000000","message":"This","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":82,"context_line":"~~~~~~~~~~"},{"line_number":83,"context_line":"When controller receives local port updated message,"},{"line_number":84,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":85,"context_line":"Thus can eliminate arp broadcast for known ports."},{"line_number":86,"context_line":"With unknown outside servers, thus will be treated as common broadcast."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For arp responder, vlan is same as vxlan."}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_878a8c19","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":4},"in_reply_to":"3aaa91ec_da5da416","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":83,"context_line":"When controller receives local port updated message,"},{"line_number":84,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":85,"context_line":"Thus can eliminate arp broadcast for known ports."},{"line_number":86,"context_line":"With unknown outside servers, thus will be treated as common broadcast."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":89,"context_line":"Openflow items like this:"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_fab9802f","line":86,"range":{"start_line":86,"start_character":30,"end_line":86,"end_character":34},"updated":"2016-06-29 10:52:38.000000000","message":"ditto","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":83,"context_line":"When controller receives local port updated message,"},{"line_number":84,"context_line":"it will  install flows on ovs to act as arp proxy."},{"line_number":85,"context_line":"Thus can eliminate arp broadcast for known ports."},{"line_number":86,"context_line":"With unknown outside servers, thus will be treated as common broadcast."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"For arp responder, vlan is same as vxlan."},{"line_number":89,"context_line":"Openflow items like this:"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_c7ae5480","line":86,"range":{"start_line":86,"start_character":30,"end_line":86,"end_character":34},"in_reply_to":"3aaa91ec_fab9802f","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Outbound-DHCP"},{"line_number":101,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":102,"context_line":"If \u0027dhcp enable\u0027 option is chosen with vlan network,"},{"line_number":103,"context_line":"controller acts as dhcp server to respond for dhcp request."},{"line_number":104,"context_line":"If \u0027dhcp enalbe\u0027 option is off, dhcp broadcast is treated as common broadcast."},{"line_number":105,"context_line":"Actually it\u0027s same as what is done for vxlan network."}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_dae2c42e","line":102,"range":{"start_line":102,"start_character":27,"end_line":102,"end_character":33},"updated":"2016-06-29 10:52:38.000000000","message":"I think \u0027enabled\u0027 could be better","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Outbound-DHCP"},{"line_number":101,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":102,"context_line":"If \u0027dhcp enable\u0027 option is chosen with vlan network,"},{"line_number":103,"context_line":"controller acts as dhcp server to respond for dhcp request."},{"line_number":104,"context_line":"If \u0027dhcp enalbe\u0027 option is off, dhcp broadcast is treated as common broadcast."},{"line_number":105,"context_line":"Actually it\u0027s same as what is done for vxlan network."}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_e7f71089","line":102,"range":{"start_line":102,"start_character":27,"end_line":102,"end_character":33},"in_reply_to":"3aaa91ec_dae2c42e","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Outbound-Common Broadcast/Multicast"},{"line_number":109,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":110,"context_line":"Broadcast excepts to arp and dhcp, it\u0027s similar to multicast processing."},{"line_number":111,"context_line":"We just take broadcast for example."},{"line_number":112,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":113,"context_line":"remote ports and unknown outside servers belong to the same vlan."}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_5a44141a","line":110,"range":{"start_line":110,"start_character":21,"end_line":110,"end_character":33},"updated":"2016-06-29 10:52:38.000000000","message":"ARP, DHCP","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Outbound-Common Broadcast/Multicast"},{"line_number":109,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":110,"context_line":"Broadcast excepts to arp and dhcp, it\u0027s similar to multicast processing."},{"line_number":111,"context_line":"We just take broadcast for example."},{"line_number":112,"context_line":"When broadcast happens, thus packet should be forwarded to local ports,"},{"line_number":113,"context_line":"remote ports and unknown outside servers belong to the same vlan."}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_872d6c00","line":110,"range":{"start_line":110,"start_character":21,"end_line":110,"end_character":33},"in_reply_to":"3aaa91ec_5a44141a","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":128,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":129,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":130,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_key,resubmit(,EGRESSTABLE,)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":133,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_2802ed3e","line":130,"range":{"start_line":130,"start_character":76,"end_line":130,"end_character":78},"updated":"2016-06-28 08:24:12.000000000","message":"should remove ,","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":127,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":128,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":129,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":130,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_key,resubmit(,EGRESSTABLE,)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":133,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_274598b2","line":130,"range":{"start_line":130,"start_character":76,"end_line":130,"end_character":78},"in_reply_to":"3aaa91ec_2802ed3e","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":139,"context_line":"~~~~~~~~~~~~"},{"line_number":140,"context_line":"When controller receives remote port updated message, it will not update"},{"line_number":141,"context_line":"broadcast flows. Because with broadcast, ovs just needs to forward it to br-1."},{"line_number":142,"context_line":"Thus has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_dac3e455","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":4},"updated":"2016-06-29 10:52:38.000000000","message":"ditto","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"166c81885b7b541a8ae0c2bf613b3d10abdc8026","unresolved":false,"context_lines":[{"line_number":139,"context_line":"~~~~~~~~~~~~"},{"line_number":140,"context_line":"When controller receives remote port updated message, it will not update"},{"line_number":141,"context_line":"broadcast flows. Because with broadcast, ovs just needs to forward it to br-1."},{"line_number":142,"context_line":"Thus has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_7a82b001","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":43},"updated":"2016-06-29 10:52:38.000000000","message":"updated","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":139,"context_line":"~~~~~~~~~~~~"},{"line_number":140,"context_line":"When controller receives remote port updated message, it will not update"},{"line_number":141,"context_line":"broadcast flows. Because with broadcast, ovs just needs to forward it to br-1."},{"line_number":142,"context_line":"Thus has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_471f04b7","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":4},"in_reply_to":"3aaa91ec_dac3e455","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Thus has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_88cb211e","line":145,"range":{"start_line":145,"start_character":78,"end_line":145,"end_character":80},"updated":"2016-06-28 08:24:12.000000000","message":"should remove ,","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Thus has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE,)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_c78134c5","line":145,"range":{"start_line":145,"start_character":78,"end_line":145,"end_character":80},"in_reply_to":"3aaa91ec_88cb211e","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"93303aaa78d5eb360405d536a60dd39b99c9e4d5","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Inbound-Arp"},{"line_number":188,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":189,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":190,"context_line":"which will be discussed as follows ."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Inbound-DHCP"},{"line_number":193,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_77db4eee","line":190,"updated":"2016-07-03 17:17:50.000000000","message":"add ARP treatment as per discussion in patch set 29.","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":187,"context_line":"Inbound-Arp"},{"line_number":188,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":189,"context_line":"Inbound arp broadcast will be handled as common broadcast,"},{"line_number":190,"context_line":"which will be discussed as follows ."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Inbound-DHCP"},{"line_number":193,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\""}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_87c9ec28","line":190,"in_reply_to":"1aa78d24_77db4eee","updated":"2016-07-06 09:57:55.000000000","message":"ARP  is treated in outbound direction.\nIf we add ARP treatment in inbound, flow pipeline will be adjusted, it\u0027s a big job.","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"2cff7ba7f36bc8cb221fb2ad2fe41d35988bcbc2","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"1. Table\u003dDestination_Port_Classification,"},{"line_number":215,"context_line":"Match:metadata\u003dnetwork_id, dl_dst\u003d\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":216,"context_line":"Actions\u003d load_reg7\u003dport_key_1, goto \"Destination_Port_Dispatch\","},{"line_number":217,"context_line":"load_reg7\u003dport_key_2, goto \"Destination_Port_Dispatch\""},{"line_number":218,"context_line":"2. Table\u003dDestination_Port_Dispatch,"},{"line_number":219,"context_line":"Match: reg7\u003dport_key, Actions: output:ofport"}],"source_content_type":"text/x-rst","patch_set":35,"id":"3aaa91ec_36c1aa2f","line":216,"range":{"start_line":216,"start_character":19,"end_line":216,"end_character":29},"updated":"2016-06-28 08:24:12.000000000","message":"keep the name port_unique_key, port_key_1 and port_key the same for consistency","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"536f764606d33e8cc9cc3d6735264c109a7ccaff","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"1. Table\u003dDestination_Port_Classification,"},{"line_number":215,"context_line":"Match:metadata\u003dnetwork_id, dl_dst\u003d\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":216,"context_line":"Actions\u003d load_reg7\u003dport_key_1, goto \"Destination_Port_Dispatch\","},{"line_number":217,"context_line":"load_reg7\u003dport_key_2, goto \"Destination_Port_Dispatch\""},{"line_number":218,"context_line":"2. Table\u003dDestination_Port_Dispatch,"},{"line_number":219,"context_line":"Match: reg7\u003dport_key, Actions: output:ofport"}],"source_content_type":"text/x-rst","patch_set":35,"id":"1aa78d24_07de9cdc","line":216,"range":{"start_line":216,"start_character":19,"end_line":216,"end_character":29},"in_reply_to":"3aaa91ec_36c1aa2f","updated":"2016-07-06 09:57:55.000000000","message":"Done","commit_id":"169d393d9a2a24723cfdabda6c79e3cdb017ddaa"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"10726e942160026381b6dfae2af8996ffef64fbc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\"\"\"\"\"\"\"\"\"\"\"\""},{"line_number":102,"context_line":"If \u0027dhcp enable\u0027 option is chosen with vlan network,"},{"line_number":103,"context_line":"controller acts as dhcp server to respond for dhcp request."},{"line_number":104,"context_line":"If \u0027dhcp enalbe\u0027 option is off, dhcp broadcast is treated as common broadcast."},{"line_number":105,"context_line":"Actually it\u0027s same as what is done for vxlan network."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_af5c5df1","line":104,"range":{"start_line":104,"start_character":9,"end_line":104,"end_character":15},"updated":"2016-07-22 07:44:51.000000000","message":"enable","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"10726e942160026381b6dfae2af8996ffef64fbc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":128,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":129,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":130,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_key,resubmit(,EGRESSTABLE)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":133,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_4fc4c15e","line":130,"range":{"start_line":130,"start_character":44,"end_line":130,"end_character":54},"updated":"2016-07-22 07:44:51.000000000","message":"what is the tunnel_key in vlan network???","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"3a20eba4a6c16b38c8b48b75af4f57f9c7d4c9f9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"controller will install broadcast flows on ovs like this:"},{"line_number":128,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":129,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":130,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_key,resubmit(,EGRESSTABLE)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"2.Table\u003dEgress_Table,"},{"line_number":133,"context_line":"Match: metadata\u003dnetwork_id,"}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_bd49f2b9","line":130,"range":{"start_line":130,"start_character":44,"end_line":130,"end_character":54},"in_reply_to":"dada55a8_4fc4c15e","updated":"2016-07-25 02:45:15.000000000","message":"I will change it to port_key which is assigned when neutron port is created.","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"10726e942160026381b6dfae2af8996ffef64fbc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"This has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_2f7b4d2b","line":145,"range":{"start_line":145,"start_character":44,"end_line":145,"end_character":56},"updated":"2016-07-22 07:44:51.000000000","message":"what is the tunnel_id,_1??","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"3a20eba4a6c16b38c8b48b75af4f57f9c7d4c9f9","unresolved":false,"context_lines":[{"line_number":142,"context_line":"This has been done when local port updated.like this."},{"line_number":143,"context_line":"1.Table\u003dL2_Lookup,"},{"line_number":144,"context_line":"Match: metadata\u003dnetwork_id, dl_dst\u003d01:00:00:00:00:00/01:00:00:00:00:00,"},{"line_number":145,"context_line":"Actions:  resubmit(,EGRESSTABLE), load_reg7\u003dtunnel_id,_1,resubmit(,EGRESSTABLE)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"The first action \u0027resubmit(,EGRESSTABLE)\u0027 has included remote broadcast senario."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_dde5c6a8","line":145,"range":{"start_line":145,"start_character":44,"end_line":145,"end_character":56},"in_reply_to":"dada55a8_2f7b4d2b","updated":"2016-07-25 02:45:15.000000000","message":"port_unique_key","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"10726e942160026381b6dfae2af8996ffef64fbc","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"If it is the first port of the network locally,"},{"line_number":160,"context_line":"controller will install flow for remote and unkown ports."},{"line_number":161,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":162,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":163,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":164,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,"}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_ef977538","line":161,"range":{"start_line":161,"start_character":31,"end_line":161,"end_character":46},"updated":"2016-07-22 07:44:51.000000000","message":"what is the port_unique_key?","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"3a20eba4a6c16b38c8b48b75af4f57f9c7d4c9f9","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"If it is the first port of the network locally,"},{"line_number":160,"context_line":"controller will install flow for remote and unkown ports."},{"line_number":161,"context_line":"1.Table\u003dL2_Lookup, Match: reg7\u003dport_unique_key, Actions: output:ofport"},{"line_number":162,"context_line":"2.Table\u003dL2_Lookup, Match: metadata\u003dnetwork_id,"},{"line_number":163,"context_line":"dl_dst\u003d00:00:00:00:00:00/01:00:00:00:00:00,  Actions: goto \"Egress_Table\""},{"line_number":164,"context_line":"3.Table\u003dEgress_Table,Match: metadata\u003dnetwork_id,mod_vlan\u003dnetwork_vlan_id,"}],"source_content_type":"text/x-rst","patch_set":39,"id":"dada55a8_7dfdba3a","line":161,"range":{"start_line":161,"start_character":31,"end_line":161,"end_character":46},"in_reply_to":"dada55a8_ef977538","updated":"2016-07-25 02:45:15.000000000","message":"Port unique key is allocated by nb_api when neutron port is created. It is a unique key.","commit_id":"f5ab8949fbab58e61a1ed3671dc5ed9a36b1eb40"}]}