)]}'
{"dragonflow/cli/df_db.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"7abb81926e3a5a7bc397a2e5f0b1484d3ed5f6b7","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def remove_table(db_driver, table, name):"},{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        db_driver.delete_key(table, name)"},{"line_number":103,"context_line":"    except df_exceptions.DBKeyNotFound:"},{"line_number":104,"context_line":"        print(\u0027Table not found: \u0027 + table)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_4638b1a0","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":28},"updated":"2016-03-09 07:18:39.000000000","message":"This just delete the given key in that table, not the whole table. You need to do it by iterating each key in that table.\n\nBy the way, a patch for removing stale tables is under review. Please check that to see if it is what you want.\n\nhttps://review.openstack.org/#/c/289151/","commit_id":"c5125fcd524efc080cc8f624e92c75848192eda2"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"b5c5d2afa7176491fb7a76313bf416346dcea10a","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def remove_table(db_driver, table, name):"},{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        db_driver.delete_key(table, name)"},{"line_number":103,"context_line":"    except df_exceptions.DBKeyNotFound:"},{"line_number":104,"context_line":"        print(\u0027Table not found: \u0027 + table)"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_225464fd","line":102,"range":{"start_line":102,"start_character":18,"end_line":102,"end_character":28},"in_reply_to":"5aef4532_4638b1a0","updated":"2016-03-09 11:08:39.000000000","message":"OK, I think we implement similar functions, maybe I can change the subroutine name into \u0027remove_table_item\u0027. Actually I committed df_db in DNAT patch, because this function is relative independent from DNAT, so Omer suggest me to split it into smaller patch.","commit_id":"c5125fcd524efc080cc8f624e92c75848192eda2"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"5e272e9596c09e38453f050923064c8d7561b16a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \"2) df_db ls \u003ctable_name\u003e - print all the keys for specific table \\n\" \\"},{"line_number":33,"context_line":"            \"3) df_db get \u003ctable_name\u003e \u003ckey\u003e - print value for specific key\\n\" \\"},{"line_number":34,"context_line":"            \"4) df_db dump - dump all tables\\n\" \\"},{"line_number":35,"context_line":"            \"5) df_db rm \u003ctable name\u003e - remove the specific db record \\n\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def print_tables():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a25d1449","line":35,"updated":"2016-03-09 11:20:50.000000000","message":"\u003ckey\u003e argument is missing here too","commit_id":"4ccd97579f131d738d3cff386ad3c07a202af458"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"19286f9295b6afba8b2c5068fa6c4a4839ba16a3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            print \"\u003ctable\u003e must be one of the following:\""},{"line_number":165,"context_line":"            print db_tables"},{"line_number":166,"context_line":"            return"},{"line_number":167,"context_line":"        remove_record(db_driver, table)"},{"line_number":168,"context_line":"        return"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    print usage_str"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_02a96824","line":167,"updated":"2016-03-09 11:20:11.000000000","message":"Where is a key/name here ?","commit_id":"4ccd97579f131d738d3cff386ad3c07a202af458"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bd2546d2a046d2ab24a4cd8831a13810e3572cc6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \"2) df_db ls \u003ctable_name\u003e - print all the keys for specific table \\n\" \\"},{"line_number":33,"context_line":"            \"3) df_db get \u003ctable_name\u003e \u003ckey\u003e - print value for specific key\\n\" \\"},{"line_number":34,"context_line":"            \"4) df_db dump - dump all tables\\n\" \\"},{"line_number":35,"context_line":"            \"5) df_db rm \u003ctable name\u003e \u003ckey\u003e - remove the specific db record \\n\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def print_tables():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_0dcf2880","line":35,"range":{"start_line":35,"start_character":57,"end_line":35,"end_character":65},"updated":"2016-03-13 19:43:31.000000000","message":"typo? specific -\u003e specified?","commit_id":"3ffb3baece6b358435dc5df31ceb0a2ecdfd4af5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"bd2546d2a046d2ab24a4cd8831a13810e3572cc6","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    try:"},{"line_number":102,"context_line":"        db_driver.delete_key(table, name)"},{"line_number":103,"context_line":"    except df_exceptions.DBKeyNotFound:"},{"line_number":104,"context_line":"        print(\u0027Table not found: \u0027 + table)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_4dc93078","line":104,"updated":"2016-03-13 19:43:31.000000000","message":"Consider rewording to \u0027Key %s not found in table %s.\u0027","commit_id":"3ffb3baece6b358435dc5df31ceb0a2ecdfd4af5"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0da792bd7c1075ceaae30783008e1442a7fcedbb","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        table \u003d sys.argv[2]"},{"line_number":163,"context_line":"        if table not in db_tables:"},{"line_number":164,"context_line":"            print \"\u003ctable\u003e must be one of the following:\""},{"line_number":165,"context_line":"            print db_tables"},{"line_number":166,"context_line":"            return"},{"line_number":167,"context_line":"        key \u003d sys.argv[3]"},{"line_number":168,"context_line":"        remove_record(db_driver, table, key)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_6f798493","line":165,"updated":"2016-03-13 15:05:10.000000000","message":"L164 \u0026 and L165 can be combined.. \n print \"\u003ctable\u003e must be one of the following: %s\" % db_tables","commit_id":"3ffb3baece6b358435dc5df31ceb0a2ecdfd4af5"}]}