)]}'
{"devstack/df-ext-services.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"ccdc7ce281ed044b7161e11b52db1951a66f1b45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Locate devstack directory"},{"line_number":4,"context_line":"TOP_DIR\u003d/opt/stack/devstack"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Detect path for this script file"},{"line_number":7,"context_line":"DF_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_2348782d","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":27},"updated":"2016-03-20 12:03:31.000000000","message":"please REMOVE  devstack add this","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7adb9b40bb6826f9288ec22d9eacef9ad8b471c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Locate devstack directory"},{"line_number":4,"context_line":"TOP_DIR\u003d/opt/stack/devstack"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Detect path for this script file"},{"line_number":7,"context_line":"DF_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_896c059e","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":27},"in_reply_to":"fa0719c6_2348782d","updated":"2016-03-20 15:48:50.000000000","message":"will do","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"}],"devstack/plugin.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"ccdc7ce281ed044b7161e11b52db1951a66f1b45","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        if is_service_enabled df-publisher-service; then"},{"line_number":441,"context_line":"            start_pubsub_service"},{"line_number":442,"context_line":"        fi"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":445,"context_line":"            start_df_l3_agent"},{"line_number":446,"context_line":"        fi"},{"line_number":447,"context_line":"        start_df"},{"line_number":448,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_a362c8ab","line":445,"range":{"start_line":443,"start_character":0,"end_line":445,"end_character":29},"updated":"2016-03-20 12:03:31.000000000","message":"call start_df_l3_agent","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7adb9b40bb6826f9288ec22d9eacef9ad8b471c4","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        if is_service_enabled df-publisher-service; then"},{"line_number":441,"context_line":"            start_pubsub_service"},{"line_number":442,"context_line":"        fi"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":445,"context_line":"            start_df_l3_agent"},{"line_number":446,"context_line":"        fi"},{"line_number":447,"context_line":"        start_df"},{"line_number":448,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_49682dbb","line":445,"range":{"start_line":443,"start_character":0,"end_line":445,"end_character":29},"in_reply_to":"fa0719c6_a362c8ab","updated":"2016-03-20 15:48:50.000000000","message":"do you mean calling start_df_l3_agent directly without check whether df-l3-agent is enabled or not?","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"ccdc7ce281ed044b7161e11b52db1951a66f1b45","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            stop_pubsub_service"},{"line_number":456,"context_line":"        fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":459,"context_line":"            stop_process df-l3-agent"},{"line_number":460,"context_line":"        fi"},{"line_number":461,"context_line":"        cleanup_database"},{"line_number":462,"context_line":"    fi"},{"line_number":463,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_635270df","line":460,"range":{"start_line":458,"start_character":9,"end_line":460,"end_character":10},"updated":"2016-03-20 12:03:31.000000000","message":"call stop_df_l3_agent","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7adb9b40bb6826f9288ec22d9eacef9ad8b471c4","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            stop_pubsub_service"},{"line_number":456,"context_line":"        fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":459,"context_line":"            stop_process df-l3-agent"},{"line_number":460,"context_line":"        fi"},{"line_number":461,"context_line":"        cleanup_database"},{"line_number":462,"context_line":"    fi"},{"line_number":463,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa0719c6_e913010c","line":460,"range":{"start_line":458,"start_character":9,"end_line":460,"end_character":10},"in_reply_to":"fa0719c6_635270df","updated":"2016-03-20 15:48:50.000000000","message":"ditto","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"b8382eecc40332bf9cdba886b52477615c9c93fa","unresolved":false,"context_lines":[{"line_number":395,"context_line":"function start_df_l3_agent {"},{"line_number":396,"context_line":"    echo \"Starting Dragonflow l3 agent\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":399,"context_line":"        run_process df-l3-agent \"python $DF_L3_BINARY --config-file $NEUTRON_CONF --config-file\u003d$Q_L3_CONF_FILE\""},{"line_number":400,"context_line":"    fi"},{"line_number":401,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_686521e0","line":398,"range":{"start_line":398,"start_character":4,"end_line":398,"end_character":44},"updated":"2016-03-21 08:44:54.000000000","message":"I am not sure we need to check another time here \n\nYou all ready checked before calling","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7f4ffa51818510895ef9edfd7bf20c36e42d7550","unresolved":false,"context_lines":[{"line_number":395,"context_line":"function start_df_l3_agent {"},{"line_number":396,"context_line":"    echo \"Starting Dragonflow l3 agent\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":399,"context_line":"        run_process df-l3-agent \"python $DF_L3_BINARY --config-file $NEUTRON_CONF --config-file\u003d$Q_L3_CONF_FILE\""},{"line_number":400,"context_line":"    fi"},{"line_number":401,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_e21668a6","line":398,"range":{"start_line":398,"start_character":4,"end_line":398,"end_character":44},"in_reply_to":"fa0719c6_686521e0","updated":"2016-03-21 10:59:39.000000000","message":"will do. this function will be call directly without verification again.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"b8382eecc40332bf9cdba886b52477615c9c93fa","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"# stop_df_l3_agent() - Stop running processes (non-screen)"},{"line_number":404,"context_line":"function stop_df_l3_agent {"},{"line_number":405,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":406,"context_line":"        stop_process df-l3-agent"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_089bc5ca","line":405,"range":{"start_line":405,"start_character":3,"end_line":405,"end_character":44},"updated":"2016-03-21 08:44:54.000000000","message":"ditto","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7f4ffa51818510895ef9edfd7bf20c36e42d7550","unresolved":false,"context_lines":[{"line_number":402,"context_line":""},{"line_number":403,"context_line":"# stop_df_l3_agent() - Stop running processes (non-screen)"},{"line_number":404,"context_line":"function stop_df_l3_agent {"},{"line_number":405,"context_line":"    if is_service_enabled df-l3-agent ; then"},{"line_number":406,"context_line":"        stop_process df-l3-agent"},{"line_number":407,"context_line":"    fi"},{"line_number":408,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_221180ad","line":405,"range":{"start_line":405,"start_character":3,"end_line":405,"end_character":44},"in_reply_to":"fa0719c6_089bc5ca","updated":"2016-03-21 10:59:39.000000000","message":"will do","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"b8382eecc40332bf9cdba886b52477615c9c93fa","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":459,"context_line":"            stop_process df-l3-agent"},{"line_number":460,"context_line":"        fi"},{"line_number":461,"context_line":"        cleanup_database"},{"line_number":462,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_68ac01ee","line":459,"range":{"start_line":459,"start_character":11,"end_line":459,"end_character":36},"updated":"2016-03-21 08:44:54.000000000","message":"please call stop_df_l3_agent","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7f4ffa51818510895ef9edfd7bf20c36e42d7550","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        fi"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if is_service_enabled df-l3-agent; then"},{"line_number":459,"context_line":"            stop_process df-l3-agent"},{"line_number":460,"context_line":"        fi"},{"line_number":461,"context_line":"        cleanup_database"},{"line_number":462,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa0719c6_e27dc8e8","line":459,"range":{"start_line":459,"start_character":11,"end_line":459,"end_character":36},"in_reply_to":"fa0719c6_68ac01ee","updated":"2016-03-21 10:59:39.000000000","message":"will do","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"c23d712f1701f02bffa9a092f5a99aa6a0042fa3","unresolved":false,"context_lines":[{"line_number":393,"context_line":"    stop_process df-publisher-service"},{"line_number":394,"context_line":"}"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"function cleanup_database {"},{"line_number":397,"context_line":"    df-db clean"},{"line_number":398,"context_line":"}"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"# start_df_l3_agent() - Start running processes, including screen"},{"line_number":401,"context_line":"function start_df_l3_agent {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa0719c6_08a273ae","line":398,"range":{"start_line":396,"start_character":0,"end_line":398,"end_character":1},"updated":"2016-03-22 03:47:31.000000000","message":"you need to rebase to solve the conflict. this patch has been merged before. it should not be here.","commit_id":"bea9945f4be26c5a11e2312d1d7a20f06201cce3"}],"devstack/settings":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"ccdc7ce281ed044b7161e11b52db1951a66f1b45","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$DRAGONFLOW_DIR/dragonflow/cmd/eventlet/df_l3_agent.py\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa0719c6_4372cc7d","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":86},"updated":"2016-03-20 12:03:31.000000000","message":"why do you need it if you have the setup.cfg \ndf-l3-agent","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7adb9b40bb6826f9288ec22d9eacef9ad8b471c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$DRAGONFLOW_DIR/dragonflow/cmd/eventlet/df_l3_agent.py\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fa0719c6_890365b8","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":86},"in_reply_to":"fa0719c6_4372cc7d","updated":"2016-03-20 15:48:50.000000000","message":"yes, will use /usr/local/bin/df-l3-agent","commit_id":"6a2d585de130d59f0daaab32fb387552d98bc865"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0498181e908dd7e54850ddee40e2f2b9171e451d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_0f6e35c9","line":9,"updated":"2016-03-20 20:41:27.000000000","message":"I think the default value should be in the dragonflow dir, like DF_LOCAL_CONTROLLER. Otherwise, you need to move the script to that location during installation/devstack/deployment.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0f909984263a47c4e8a4338d0dde3eae79207e52","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_a4e76b3f","line":9,"in_reply_to":"fa0719c6_0f6e35c9","updated":"2016-03-21 01:46:02.000000000","message":"+1, the absolute path is not appropriate.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"40bea8170ab95103c090af46513334e895cf60f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_dab99aee","line":9,"in_reply_to":"fa0719c6_0f6e35c9","updated":"2016-03-21 04:57:37.000000000","message":"@Omer, do you think it\u0027s ok? \nDF_L3_BINARY\u003d${DF_L3_BINARY:-\"$DRAGONFLOW_DIR/dragonflow/cmd/eventlet/df_l3_agent.py\"}\n\nAt the 1st time I defined the path as above, but Eran think if I use the setup.cfg, then it\u0027s not necessary to define the entry in Dragonflow directory. I will discuss with you on the irc meeting.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"7f4ffa51818510895ef9edfd7bf20c36e42d7550","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_82896ccd","line":9,"in_reply_to":"fa0719c6_4883fdcc","updated":"2016-03-21 10:59:39.000000000","message":"will do","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"40bea8170ab95103c090af46513334e895cf60f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_9a5562c8","line":9,"in_reply_to":"fa0719c6_a4e76b3f","updated":"2016-03-21 04:57:37.000000000","message":"OK, thanks. So if using a relative path, you will think it ok, right?","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"b8382eecc40332bf9cdba886b52477615c9c93fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"/usr/local/bin/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa0719c6_4883fdcc","line":9,"in_reply_to":"fa0719c6_dab99aee","updated":"2016-03-21 08:44:54.000000000","message":"sorry for the confusion \nPlease set it with (we could make it loadable only when needed ) \nDF_L3_BINARY\u003d${DF_L3_BINARY:-\"$DRAGONFLOW_DIR/dragonflow/cmd/eventlet/df_l3_agent.py\"}","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"1ea5e91a76e47698a860341aaaef1ce182526875","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"da0c15f0_91f7a2f4","line":9,"updated":"2016-03-28 15:09:27.000000000","message":"I think NEUTRON_BIN_DIR still translates to /usr/local/bin. Which means it still needs to be somehow copies there (which I didn\u0027t see).\n\nConsider using $DRAGONFLOW_DIR/cmd/eventlet/df_l3_agent.py.","commit_id":"7b945d03f86ad8c841a0be3e15de652df218e851"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"a4ddc9ca92c81e3f60799d9e3e334e0d20efef11","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"ba0121b8_3188ad22","line":9,"in_reply_to":"ba0121b8_5fad6d30","updated":"2016-03-29 03:02:31.000000000","message":"yes","commit_id":"7b945d03f86ad8c841a0be3e15de652df218e851"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"a4ddc9ca92c81e3f60799d9e3e334e0d20efef11","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"ba0121b8_d19cd16b","line":9,"in_reply_to":"da0c15f0_91f7a2f4","updated":"2016-03-29 03:02:31.000000000","message":"As Li Ma mentioned, pbr will generate df-l3-agent since we set the console script in setup.cfg. and the file path is /usr/local/bin/df-l3-agent\n\nconsole_scripts \u003d\ndf-l3-agent \u003d dragonflow.cmd.eventlet.df_l3_agent:main","commit_id":"7b945d03f86ad8c841a0be3e15de652df218e851"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f8e495ef7e4b5c289dd2eb6faae974511a303d9f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"DF_L3_SERVICE_PLUGIN\u003d\"dragonflow.neutron.services.l3.l3_controller_plugin.ControllerL3ServicePlugin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DF_LOCAL_CONTROLLER\u003d$DRAGONFLOW_DIR/dragonflow/controller/df_local_controller.py"},{"line_number":9,"context_line":"DF_L3_BINARY\u003d${DF_L3_BINARY:-\"$NEUTRON_BIN_DIR/df-l3-agent\"}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DF_L2_RESPONDER\u003d${DF_L2_RESPONDER:-\u0027True\u0027}"},{"line_number":12,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"ba0121b8_5fad6d30","line":9,"in_reply_to":"da0c15f0_91f7a2f4","updated":"2016-03-29 02:24:47.000000000","message":"In the setup.cfg, it defines the console scripts which can be automatically generated by pbr.","commit_id":"7b945d03f86ad8c841a0be3e15de652df218e851"}],"doc/source/multi-node-conf/controller_node_local_controller.conf":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"1ba2af70b3618082107457958f00ff2b05075b9b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"disable_service n-net"},{"line_number":31,"context_line":"enable_service q-svc"},{"line_number":32,"context_line":"enable_service df-l3-agent"},{"line_number":33,"context_line":"disable_service heat"},{"line_number":34,"context_line":"disable_service tempest"},{"line_number":35,"context_line":""}],"source_content_type":"text/plain","patch_set":11,"id":"ba0121b8_0327ff12","line":32,"range":{"start_line":32,"start_character":17,"end_line":32,"end_character":18},"updated":"2016-03-29 15:17:41.000000000","message":"Please add \n[[post-config|$NEUTRON_CONF]]\n[DEFAULT]\nrouter_distributed\u003dTrue","commit_id":"7b945d03f86ad8c841a0be3e15de652df218e851"}],"doc/source/multi-node-conf/network_node_local_controller.conf":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"7ae79d915fa42a35c192f456d8ddd6811fe7d660","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Sample DevStack local.conf."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This sample file is intended to be used when adding an additional compute node"},{"line_number":5,"context_line":"# to your test environment.  It runs a very minimal set of services."}],"source_content_type":"text/plain","patch_set":8,"id":"fa0719c6_8dd47fbd","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":29},"updated":"2016-03-23 13:07:34.000000000","message":"I think it can be confusing this way it is missing the controller conf with out the l3 agent and \n\nCurrently all our sample files are two node deployment Compute and Network+Controller\n\nIf we want a 3 node setup we better create a another  sample directory","commit_id":"f012a5ad37c77e61b49d5ec6a4c4b607921ef270"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"8e88f5bde1cdd0a9aed7ae91ca3545f8ebd9972f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Sample DevStack local.conf."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This sample file is intended to be used when adding an additional compute node"},{"line_number":5,"context_line":"# to your test environment.  It runs a very minimal set of services."}],"source_content_type":"text/plain","patch_set":8,"id":"fa0719c6_d53ff6b1","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":29},"in_reply_to":"fa0719c6_8dd47fbd","updated":"2016-03-24 01:52:49.000000000","message":"yes, I miss changing the description. and I will provide more detailed description. The network node is a logical node. it can be deployed on the same host node with a controller node or compute node. or it\u0027s deployed on an independent host node.\n\nWherever the network is deployed, what you need to do is just to enable the df-l3-agent insteading of neutron-l3-agent.","commit_id":"f012a5ad37c77e61b49d5ec6a4c4b607921ef270"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"7ae79d915fa42a35c192f456d8ddd6811fe7d660","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Sample DevStack local.conf."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This sample file is intended to be used when adding an additional compute node"},{"line_number":5,"context_line":"# to your test environment.  It runs a very minimal set of services."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# For this configuration to work, you *must* set the SERVICE_HOST option to the"}],"source_content_type":"text/plain","patch_set":8,"id":"fa0719c6_6d064b87","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":80},"updated":"2016-03-23 13:07:34.000000000","message":"This is for the network node","commit_id":"f012a5ad37c77e61b49d5ec6a4c4b607921ef270"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"8e88f5bde1cdd0a9aed7ae91ca3545f8ebd9972f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Sample DevStack local.conf."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This sample file is intended to be used when adding an additional compute node"},{"line_number":5,"context_line":"# to your test environment.  It runs a very minimal set of services."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# For this configuration to work, you *must* set the SERVICE_HOST option to the"}],"source_content_type":"text/plain","patch_set":8,"id":"fa0719c6_15468e4e","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":80},"in_reply_to":"fa0719c6_6d064b87","updated":"2016-03-24 01:52:49.000000000","message":"will do","commit_id":"f012a5ad37c77e61b49d5ec6a4c4b607921ef270"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"5715b7c949e0054ebc777c90972ec0d0c77af9f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# independent host node too."},{"line_number":7,"context_line":"# Wherever the network is deployed, you need to enable the df-l3-agent insteading"},{"line_number":8,"context_line":"# of neutron-l3-agent."},{"line_number":9,"context_line":"# This sample file is intended to be used when df-l3-agent is deployed on the "},{"line_number":10,"context_line":"# controller node."},{"line_number":11,"context_line":"# to your test environment.  It runs a very minimal set of services."},{"line_number":12,"context_line":"#"}],"source_content_type":"text/plain","patch_set":9,"id":"fa0719c6_41fcc43d","line":9,"range":{"start_line":9,"start_character":77,"end_line":9,"end_character":78},"updated":"2016-03-24 05:48:32.000000000","message":"please move the trialing white space","commit_id":"d9ac224dae71b97a3e97f222489a90f156262a23"}],"dragonflow/cmd/eventlet/__init__.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0498181e908dd7e54850ddee40e2f2b9171e451d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.common import eventlet_utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"eventlet_utils.monkey_patch()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_0f575503","line":15,"updated":"2016-03-20 20:41:27.000000000","message":"This was already done in https://review.openstack.org/#/c/257838/. Consider basing this patch on that.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"},{"author":{"_account_id":11364,"name":"Fei Rao","email":"milo.frao@gmail.com","username":"milo.frao"},"change_message_id":"40bea8170ab95103c090af46513334e895cf60f5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.common import eventlet_utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"eventlet_utils.monkey_patch()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_1a41520c","line":15,"in_reply_to":"fa0719c6_0f575503","updated":"2016-03-21 04:57:37.000000000","message":"Yes, Omer. We can do it as you mentioned. Now we keep this file is because Ma Li\u0027s patch has not merged into master still, if this file get removed, the df-l3-agent will cannot be started correctly.","commit_id":"95d13e355e527e5b938784c07686c6ce6bb6918a"}]}