)]}'
{"devstack/ovs_manager.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"4e8d6c9c0a527e4b13a288d1dedf7cc4fe661e6c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function stop_ovs"},{"line_number":152,"context_line":"{"},{"line_number":153,"context_line":"    cleanup_ovs"},{"line_number":154,"context_line":"    stop_ovs_dp"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    SERVICE_NAME\u003dopenvswitch  # Default value"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba0121b8_9d9f0303","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":15},"updated":"2016-03-29 09:02:29.000000000","message":"I think this should be called from the plugin explicitly and not form here","commit_id":"0892e37ba65c139063ee91d3ded98fc2fcd6b632"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"79981653fdafc8d694d952a898dd6eb70dc2d624","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function stop_ovs"},{"line_number":152,"context_line":"{"},{"line_number":153,"context_line":"    cleanup_ovs"},{"line_number":154,"context_line":"    stop_ovs_dp"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    SERVICE_NAME\u003dopenvswitch  # Default value"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba0121b8_8981854d","line":153,"range":{"start_line":153,"start_character":4,"end_line":153,"end_character":15},"in_reply_to":"ba0121b8_9d9f0303","updated":"2016-03-29 09:55:38.000000000","message":"Done","commit_id":"0892e37ba65c139063ee91d3ded98fc2fcd6b632"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"a75631abeb3fe6c72bb34f0d84c9e93f40b184ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"OVS_INSTALL_FROM_GIT\u003d${OVS_INSTALL_FROM_GIT:-\"True\"}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_ad4a60c3","line":1,"updated":"2016-03-30 07:08:25.000000000","message":"I would rename this file to ovs_setup, ovs_manager sounds a bit strange to me.\n(not critical comment, can stay as it is)","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58ab8b301aed37a6cd9a4797d137b54380850644","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"OVS_INSTALL_FROM_GIT\u003d${OVS_INSTALL_FROM_GIT:-\"True\"}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_682c9d02","line":1,"in_reply_to":"ba0121b8_ad4a60c3","updated":"2016-03-30 13:12:17.000000000","message":"Done","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"}],"devstack/plugin.sh":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"4e8d6c9c0a527e4b13a288d1dedf7cc4fe661e6c","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":352,"context_line":"        stop_df"},{"line_number":353,"context_line":"        stop_ovs"},{"line_number":354,"context_line":"        if [[ \"$DF_PUB_SUB\" \u003d\u003d \"True\" ]]; then"},{"line_number":355,"context_line":"            stop_pubsub_service"},{"line_number":356,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba0121b8_9de8a37e","line":353,"range":{"start_line":353,"start_character":8,"end_line":353,"end_character":16},"updated":"2016-03-29 09:02:29.000000000","message":"I think that we should call clean up explicitly here and not in the stop_ovs for the following reasons \n1) The functionality of the function will be clearer \n2) We continue to follow the same logic as before \n3) We can use stop_ovs for restart that will not clean the DB in the future","commit_id":"0892e37ba65c139063ee91d3ded98fc2fcd6b632"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"79981653fdafc8d694d952a898dd6eb70dc2d624","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    if [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":352,"context_line":"        stop_df"},{"line_number":353,"context_line":"        stop_ovs"},{"line_number":354,"context_line":"        if [[ \"$DF_PUB_SUB\" \u003d\u003d \"True\" ]]; then"},{"line_number":355,"context_line":"            stop_pubsub_service"},{"line_number":356,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ba0121b8_e9964193","line":353,"range":{"start_line":353,"start_character":8,"end_line":353,"end_character":16},"in_reply_to":"ba0121b8_9de8a37e","updated":"2016-03-29 09:55:38.000000000","message":"Done","commit_id":"0892e37ba65c139063ee91d3ded98fc2fcd6b632"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"a75631abeb3fe6c72bb34f0d84c9e93f40b184ef","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        sudo ovs-vsctl del-port ${port}"},{"line_number":82,"context_line":"    done"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":85,"context_line":"    cd $DEST/$OVS_REPO_NAME"},{"line_number":86,"context_line":"    sudo make uninstall"},{"line_number":87,"context_line":"    cd $_pwd"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_ad78a0f3","side":"PARENT","line":84,"updated":"2016-03-30 07:08:25.000000000","message":"I havent seen you call this uninstall on unstack, i think we want to remove our installation on unstack and also remove the service","commit_id":"e6fcdafe8a8c1219a1b0458f77a9d6e12be3aadd"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"a75631abeb3fe6c72bb34f0d84c9e93f40b184ef","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"function start_ovs {"},{"line_number":220,"context_line":"    echo \"Starting OVS\""},{"line_number":221,"context_line":"    SERVICE_NAME\u003dopenvswitch  # Default value"},{"line_number":222,"context_line":"    if is_fedora; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_2dff7068","line":219,"updated":"2016-03-30 07:08:25.000000000","message":"If there is already an OVS specific file i think its best to move all OVS related method to it","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58ab8b301aed37a6cd9a4797d137b54380850644","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":"}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"function start_ovs {"},{"line_number":220,"context_line":"    echo \"Starting OVS\""},{"line_number":221,"context_line":"    SERVICE_NAME\u003dopenvswitch  # Default value"},{"line_number":222,"context_line":"    if is_fedora; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_284bc5ca","line":219,"in_reply_to":"ba0121b8_2dff7068","updated":"2016-03-30 13:12:17.000000000","message":"Done","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"a75631abeb3fe6c72bb34f0d84c9e93f40b184ef","unresolved":false,"context_lines":[{"line_number":315,"context_line":"if [[ \"$Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER\" \u003d\u003d \"True\" ]]; then"},{"line_number":316,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":317,"context_line":"        if [[ \"$OFFLINE\" !\u003d \"True\" ]]; then"},{"line_number":318,"context_line":"            install_neutron"},{"line_number":319,"context_line":"            install_df"},{"line_number":320,"context_line":"            install_ovs"},{"line_number":321,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_8dd79cec","line":318,"updated":"2016-03-30 07:08:25.000000000","message":"if ! is_neutron_enabled ; then\n        install_neutron\n    fi","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58ab8b301aed37a6cd9a4797d137b54380850644","unresolved":false,"context_lines":[{"line_number":315,"context_line":"if [[ \"$Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER\" \u003d\u003d \"True\" ]]; then"},{"line_number":316,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":317,"context_line":"        if [[ \"$OFFLINE\" !\u003d \"True\" ]]; then"},{"line_number":318,"context_line":"            install_neutron"},{"line_number":319,"context_line":"            install_df"},{"line_number":320,"context_line":"            install_ovs"},{"line_number":321,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_c885e9ad","line":318,"in_reply_to":"ba0121b8_8dd79cec","updated":"2016-03-30 13:12:17.000000000","message":"I don\u0027t think that\u0027s right - we always need neutron, even if none of its services where explicitly requested. dragonflow relies on it.","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"3b14a4c1341b90f50c252017c1ab79ca33326488","unresolved":false,"context_lines":[{"line_number":315,"context_line":"if [[ \"$Q_ENABLE_DRAGONFLOW_LOCAL_CONTROLLER\" \u003d\u003d \"True\" ]]; then"},{"line_number":316,"context_line":"    if [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":317,"context_line":"        if [[ \"$OFFLINE\" !\u003d \"True\" ]]; then"},{"line_number":318,"context_line":"            install_neutron"},{"line_number":319,"context_line":"            install_df"},{"line_number":320,"context_line":"            install_ovs"},{"line_number":321,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_baea420d","line":318,"in_reply_to":"ba0121b8_c885e9ad","updated":"2016-03-31 11:32:36.000000000","message":"if neutron is already enabled it is installed by devstack no need to re-install it twice, especially when we dont know the order of things","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"}],"dragonflow/tests/contrib/post_test_hook.sh":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"a75631abeb3fe6c72bb34f0d84c9e93f40b184ef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"owner\u003dstack"},{"line_number":41,"context_line":"sudo_env\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"sudo pip uninstall -y virtualenv"},{"line_number":44,"context_line":"sudo pip install virtualenv\u003d\u003d15.0.1"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Set owner permissions according to job\u0027s requirements."}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_cdca341a","line":43,"updated":"2016-03-30 07:08:25.000000000","message":"Maybe add a comment why we do this, also have you tried just changing test-requirements for this version instead of doing this here?","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"58ab8b301aed37a6cd9a4797d137b54380850644","unresolved":false,"context_lines":[{"line_number":40,"context_line":"owner\u003dstack"},{"line_number":41,"context_line":"sudo_env\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"sudo pip uninstall -y virtualenv"},{"line_number":44,"context_line":"sudo pip install virtualenv\u003d\u003d15.0.1"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Set owner permissions according to job\u0027s requirements."}],"source_content_type":"text/x-sh","patch_set":7,"id":"ba0121b8_a8451571","line":43,"in_reply_to":"ba0121b8_cdca341a","updated":"2016-03-30 13:12:17.000000000","message":"Will add the comment.\nFrom what I understood from the infra guys, the test-requirements file is looked at after the virtualenv is set-up, which is too late for the issue I\u0027m trying to work around.","commit_id":"29a9abe6a2d9b34db28d6d8b942d0598478391ee"}]}