)]}'
{"dragonflow/db/drivers/ovsdb_vswitch_impl.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"400512a416a1537e53b5ea85d1e167079b673ced","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027uuid\u0027,"},{"line_number":42,"context_line":"        \u0027ofport\u0027,"},{"line_number":43,"context_line":"        \u0027name\u0027,"},{"line_number":44,"context_line":"        \u0027admin_state\u0027,"},{"line_number":45,"context_line":"        \u0027type\u0027,"},{"line_number":46,"context_line":"        \u0027external_ids\u0027,"},{"line_number":47,"context_line":"        \u0027options\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b9aeed7e","line":44,"range":{"start_line":44,"start_character":9,"end_line":44,"end_character":20},"updated":"2016-04-06 13:53:30.000000000","message":"missing bridge","commit_id":"054f26d3df3eaf6f9f67be14f7bf1e8c02b301ea"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"77cf78f19a4af77b70eadce78fe78158b2a1618e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027external_ids\u0027,"},{"line_number":48,"context_line":"        \u0027options\u0027,"},{"line_number":49,"context_line":"    ],"},{"line_number":50,"context_line":"    \u0027Bridge\u0027: ["},{"line_number":51,"context_line":"        \u0027ports\u0027"},{"line_number":52,"context_line":"    ],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_83d6ebee","line":52,"range":{"start_line":50,"start_character":4,"end_line":52,"end_character":6},"updated":"2016-04-07 08:55:40.000000000","message":"why monitor Bridge table, I think Interface is enough","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"369288738f2c91decfaa7ed4372c99818986a9e8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027external_ids\u0027,"},{"line_number":48,"context_line":"        \u0027options\u0027,"},{"line_number":49,"context_line":"    ],"},{"line_number":50,"context_line":"    \u0027Bridge\u0027: ["},{"line_number":51,"context_line":"        \u0027ports\u0027"},{"line_number":52,"context_line":"    ],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_affdd16f","line":52,"range":{"start_line":50,"start_character":4,"end_line":52,"end_character":6},"in_reply_to":"9a061dce_83d6ebee","updated":"2016-04-07 09:05:02.000000000","message":"Because we need it in the local cache \nWe do query on the Bridge info","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"45851114c1c1ffdcc4fdb35fb254e93cd5a93afa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027external_ids\u0027,"},{"line_number":48,"context_line":"        \u0027options\u0027,"},{"line_number":49,"context_line":"    ],"},{"line_number":50,"context_line":"    \u0027Bridge\u0027: ["},{"line_number":51,"context_line":"        \u0027ports\u0027"},{"line_number":52,"context_line":"    ],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_cf8765b3","line":52,"range":{"start_line":50,"start_character":4,"end_line":52,"end_character":6},"in_reply_to":"9a061dce_affdd16f","updated":"2016-04-07 09:08:36.000000000","message":"Interface table also contains the bridge Info, what external bridge info do we need in Bridge Table?","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a38fffefff3ee04026451d95f030d2f5af82225e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027external_ids\u0027,"},{"line_number":48,"context_line":"        \u0027options\u0027,"},{"line_number":49,"context_line":"    ],"},{"line_number":50,"context_line":"    \u0027Bridge\u0027: ["},{"line_number":51,"context_line":"        \u0027ports\u0027"},{"line_number":52,"context_line":"    ],"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_fe98157a","line":52,"range":{"start_line":50,"start_character":4,"end_line":52,"end_character":6},"in_reply_to":"9a061dce_cf8765b3","updated":"2016-04-07 10:17:45.000000000","message":"Bridge table is accessed directly via IDL. I think the schema helper needs it for it to appear in the idl.","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"cc5b4c6a7f81ac09d922516e7779b6106fae7f8a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class Connection(connection.Connection):"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    Extend the Neutron OVS Connection class to support being given the IDL"},{"line_number":59,"context_line":"    schema externally or manually."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_2fe541a7","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":16},"updated":"2016-04-07 09:16:42.000000000","message":"I would call it DFConnection \n\nIt is quit confusing connection that i iheratense form another connection","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a38fffefff3ee04026451d95f030d2f5af82225e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class Connection(connection.Connection):"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":"    Extend the Neutron OVS Connection class to support being given the IDL"},{"line_number":59,"context_line":"    schema externally or manually."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_3e9f2d60","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":16},"in_reply_to":"9a061dce_2fe541a7","updated":"2016-04-07 10:17:45.000000000","message":"Done","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"cc5b4c6a7f81ac09d922516e7779b6106fae7f8a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _get_schema_helper(self):"},{"line_number":68,"context_line":"        if self._schema_helper:"},{"line_number":69,"context_line":"            return self._schema_helper"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"},{"line_number":72,"context_line":"                                                self.schema_name)"},{"line_number":73,"context_line":"        except Exception:"},{"line_number":74,"context_line":"            # We may have failed do to set-manager not being called"},{"line_number":75,"context_line":"            helpers.enable_connection_uri(self.connection)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":78,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":79,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":80,"context_line":"            def do_get_schema_helper():"},{"line_number":81,"context_line":"                return idlutils.get_schema_helper(self.connection,"},{"line_number":82,"context_line":"                                                  self.schema_name)"},{"line_number":83,"context_line":"            helper \u003d do_get_schema_helper()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        helper.register_all()"},{"line_number":86,"context_line":"        return helper"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def start(self):"},{"line_number":89,"context_line":"        with self.lock:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_32f126ce","line":86,"range":{"start_line":70,"start_character":8,"end_line":86,"end_character":21},"updated":"2016-04-07 09:16:42.000000000","message":"Do we really need this code, the all point was that we want o pass our own schema and we pass it so why do we want o support this case just return an error saying that you should use the neutron class for that use case","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a38fffefff3ee04026451d95f030d2f5af82225e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _get_schema_helper(self):"},{"line_number":68,"context_line":"        if self._schema_helper:"},{"line_number":69,"context_line":"            return self._schema_helper"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            helper \u003d idlutils.get_schema_helper(self.connection,"},{"line_number":72,"context_line":"                                                self.schema_name)"},{"line_number":73,"context_line":"        except Exception:"},{"line_number":74,"context_line":"            # We may have failed do to set-manager not being called"},{"line_number":75,"context_line":"            helpers.enable_connection_uri(self.connection)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # There is a small window for a race, so retry up to a second"},{"line_number":78,"context_line":"            @retrying.retry(wait_exponential_multiplier\u003d10,"},{"line_number":79,"context_line":"                            stop_max_delay\u003d1000)"},{"line_number":80,"context_line":"            def do_get_schema_helper():"},{"line_number":81,"context_line":"                return idlutils.get_schema_helper(self.connection,"},{"line_number":82,"context_line":"                                                  self.schema_name)"},{"line_number":83,"context_line":"            helper \u003d do_get_schema_helper()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        helper.register_all()"},{"line_number":86,"context_line":"        return helper"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def start(self):"},{"line_number":89,"context_line":"        with self.lock:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_1e9a296e","line":86,"range":{"start_line":70,"start_character":8,"end_line":86,"end_character":21},"in_reply_to":"9a061dce_32f126ce","updated":"2016-04-07 10:17:45.000000000","message":"Done","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"77cf78f19a4af77b70eadce78fe78158b2a1618e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.ovsdb_monitor_table_filter \u003d ovsdb_monitor_table_filter_default"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_schema_helper(self, tables\u003d\u0027all\u0027):"},{"line_number":119,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            helper \u003d idlutils.get_schema_helper(db_connection,"},{"line_number":122,"context_line":"                                                self.db_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_230a7f79","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":74},"updated":"2016-04-07 08:55:40.000000000","message":"why change back to ip socket instead of unix socket","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a38fffefff3ee04026451d95f030d2f5af82225e","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.ovsdb_monitor_table_filter \u003d ovsdb_monitor_table_filter_default"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_schema_helper(self, tables\u003d\u0027all\u0027):"},{"line_number":119,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            helper \u003d idlutils.get_schema_helper(db_connection,"},{"line_number":122,"context_line":"                                                self.db_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_de7a7123","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":74},"in_reply_to":"9a061dce_230a7f79","updated":"2016-04-07 10:17:45.000000000","message":"Due to https://bugs.launchpad.net/dragonflow/+bug/1567248.","commit_id":"ad787fbda7a8cc21f9a79971508026521823704f"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"e6c68c84c06fe9b27c15aee2ed5ba70e8b85823d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.idl \u003d None"},{"line_number":98,"context_line":"        self.nb_api \u003d nb_api"},{"line_number":99,"context_line":"        self.ovsdb_monitor \u003d None"},{"line_number":100,"context_line":"        self.ovsdb_monitor_table_filter \u003d ovsdb_monitor_table_filter_default"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _get_schema_helper(self, tables\u003d\u0027all\u0027):"},{"line_number":103,"context_line":"        db_connection \u003d (\u0027%s:%s:%s\u0027 % (self.protocol, self.ip, self.port))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_0e76766f","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":76},"updated":"2016-04-07 11:31:18.000000000","message":"Please remove it is not used","commit_id":"2ca38a7dbc9e2bac4815e0274ba6cfd72a908a34"}]}