)]}'
{"dragonflow/db/api_nb.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"15a6ec5ed25ff0bf4b325df123eda64eba43c93f","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                self.controller.publisher_deleted(key)"},{"line_number":229,"context_line":"        elif \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":230,"context_line":"            if action \u003d\u003d \u0027update\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":231,"context_line":"                ovs_port \u003d OvsPort(value)"},{"line_number":232,"context_line":"                self.controller.ovs_port_updated(ovs_port)"},{"line_number":233,"context_line":"            elif action \u003d\u003d \u0027sync_finished\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_b61168b2","line":230,"range":{"start_line":230,"start_character":26,"end_line":230,"end_character":32},"updated":"2016-04-10 13:55:47.000000000","message":"I looked in the code and we are only sending  create\n\nDid you find a flow that we are sending update ?","commit_id":"1f0a71be562aa83ceb41376fac8c33b1986bb5b1"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"aebe0be7507cf04c464bc8f4198ea97726969ceb","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                self.controller.publisher_deleted(key)"},{"line_number":229,"context_line":"        elif \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":230,"context_line":"            if action \u003d\u003d \u0027update\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":231,"context_line":"                ovs_port \u003d OvsPort(value)"},{"line_number":232,"context_line":"                self.controller.ovs_port_updated(ovs_port)"},{"line_number":233,"context_line":"            elif action \u003d\u003d \u0027sync_finished\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_a5c008e2","line":230,"range":{"start_line":230,"start_character":26,"end_line":230,"end_character":32},"updated":"2016-04-11 02:30:35.000000000","message":"We\u0027d better use the same naming style. So I think \"set\" is better than \"update\" and adapting the name should be done in OVSDBMonitor","commit_id":"1f0a71be562aa83ceb41376fac8c33b1986bb5b1"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0d1053d19d0fb1a284785efae1de18789fd99fe5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                self.controller.publisher_deleted(key)"},{"line_number":229,"context_line":"        elif \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":230,"context_line":"            if action \u003d\u003d \u0027update\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":231,"context_line":"                ovs_port \u003d OvsPort(value)"},{"line_number":232,"context_line":"                self.controller.ovs_port_updated(ovs_port)"},{"line_number":233,"context_line":"            elif action \u003d\u003d \u0027sync_finished\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_b0516811","line":230,"range":{"start_line":230,"start_character":26,"end_line":230,"end_character":32},"in_reply_to":"7a1b2928_a5c008e2","updated":"2016-04-11 02:42:47.000000000","message":"All right. thanks for your suggestion. i\u0027ll upload a ps, following your idea. But firstly, this bug needs to be confirmed by others. Although the fix is very simple, I\u0027m not sure if it will bring some side-effect. I\u0027d like to listen to others opinions on this bug.","commit_id":"1f0a71be562aa83ceb41376fac8c33b1986bb5b1"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"1031fcbbf9be7c1822b44ce8aa1e783e386dad49","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                self.controller.publisher_deleted(key)"},{"line_number":229,"context_line":"        elif \u0027ovsinterface\u0027 \u003d\u003d table:"},{"line_number":230,"context_line":"            if action \u003d\u003d \u0027update\u0027 or action \u003d\u003d \u0027create\u0027:"},{"line_number":231,"context_line":"                ovs_port \u003d OvsPort(value)"},{"line_number":232,"context_line":"                self.controller.ovs_port_updated(ovs_port)"},{"line_number":233,"context_line":"            elif action \u003d\u003d \u0027sync_finished\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_6a907fed","line":230,"range":{"start_line":230,"start_character":26,"end_line":230,"end_character":32},"in_reply_to":"7a1b2928_b61168b2","updated":"2016-04-11 01:07:20.000000000","message":"Yes. As I described in the bug thread, we rely on update event to configure logical port.\nhttps://github.com/openstack/dragonflow/blob/master/dragonflow/db/drivers/ovsdb_vswitch_impl.py#L398\nhttps://github.com/openstack/dragonflow/blob/master/dragonflow/db/drivers/ovsdb_vswitch_impl.py#L382","commit_id":"1f0a71be562aa83ceb41376fac8c33b1986bb5b1"}]}
