)]}'
{"dragonflow/tests/fullstack/test_objects.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"6f56f75cb085b2e7842bb82699a21aac0edcf47f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_VM_port(self):"},{"line_number":238,"context_line":"        ports \u003d self.neutron.list_ports()"},{"line_number":239,"context_line":"        if not ports:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        for port in ports[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_332e8dfa","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":39},"updated":"2016-04-25 17:19:56.000000000","message":"I think you can directly add a filter to list_ports().","commit_id":"18aa7f98064fe6136c8bf74b550f81a3590815eb"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a56a32751dc5981d0e9d3edcbff3717c3b5430bd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        )"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def _get_VM_port(self):"},{"line_number":238,"context_line":"        ports \u003d self.neutron.list_ports()"},{"line_number":239,"context_line":"        if not ports:"},{"line_number":240,"context_line":"            return None"},{"line_number":241,"context_line":"        for port in ports[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_8e35b847","line":238,"range":{"start_line":238,"start_character":29,"end_line":238,"end_character":39},"in_reply_to":"1a122d0e_332e8dfa","updated":"2016-04-25 17:53:19.000000000","message":"I\u0027ll verify. If so, I will make the change.","commit_id":"18aa7f98064fe6136c8bf74b550f81a3590815eb"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"24e8b48cb4dc53924b63634e944f3a637730eec9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return networks[0]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_port_by_mac(neutron, vm_mac):"},{"line_number":44,"context_line":"    ports \u003d neutron.list_ports(mac_address\u003dvm_mac)"},{"line_number":45,"context_line":"    if ports is None:"},{"line_number":46,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_08d1b2fb","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":19},"updated":"2016-05-04 12:31:14.000000000","message":"this function isn\u0027t needed now. You can delete it.","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ddaf0520379dd08f4b12ac2de49765eb5df85769","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    return networks[0]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def get_port_by_mac(neutron, vm_mac):"},{"line_number":44,"context_line":"    ports \u003d neutron.list_ports(mac_address\u003dvm_mac)"},{"line_number":45,"context_line":"    if ports is None:"},{"line_number":46,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_83128fb2","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":19},"in_reply_to":"1a122d0e_08d1b2fb","updated":"2016-05-05 12:09:21.000000000","message":"I can. But it may be useful in the future. I don\u0027t mind either way.\n\nWhatever the consensus decides. In any case, if we keep it, it has to be written correctly. :)","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"d60f34cebd4fbd2eabf2f9996ab0aad1ebfbc37c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    ports \u003d neutron.list_ports(mac_address\u003dvm_mac)"},{"line_number":45,"context_line":"    if ports is None:"},{"line_number":46,"context_line":"        return None"},{"line_number":47,"context_line":"    for port in ports[\u0027ports\u0027]:"},{"line_number":48,"context_line":"        if vm_mac \u003d\u003d port[\u0027mac_address\u0027]:"},{"line_number":49,"context_line":"            return port"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class RouterTestObj(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ec5c58f2","line":49,"range":{"start_line":47,"start_character":4,"end_line":49,"end_character":23},"updated":"2016-05-04 06:08:06.000000000","message":"are these lines necessary here? why not return ports[0] if len(ports) \u003e 0.","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"8e52a5fb5d9b6f59e44314a474619f223e7eacf8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    ports \u003d neutron.list_ports(mac_address\u003dvm_mac)"},{"line_number":45,"context_line":"    if ports is None:"},{"line_number":46,"context_line":"        return None"},{"line_number":47,"context_line":"    for port in ports[\u0027ports\u0027]:"},{"line_number":48,"context_line":"        if vm_mac \u003d\u003d port[\u0027mac_address\u0027]:"},{"line_number":49,"context_line":"            return port"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class RouterTestObj(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_d95caf7f","line":49,"range":{"start_line":47,"start_character":4,"end_line":49,"end_character":23},"in_reply_to":"1a122d0e_ec5c58f2","updated":"2016-05-04 11:53:35.000000000","message":"Done","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"24e8b48cb4dc53924b63634e944f3a637730eec9","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        ports \u003d self.neutron.list_ports(device_id\u003dserver_id)"},{"line_number":240,"context_line":"        if not ports:"},{"line_number":241,"context_line":"            return None"},{"line_number":242,"context_line":"        for port in ports[\u0027ports\u0027]:"},{"line_number":243,"context_line":"            if server_id \u003d\u003d port[\u0027device_id\u0027]:"},{"line_number":244,"context_line":"                return port"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def close(self):"},{"line_number":247,"context_line":"        if self.closed or self.server is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_888e6225","line":244,"range":{"start_line":242,"start_character":0,"end_line":244,"end_character":27},"updated":"2016-05-04 12:31:14.000000000","message":"just return ports[0]?","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ddaf0520379dd08f4b12ac2de49765eb5df85769","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        ports \u003d self.neutron.list_ports(device_id\u003dserver_id)"},{"line_number":240,"context_line":"        if not ports:"},{"line_number":241,"context_line":"            return None"},{"line_number":242,"context_line":"        for port in ports[\u0027ports\u0027]:"},{"line_number":243,"context_line":"            if server_id \u003d\u003d port[\u0027device_id\u0027]:"},{"line_number":244,"context_line":"                return port"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def close(self):"},{"line_number":247,"context_line":"        if self.closed or self.server is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_03279f12","line":244,"range":{"start_line":242,"start_character":0,"end_line":244,"end_character":27},"in_reply_to":"1a122d0e_888e6225","updated":"2016-05-05 12:09:21.000000000","message":"Done","commit_id":"b507481eb2b07bfce24fbcebb769dcda34625ae9"}]}
