)]}'
{"dragonflow/db/pubsub_drivers/redis_db_pubsub_driver.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"291b2577f7660577bdd10041ca8ee8b41de4f89f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.ip \u003d ip_port[0]"},{"line_number":96,"context_line":"        self.plugin_updates_port \u003d ip_port[1]"},{"line_number":97,"context_line":"        self.pub_sub \u003d self.client.pubsub()"},{"line_number":98,"context_line":"        self.register_topic(db_common.SEND_ALL_TOPIC)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def register_listen_address(self, uri):"},{"line_number":101,"context_line":"        super(RedisSubscriberAgent, self).register_listen_address(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7953e86c","line":98,"updated":"2016-05-04 05:36:38.000000000","message":"Isnt it better to include this in the base class? I think all subscribers will want to register to ALL_TOPIC","commit_id":"485975eecc03b1f85435a61fc1d3b486d40ab488"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"3b5c6a475739597d809b9a2bff672deb6d1a1891","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.ip \u003d ip_port[0]"},{"line_number":96,"context_line":"        self.plugin_updates_port \u003d ip_port[1]"},{"line_number":97,"context_line":"        self.pub_sub \u003d self.client.pubsub()"},{"line_number":98,"context_line":"        self.register_topic(db_common.SEND_ALL_TOPIC)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def register_listen_address(self, uri):"},{"line_number":101,"context_line":"        super(RedisSubscriberAgent, self).register_listen_address(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d9c83c24","line":98,"in_reply_to":"1a122d0e_7953e86c","updated":"2016-05-04 05:37:11.000000000","message":"Also we should start adding unit tests that verify things like that","commit_id":"485975eecc03b1f85435a61fc1d3b486d40ab488"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0d859fdc48b990e25f0b3ee149511bffcc0851c5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.ip \u003d ip_port[0]"},{"line_number":96,"context_line":"        self.plugin_updates_port \u003d ip_port[1]"},{"line_number":97,"context_line":"        self.pub_sub \u003d self.client.pubsub()"},{"line_number":98,"context_line":"        self.register_topic(db_common.SEND_ALL_TOPIC)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def register_listen_address(self, uri):"},{"line_number":101,"context_line":"        super(RedisSubscriberAgent, self).register_listen_address(uri)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f90b6b7b","line":98,"in_reply_to":"1a122d0e_d9c83c24","updated":"2016-05-04 11:52:03.000000000","message":"\u003e Isnt it better to include this in the base class? I think all subscribers will want to register to ALL_TOPIC\n\nIf anything, the caller should do it. I\u0027ll modify the patch to have the caller call register_topic, and remove the identical line from the zmq implementation.\n\n\u003e Also we should start adding unit tests that verify things like that\n\nThe fullstack tests don\u0027t include redis yet. I understand that there is a plan to add a fullstack test with redis set-up.","commit_id":"485975eecc03b1f85435a61fc1d3b486d40ab488"}]}