)]}'
{"devstack/zookeeper_driver":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"87c5e38a306c84b4c2bbf10292f20f3d7aa42fe2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            install_package \"zookeeperd\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":37,"context_line":"                sudo systemctl stop zookeeper.service || true"},{"line_number":38,"context_line":"                sudo cp $DEST/dragonflow/devstack/zookeeper.service /etc/systemd/system/"},{"line_number":39,"context_line":"                sudo systemctl daemon-reload"},{"line_number":40,"context_line":"            else "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_041b4874","line":37,"updated":"2016-05-15 19:03:15.000000000","message":"Won\u0027t \u0027service zookeeper stop\u0027 work here? If it does, it could make this code a little simpler.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e75cb3c9e8a3daa9b2845926054d5204b7a3946e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            install_package \"zookeeperd\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":37,"context_line":"                sudo systemctl stop zookeeper.service || true"},{"line_number":38,"context_line":"                sudo cp $DEST/dragonflow/devstack/zookeeper.service /etc/systemd/system/"},{"line_number":39,"context_line":"                sudo systemctl daemon-reload"},{"line_number":40,"context_line":"            else "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_0a186f1d","line":37,"in_reply_to":"dab17558_041b4874","updated":"2016-05-16 00:53:00.000000000","message":"Yes, it won\u0027t work. I\u0027m using Ubuntu 16.04 server.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"e2c09015ed5bfd7e932bbb7ffb80fb2f194b639b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Make sure the cluster is set up correctly"},{"line_number":52,"context_line":"            sudo sed -i \"/^server.1\u003d/c server.1\u003d${HOSTNAME}:2888:3888\" $ZOOKEEPER_CONF_FILE"},{"line_number":53,"context_line":"            sudo sed -i \"/^#server.1\u003d/c server.1\u003d${HOSTNAME}:2888:3888\" $ZOOKEEPER_CONF_FILE"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            echo \"1\" | sudo tee $ZOOKEEPER_CONF_DIR/myid"},{"line_number":56,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_807efb67","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":92},"updated":"2016-05-16 07:05:05.000000000","message":"why do we need to run this line twice ? \nYou do it for the commented out lines ?","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"70d330bd4e99b99aa2012adb84dcedb24c357b95","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            # Make sure the cluster is set up correctly"},{"line_number":52,"context_line":"            sudo sed -i \"/^server.1\u003d/c server.1\u003d${HOSTNAME}:2888:3888\" $ZOOKEEPER_CONF_FILE"},{"line_number":53,"context_line":"            sudo sed -i \"/^#server.1\u003d/c server.1\u003d${HOSTNAME}:2888:3888\" $ZOOKEEPER_CONF_FILE"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            echo \"1\" | sudo tee $ZOOKEEPER_CONF_DIR/myid"},{"line_number":56,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_22443748","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":92},"in_reply_to":"dab17558_807efb67","updated":"2016-05-17 07:06:14.000000000","message":"Yes, there are two kind of format in zookeeper conf file.\nOne is starting with \u0027server.1\u0027, and the other is \u0027#server.1\u0027.\nI\u0027ll combine these two formats into one sed script and update it later.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"87c5e38a306c84b4c2bbf10292f20f3d7aa42fe2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":81,"context_line":"                sudo systemctl restart zookeeper.service"},{"line_number":82,"context_line":"            else"},{"line_number":83,"context_line":"                sudo service zookeeper restart"},{"line_number":84,"context_line":"            fi"},{"line_number":85,"context_line":"        fi"},{"line_number":86,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_640b3425","line":83,"updated":"2016-05-15 19:03:15.000000000","message":"Doesn\u0027t \u0027service zookeeper restart\u0027 cover ubuntu 16 as well?\n\nAdditionally, to be handled in another patch, it looks like there is not fedora support here.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e75cb3c9e8a3daa9b2845926054d5204b7a3946e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":81,"context_line":"                sudo systemctl restart zookeeper.service"},{"line_number":82,"context_line":"            else"},{"line_number":83,"context_line":"                sudo service zookeeper restart"},{"line_number":84,"context_line":"            fi"},{"line_number":85,"context_line":"        fi"},{"line_number":86,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_ea140bea","line":83,"in_reply_to":"dab17558_640b3425","updated":"2016-05-16 00:53:00.000000000","message":"Yes, I cannot find official package for fedora. If we need it, we can build from source for fedora distro.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"87c5e38a306c84b4c2bbf10292f20f3d7aa42fe2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":93,"context_line":"                sudo systemctl stop zookeeper.service || true"},{"line_number":94,"context_line":"            else"},{"line_number":95,"context_line":"                sudo service zookeeper stop || true"},{"line_number":96,"context_line":"            fi"},{"line_number":97,"context_line":"        fi"},{"line_number":98,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_c414a045","line":95,"updated":"2016-05-15 19:03:15.000000000","message":"Same here.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e75cb3c9e8a3daa9b2845926054d5204b7a3946e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"            if [ $UBUNTU_RELEASE_BASE_NUM -ge 16 ] ; then"},{"line_number":93,"context_line":"                sudo systemctl stop zookeeper.service || true"},{"line_number":94,"context_line":"            else"},{"line_number":95,"context_line":"                sudo service zookeeper stop || true"},{"line_number":96,"context_line":"            fi"},{"line_number":97,"context_line":"        fi"},{"line_number":98,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dab17558_4ad4371f","line":95,"in_reply_to":"dab17558_c414a045","updated":"2016-05-16 00:53:00.000000000","message":"Explained above.","commit_id":"9f3f313ac867c415fadde763340cbae325f33cb0"}]}