)]}'
{"dragonflow/controller/dhcp_app.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"481e1f24fb2fc8e88fc625321ee6e0338fa3f14f","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _get_port_mtu(self, lport):"},{"line_number":295,"context_line":"        # get network mtu from lport"},{"line_number":296,"context_line":"        mtu \u003d lport.get_mtu()"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        tunnel_type \u003d cfg.CONF.df.tunnel_type"},{"line_number":299,"context_line":"        if tunnel_type \u003d\u003d n_p_const.TYPE_VXLAN:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_0b6edc00","line":296,"range":{"start_line":296,"start_character":14,"end_line":296,"end_character":19},"updated":"2016-05-19 12:47:30.000000000","message":"Consider getting the MTU from the logical switch via _get_subnet_by_port(..)","commit_id":"63a1d83dd87d5b89c10131bbeeecbb54ee2f37f3"},{"author":{"_account_id":20336,"name":"heshan","email":"shan.he@huawei.com","username":"shanhe"},"change_message_id":"b40e8d78a5f1c9a1d9eb5b1b0589489007ac1d21","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (port_rate_limiter,"},{"line_number":106,"context_line":"            ofport_num,"},{"line_number":107,"context_line":"            lport_id) \u003d self.local_tunnel_to_pid_map[port_tunnel_key]"},{"line_number":108,"context_line":"        if port_rate_limiter():"},{"line_number":109,"context_line":"            self._block_port_dhcp_traffic("},{"line_number":110,"context_line":"                    ofport_num,"},{"line_number":111,"context_line":"                    self.block_hard_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_7806b521","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":28},"updated":"2016-05-27 07:26:36.000000000","message":"look into RateLimiter(), when the 4th packet in, the expression \u0027cTime - self.deque[0] \u003e self.time_unit\u0027 will always be true, so the funtion will return false forever, that\u0027s not what we want.","commit_id":"37c5e77f137fff0b0e96cb7600f31ea8c797a900"},{"author":{"_account_id":20336,"name":"heshan","email":"shan.he@huawei.com","username":"shanhe"},"change_message_id":"683d32925387b21c03bea711a07472a8eff5e9b7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (port_rate_limiter,"},{"line_number":106,"context_line":"            ofport_num,"},{"line_number":107,"context_line":"            lport_id) \u003d self.local_tunnel_to_pid_map[port_tunnel_key]"},{"line_number":108,"context_line":"        if port_rate_limiter():"},{"line_number":109,"context_line":"            self._block_port_dhcp_traffic("},{"line_number":110,"context_line":"                    ofport_num,"},{"line_number":111,"context_line":"                    self.block_hard_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_5800a301","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":28},"in_reply_to":"9abb7d3a_62e871e3","updated":"2016-05-31 01:55:26.000000000","message":"thx, I got what you mean.","commit_id":"37c5e77f137fff0b0e96cb7600f31ea8c797a900"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"fb8ae20942269d2b3b45e0da0635f6ee670bec2d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (port_rate_limiter,"},{"line_number":106,"context_line":"            ofport_num,"},{"line_number":107,"context_line":"            lport_id) \u003d self.local_tunnel_to_pid_map[port_tunnel_key]"},{"line_number":108,"context_line":"        if port_rate_limiter():"},{"line_number":109,"context_line":"            self._block_port_dhcp_traffic("},{"line_number":110,"context_line":"                    ofport_num,"},{"line_number":111,"context_line":"                    self.block_hard_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_c3cff6b1","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":28},"in_reply_to":"9abb7d3a_7806b521","updated":"2016-05-27 07:32:06.000000000","message":"Please try to discuss and fix it in another patch. This is not what this patch deals with.","commit_id":"37c5e77f137fff0b0e96cb7600f31ea8c797a900"},{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"02302be28edbc692b9316ba741374cb0232f97f9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        (port_rate_limiter,"},{"line_number":106,"context_line":"            ofport_num,"},{"line_number":107,"context_line":"            lport_id) \u003d self.local_tunnel_to_pid_map[port_tunnel_key]"},{"line_number":108,"context_line":"        if port_rate_limiter():"},{"line_number":109,"context_line":"            self._block_port_dhcp_traffic("},{"line_number":110,"context_line":"                    ofport_num,"},{"line_number":111,"context_line":"                    self.block_hard_timeout)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_62e871e3","line":108,"range":{"start_line":108,"start_character":11,"end_line":108,"end_character":28},"in_reply_to":"9abb7d3a_7806b521","updated":"2016-05-30 12:34:36.000000000","message":"The the leftmost value will be popped from the dqueue when reach maxlen","commit_id":"37c5e77f137fff0b0e96cb7600f31ea8c797a900"}],"dragonflow/neutron/plugin.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"481e1f24fb2fc8e88fc625321ee6e0338fa3f14f","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        tunnel_key \u003d self.nb_api.allocate_tunnel_key()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        # pass network mtu to its port"},{"line_number":649,"context_line":"        lswitch \u003d self.nb_api.get_lswitch(port[\u0027network_id\u0027],"},{"line_number":650,"context_line":"                                          port[\u0027tenant_id\u0027])"},{"line_number":651,"context_line":"        port_mtu \u003d lswitch.get_mtu()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # Router GW ports are not needed by dragonflow controller and"},{"line_number":654,"context_line":"        # they currently cause error as they couldnt be mapped to"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_6be1689a","line":651,"range":{"start_line":649,"start_character":8,"end_line":651,"end_character":36},"updated":"2016-05-19 12:47:30.000000000","message":"I am not sure we need to duplicate it in the port data.\nWe could get it in the dhcp app from the logical switch objectobjcet same as we get the dns servers and DHCP enable ...","commit_id":"63a1d83dd87d5b89c10131bbeeecbb54ee2f37f3"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"35a4bff12930cb4ed3d8946ee3a8348671d92e61","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        tunnel_key \u003d self.nb_api.allocate_tunnel_key()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        # pass network mtu to its port"},{"line_number":649,"context_line":"        lswitch \u003d self.nb_api.get_lswitch(port[\u0027network_id\u0027],"},{"line_number":650,"context_line":"                                          port[\u0027tenant_id\u0027])"},{"line_number":651,"context_line":"        port_mtu \u003d lswitch.get_mtu()"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # Router GW ports are not needed by dragonflow controller and"},{"line_number":654,"context_line":"        # they currently cause error as they couldnt be mapped to"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_0ddd4de0","line":651,"range":{"start_line":649,"start_character":8,"end_line":651,"end_character":36},"in_reply_to":"bab6814e_6be1689a","updated":"2016-05-19 13:58:20.000000000","message":"OK, thanks for advice. I\u0027ll fix it.","commit_id":"63a1d83dd87d5b89c10131bbeeecbb54ee2f37f3"},{"author":{"_account_id":20405,"name":"liuhaixia","email":"liuhaixia315@huawei.com","username":"liuhaixia"},"change_message_id":"2326e6dd1476f6959c36de94660b45dfdf5bb3ad","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                                   topic\u003dnetwork[\u0027tenant_id\u0027],"},{"line_number":389,"context_line":"                                   external_ids\u003dexternal_ids,"},{"line_number":390,"context_line":"                                   router_external\u003dnetwork[\u0027router:external\u0027],"},{"line_number":391,"context_line":"                                   mtu\u003dnetwork[\u0027mtu\u0027],"},{"line_number":392,"context_line":"                                   version\u003dnw_version,"},{"line_number":393,"context_line":"                                   subnets\u003d[])"},{"line_number":394,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_4af0b4fe","line":391,"range":{"start_line":391,"start_character":18,"end_line":391,"end_character":54},"updated":"2016-05-20 03:44:35.000000000","message":"If mtu in  api is none, is this also none here?\nBecause with ml2 plugin, if mtu is none, type driver will update it.But I don\u0027t see DFPlugin do this as what ml2 plugin do.","commit_id":"92b3dcec8837a29b48b7a2a84550eb0b31ab9ec0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"8ec83bebc21165113e7c167d5a121fb209df1101","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                                   topic\u003dnetwork[\u0027tenant_id\u0027],"},{"line_number":389,"context_line":"                                   external_ids\u003dexternal_ids,"},{"line_number":390,"context_line":"                                   router_external\u003dnetwork[\u0027router:external\u0027],"},{"line_number":391,"context_line":"                                   mtu\u003dnetwork[\u0027mtu\u0027],"},{"line_number":392,"context_line":"                                   version\u003dnw_version,"},{"line_number":393,"context_line":"                                   subnets\u003d[])"},{"line_number":394,"context_line":"        return network"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_7c7c4db5","line":391,"range":{"start_line":391,"start_character":18,"end_line":391,"end_character":54},"in_reply_to":"bab6814e_4af0b4fe","updated":"2016-05-20 13:39:04.000000000","message":"please check the net-mtu extension. mtu value cannot be set by user. it is automatically set by neutron server. the default value is 1500 defined as neutron constant.","commit_id":"92b3dcec8837a29b48b7a2a84550eb0b31ab9ec0"}],"dragonflow/tests/unit/test_topology.py":[{"author":{"_account_id":13070,"name":"Eran Gampel","email":"eran@gampel.net","username":"Gampel"},"change_message_id":"482af7e8daec2ccb15cc10be02349a1036717411","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \"macs\": [\"112233445566\"],"},{"line_number":65,"context_line":"                \"lswitch\": \"lswitch1\","},{"line_number":66,"context_line":"                \"topic\": \"tenant1\","},{"line_number":67,"context_line":"                \"mtu\": \"1500\""},{"line_number":68,"context_line":"            }"},{"line_number":69,"context_line":"            \u0027\u0027\u0027"},{"line_number":70,"context_line":"        self.lswitch1_value \u003d \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_2b2a0b2d","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":29},"updated":"2016-05-24 06:38:56.000000000","message":"I think we need to remove the mtu from the port","commit_id":"45f3ca8398826294fb893b069487b1c820590e30"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"a070bdb7025e4cc3786a9383abe5e40a0af5d82f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                \"macs\": [\"112233445566\"],"},{"line_number":65,"context_line":"                \"lswitch\": \"lswitch1\","},{"line_number":66,"context_line":"                \"topic\": \"tenant1\","},{"line_number":67,"context_line":"                \"mtu\": \"1500\""},{"line_number":68,"context_line":"            }"},{"line_number":69,"context_line":"            \u0027\u0027\u0027"},{"line_number":70,"context_line":"        self.lswitch1_value \u003d \u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_bd93685a","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":29},"in_reply_to":"bab6814e_2b2a0b2d","updated":"2016-05-26 00:53:04.000000000","message":"Done","commit_id":"45f3ca8398826294fb893b069487b1c820590e30"}]}