)]}'
{"dragonflow/db/api_nb.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"4946534e44e300975a939c0d81a6825c67d2b3cb","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return self.secrule.get(\u0027id\u0027)"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def get_topic(self):"},{"line_number":973,"context_line":"        return self.secrule.get(\u0027tenant_id\u0027)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def get_direction(self):"},{"line_number":976,"context_line":"        return self.secrule[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_bdaec82b","line":973,"updated":"2016-05-26 01:04:34.000000000","message":"I checked other objects. It seems that they get topic via topic key, not tenant-id key. Is it possible to keep them in the same way?","commit_id":"1b1411dd1c2427ddde4e10a3c2484e6bb663af95"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"f75a0d38c7d86c9973bae7f8dd576b019eb30425","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return self.secrule.get(\u0027id\u0027)"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def get_topic(self):"},{"line_number":973,"context_line":"        return self.secrule.get(\u0027tenant_id\u0027)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def get_direction(self):"},{"line_number":976,"context_line":"        return self.secrule[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1bd6fcf0","line":973,"in_reply_to":"bab6814e_1bbf1cab","updated":"2016-05-26 02:08:16.000000000","message":"ok","commit_id":"1b1411dd1c2427ddde4e10a3c2484e6bb663af95"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"e49ea0324ef9cee75ee5fe8bc8171e0ea01f1d6f","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return self.secrule.get(\u0027id\u0027)"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def get_topic(self):"},{"line_number":973,"context_line":"        return self.secrule.get(\u0027tenant_id\u0027)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def get_direction(self):"},{"line_number":976,"context_line":"        return self.secrule[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1bbf1cab","line":973,"in_reply_to":"bab6814e_bb1d3064","updated":"2016-05-26 02:07:08.000000000","message":"Yes, that\u0027s my suggestion.","commit_id":"1b1411dd1c2427ddde4e10a3c2484e6bb663af95"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"5e95fb80842d89f1967644b05367a730ec4ddf13","unresolved":false,"context_lines":[{"line_number":970,"context_line":"        return self.secrule.get(\u0027id\u0027)"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def get_topic(self):"},{"line_number":973,"context_line":"        return self.secrule.get(\u0027tenant_id\u0027)"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    def get_direction(self):"},{"line_number":976,"context_line":"        return self.secrule[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_bb1d3064","line":973,"in_reply_to":"bab6814e_bdaec82b","updated":"2016-05-26 01:46:53.000000000","message":"well, if you think here break the uniform of all objects topic key, I can change the tenant_id key to topic key in sg rules","commit_id":"1b1411dd1c2427ddde4e10a3c2484e6bb663af95"}],"dragonflow/neutron/plugin.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"971407e98d567473dc802b73f23804e9dcd2d8e5","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        tenant_id \u003d sg_db[\u0027tenant_id\u0027]"},{"line_number":222,"context_line":"        rules \u003d sg_db.get(\u0027security_group_rules\u0027)"},{"line_number":223,"context_line":"        for rule in rules:"},{"line_number":224,"context_line":"            rule[\u0027topic\u0027] \u003d rule.get(\u0027tenant_id\u0027)"},{"line_number":225,"context_line":"            del rule[\u0027tenant_id\u0027]"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.nb_api.create_security_group(id\u003dsg_id, topic\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_1a8e4678","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":49},"updated":"2016-05-29 11:03:58.000000000","message":"nit: You can use rule.pop(\u0027tenant_id\u0027) to get and remove the tenant_id at the same time. But this can definitely be done in another patch.","commit_id":"8b2e334dac69750c55ae34ce6cb02c0733133d3f"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"b91ed0c9aac87bfc8cee34a92db2d7118794ae8f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        tenant_id \u003d sg_db[\u0027tenant_id\u0027]"},{"line_number":222,"context_line":"        rules \u003d sg_db.get(\u0027security_group_rules\u0027)"},{"line_number":223,"context_line":"        for rule in rules:"},{"line_number":224,"context_line":"            rule[\u0027topic\u0027] \u003d rule.get(\u0027tenant_id\u0027)"},{"line_number":225,"context_line":"            del rule[\u0027tenant_id\u0027]"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.nb_api.create_security_group(id\u003dsg_id, topic\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_baca9a9f","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":49},"in_reply_to":"9abb7d3a_1a8e4678","updated":"2016-05-29 11:08:43.000000000","message":"ok, thx for your suggestion","commit_id":"8b2e334dac69750c55ae34ce6cb02c0733133d3f"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"971407e98d567473dc802b73f23804e9dcd2d8e5","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                    context.session, sg_id)"},{"line_number":240,"context_line":"            sg_group \u003d self.get_security_group(context, sg_id)"},{"line_number":241,"context_line":"        sg_rule[\u0027topic\u0027] \u003d sg_rule.get(\u0027tenant_id\u0027)"},{"line_number":242,"context_line":"        del sg_rule[\u0027tenant_id\u0027]"},{"line_number":243,"context_line":"        self.nb_api.add_security_group_rules(sg_id, sg_group[\u0027tenant_id\u0027],"},{"line_number":244,"context_line":"                                             sg_rules\u003d[sg_rule],"},{"line_number":245,"context_line":"                                             sg_version\u003dsg_version_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_7ae9521a","line":242,"updated":"2016-05-29 11:03:58.000000000","message":"Same here","commit_id":"8b2e334dac69750c55ae34ce6cb02c0733133d3f"}]}