)]}'
{"devstack/redis_driver":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"342b66568100dfa9c451863c73a77cf34ebcd81c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            sudo ./configure"},{"line_number":77,"context_line":"            sudo make"},{"line_number":78,"context_line":"            sudo make install"},{"line_number":79,"context_line":"            set +e"},{"line_number":80,"context_line":"            gem list redis | grep redis"},{"line_number":81,"context_line":"\t\t\tretVal\u003d$?"},{"line_number":82,"context_line":"\t\t\tset -e"},{"line_number":83,"context_line":"            if [ $retVal -ne 0 ];then"},{"line_number":84,"context_line":"                sudo gem source -a https://rubygems.org/"},{"line_number":85,"context_line":"                sudo gem install redis"},{"line_number":86,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7aa08908_9cc5475d","line":83,"range":{"start_line":79,"start_character":0,"end_line":83,"end_character":37},"updated":"2016-06-05 07:44:06.000000000","message":"nit: Consider rewriting as:\nif ! gem list redis | grep -q redis ; then\n    # call installer\n\nI think it might be more elegant than resetting and re-setting the -e flag.","commit_id":"4243344cd157eff2f3d599664a048bb71cbfd467"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"110868f858e547f817e471be2e5af5a969e26098","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            sudo ./configure"},{"line_number":77,"context_line":"            sudo make"},{"line_number":78,"context_line":"            sudo make install"},{"line_number":79,"context_line":"            ! gem list redis | grep -q redis"},{"line_number":80,"context_line":"            if [ $? -eq 0 ];then"},{"line_number":81,"context_line":"                sudo gem source -a https://rubygems.org/"},{"line_number":82,"context_line":"                sudo gem install redis"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7aa08908_30f3920c","line":79,"updated":"2016-06-05 17:24:58.000000000","message":"You still have to put it as the condition of the \u0027if\u0027, otherwise if the redis gem is installed, it will cause ./stack.sh to fail.","commit_id":"cab96057bd722e979dd879b3935616302db2febb"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"d0e398f3a4293775e6e159765c40fdbebe802b4f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# - nb_db_driver_stop_server"},{"line_number":10,"context_line":"# - nb_db_driver_clean"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"REDIS_VERSION\u003d3.3.0"},{"line_number":13,"context_line":"RUBY_VERSION\u003d2.3"},{"line_number":14,"context_line":"REDIS_SERVER_LIST\u003d$REMOTE_DB_IP"},{"line_number":15,"context_line":"REMOTE_PORT_START\u003d$REMOTE_DB_PORT"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7aa08908_80abc91c","line":12,"range":{"start_line":12,"start_character":14,"end_line":12,"end_character":19},"updated":"2016-06-07 07:20:14.000000000","message":"seem redis stable version newest is 3.2.0","commit_id":"0e6fc94ecd848ab782e5d47e51e12b53781b3904"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"e88ea1b5ce98c4a10acfec7c7c62d2cf9b72f498","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            tar xzvf $DEST/ruby/ruby-$RUBY_VERSION.0.tar.gz -C $DEST/ruby"},{"line_number":75,"context_line":"            cd $DEST/ruby/ruby-$RUBY_VERSION.0"},{"line_number":76,"context_line":"            sudo ./configure"},{"line_number":77,"context_line":"            sudo make"},{"line_number":78,"context_line":"            sudo make install"},{"line_number":79,"context_line":"            ! gem list redis | grep -q redis"},{"line_number":80,"context_line":"            if [ $? -eq 0 ];then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"7aa08908_8c593101","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":21},"updated":"2016-06-07 12:33:00.000000000","message":"maybe change ruby install under stack not with sudo","commit_id":"fd671882d95506962ac60967a337e05615178332"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"1052b9d5fffb4f0ea1b3aacaed8a391ba8a050e2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"             [ \"$create\" ] \u0026\u0026 {"},{"line_number":130,"context_line":"                 echo \"create the cluster: \"$redis_cluster"},{"line_number":131,"context_line":"                 pushd /opt/redis3/bin/"},{"line_number":132,"context_line":"                 echo \"yes\" |./redis-trib.rb create --replicas 1 $redis_cluster"},{"line_number":133,"context_line":"                 popd"},{"line_number":134,"context_line":"             }"},{"line_number":135,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7aa08908_98471abc","line":132,"range":{"start_line":132,"start_character":17,"end_line":132,"end_character":79},"updated":"2016-06-15 10:18:11.000000000","message":"use sudo may get the err for ruby load fixed, I test in my patch https://review.openstack.org/#/c/329745/  but full stack still not pass.","commit_id":"e7b43909cd870d3bb1876396970839c8d5215e07"}]}