)]}'
{"dragonflow/controller/l3_app.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"78b5d56ec233feacda2c7528a3b25d35ba921176","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # If router interface IP, send to output table"},{"line_number":158,"context_line":"        ether_type \u003d ether.ETH_TYPE_IP if is_ipv4 else ether.ETH_TYPE_IPV6"},{"line_number":159,"context_line":"        match \u003d parser.OFPMatch(eth_type\u003dether_type,"},{"line_number":160,"context_line":"                                metadata\u003dlocal_network_id,"},{"line_number":161,"context_line":"                                ipv4_dst\u003ddst_ip)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        goto_inst \u003d parser.OFPInstructionGotoTable(const.EGRESS_TABLE)"},{"line_number":164,"context_line":"        inst \u003d [goto_inst]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5e5a6150","line":161,"range":{"start_line":159,"start_character":8,"end_line":161,"end_character":48},"updated":"2016-06-07 08:49:58.000000000","message":"You removed the ipv6 match. Could you provide some useful information about this refactoring?","commit_id":"9ace1a5309e75beab707434f27d235d7e4d1ad4d"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"1ca36d3df531d588d1e8724c6e6e0c589aecc6d3","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # If router interface IP, send to output table"},{"line_number":158,"context_line":"        ether_type \u003d ether.ETH_TYPE_IP if is_ipv4 else ether.ETH_TYPE_IPV6"},{"line_number":159,"context_line":"        match \u003d parser.OFPMatch(eth_type\u003dether_type,"},{"line_number":160,"context_line":"                                metadata\u003dlocal_network_id,"},{"line_number":161,"context_line":"                                ipv4_dst\u003ddst_ip)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        goto_inst \u003d parser.OFPInstructionGotoTable(const.EGRESS_TABLE)"},{"line_number":164,"context_line":"        inst \u003d [goto_inst]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c4b4bed2","line":161,"range":{"start_line":159,"start_character":8,"end_line":161,"end_character":48},"in_reply_to":"7aa08908_5e5a6150","updated":"2016-06-07 09:11:13.000000000","message":"this is not correct, in case of IPv6 this needs to be ipv6_dst","commit_id":"9ace1a5309e75beab707434f27d235d7e4d1ad4d"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"878c83f434171ba495aad03dec04e5ba8527ffe8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        tunnel_key \u003d router_port.get_tunnel_key()"},{"line_number":150,"context_line":"        dst_ip \u003d router_port.get_ip()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        is_ipv4 \u003d netaddr.IPAddress(router_port.get_ip()).version \u003d\u003d 4"},{"line_number":153,"context_line":"        # Add router ARP responder for IPv4 Addresses"},{"line_number":154,"context_line":"        if is_ipv4:"},{"line_number":155,"context_line":"            ArpResponder(datapath, local_network_id, dst_ip, mac).add()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d8b13b91","line":152,"updated":"2016-06-07 11:44:37.000000000","message":"If we are already extracting dst_ip, lets use it here instead","commit_id":"c3bd20f5c66f7412051771e06f44c430e2c27601"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"cc928a1c26d1bc1fbd8fa6a3e5f0fbfbca424aee","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        tunnel_key \u003d router_port.get_tunnel_key()"},{"line_number":150,"context_line":"        dst_ip \u003d router_port.get_ip()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        is_ipv4 \u003d netaddr.IPAddress(router_port.get_ip()).version \u003d\u003d 4"},{"line_number":153,"context_line":"        # Add router ARP responder for IPv4 Addresses"},{"line_number":154,"context_line":"        if is_ipv4:"},{"line_number":155,"context_line":"            ArpResponder(datapath, local_network_id, dst_ip, mac).add()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_49684222","line":152,"in_reply_to":"7aa08908_d8b13b91","updated":"2016-06-15 11:19:53.000000000","message":"Makes sense","commit_id":"c3bd20f5c66f7412051771e06f44c430e2c27601"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"77b944ee95a7ad19becd1941e836ea8e61d37770","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            ArpResponder(datapath, local_network_id, dst_ip, mac).add()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # If router interface IP, send to output table"},{"line_number":158,"context_line":"        if is_ipv4:"},{"line_number":159,"context_line":"            match \u003d parser.OFPMatch(eth_type\u003dether.ETH_TYPE_IP,"},{"line_number":160,"context_line":"                                    metadata\u003dlocal_network_id,"},{"line_number":161,"context_line":"                                    ipv4_dst\u003ddst_ip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e0e53809","line":158,"range":{"start_line":158,"start_character":11,"end_line":158,"end_character":18},"updated":"2016-06-13 11:09:33.000000000","message":"can we merge these two if statements?","commit_id":"c3bd20f5c66f7412051771e06f44c430e2c27601"},{"author":{"_account_id":18186,"name":"Denis Makogon","username":"denismakogon","inactive":true},"change_message_id":"cc928a1c26d1bc1fbd8fa6a3e5f0fbfbca424aee","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            ArpResponder(datapath, local_network_id, dst_ip, mac).add()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # If router interface IP, send to output table"},{"line_number":158,"context_line":"        if is_ipv4:"},{"line_number":159,"context_line":"            match \u003d parser.OFPMatch(eth_type\u003dether.ETH_TYPE_IP,"},{"line_number":160,"context_line":"                                    metadata\u003dlocal_network_id,"},{"line_number":161,"context_line":"                                    ipv4_dst\u003ddst_ip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_89722a10","line":158,"range":{"start_line":158,"start_character":11,"end_line":158,"end_character":18},"in_reply_to":"7aa08908_e0e53809","updated":"2016-06-15 11:19:53.000000000","message":"+1","commit_id":"c3bd20f5c66f7412051771e06f44c430e2c27601"}]}