)]}'
{"doc/source/specs/port_qos.rst":[{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_6a04f77d","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":18},"updated":"2016-06-22 07:45:37.000000000","message":"delete the ,    and Dragonflow","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_ca236b04","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":74},"updated":"2016-06-22 07:45:37.000000000","message":"it","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_060fb288","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":18},"in_reply_to":"3aaa91ec_6a04f77d","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_666f962b","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":74},"in_reply_to":"3aaa91ec_af598e00","updated":"2016-06-25 02:39:19.000000000","message":"i use a new description","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_46253a07","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":74},"in_reply_to":"3aaa91ec_ca236b04","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem Description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_af598e00","line":18,"range":{"start_line":18,"start_character":70,"end_line":18,"end_character":74},"in_reply_to":"3aaa91ec_ca236b04","updated":"2016-06-23 09:05:54.000000000","message":"why not delete the sentence?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_25e93d15","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":67},"updated":"2016-06-23 09:05:54.000000000","message":"You mean you are going to implement port qos, and network qos will stay unsurpported?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"cfca32127e5ae5d51e69c26f32552963236c3c20","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_c5923c57","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":67},"updated":"2016-06-22 08:02:46.000000000","message":"not support yet","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_868e02ce","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":67},"in_reply_to":"3aaa91ec_25e93d15","updated":"2016-06-25 02:39:19.000000000","message":"yes","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"The QoS of neutron provides a way to attach QoS policies to neturon ports"},{"line_number":18,"context_line":"and networks. So, DrangonFlow need to develop this feature to support them."},{"line_number":19,"context_line":"Currently, DragonFlow only supports applying QoS policies to ports."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2658ee89","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":67},"in_reply_to":"3aaa91ec_c5923c57","updated":"2016-06-25 02:39:19.000000000","message":"I change it by a new description","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_121d65bd","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":18},"updated":"2016-06-23 09:05:54.000000000","message":"1. You planning define a new object? \nCould you explain the difference and relationships between the object and the existing one? The old one will be deprecated? Why not inherrit the old one?\n2. why do we need this new object? we can use qos_policy directly, which can and already contains tenant_id, description and other attributes you list here","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_8a8843e9","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":20},"updated":"2016-06-22 07:45:37.000000000","message":"an","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_a0f6508c","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":18},"in_reply_to":"3aaa91ec_121d65bd","updated":"2016-06-25 02:39:19.000000000","message":"in neutron there are qos policies and rule,\nwe want to use a qos boject which include that.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_66b2f695","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":20},"in_reply_to":"3aaa91ec_8a8843e9","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_5040c556","line":24,"range":{"start_line":24,"start_character":58,"end_line":24,"end_character":61},"updated":"2016-06-22 09:28:06.000000000","message":"\u0027all\u0027 and \u0027dhcp\u0027","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_aa5a5f81","line":24,"range":{"start_line":24,"start_character":37,"end_line":24,"end_character":38},"updated":"2016-06-22 07:45:37.000000000","message":"invalid char??","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_f5a93825","line":24,"range":{"start_line":24,"start_character":58,"end_line":24,"end_character":61},"in_reply_to":"3aaa91ec_5040c556","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Proposed Change"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_95aef42b","line":24,"range":{"start_line":24,"start_character":37,"end_line":24,"end_character":38},"in_reply_to":"3aaa91ec_aa5a5f81","updated":"2016-06-25 02:39:19.000000000","message":"format","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2a4f8fbe","line":25,"range":{"start_line":25,"start_character":70,"end_line":25,"end_character":71},"updated":"2016-06-22 07:45:37.000000000","message":"ditto","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"5d6be41414e9e44248758f8bf0c5cb0e283dc046","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_6add1714","line":25,"range":{"start_line":25,"start_character":69,"end_line":25,"end_character":71},"updated":"2016-06-22 07:32:28.000000000","message":"wrong format","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_d57b5cbc","line":25,"range":{"start_line":25,"start_character":70,"end_line":25,"end_character":71},"in_reply_to":"3aaa91ec_2a4f8fbe","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_d5a4fc4b","line":25,"range":{"start_line":25,"start_character":69,"end_line":25,"end_character":71},"in_reply_to":"3aaa91ec_6add1714","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2afdcf3a","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"updated":"2016-06-22 07:45:37.000000000","message":"I suggest you to provide a table to describe the consist of the qos object","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_c5695927","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"updated":"2016-06-23 09:05:54.000000000","message":"No \u0027shared\u0027 attribute? I think cloud admin need this attribute to apply a qos policy to multple teanant network.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_ab109e4f","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_2afdcf3a","updated":"2016-06-22 09:28:06.000000000","message":"+1","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_354d809a","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_2afdcf3a","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_7543886c","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_52ba4dc1","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_52ba4dc1","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_ab109e4f","updated":"2016-06-23 09:05:54.000000000","message":"+1.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_15504431","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_ab109e4f","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"DragonFlow defines a object called qos to implement the port QoS. The"},{"line_number":24,"context_line":"qos has some attributes which are id¡¢type which includes all and dscp¡¢"},{"line_number":25,"context_line":"tenant_id¡¢description and qos_policies which include tx_averateLimit¡¢"},{"line_number":26,"context_line":"tx_burstSize¡¢rx_averateLimit¡¢rx_burstSize and dscp. The tx_averateLimit"},{"line_number":27,"context_line":"and tx_burstSize used to limit the bandwidth of egress direction (from the"},{"line_number":28,"context_line":"vm point of view), the rx_averateLimit and rx_burstSize used to limit the"},{"line_number":29,"context_line":"bandwidth of ingress direction. DragonFlow doesn\u0027t use the attribute dscp"},{"line_number":30,"context_line":"in this patch."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_151e846f","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"3aaa91ec_c5695927","updated":"2016-06-25 02:39:19.000000000","message":"we don\u0027t support that in this patch","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"},{"line_number":34,"context_line":"--------------------"},{"line_number":35,"context_line":"The DragonFlow ML2 driver save the qos object to DragonFlow DB."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2b3cae92","line":35,"range":{"start_line":35,"start_character":59,"end_line":35,"end_character":62},"updated":"2016-06-22 09:28:06.000000000","message":"An end to end use case description is better. You can start from when the qos policies are created by tenant or admin, to how the qos policies is related to ports, ...","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"},{"line_number":34,"context_line":"--------------------"},{"line_number":35,"context_line":"The DragonFlow ML2 driver save the qos object to DragonFlow DB."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_f27d391d","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"updated":"2016-06-23 09:05:54.000000000","message":"Why not qos service plugin? IMHO, ML2, as the core plugin, only handle core resources.\nIf you are going to use qos plugin, you need to modify it to use the new Qos object, right?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"},{"line_number":34,"context_line":"--------------------"},{"line_number":35,"context_line":"The DragonFlow ML2 driver save the qos object to DragonFlow DB."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_8abb2372","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"updated":"2016-06-22 07:45:37.000000000","message":"could you please describe it more detail?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"},{"line_number":34,"context_line":"--------------------"},{"line_number":35,"context_line":"The DragonFlow ML2 driver save the qos object to DragonFlow DB."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_fb4ac953","line":35,"range":{"start_line":35,"start_character":59,"end_line":35,"end_character":62},"in_reply_to":"3aaa91ec_2b3cae92","updated":"2016-06-25 02:39:19.000000000","message":"we only describe the change of this part.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"ML2 Mechanism Driver"},{"line_number":34,"context_line":"--------------------"},{"line_number":35,"context_line":"The DragonFlow ML2 driver save the qos object to DragonFlow DB."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_9b6625eb","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"in_reply_to":"3aaa91ec_f27d391d","updated":"2016-06-25 02:39:19.000000000","message":"add the qos plugin and describe that.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_6be23605","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":61},"updated":"2016-06-22 09:28:06.000000000","message":"related to qos","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2a594f5b","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":21},"updated":"2016-06-22 07:45:37.000000000","message":"subscribes","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e02e988a","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":21},"in_reply_to":"3aaa91ec_2a594f5b","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"QoS App"},{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_c0443c4b","line":40,"range":{"start_line":40,"start_character":44,"end_line":40,"end_character":61},"in_reply_to":"3aaa91ec_6be23605","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_ab1d3e11","line":41,"range":{"start_line":41,"start_character":43,"end_line":41,"end_character":47},"updated":"2016-06-22 09:28:06.000000000","message":"care about","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_6a187785","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":38},"updated":"2016-06-22 07:45:37.000000000","message":"qos and port update","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_6070e8a4","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":38},"in_reply_to":"3aaa91ec_6a187785","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"-------"},{"line_number":39,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":40,"context_line":"QoS.The app subscribe the northbound events qos object events which"},{"line_number":41,"context_line":"include updating qos and updating port and care the southbound port events"},{"line_number":42,"context_line":"which include port online and port offline."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_c06b9cb5","line":41,"range":{"start_line":41,"start_character":43,"end_line":41,"end_character":47},"in_reply_to":"3aaa91ec_ab1d3e11","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"},{"line_number":45,"context_line":"-----------"},{"line_number":46,"context_line":"when the QoS app receives the port online event, it will get the qos attached"},{"line_number":47,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_b2e9f182","line":46,"range":{"start_line":46,"start_character":65,"end_line":46,"end_character":68},"updated":"2016-06-23 09:05:54.000000000","message":"qos policy? What do you mean by \u0027attach\u0027?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Port Online"},{"line_number":45,"context_line":"-----------"},{"line_number":46,"context_line":"when the QoS app receives the port online event, it will get the qos attached"},{"line_number":47,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_a0c2d082","line":46,"range":{"start_line":46,"start_character":65,"end_line":46,"end_character":68},"in_reply_to":"3aaa91ec_b2e9f182","updated":"2016-06-25 02:39:19.000000000","message":"port will have a attribute called qos, \"attach\" is good.","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"321661092bff9caff4f5b4fd13f40806f0f8711c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"-----------"},{"line_number":46,"context_line":"when the QoS app receives the port online event, it will get the qos attached"},{"line_number":47,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_b2457171","line":48,"range":{"start_line":48,"start_character":14,"end_line":48,"end_character":61},"updated":"2016-06-23 09:05:54.000000000","message":"Why ingress?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"-----------"},{"line_number":46,"context_line":"when the QoS app receives the port online event, it will get the qos attached"},{"line_number":47,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_a094908a","line":48,"range":{"start_line":48,"start_character":14,"end_line":48,"end_character":61},"in_reply_to":"3aaa91ec_b2457171","updated":"2016-06-25 02:39:19.000000000","message":"ingress is from the br-int point of view","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"},{"line_number":52,"context_line":"direction of the port."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port Offline"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_0b4a92c5","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":28},"updated":"2016-06-22 09:28:06.000000000","message":"how about dscp?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"},{"line_number":52,"context_line":"direction of the port."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port Offline"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_20c0a04f","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":28},"in_reply_to":"3aaa91ec_0b4a92c5","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"70ffb40ab375b29641f37f52f8dcf417b93fccf4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"},{"line_number":52,"context_line":"direction of the port."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port Offline"},{"line_number":55,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_8be7a2e3","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":9},"updated":"2016-06-22 09:28:06.000000000","message":"traffic","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"the OVS for limiting the bandwidth of egress direction of the port. In addition,"},{"line_number":50,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit of"},{"line_number":51,"context_line":"qos to other_config of queue on the OVS for limiting the bandwidth of ingress"},{"line_number":52,"context_line":"direction of the port."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Port Offline"},{"line_number":55,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e06698b9","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":9},"in_reply_to":"3aaa91ec_8be7a2e3","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"3.port applys no qos"},{"line_number":65,"context_line":"For all the scenarios, the QoS app will do nothing if the port\u0027s status is down."},{"line_number":66,"context_line":"when the port\u0027s status is up, the QoS app will do something like the port online"},{"line_number":67,"context_line":"event for scenario 1 and do something like the qos object updating event for"},{"line_number":68,"context_line":"scenario 2 and do something like the port offline event for scenario 3."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_a5573001","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":20},"updated":"2016-06-22 07:45:37.000000000","message":"where is scenario 1, you do not mark it","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"3.port applys no qos"},{"line_number":65,"context_line":"For all the scenarios, the QoS app will do nothing if the port\u0027s status is down."},{"line_number":66,"context_line":"when the port\u0027s status is up, the QoS app will do something like the port online"},{"line_number":67,"context_line":"event for scenario 1 and do something like the qos object updating event for"},{"line_number":68,"context_line":"scenario 2 and do something like the port offline event for scenario 3."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e05cd81a","line":67,"range":{"start_line":67,"start_character":9,"end_line":67,"end_character":20},"in_reply_to":"3aaa91ec_a5573001","updated":"2016-06-25 02:39:19.000000000","message":"before the scenario 2","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"02d19efcd1838ee21c4e41152850adec44a14e1e","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Qos Object Delete"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":"It is not permit to delete the qos object attached to some ports."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Qos Object Update"},{"line_number":76,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_65826854","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":65},"updated":"2016-06-22 07:45:37.000000000","message":"I suggest you to describe the process pipeline by step 1\\2\\3... and if you do not want to type too many words, you could draw a picture:)","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Qos Object Delete"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":"It is not permit to delete the qos object attached to some ports."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Qos Object Update"},{"line_number":76,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_c07f1c13","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":65},"in_reply_to":"3aaa91ec_65826854","updated":"2016-06-25 02:39:19.000000000","message":"this process is so easy, I think is ok","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"cfca32127e5ae5d51e69c26f32552963236c3c20","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Qos Object Delete"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":"It is not permit to delete the qos object attached to some ports."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Qos Object Update"},{"line_number":76,"context_line":"-----------------"},{"line_number":77,"context_line":"when Updating the qos object, the new value of bandwidth will be propagated"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_a5e8d07d","line":74,"updated":"2016-06-22 08:02:46.000000000","message":"when permit to delete ,what to do ?","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Qos Object Delete"},{"line_number":72,"context_line":"-----------------"},{"line_number":73,"context_line":"It is not permit to delete the qos object attached to some ports."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Qos Object Update"},{"line_number":76,"context_line":"-----------------"},{"line_number":77,"context_line":"when Updating the qos object, the new value of bandwidth will be propagated"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e0705842","line":74,"in_reply_to":"3aaa91ec_a5e8d07d","updated":"2016-06-25 02:39:19.000000000","message":"if no port apply the qos , delete the qos from db","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"cfca32127e5ae5d51e69c26f32552963236c3c20","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"References"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":"[1] http://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_8572f4e3","line":83,"range":{"start_line":83,"start_character":1,"end_line":83,"end_character":3},"updated":"2016-06-22 08:02:46.000000000","message":"where is [1]","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"d7ae676bbc7cf084d3e6d67819fb915fce95376c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"References"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":83,"context_line":"[1] http://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_80b35409","line":83,"range":{"start_line":83,"start_character":1,"end_line":83,"end_character":3},"in_reply_to":"3aaa91ec_8572f4e3","updated":"2016-06-25 02:39:19.000000000","message":"Done","commit_id":"b608597da17a192bfa5aefc527da5c0208d9518d"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6d8399673c9c1698beb877980a79d5cdd795d273","unresolved":false,"context_lines":[{"line_number":68,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The type of QoS includes \"all\" and \"dscp\". Excepting the basic attributes"},{"line_number":71,"context_line":"id¡¢type etc,the qos object may have all of the attributes in the qos_policies"},{"line_number":72,"context_line":"when the type of QoS is \"all\" and only have the dscp attribute in the"},{"line_number":73,"context_line":"qos_policies when the type of QoS is \"dscp\"."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_015da314","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":9},"updated":"2016-06-25 10:16:41.000000000","message":"need to fix","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"QoS plugin"},{"line_number":76,"context_line":"----------"},{"line_number":77,"context_line":"The QoS plugin which is one of the neutron service plugins handles the CRUD"},{"line_number":78,"context_line":"of QoS policies and rules. We will convert the QoS policies and rules to qos"},{"line_number":79,"context_line":"object in DragonFlow and deal with the CRUD of qos."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"ML2 Mechanism Driver"},{"line_number":82,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_e6998dc5","line":79,"range":{"start_line":78,"start_character":27,"end_line":79,"end_character":51},"updated":"2016-06-25 09:47:20.000000000","message":"Those should be done in QoS plugin. Besides, I don\u0027t think we should modify any codes in QoS plugin.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"ML2 Mechanism Driver"},{"line_number":82,"context_line":"--------------------"},{"line_number":83,"context_line":"When port update related to a qos, the DragonFlow ML2 driver will"},{"line_number":84,"context_line":"notify the DragonFlow DB to save the relationship of port and qos."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"QoS App"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_265555c5","line":83,"range":{"start_line":83,"start_character":4,"end_line":83,"end_character":5},"updated":"2016-06-25 09:47:20.000000000","message":"I think the conversion to the qos objects mentioned in the above paragraph should be done here.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6d8399673c9c1698beb877980a79d5cdd795d273","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"ML2 Mechanism Driver"},{"line_number":82,"context_line":"--------------------"},{"line_number":83,"context_line":"When port update related to a qos, the DragonFlow ML2 driver will"},{"line_number":84,"context_line":"notify the DragonFlow DB to save the relationship of port and qos."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"QoS App"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_018be368","line":83,"range":{"start_line":83,"start_character":5,"end_line":83,"end_character":16},"updated":"2016-06-25 10:16:41.000000000","message":"updates","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"QoS App"},{"line_number":87,"context_line":"-------"},{"line_number":88,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":89,"context_line":"QoS.The app subscribes the northbound events related to qos object which"},{"line_number":90,"context_line":"include qos and port update and care about the southbound port events"},{"line_number":91,"context_line":"which include port online and port offline."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_a65785c8","line":88,"range":{"start_line":88,"start_character":50,"end_line":88,"end_character":59},"updated":"2016-06-25 09:47:20.000000000","message":"implements","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"QoS App"},{"line_number":87,"context_line":"-------"},{"line_number":88,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":89,"context_line":"QoS.The app subscribes the northbound events related to qos object which"},{"line_number":90,"context_line":"include qos and port update and care about the southbound port events"},{"line_number":91,"context_line":"which include port online and port offline."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Port Online"},{"line_number":94,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_2606f51f","line":91,"range":{"start_line":89,"start_character":3,"end_line":91,"end_character":43},"updated":"2016-06-25 09:47:20.000000000","message":"Maybe using port created/updated/removed instead of port online/offline/update will be better, because a APP shouldn\u0027t directly subscribe those events.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6d8399673c9c1698beb877980a79d5cdd795d273","unresolved":false,"context_lines":[{"line_number":86,"context_line":"QoS App"},{"line_number":87,"context_line":"-------"},{"line_number":88,"context_line":"The QoS app is a module of local controller which implement the logic of"},{"line_number":89,"context_line":"QoS.The app subscribes the northbound events related to qos object which"},{"line_number":90,"context_line":"include qos and port update and care about the southbound port events"},{"line_number":91,"context_line":"which include port online and port offline."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Port Online"},{"line_number":94,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_81f513ee","line":91,"range":{"start_line":89,"start_character":3,"end_line":91,"end_character":43},"in_reply_to":"3aaa91ec_2606f51f","updated":"2016-06-25 10:16:41.000000000","message":"+1","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Port Online"},{"line_number":94,"context_line":"-----------"},{"line_number":95,"context_line":"when the QoS app receives the port online event, it will get the qos attached"},{"line_number":96,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":97,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":98,"context_line":"the OVS for limiting the bandwidth of egress traffic of the port. In addition,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_23aa6719","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":1},"updated":"2016-06-25 09:47:20.000000000","message":"uppercase","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Port Offline"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"when the QoS app receives the port offline event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Port Update"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_a36c9708","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":1},"updated":"2016-06-25 09:47:20.000000000","message":"ditto","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Port Update"},{"line_number":109,"context_line":"-------------"},{"line_number":110,"context_line":"The Port Update event can show three scenarios:"},{"line_number":111,"context_line":"1.port applys a qos"},{"line_number":112,"context_line":"2.port applys a new qos"},{"line_number":113,"context_line":"3.port applys no qos"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_833d1bdf","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":15},"updated":"2016-06-25 09:47:20.000000000","message":"uppercase here? I suggest unifying the case of port update/online/offline in this spec.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"1.port applys a qos"},{"line_number":112,"context_line":"2.port applys a new qos"},{"line_number":113,"context_line":"3.port applys no qos"},{"line_number":114,"context_line":"For all the scenarios, the QoS app will do nothing if the port\u0027s status is down."},{"line_number":115,"context_line":"when the port\u0027s status is up, the QoS app will do something like the port online"},{"line_number":116,"context_line":"event for scenario 1 and do something like the qos object update event for"},{"line_number":117,"context_line":"scenario 2 and do something like the port offline event for scenario 3."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_a60b057c","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":80},"updated":"2016-06-25 09:47:20.000000000","message":"I don\u0027t think that should be considered in a APP\u0027s point of view. When the local controller notifies APPs that a local port was created or updated, it can guaranteed the port is online.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":22060,"name":"jingting","email":"kangjingting@huawei.com","username":"jingting"},"change_message_id":"218028e4a631d9fb783cc5f3d1596d1cde1decef","unresolved":false,"context_lines":[{"line_number":111,"context_line":"1.port applys a qos"},{"line_number":112,"context_line":"2.port applys a new qos"},{"line_number":113,"context_line":"3.port applys no qos"},{"line_number":114,"context_line":"For all the scenarios, the QoS app will do nothing if the port\u0027s status is down."},{"line_number":115,"context_line":"when the port\u0027s status is up, the QoS app will do something like the port online"},{"line_number":116,"context_line":"event for scenario 1 and do something like the qos object update event for"},{"line_number":117,"context_line":"scenario 2 and do something like the port offline event for scenario 3."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_988d76d5","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":80},"in_reply_to":"3aaa91ec_a60b057c","updated":"2016-06-27 01:52:52.000000000","message":"It can\u0027t guarante a port is online or not while controller notify event of port create and update. These are two separate steps. But it indeed should care of event of create and update instead of online and offline for APP.","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"63f8e1cd6eba365e69b948fb004f52df55a8f78c","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Qos Object Update"},{"line_number":126,"context_line":"-----------------"},{"line_number":127,"context_line":"when Updating the qos object, the new value of bandwidth will be propagated"},{"line_number":128,"context_line":"to all the ports which apply the qos object."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"3aaa91ec_c323a3bb","line":127,"range":{"start_line":127,"start_character":5,"end_line":127,"end_character":7},"updated":"2016-06-25 09:47:20.000000000","message":"u","commit_id":"c1219a26e58ed1330b723e61b88528557bdef5d2"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":39,"context_line":"|   description      |   QoS description                           |"},{"line_number":40,"context_line":"|                    |                                             |"},{"line_number":41,"context_line":"+------------------------------------------------------------------+"},{"line_number":42,"context_line":"|   qos_policies     |   QoS policies                              |"},{"line_number":43,"context_line":"|                    |                                             |"},{"line_number":44,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_93fb9778","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":16},"updated":"2016-06-27 02:45:48.000000000","message":"I guess it should be qos_policy","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":39,"context_line":"|   description      |   QoS description                           |"},{"line_number":40,"context_line":"|                    |                                             |"},{"line_number":41,"context_line":"+------------------------------------------------------------------+"},{"line_number":42,"context_line":"|   qos_policies     |   QoS policies                              |"},{"line_number":43,"context_line":"|                    |                                             |"},{"line_number":44,"context_line":"+--------------------+---------------------------------------------+"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_d3923ff5","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":37},"updated":"2016-06-27 02:45:48.000000000","message":"Is it a dictionary, or a class ? Perhaps you could explain the type of qos_policy.","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The type of QoS includes \"all\" and \"dscp\". Excepting the basic attributes"},{"line_number":71,"context_line":"id、type etc, the qos object may have all of the attributes in the qos_policies"},{"line_number":72,"context_line":"when the type of QoS is \"all\" and only have the dscp attribute in the"},{"line_number":73,"context_line":"qos_policies when the type of QoS is \"dscp\"."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_731eeb0c","line":70,"range":{"start_line":70,"start_character":43,"end_line":70,"end_character":52},"updated":"2016-06-27 02:45:48.000000000","message":"Besides","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The type of QoS includes \"all\" and \"dscp\". Excepting the basic attributes"},{"line_number":71,"context_line":"id、type etc, the qos object may have all of the attributes in the qos_policies"},{"line_number":72,"context_line":"when the type of QoS is \"all\" and only have the dscp attribute in the"},{"line_number":73,"context_line":"qos_policies when the type of QoS is \"dscp\"."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_b3c21351","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":15},"updated":"2016-06-27 02:45:48.000000000","message":"Does Qos here mean the object you defined? I suggest to make it consistent, qos, qos object and Qos","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":68,"context_line":"The egress and ingress directions are from the VM point of view."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"The type of QoS includes \"all\" and \"dscp\". Excepting the basic attributes"},{"line_number":71,"context_line":"id、type etc, the qos object may have all of the attributes in the qos_policies"},{"line_number":72,"context_line":"when the type of QoS is \"all\" and only have the dscp attribute in the"},{"line_number":73,"context_line":"qos_policies when the type of QoS is \"dscp\"."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_93239755","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":4},"updated":"2016-06-27 02:45:48.000000000","message":"fix it","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":72,"context_line":"when the type of QoS is \"all\" and only have the dscp attribute in the"},{"line_number":73,"context_line":"qos_policies when the type of QoS is \"dscp\"."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"QoS Notification Driver"},{"line_number":76,"context_line":"----------"},{"line_number":77,"context_line":"The QoS plugin which is one of the neutron service plugins handles the CRUD"},{"line_number":78,"context_line":"of QoS policies and rules. We will convert the QoS policies and rules to qos"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_d3751f32","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":23},"updated":"2016-06-27 02:45:48.000000000","message":"If you are going to add a driver, perhaps you could do some explanation","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":94,"context_line":"-----------"},{"line_number":95,"context_line":"When the QoS app receives the port created event, it will get the qos attached"},{"line_number":96,"context_line":"to the port from the DB store, then set the tx_burstSize and tx_averateLimit"},{"line_number":97,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":98,"context_line":"the OVS for limiting the bandwidth of egress traffic of the port. In addition,"},{"line_number":99,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit"},{"line_number":100,"context_line":"and dscp of qos to other_config and dscp of queue on the OVS for limiting the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_13e047cc","line":97,"range":{"start_line":97,"start_character":14,"end_line":97,"end_character":62},"updated":"2016-06-27 02:45:48.000000000","message":"ingress_policing_bust and ingress_policing_rate fields of the corresponding interface","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"6ed957cb355459983c5956bdbc521ce61ce38a51","unresolved":false,"context_lines":[{"line_number":97,"context_line":"of the qos to ingress_policing_bust and ingress_policing_rate of interface on"},{"line_number":98,"context_line":"the OVS for limiting the bandwidth of egress traffic of the port. In addition,"},{"line_number":99,"context_line":"the QoS app creates a queue attached to the port and set the rx_averateLimit"},{"line_number":100,"context_line":"and dscp of qos to other_config and dscp of queue on the OVS for limiting the"},{"line_number":101,"context_line":"bandwidth of ingress traffic of the port."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Port Removed"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3aaa91ec_1315e79a","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":41},"updated":"2016-06-27 02:45:48.000000000","message":"qos object to the other_config and dscp fields of the queue created","commit_id":"13f96e4dd381d1772f28019ca6e1abd307ce6b49"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"4ce9941aab3a153c56296b3ff0c2edeae0cd1acf","unresolved":false,"context_lines":[{"line_number":87,"context_line":"-------"},{"line_number":88,"context_line":"The QoS app is a module of local controller which implements the logic of"},{"line_number":89,"context_line":"QoS. The app subscribes the northbound events related to qos object which"},{"line_number":90,"context_line":"include qos updated and port updated and care about the southbound port events"},{"line_number":91,"context_line":"which include port created and port removed."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Port Created"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_b593e4a2","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":19},"updated":"2016-07-04 08:00:26.000000000","message":"Besides update, where are the other qos messages processed(create/delete)?","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"bdf2cc18e6593d022d93604a097d9eac58b4c007","unresolved":false,"context_lines":[{"line_number":87,"context_line":"-------"},{"line_number":88,"context_line":"The QoS app is a module of local controller which implements the logic of"},{"line_number":89,"context_line":"QoS. The app subscribes the northbound events related to qos object which"},{"line_number":90,"context_line":"include qos updated and port updated and care about the southbound port events"},{"line_number":91,"context_line":"which include port created and port removed."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Port Created"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_2c866a13","line":90,"range":{"start_line":90,"start_character":12,"end_line":90,"end_character":19},"in_reply_to":"1aa78d24_b593e4a2","updated":"2016-07-05 02:04:36.000000000","message":"qos app don\u0027t care about create message, delete message described on the last of this spec.","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"7f0b124a8855473f01a5c3dfef1f2529d35ffa4c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rx_averateLimit and dscp of qos to other_config and dscp of the queue on the OVS"},{"line_number":101,"context_line":"for limiting the bandwidth of ingress traffic of the port."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Port Removed"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"When the QoS app receives the port removed event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_1409352d","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":12},"updated":"2016-07-02 07:21:56.000000000","message":"It the port is deleted, are the qos policies automatically deleted?","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"bdf2cc18e6593d022d93604a097d9eac58b4c007","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rx_averateLimit and dscp of qos to other_config and dscp of the queue on the OVS"},{"line_number":101,"context_line":"for limiting the bandwidth of ingress traffic of the port."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Port Removed"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"When the QoS app receives the port removed event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_6c9fd250","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"1aa78d24_1409352d","updated":"2016-07-05 02:04:36.000000000","message":"the qos and queue created on the ovs will be delete automatically.","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"fcdd6adbf543916dc21142d7e01ec73cafaeba9d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"rx_averateLimit and dscp of qos to other_config and dscp of the queue on the OVS"},{"line_number":101,"context_line":"for limiting the bandwidth of ingress traffic of the port."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"Port Removed"},{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"When the QoS app receives the port removed event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_d05abe82","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":12},"in_reply_to":"1aa78d24_6c9fd250","updated":"2016-07-11 09:02:46.000000000","message":"Ok, I suggest you add it to the section.","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"4ce9941aab3a153c56296b3ff0c2edeae0cd1acf","unresolved":false,"context_lines":[{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"When the QoS app receives the port removed event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Port Updated"},{"line_number":109,"context_line":"------------"},{"line_number":110,"context_line":"The port updated event can show three scenarios:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_150478be","line":107,"updated":"2016-07-04 08:00:26.000000000","message":"I think we also to do something when port offline. For example, vm port is migrated to another host.","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":22338,"name":"xuxiaojie","email":"xiaojie.xu@huawei.com","username":"xuxiaojie"},"change_message_id":"bdf2cc18e6593d022d93604a097d9eac58b4c007","unresolved":false,"context_lines":[{"line_number":104,"context_line":"------------"},{"line_number":105,"context_line":"When the QoS app receives the port removed event, it will unset the bandwidth"},{"line_number":106,"context_line":"limiting of the port."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Port Updated"},{"line_number":109,"context_line":"------------"},{"line_number":110,"context_line":"The port updated event can show three scenarios:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa78d24_ec2e22f9","line":107,"in_reply_to":"1aa78d24_150478be","updated":"2016-07-05 02:04:36.000000000","message":"vm port is migrated from A to B, on the A qos app will deal with the port removed event, on the B port created event.\nunset the bandwidth include deleting the qos and queueu created on the ovs and unseting the ingress_* of interface.\nwhat any other thing will do ?","commit_id":"8b7465014104f5bab67672c02769daabb851a67e"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dc99e201af7706d71aad7f68a6eff8d0ba46bf88","unresolved":false,"context_lines":[{"line_number":120,"context_line":"------------\r"},{"line_number":121,"context_line":"\r"},{"line_number":122,"context_line":"The port updated event can show three scenarios:\r"},{"line_number":123,"context_line":"1. port applys a qos\r"},{"line_number":124,"context_line":"2. port applys a new qos\r"},{"line_number":125,"context_line":"3. port applys no qos\r"},{"line_number":126,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_4c732f16","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":14},"updated":"2016-07-22 07:26:31.000000000","message":"applies","commit_id":"59872abe14fb83aed9805f92ddb5a5fd40813189"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"2cad2548c3d3868f02fe9746e21b26df256a3f35","unresolved":false,"context_lines":[{"line_number":120,"context_line":"------------\r"},{"line_number":121,"context_line":"\r"},{"line_number":122,"context_line":"The port updated event can show three scenarios:\r"},{"line_number":123,"context_line":"1. port applys a qos\r"},{"line_number":124,"context_line":"2. port applys a new qos\r"},{"line_number":125,"context_line":"3. port applys no qos\r"},{"line_number":126,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_6f6b8586","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":14},"in_reply_to":"dada55a8_4c732f16","updated":"2016-07-22 07:39:28.000000000","message":"np, I\u0027ll modify it soon :)","commit_id":"59872abe14fb83aed9805f92ddb5a5fd40813189"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dc99e201af7706d71aad7f68a6eff8d0ba46bf88","unresolved":false,"context_lines":[{"line_number":121,"context_line":"\r"},{"line_number":122,"context_line":"The port updated event can show three scenarios:\r"},{"line_number":123,"context_line":"1. port applys a qos\r"},{"line_number":124,"context_line":"2. port applys a new qos\r"},{"line_number":125,"context_line":"3. port applys no qos\r"},{"line_number":126,"context_line":"\r"},{"line_number":127,"context_line":"For scenario 1, the QoS app will set the corresponding configuration of the qos\r"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_ec58238d","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":14},"updated":"2016-07-22 07:26:31.000000000","message":"ditto","commit_id":"59872abe14fb83aed9805f92ddb5a5fd40813189"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dc99e201af7706d71aad7f68a6eff8d0ba46bf88","unresolved":false,"context_lines":[{"line_number":122,"context_line":"The port updated event can show three scenarios:\r"},{"line_number":123,"context_line":"1. port applys a qos\r"},{"line_number":124,"context_line":"2. port applys a new qos\r"},{"line_number":125,"context_line":"3. port applys no qos\r"},{"line_number":126,"context_line":"\r"},{"line_number":127,"context_line":"For scenario 1, the QoS app will set the corresponding configuration of the qos\r"},{"line_number":128,"context_line":"for the port, the configuration is similar with the description in\r"}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_cc5d5f7b","line":125,"range":{"start_line":125,"start_character":8,"end_line":125,"end_character":14},"updated":"2016-07-22 07:26:31.000000000","message":"ditto","commit_id":"59872abe14fb83aed9805f92ddb5a5fd40813189"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"fffa25a577d97fade8eb8f19279c74fb7dc20ae1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"The QoS app is a module of local controller which implements the logic of"},{"line_number":102,"context_line":"QoS. The app concerns about the qos updated and port updated northbound events"},{"line_number":103,"context_line":"and also care about the southbound port events which include port created and"},{"line_number":104,"context_line":"port removed."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Port Created"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3ac371cc_fb84b70b","line":103,"range":{"start_line":103,"start_character":9,"end_line":103,"end_character":13},"updated":"2016-08-17 13:20:49.000000000","message":"\"cares\" here","commit_id":"15fa3a0ad0e240db9bdd0c569fc3c30ae00a2351"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"fffa25a577d97fade8eb8f19279c74fb7dc20ae1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"When the QoS app receives the port removed event, it will delete the"},{"line_number":121,"context_line":"corresponding qos configuration of the removed port on the local host, for"},{"line_number":122,"context_line":"example, unset the ingress_policy of the interface and the other_config and"},{"line_number":123,"context_line":"dscp of the queue."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Port Updated"},{"line_number":126,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3ac371cc_fb37974a","line":123,"range":{"start_line":123,"start_character":12,"end_line":123,"end_character":17},"updated":"2016-08-17 13:20:49.000000000","message":"What will happen with the packets in the queue ?","commit_id":"15fa3a0ad0e240db9bdd0c569fc3c30ae00a2351"}]}