)]}'
{"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ed3fdede1cc2586503cd448098e0bee59821cd67","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            security_groups\u003dport.get(\u0027security_groups\u0027, None),"},{"line_number":457,"context_line":"            port_security_enabled\u003dport.get(psec.PORTSECURITY, False),"},{"line_number":458,"context_line":"            allowed_address_pairs\u003dport.get(addr_pair.ADDRESS_PAIRS, None),"},{"line_number":459,"context_line":"            binding_profile\u003dport.get(\u0027binding:profile\u0027, None),"},{"line_number":460,"context_line":"            binding_vnic_type\u003dport.get(\u0027binding:vnic_type\u0027, None))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        LOG.info(_LI(\"DFMechDriver: create port %s\"), port[\u0027id\u0027])"},{"line_number":463,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_6db3a798","line":460,"range":{"start_line":459,"start_character":0,"end_line":460,"end_character":66},"updated":"2016-06-27 07:12:18.000000000","message":"Please use the constants in neutron.extensions.portbinding.","commit_id":"17415a16959714dfb342e1f6bd1718c038f8ba45"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"4ece16252eb90317af2643f475bcc8dcea7d232c","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            security_groups\u003dport.get(\u0027security_groups\u0027, None),"},{"line_number":457,"context_line":"            port_security_enabled\u003dport.get(psec.PORTSECURITY, False),"},{"line_number":458,"context_line":"            allowed_address_pairs\u003dport.get(addr_pair.ADDRESS_PAIRS, None),"},{"line_number":459,"context_line":"            binding_profile\u003dport.get(\u0027binding:profile\u0027, None),"},{"line_number":460,"context_line":"            binding_vnic_type\u003dport.get(\u0027binding:vnic_type\u0027, None))"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        LOG.info(_LI(\"DFMechDriver: create port %s\"), port[\u0027id\u0027])"},{"line_number":463,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_df335912","line":460,"range":{"start_line":459,"start_character":0,"end_line":460,"end_character":66},"in_reply_to":"3aaa91ec_6db3a798","updated":"2016-06-27 09:31:51.000000000","message":"Ok, thx for reviewing","commit_id":"17415a16959714dfb342e1f6bd1718c038f8ba45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ed3fdede1cc2586503cd448098e0bee59821cd67","unresolved":false,"context_lines":[{"line_number":530,"context_line":"            allowed_address_pairs\u003dupdated_port.get(addr_pair.ADDRESS_PAIRS,"},{"line_number":531,"context_line":"                                                   None),"},{"line_number":532,"context_line":"            binding_profile\u003dupdated_port.get(\u0027binding:profile\u0027, None),"},{"line_number":533,"context_line":"            binding_vnic_type\u003dupdated_port.get(\u0027binding:vnic_type\u0027, None),"},{"line_number":534,"context_line":"            version\u003dupdated_port[\u0027db_version\u0027])"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        LOG.info(_LI(\"DFMechDriver: update port %s\"), updated_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_4daeab2e","line":533,"updated":"2016-06-27 07:12:18.000000000","message":"Same here.","commit_id":"17415a16959714dfb342e1f6bd1718c038f8ba45"}],"dragonflow/neutron/plugin.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ed3fdede1cc2586503cd448098e0bee59821cd67","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                                 allowed_address_pairs\u003dupdated_port["},{"line_number":570,"context_line":"                                     addr_pair.ADDRESS_PAIRS],"},{"line_number":571,"context_line":"                                 binding_profile\u003dupdated_port.get("},{"line_number":572,"context_line":"                                     \u0027binding:profile\u0027, None),"},{"line_number":573,"context_line":"                                 binding_vnic_type\u003dupdated_port.get("},{"line_number":574,"context_line":"                                     \u0027binding:vnic_type\u0027, None),"},{"line_number":575,"context_line":"                                 version\u003dport_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d02b4e80","line":572,"updated":"2016-06-27 07:12:18.000000000","message":"Sane here re: constants","commit_id":"17415a16959714dfb342e1f6bd1718c038f8ba45"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"ed3fdede1cc2586503cd448098e0bee59821cd67","unresolved":false,"context_lines":[{"line_number":713,"context_line":"            security_groups\u003dsgs,"},{"line_number":714,"context_line":"            port_security_enabled\u003dport[psec.PORTSECURITY],"},{"line_number":715,"context_line":"            binding_profile\u003dport.get(\u0027binding:profile\u0027, None),"},{"line_number":716,"context_line":"            binding_vnic_type\u003dport.get(\u0027binding:vnic_type\u0027, None),"},{"line_number":717,"context_line":"            allowed_address_pairs\u003dport[addr_pair.ADDRESS_PAIRS])"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_301f325c","line":716,"updated":"2016-06-27 07:12:18.000000000","message":"Sane here re: constants","commit_id":"17415a16959714dfb342e1f6bd1718c038f8ba45"}],"dragonflow/tests/unit/test_mech_driver.py":[{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"043fd175610b7ee02595317b17044299a490b4b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3aaa91ec_94b8932b","updated":"2016-06-27 09:54:05.000000000","message":"There was a conflict between this patch and the latest code on master branch. So I tried to resolve the confict, but I found test_mech_driver.py was turned into dos format(\"\\r\\n\" -\u003e \"\\n\") by the git rebase operation. So I did a dos2unix operation.\n\nBut it seems test_mech_driver.py in master branch is not in dos format","commit_id":"28a3e6977b585fa8f75dea0229c0e5886d9ba2b3"},{"author":{"_account_id":21007,"name":"yuan wei","email":"wei.yuan@huawei.com","username":"yuanwei"},"change_message_id":"8122d8390c25bf0bf454c09f763336a4eedf7332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3aaa91ec_300419c5","in_reply_to":"3aaa91ec_94b8932b","updated":"2016-06-28 03:09:16.000000000","message":"Only a suggestion:). If we could raise a bug about it and fix that bug in another patch, because it\u0027s hard to review the changes when we can\u0027t see directly which part was changed.","commit_id":"28a3e6977b585fa8f75dea0229c0e5886d9ba2b3"}]}
