)]}'
{"dragonflow/controller/dnat_app.py":[{"author":{"_account_id":20336,"name":"heshan","email":"shan.he@huawei.com","username":"shanhe"},"change_message_id":"3f12ecee7228f562c32291fd28f403baebba57b2","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def add_local_port(self, lport):"},{"line_number":368,"context_line":"        port_id \u003d lport.get_id()"},{"line_number":369,"context_line":"        ips_to_disassociate \u003d ["},{"line_number":370,"context_line":"            fip for fip in six.itervalues(self.local_floatingips)"},{"line_number":371,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":372,"context_line":"        for floatingip in ips_to_disassociate:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2cdb5bef","line":369,"range":{"start_line":369,"start_character":8,"end_line":369,"end_character":27},"updated":"2016-07-17 12:46:18.000000000","message":"I think it should be \u0027ips_to_associate\u0027","commit_id":"e14b0d04619c7969d06aa1f488ba7a90a22b816a"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"ee989e18c6c7d69b33c3c442f03e5dcee4c49968","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    def add_local_port(self, lport):"},{"line_number":368,"context_line":"        port_id \u003d lport.get_id()"},{"line_number":369,"context_line":"        ips_to_disassociate \u003d ["},{"line_number":370,"context_line":"            fip for fip in six.itervalues(self.local_floatingips)"},{"line_number":371,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":372,"context_line":"        for floatingip in ips_to_disassociate:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0cc31c58","line":369,"range":{"start_line":369,"start_character":8,"end_line":369,"end_character":27},"updated":"2016-07-21 14:35:20.000000000","message":"copy from remove_local_port?","commit_id":"e14b0d04619c7969d06aa1f488ba7a90a22b816a"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"61617b6398e0a7b893b9a6dea9709acae02d4992","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            fip for fip in six.itervalues(self.local_floatingips)"},{"line_number":371,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":372,"context_line":"        for floatingip in ips_to_associate:"},{"line_number":373,"context_line":"            self._install_ingress_nat_rules(floatingip)"},{"line_number":374,"context_line":"            self._install_egress_nat_rules(floatingip)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def update_bridge_port(self, lport):"},{"line_number":377,"context_line":"        port_name \u003d lport.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_49196179","line":374,"range":{"start_line":373,"start_character":12,"end_line":374,"end_character":54},"updated":"2016-07-22 06:43:46.000000000","message":"when remote_local_port, you invoke self.local_floatingips.pop(floatingip.get_id(), 0)\nAnd when the port online, it will find nothing in the self.local_floatingips","commit_id":"f626c8e9e7ff84e0ee555435c74e34f9134e93b3"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"ac62a43615853a0e0e50429ae45899490b199b6f","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            fip for fip in six.itervalues(self.local_floatingips)"},{"line_number":371,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":372,"context_line":"        for floatingip in ips_to_associate:"},{"line_number":373,"context_line":"            self._install_ingress_nat_rules(floatingip)"},{"line_number":374,"context_line":"            self._install_egress_nat_rules(floatingip)"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def update_bridge_port(self, lport):"},{"line_number":377,"context_line":"        port_name \u003d lport.get_name()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_0978092b","line":374,"range":{"start_line":373,"start_character":12,"end_line":374,"end_character":54},"in_reply_to":"dada55a8_49196179","updated":"2016-07-22 06:46:12.000000000","message":"remove_local_port","commit_id":"f626c8e9e7ff84e0ee555435c74e34f9134e93b3"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"57ed05c7adcbf17550264bec4741e1d5584ebe60","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":364,"context_line":"        for floatingip in ips_to_disassociate:"},{"line_number":365,"context_line":"            self.delete_floatingip(floatingip)"},{"line_number":366,"context_line":"            self.update_floatingip_status("},{"line_number":367,"context_line":"            floatingip, n_const.FLOATINGIP_STATUS_DOWN)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def add_local_port(self, lport):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_9885615b","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":41},"updated":"2016-07-22 08:31:34.000000000","message":"if floatingip.get_id() in self.local_floatingips:\n    self.local_floatingips.pop(floatingip.get_id())\n\ni think add it will be better","commit_id":"5e7ef1add1fbbc94d562a1d3669b998b71b0a955"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"665cca2a9a460ef88ecc1aefcff97fa8ad206585","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":364,"context_line":"        for floatingip in ips_to_disassociate:"},{"line_number":365,"context_line":"            self.delete_floatingip(floatingip)"},{"line_number":366,"context_line":"            self.update_floatingip_status("},{"line_number":367,"context_line":"            floatingip, n_const.FLOATINGIP_STATUS_DOWN)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def add_local_port(self, lport):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_48dbe51b","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":41},"in_reply_to":"dada55a8_9885615b","updated":"2016-07-23 09:21:32.000000000","message":"@weizj, you could not delete the element here, otherwise when the port online which will invoke the add_local_port below, it will find nothing from self.local_floatingips, that\u0027s why feipeng modify the code here based on last patch.","commit_id":"5e7ef1add1fbbc94d562a1d3669b998b71b0a955"},{"author":{"_account_id":20287,"name":"hujie","email":"mike.hu@huawei.com","username":"hujie"},"change_message_id":"665cca2a9a460ef88ecc1aefcff97fa8ad206585","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            fip for fip in six.itervalues(self.local_floatingips)"},{"line_number":373,"context_line":"            if fip.get_lport_id() \u003d\u003d port_id]"},{"line_number":374,"context_line":"        for floatingip in ips_to_associate:"},{"line_number":375,"context_line":"            self._install_ingress_nat_rules(floatingip)"},{"line_number":376,"context_line":"            self._install_egress_nat_rules(floatingip)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def update_bridge_port(self, lport):"},{"line_number":379,"context_line":"        port_name \u003d lport.get_name()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_88031d76","line":376,"range":{"start_line":375,"start_character":12,"end_line":376,"end_character":54},"updated":"2016-07-23 09:21:32.000000000","message":"suggest you put the two LOC into one method create_floatingip(), because the code appears multi-times.","commit_id":"5e7ef1add1fbbc94d562a1d3669b998b71b0a955"}]}