)]}'
{"devstack/ovs_dpdk_setup.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2d7bd7d1c3a895d0544d5eb68871eea33807bdd7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"PCI_BUS_INFO\u003d`sudo ethtool -i ${DPDK_NIC_NAME} | grep bus-info`"},{"line_number":9,"context_line":"DPDK_PCI_TARGET\u003d${PCI_BUS_INFO#*:}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"OVS_DIR\u003d/usr/local/var/run/openvswitch"},{"line_number":12,"context_line":"OVSDB_SOCK\u003d/usr/local/var/run/openvswitch/db.sock"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# COPY from ovs_setup.sh"},{"line_number":15,"context_line":"function _neutron_ovs_get_dnf {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_1344f918","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":49},"updated":"2016-08-11 10:10:59.000000000","message":"When installed via the package manager, OVS_DIR is /var/run/openvswitch .","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dccf60ec241d5e4de7f0adadcc46a2ea3087fcbd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"PCI_BUS_INFO\u003d`sudo ethtool -i ${DPDK_NIC_NAME} | grep bus-info`"},{"line_number":9,"context_line":"DPDK_PCI_TARGET\u003d${PCI_BUS_INFO#*:}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"OVS_DIR\u003d/usr/local/var/run/openvswitch"},{"line_number":12,"context_line":"OVSDB_SOCK\u003d/usr/local/var/run/openvswitch/db.sock"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# COPY from ovs_setup.sh"},{"line_number":15,"context_line":"function _neutron_ovs_get_dnf {"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_b6da0815","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":49},"in_reply_to":"9ad45d7e_1344f918","updated":"2016-08-12 01:56:50.000000000","message":"Yes, ovs-dpdk will use /usr/local/ by default. So, I redefine these path in this file.","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2d7bd7d1c3a895d0544d5eb68871eea33807bdd7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"OVS_DIR\u003d/usr/local/var/run/openvswitch"},{"line_number":12,"context_line":"OVSDB_SOCK\u003d/usr/local/var/run/openvswitch/db.sock"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# COPY from ovs_setup.sh"},{"line_number":15,"context_line":"function _neutron_ovs_get_dnf {"},{"line_number":16,"context_line":"    if is_fedora; then"},{"line_number":17,"context_line":"        if [ $os_RELEASE -ge 22 ]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_737e151a","line":14,"updated":"2016-08-11 10:10:59.000000000","message":"Why not simply source ovs_setup.sh? It only defines functions. I think if you redefine functions here, they will override those in ovs_setup.","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dccf60ec241d5e4de7f0adadcc46a2ea3087fcbd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"OVS_DIR\u003d/usr/local/var/run/openvswitch"},{"line_number":12,"context_line":"OVSDB_SOCK\u003d/usr/local/var/run/openvswitch/db.sock"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# COPY from ovs_setup.sh"},{"line_number":15,"context_line":"function _neutron_ovs_get_dnf {"},{"line_number":16,"context_line":"    if is_fedora; then"},{"line_number":17,"context_line":"        if [ $os_RELEASE -ge 22 ]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_b6196824","line":14,"in_reply_to":"9ad45d7e_737e151a","updated":"2016-08-12 01:56:50.000000000","message":"I\u0027m not sure if they can be override. I\u0027ll check it, thanks a lot.","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"}],"devstack/ovs_setup.sh":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2d7bd7d1c3a895d0544d5eb68871eea33807bdd7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            fi"},{"line_number":114,"context_line":"        done"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # try to unload openvswitch module from kernel"},{"line_number":117,"context_line":"        #if test -n \"`lsmod | grep openvswitch`\"; then"},{"line_number":118,"context_line":"        #    sudo modprobe -r openvswitch"},{"line_number":119,"context_line":"        #fi"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if is_ubuntu; then"},{"line_number":122,"context_line":"            _neutron_ovs_install_ovs_ubuntu"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_f364c522","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":11},"updated":"2016-08-11 10:10:59.000000000","message":"I think this can be removed entirely.","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dccf60ec241d5e4de7f0adadcc46a2ea3087fcbd","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            fi"},{"line_number":114,"context_line":"        done"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        # try to unload openvswitch module from kernel"},{"line_number":117,"context_line":"        #if test -n \"`lsmod | grep openvswitch`\"; then"},{"line_number":118,"context_line":"        #    sudo modprobe -r openvswitch"},{"line_number":119,"context_line":"        #fi"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        if is_ubuntu; then"},{"line_number":122,"context_line":"            _neutron_ovs_install_ovs_ubuntu"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9ad45d7e_d67e9ce2","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":11},"in_reply_to":"9ad45d7e_f364c522","updated":"2016-08-12 01:56:50.000000000","message":"OK, I will fix it.","commit_id":"28629baeecbb463e48b597add72dfc390620a1de"}],"dragonflow/common/utils.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7ae9cf67511e512c3a3bb078d1c3826fc05470eb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sock_dir,"},{"line_number":40,"context_line":"        # this parameter will become the virtio port name,"},{"line_number":41,"context_line":"        # so it should not exceed IFNAMSIZ(16)."},{"line_number":42,"context_line":"        (n_const.VHOST_USER_DEVICE_PREFIX + port_id)[:14])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def load_driver(driver_cfg, namespace):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_9a7927cb","line":42,"range":{"start_line":42,"start_character":54,"end_line":42,"end_character":56},"updated":"2016-08-01 07:09:56.000000000","message":"why 14?","commit_id":"541a3684fb4bca82bc37b5e40132b73fca54eb38"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"98564df36fda4cacb5f639e65e5b033f5ef99b98","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sock_dir,"},{"line_number":40,"context_line":"        # this parameter will become the virtio port name,"},{"line_number":41,"context_line":"        # so it should not exceed IFNAMSIZ(16)."},{"line_number":42,"context_line":"        (n_const.VHOST_USER_DEVICE_PREFIX + port_id)[:14])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def load_driver(driver_cfg, namespace):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e8302458","line":42,"range":{"start_line":42,"start_character":54,"end_line":42,"end_character":56},"in_reply_to":"bacf61ea_9a7927cb","updated":"2016-08-02 06:21:53.000000000","message":"just copied from neutron ml2 ovs driver.","commit_id":"541a3684fb4bca82bc37b5e40132b73fca54eb38"}],"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7ae9cf67511e512c3a3bb078d1c3826fc05470eb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                portbindings.VIF_TYPE: portbindings.VIF_TYPE_VHOST_USER,"},{"line_number":87,"context_line":"                portbindings.VIF_DETAILS: {"},{"line_number":88,"context_line":"                    # TODO(nick-ma-z): VIF security is disabled for vhu port."},{"line_number":89,"context_line":"                    # This will be revisited if the function is supported by"},{"line_number":90,"context_line":"                    # OVS upstream."},{"line_number":91,"context_line":"                    portbindings.CAP_PORT_FILTER: False,"},{"line_number":92,"context_line":"                    portbindings.VHOST_USER_MODE:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_ba7cebb5","line":89,"range":{"start_line":89,"start_character":48,"end_line":89,"end_character":60},"updated":"2016-08-01 07:09:56.000000000","message":"what function is lacking?","commit_id":"541a3684fb4bca82bc37b5e40132b73fca54eb38"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"98564df36fda4cacb5f639e65e5b033f5ef99b98","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                portbindings.VIF_TYPE: portbindings.VIF_TYPE_VHOST_USER,"},{"line_number":87,"context_line":"                portbindings.VIF_DETAILS: {"},{"line_number":88,"context_line":"                    # TODO(nick-ma-z): VIF security is disabled for vhu port."},{"line_number":89,"context_line":"                    # This will be revisited if the function is supported by"},{"line_number":90,"context_line":"                    # OVS upstream."},{"line_number":91,"context_line":"                    portbindings.CAP_PORT_FILTER: False,"},{"line_number":92,"context_line":"                    portbindings.VHOST_USER_MODE:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e81784a0","line":89,"range":{"start_line":89,"start_character":48,"end_line":89,"end_character":60},"in_reply_to":"bacf61ea_ba7cebb5","updated":"2016-08-02 06:21:53.000000000","message":"conntrack in user space. currently ovs is still working on it, afaik.","commit_id":"541a3684fb4bca82bc37b5e40132b73fca54eb38"}]}