)]}'
{"dragonflow/db/drivers/redis_db_driver.py":[{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"26367ddf02d13cda0bd48b997fe2791435e6d168","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                local_keys \u003d client.keys(local_key)"},{"line_number":67,"context_line":"                if len(local_keys) \u003e 0:"},{"line_number":68,"context_line":"                    for tmp_key in local_keys:"},{"line_number":69,"context_line":"                        self._execute_cmd(\"GET\", tmp_key)"},{"line_number":70,"context_line":"            except Exception:"},{"line_number":71,"context_line":"                LOG.exception(_LE(\"exception when delete_table: \""},{"line_number":72,"context_line":"                                  \"%(key)s \")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_33a09a43","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":46},"updated":"2016-07-28 14:43:47.000000000","message":"not DEL ?","commit_id":"049ec6d784dcf531268f0e373be2eabf8c144589"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"54b921058652d50df787a455429ce2315ffd92b6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                local_keys \u003d client.keys(local_key)"},{"line_number":67,"context_line":"                if len(local_keys) \u003e 0:"},{"line_number":68,"context_line":"                    for tmp_key in local_keys:"},{"line_number":69,"context_line":"                        self._execute_cmd(\"GET\", tmp_key)"},{"line_number":70,"context_line":"            except Exception:"},{"line_number":71,"context_line":"                LOG.exception(_LE(\"exception when delete_table: \""},{"line_number":72,"context_line":"                                  \"%(key)s \")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_832a748e","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":46},"in_reply_to":"bacf61ea_33a09a43","updated":"2016-07-31 07:16:36.000000000","message":"You are right !","commit_id":"049ec6d784dcf531268f0e373be2eabf8c144589"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3f3046c68da1a7d9d495c8d67b510f3b07f138d1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                if len(local_keys) \u003e 0:"},{"line_number":68,"context_line":"                    for tmp_key in local_keys:"},{"line_number":69,"context_line":"                        self._execute_cmd(\"DEL\", tmp_key)"},{"line_number":70,"context_line":"        except Exception:"},{"line_number":71,"context_line":"            LOG.exception(_LE(\"exception when delete_table: \""},{"line_number":72,"context_line":"                              \"%(key)s \")"},{"line_number":73,"context_line":"                              % {\u0027key\u0027: local_key})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8349d4b9","line":70,"updated":"2016-07-31 06:45:25.000000000","message":"When can these exceptions occur? If an exception is raised, the rest of the delete_table command is ignored. Maybe have the try...except block only on the inner loops? (or one over the \u0027client.keys\u0027 command, and one over the self._execute_cmd command?","commit_id":"5b9f6174b55ac4fdf3ea69df4ef785c21f211cff"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"86faf1c7f8d1582b782e43622916578b76c89b2a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                if len(local_keys) \u003e 0:"},{"line_number":68,"context_line":"                    for tmp_key in local_keys:"},{"line_number":69,"context_line":"                        self._execute_cmd(\"DEL\", tmp_key)"},{"line_number":70,"context_line":"        except Exception:"},{"line_number":71,"context_line":"            LOG.exception(_LE(\"exception when delete_table: \""},{"line_number":72,"context_line":"                              \"%(key)s \")"},{"line_number":73,"context_line":"                              % {\u0027key\u0027: local_key})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_cb28b088","line":70,"in_reply_to":"bacf61ea_8349d4b9","updated":"2016-08-02 10:11:30.000000000","message":"Done","commit_id":"5b9f6174b55ac4fdf3ea69df4ef785c21f211cff"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3f3046c68da1a7d9d495c8d67b510f3b07f138d1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        except Exception:"},{"line_number":71,"context_line":"            LOG.exception(_LE(\"exception when delete_table: \""},{"line_number":72,"context_line":"                              \"%(key)s \")"},{"line_number":73,"context_line":"                              % {\u0027key\u0027: local_key})"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _handle_db_conn_error(self, ip_port, local_key\u003dNone):"},{"line_number":76,"context_line":"        self.redis_mgt.remove_node_from_master_list(ip_port)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_23cf482a","line":73,"updated":"2016-07-31 06:45:25.000000000","message":"Don\u0027t use % here. Pass local_key as a parameter to LOG.exception, and let it do the formatting.","commit_id":"5b9f6174b55ac4fdf3ea69df4ef785c21f211cff"}]}