)]}'
{"dragonflow/controller/dhcp_app.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0c31df5b2ddf64217feb1afcf51caa11f1eb7e5d","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            dns_bin +\u003d addrconv.ipv4.text_to_bin(address)"},{"line_number":280,"context_line":"        return dns_bin"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _get_host_routes_list_bin(self, subnet, port_ip):"},{"line_number":283,"context_line":"        host_routes \u003d subnet.get_host_routes()"},{"line_number":284,"context_line":"        # Add route for metadata request."},{"line_number":285,"context_line":"        host_routes.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_659fe250","line":282,"updated":"2016-08-21 09:03:01.000000000","message":"Consider passing the lport, and not the IP. This way, if additional information is needed in future, this doesn\u0027t have to change. If the information is not needed (e.g. disabled by configuration), then the get_ip method call can be skipped.","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ae818937f20e411c5987c45c98721de103a60873","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            dns_bin +\u003d addrconv.ipv4.text_to_bin(address)"},{"line_number":280,"context_line":"        return dns_bin"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _get_host_routes_list_bin(self, subnet, port_ip):"},{"line_number":283,"context_line":"        host_routes \u003d subnet.get_host_routes()"},{"line_number":284,"context_line":"        # Add route for metadata request."},{"line_number":285,"context_line":"        host_routes.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e515929b","line":282,"in_reply_to":"1ac06dbe_659fe250","updated":"2016-08-21 09:23:40.000000000","message":"Done","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0c31df5b2ddf64217feb1afcf51caa11f1eb7e5d","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def _get_host_routes_list_bin(self, subnet, port_ip):"},{"line_number":283,"context_line":"        host_routes \u003d subnet.get_host_routes()"},{"line_number":284,"context_line":"        # Add route for metadata request."},{"line_number":285,"context_line":"        host_routes.append("},{"line_number":286,"context_line":"            {\u0027destination\u0027: \u0027%s/32\u0027 % const.METADATA_SERVICE_IP,"},{"line_number":287,"context_line":"             \u0027nexthop\u0027: port_ip})"},{"line_number":288,"context_line":"        routes_bin \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_0590ae42","line":285,"updated":"2016-08-21 09:03:01.000000000","message":"I am not sure this is correct... the link local address should be set by the VM, not applied via DHCP.\n\nIt has to at least have a configuration option, so it can be disabled/enabled according to the administrator.\n\nI\u0027d be happy to hear comments about this.","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ae818937f20e411c5987c45c98721de103a60873","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def _get_host_routes_list_bin(self, subnet, port_ip):"},{"line_number":283,"context_line":"        host_routes \u003d subnet.get_host_routes()"},{"line_number":284,"context_line":"        # Add route for metadata request."},{"line_number":285,"context_line":"        host_routes.append("},{"line_number":286,"context_line":"            {\u0027destination\u0027: \u0027%s/32\u0027 % const.METADATA_SERVICE_IP,"},{"line_number":287,"context_line":"             \u0027nexthop\u0027: port_ip})"},{"line_number":288,"context_line":"        routes_bin \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_05138eb9","line":285,"in_reply_to":"1ac06dbe_0590ae42","updated":"2016-08-21 09:23:40.000000000","message":"In my env, the route to link local address will not always be set by VM. The ubuntu 1604 VM will have the route by default, the fedora 24 and cirros will not have this route. So I think it is not a sure thing to have this route in VM.\nI think it is reasonable to have a configuration for this route. will add it.","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"}],"dragonflow/tests/unit/test_dhcp_app.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"0c31df5b2ddf64217feb1afcf51caa11f1eb7e5d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TestDHCPApp, self).setUp()"},{"line_number":28,"context_line":"        self.app \u003d dhcp_app.DHCPApp(mock.Mock())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_host_route_include_metadata_route(self):"},{"line_number":31,"context_line":"        mock_subnet \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        mock_subnet.get_host_routes \u003d mock.Mock(return_value\u003d[])"},{"line_number":33,"context_line":"        port_ip \u003d \"10.0.0.3\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_25b4cacf","line":30,"updated":"2016-08-21 09:03:01.000000000","message":"This test is very tightly-bound to the implementation. Is there a more general way to do it? e.g. parse the dhcp response and verify the metadata service ip is there (possibly best?), or use assertIn to see if the IP is encoded in the string?","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ae818937f20e411c5987c45c98721de103a60873","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        super(TestDHCPApp, self).setUp()"},{"line_number":28,"context_line":"        self.app \u003d dhcp_app.DHCPApp(mock.Mock())"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def test_host_route_include_metadata_route(self):"},{"line_number":31,"context_line":"        mock_subnet \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        mock_subnet.get_host_routes \u003d mock.Mock(return_value\u003d[])"},{"line_number":33,"context_line":"        port_ip \u003d \"10.0.0.3\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_a5739a14","line":30,"in_reply_to":"1ac06dbe_25b4cacf","updated":"2016-08-21 09:23:40.000000000","message":"Will modify the test case in next PS.","commit_id":"771375bd0ecfd7ecaa76f0d14cd91d356f5701b5"}]}