)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"02eaf2f7ca5c66d654b9e30a9b6c298a5207976b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-08-30 09:02:41 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix bug with handling of dhcp address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1615351"},{"line_number":10,"context_line":"Change-Id: I61d27c06b4407627202f50ba8271e56f81e5bd00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa7ab95a_474959b6","line":8,"updated":"2016-08-30 09:45:38.000000000","message":"Please add a short description of the bug and how you solve it in this patch.","commit_id":"bb151bdb1f0c0d97b2ec9ac207f9e049d5fe22f4"}],"dragonflow/neutron/ml2/mech_driver.py":[{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"771d9c4a1baf6698e98207960094675ba57f76a1","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return port"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":291,"context_line":"        \"\"\"Create the dhcp configration for the subnet if required."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Returns the dhcp ip and dhcp server port (if created)."},{"line_number":294,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_c301ef07","line":291,"range":{"start_line":291,"start_character":27,"end_line":291,"end_character":39},"updated":"2016-08-30 02:57:41.000000000","message":"typo: should be configuration\nI know it\u0027s not your fault, you can correct it by the way.","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9ca43b03029132335ec00e1e9c5e7a0c96d32b24","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        return port"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":291,"context_line":"        \"\"\"Create the dhcp configration for the subnet if required."},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        Returns the dhcp ip and dhcp server port (if created)."},{"line_number":294,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_2d38c43c","line":291,"range":{"start_line":291,"start_character":27,"end_line":291,"end_character":39},"in_reply_to":"fa7ab95a_c301ef07","updated":"2016-08-30 05:57:49.000000000","message":"Done","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"771d9c4a1baf6698e98207960094675ba57f76a1","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            else:"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"                dhcp_port \u003d self._create_dhcp_server_port(context, subnet)"},{"line_number":301,"context_line":"                dhcp_ip \u003d self._get_ip_from_port(dhcp_port)"},{"line_number":302,"context_line":"                return dhcp_ip, dhcp_port"},{"line_number":303,"context_line":"        return None, None"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_a6b79938","line":301,"range":{"start_line":301,"start_character":16,"end_line":301,"end_character":59},"updated":"2016-08-30 02:57:41.000000000","message":"This line is loosely related with the function. I think you can put it in the caller and keep this function and _handle_update_subnet_dhcp unchanged.","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9ca43b03029132335ec00e1e9c5e7a0c96d32b24","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            else:"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"                dhcp_port \u003d self._create_dhcp_server_port(context, subnet)"},{"line_number":301,"context_line":"                dhcp_ip \u003d self._get_ip_from_port(dhcp_port)"},{"line_number":302,"context_line":"                return dhcp_ip, dhcp_port"},{"line_number":303,"context_line":"        return None, None"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_6daf2c2a","line":301,"range":{"start_line":301,"start_character":16,"end_line":301,"end_character":59},"in_reply_to":"fa7ab95a_a6b79938","updated":"2016-08-30 05:57:49.000000000","message":"create_subnet_postcommit() function before this patch was expecting to receive port from this function and afterwards it was extracting ip from it.\nif subnet[\u0027enable_dhcp\u0027]:\n  if cfg.CONF.df.use_centralized_ipv6_DHCP:\n    return subnet[\u0027allocation_pools\u0027][0][\u0027start\u0027]\nThis patch is to fix a bug when port object is not created and instead we return an IP address.\nAs a result, we return ip together with port object (in case it was created).","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"},{"author":{"_account_id":20297,"name":"duankebo","email":"duankebo@huawei.com","username":"duankebo"},"change_message_id":"771d9c4a1baf6698e98207960094675ba57f76a1","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        core_plugin.delete_port(context, port[\u0027id\u0027])"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def _handle_update_subnet_dhcp(self, context, old_subnet, new_subnet):"},{"line_number":375,"context_line":"        \"\"\"Update the dhcp configration for."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        Returns the dhcp ip if exists and optionaly value of dhcp server port"},{"line_number":378,"context_line":"        if this port was created."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_e64e016e","line":375,"range":{"start_line":375,"start_character":27,"end_line":375,"end_character":39},"updated":"2016-08-30 02:57:41.000000000","message":"Correct this one too.","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"9ca43b03029132335ec00e1e9c5e7a0c96d32b24","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        core_plugin.delete_port(context, port[\u0027id\u0027])"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def _handle_update_subnet_dhcp(self, context, old_subnet, new_subnet):"},{"line_number":375,"context_line":"        \"\"\"Update the dhcp configration for."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        Returns the dhcp ip if exists and optionaly value of dhcp server port"},{"line_number":378,"context_line":"        if this port was created."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_ad7cd4b5","line":375,"range":{"start_line":375,"start_character":27,"end_line":375,"end_character":39},"in_reply_to":"fa7ab95a_e64e016e","updated":"2016-08-30 05:57:49.000000000","message":"Done","commit_id":"87fa884e8d7d8233865e2bb28a1b66f2cae8f62c"}],"dragonflow/neutron/plugin.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0d079a474b2723c6235be5408604565572313b73","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                new_subnet \u003d super(DFPlugin,"},{"line_number":327,"context_line":"                                   self).create_subnet(context, subnet)"},{"line_number":328,"context_line":"                dhcp_ip, dhcp_port \u003d self._handle_create_subnet_dhcp("},{"line_number":329,"context_line":"                                     context, new_subnet)"},{"line_number":330,"context_line":"                network_version \u003d version_db._update_db_version_row("},{"line_number":331,"context_line":"                        context.session, net_id)"},{"line_number":332,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_acd31903","line":329,"range":{"start_line":329,"start_character":0,"end_line":329,"end_character":57},"updated":"2016-08-23 12:22:44.000000000","message":"The idention here looks not right, maybe you should not change it.","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"249977b5b5ad4f827b1237aa44cabfe6c4ccf7ed","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                new_subnet \u003d super(DFPlugin,"},{"line_number":327,"context_line":"                                   self).create_subnet(context, subnet)"},{"line_number":328,"context_line":"                dhcp_ip, dhcp_port \u003d self._handle_create_subnet_dhcp("},{"line_number":329,"context_line":"                                     context, new_subnet)"},{"line_number":330,"context_line":"                network_version \u003d version_db._update_db_version_row("},{"line_number":331,"context_line":"                        context.session, net_id)"},{"line_number":332,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_349e1007","line":329,"range":{"start_line":329,"start_character":0,"end_line":329,"end_character":57},"in_reply_to":"1ac06dbe_acd31903","updated":"2016-08-24 07:58:05.000000000","message":"I can revert this.","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0d079a474b2723c6235be5408604565572313b73","unresolved":false,"context_lines":[{"line_number":993,"context_line":"            port \u003d self._create_dhcp_server_port(context, new_subnet)"},{"line_number":994,"context_line":"            dhcp_ip \u003d self._get_ip_from_port(port)"},{"line_number":995,"context_line":"            return dhcp_ip, port"},{"line_number":996,"context_line":"        if port:"},{"line_number":997,"context_line":"            dhcp_ip \u003d self._get_ip_from_port(port)"},{"line_number":998,"context_line":"        return dhcp_ip, None"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":1001,"context_line":"        \"\"\"Create the dhcp configration for the subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_ccfe55ad","line":998,"range":{"start_line":996,"start_character":8,"end_line":998,"end_character":28},"updated":"2016-08-23 12:22:44.000000000","message":"This will return dhcp_port as None, even if it is not, is that correct?","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"249977b5b5ad4f827b1237aa44cabfe6c4ccf7ed","unresolved":false,"context_lines":[{"line_number":993,"context_line":"            port \u003d self._create_dhcp_server_port(context, new_subnet)"},{"line_number":994,"context_line":"            dhcp_ip \u003d self._get_ip_from_port(port)"},{"line_number":995,"context_line":"            return dhcp_ip, port"},{"line_number":996,"context_line":"        if port:"},{"line_number":997,"context_line":"            dhcp_ip \u003d self._get_ip_from_port(port)"},{"line_number":998,"context_line":"        return dhcp_ip, None"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":1001,"context_line":"        \"\"\"Create the dhcp configration for the subnet"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_9448a4b4","line":998,"range":{"start_line":996,"start_character":8,"end_line":998,"end_character":28},"in_reply_to":"1ac06dbe_ccfe55ad","updated":"2016-08-24 07:58:05.000000000","message":"Yes, parent function will try to delete this port on failure.\nSo, I do not return here the port object just the ip.","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0d079a474b2723c6235be5408604565572313b73","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":1001,"context_line":"        \"\"\"Create the dhcp configration for the subnet"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        Returns the dhcp server port if configured"},{"line_number":1004,"context_line":"        \"\"\""},{"line_number":1005,"context_line":"        if subnet[\u0027enable_dhcp\u0027]:"},{"line_number":1006,"context_line":"            if cfg.CONF.df.use_centralized_ipv6_DHCP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_2cbc49db","line":1003,"range":{"start_line":1003,"start_character":8,"end_line":1003,"end_character":50},"updated":"2016-08-23 12:22:44.000000000","message":"Should the docstring be updated?","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":18903,"name":"Yuli","email":"stremovsky@gmail.com","username":"yuli"},"change_message_id":"249977b5b5ad4f827b1237aa44cabfe6c4ccf7ed","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"    def _handle_create_subnet_dhcp(self, context, subnet):"},{"line_number":1001,"context_line":"        \"\"\"Create the dhcp configration for the subnet"},{"line_number":1002,"context_line":""},{"line_number":1003,"context_line":"        Returns the dhcp server port if configured"},{"line_number":1004,"context_line":"        \"\"\""},{"line_number":1005,"context_line":"        if subnet[\u0027enable_dhcp\u0027]:"},{"line_number":1006,"context_line":"            if cfg.CONF.df.use_centralized_ipv6_DHCP:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_14d314d6","line":1003,"range":{"start_line":1003,"start_character":8,"end_line":1003,"end_character":50},"in_reply_to":"1ac06dbe_2cbc49db","updated":"2016-08-24 07:58:05.000000000","message":"You are right!","commit_id":"c2bc05480342b1dd014864cf114529fedf288e72"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"58594e86b59e7ff2f55ae3650ee7dde3c2de49e3","unresolved":false,"context_lines":[{"line_number":973,"context_line":"    def _update_subnet_dhcp(self, context, old_subnet, new_subnet):"},{"line_number":974,"context_line":"        \"\"\"Update the dhcp configration for."},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"        Returns the dhcp server port if configured"},{"line_number":977,"context_line":"        \"\"\""},{"line_number":978,"context_line":"        dhcp_ip \u003d None"},{"line_number":979,"context_line":"        if cfg.CONF.df.use_centralized_ipv6_DHCP:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_3287a7d8","line":976,"range":{"start_line":976,"start_character":8,"end_line":976,"end_character":50},"updated":"2016-08-27 08:16:09.000000000","message":"Sorry, I miss to point out this place in my last comment. I think this comment deserve an update.","commit_id":"7c22b8344db362ded6ec159f1d0cf892ce684e8d"}]}