)]}'
{"devstack/redis_driver":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"249265088440e54e6a44e8e242c966e443ea1060","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_GIT \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a89bdaa_25e0c395","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":33},"updated":"2016-09-08 09:45:37.000000000","message":"Is redis installed from git? If not, the name here confuse me.","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"ded64c8fc5fd40381038021fa5db947976fc1186","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_GIT \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_1113d60e","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":43},"updated":"2016-08-31 01:50:02.000000000","message":"suggest to keep is_service_enabled and False -\u003e True!!","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"7cbdbeb8f8699669609661ed37b4cb00bb133f13","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_GIT \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_2b1bbe81","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":43},"in_reply_to":"fa7ab95a_1113d60e","updated":"2016-09-01 01:05:22.000000000","message":"May I ask why we need is_service_enabled ? IMHO, is_service_enabled is called in plugin.sh before nb_db_driver_install_server is called, so we need don\u0027t need call it again\n\nI will fix False -\u003e True","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f754ad34198fe44f0a59c2cf471fa27117dce849","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_GIT \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_a84c3177","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":43},"in_reply_to":"fa7ab95a_2b1bbe81","updated":"2016-09-01 01:23:15.000000000","message":"Got it. No problem.","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"ded64c8fc5fd40381038021fa5db947976fc1186","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_f10d92e9","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"updated":"2016-08-31 01:50:02.000000000","message":"Firstly you need to make sure the ubuntu and fedora distro supports redis-cluster. AFAIK, you have to specify the distro versions which it support redis 3.0+.","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"7cbdbeb8f8699669609661ed37b4cb00bb133f13","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_06050fc1","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"fa7ab95a_163c772e","updated":"2016-09-01 01:05:22.000000000","message":"I will fix it","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"8926aea83c975a5533ed9e4199a6e02971b6ab60","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a89bdaa_7e7d7bb0","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"fa7ab95a_686229da","updated":"2016-09-06 09:39:22.000000000","message":"Sorry, I did not make it clear. I meant when OVS_INSTALL_FROM_GIT is False(I mentioned it as True by mistake in my last comment), we do not specify ovs version.\nAnd we can specify a version of ovs or redis when we are using yum or apt-get to install them","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f754ad34198fe44f0a59c2cf471fa27117dce849","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_686229da","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"fa7ab95a_e68bcb66","updated":"2016-09-01 01:23:15.000000000","message":"OVS_INSTALL_FROM_GIT specifies OVS branch to make sure we use the right version and it also only installs development tools packages from distro of which the name is consistent among all the versions.\n\nYou can use lsb tools to obtain the current distro version. And I also reminded that there were some similar functions which has been implemented in devstack script.\n\nHere it is.\nhttps://github.com/openstack/dragonflow/blob/master/devstack/zookeeper_driver#L14-L16","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"df51cf63b59d271c75710309b737418226061fd6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_163c772e","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"fa7ab95a_f10d92e9","updated":"2016-08-31 17:05:00.000000000","message":"Additionally, why use real_install_package and not install_package?","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"7cbdbeb8f8699669609661ed37b4cb00bb133f13","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa7ab95a_e68bcb66","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"fa7ab95a_f10d92e9","updated":"2016-09-01 01:05:22.000000000","message":"Yes ,you\u0027re reght. But I don\u0027t find a way to assign a range of distro versions, like \u003e\u003d3.0, for both yum and apt-get. (apt-get only support assign a specific version with \u0027\u003d\u0027, but not \u0027\u003e\u0027). Any idea?\nIn addition, I think ovs has the same problem when enable OVS_INSTALL_FROM_GIT\u003dTrue, right ?","commit_id":"832cc1a0b0de96962ce60fcf40570114ec8148cd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"140f30fdcbef723eb713dd91859bc04ea4fd8c29","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_RUBY \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_1ee6ea14","line":49,"range":{"start_line":49,"start_character":39,"end_line":49,"end_character":44},"updated":"2016-09-13 00:44:29.000000000","message":"True?","commit_id":"8c7531705e4ecd47c42be36f5abcdddc3eb0aee8"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"bd127f04aa96748b53d75a4c0bb1c4a43ab3e054","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_RUBY \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_f95fa03e","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":45},"updated":"2016-09-13 01:43:19.000000000","message":"if you want to close install from source code. please make sure you yum or apt-get install will get right version of redis for cluster support","commit_id":"8c7531705e4ecd47c42be36f5abcdddc3eb0aee8"},{"author":{"_account_id":9044,"name":"Will","email":"wangjian.ika@bytedance.com","username":"Will"},"change_message_id":"c7f8d9eddd73ef16605773a72c2adb2dba5ad393","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_RUBY \u003d\u003d \"False\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_8e000704","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":45},"in_reply_to":"9a89bdaa_f95fa03e","updated":"2016-09-13 04:54:03.000000000","message":"we don\u0027t guarantee the version of redis. if users decide to use yum to install redis, they should guarantee their repos contain the proper softwares. We don\u0027t guarantee the version of ovs either, when dragonflow or neutron installs it","commit_id":"8c7531705e4ecd47c42be36f5abcdddc3eb0aee8"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"140f30fdcbef723eb713dd91859bc04ea4fd8c29","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_9e959a34","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":31},"updated":"2016-09-13 00:44:29.000000000","message":"It looks like real_install_package is not commonly used, even by devstack. When not just use install_package?","commit_id":"8c7531705e4ecd47c42be36f5abcdddc3eb0aee8"},{"author":{"_account_id":20298,"name":"feipeng","email":"feipeng1@huawei.com","username":"feipeng"},"change_message_id":"bd127f04aa96748b53d75a4c0bb1c4a43ab3e054","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           real_install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           real_install_package -y redis"},{"line_number":95,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_7400f701","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":31},"updated":"2016-09-13 01:43:19.000000000","message":"not see this function real_install_package","commit_id":"8c7531705e4ecd47c42be36f5abcdddc3eb0aee8"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"691108c79db9bcc8a058937d355c84f02a05429d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"function nb_db_driver_install_server {"},{"line_number":47,"context_line":"    sudo pip install crc16"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if $DF_REDIS_INSTALL_FROM_RUBY \u003d\u003d \"True\"; then"},{"line_number":50,"context_line":"        echo \"Installing rediscluster\""},{"line_number":51,"context_line":"        if [ ! -f \"$DEST/redis/redis-$REDIS_VERSION/redis\" ]; then"},{"line_number":52,"context_line":"            mkdir -p $DEST/redis"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a89bdaa_14a16646","line":49,"updated":"2016-09-13 06:13:41.000000000","message":"I think this should be if [ \"$...\" \u003d\u003d \"True\" ]; then .","commit_id":"37015710d126916b96c372943c88cb616ff84ea1"},{"author":{"_account_id":23235,"name":"Lihi Wishnitzer","email":"lihiwish@gmail.com","username":"lihiwish"},"change_message_id":"c94efdf47eb9af3819bbf5f5ba048bbc872be14d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_0820089b","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"updated":"2016-09-13 20:33:36.000000000","message":"Shouldn\u0027t you check if the service enabled before installing?\n(if is_service_enabled df-redis-server ; then)","commit_id":"dbde63b9e02f48d717fc74f41155f8a07b75b69e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"c33a38d48caae33ba8f20a241bd40636b9cbaa1d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            popd"},{"line_number":89,"context_line":"        fi"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        if is_ubuntu; then"},{"line_number":92,"context_line":"           install_package -y redis-server"},{"line_number":93,"context_line":"        elif is_fedora; then"},{"line_number":94,"context_line":"           install_package -y redis"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":"    fi"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a8ec9b2_ecc68915","line":95,"range":{"start_line":91,"start_character":8,"end_line":95,"end_character":10},"in_reply_to":"7a8ec9b2_0820089b","updated":"2016-09-14 00:34:35.000000000","message":"I don\u0027t think so, if this function can be called, the redis must already be enabled. see https://github.com/openstack/dragonflow/blob/3a9970bfb3dc4841d0e28d14963495972c326901/devstack/plugin.sh#L89","commit_id":"dbde63b9e02f48d717fc74f41155f8a07b75b69e"}]}