)]}'
{"devstack/ovs_setup.sh":[{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"d3f268cc1602dc5584663399aa75cbb7d0667818","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                break"},{"line_number":116,"context_line":"            fi"},{"line_number":117,"context_line":"        done"},{"line_number":118,"context_line":"        if [ \"$_is_ovs_installed\" \u003d true ]; then"},{"line_number":119,"context_line":"            cleanup_ovs"},{"line_number":120,"context_line":"            stop_ovs"},{"line_number":121,"context_line":"            uninstall_ovs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_442077f7","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":10},"updated":"2016-09-08 04:08:53.000000000","message":"add a blank line is better","commit_id":"ae74df5331c017d128a5149ecef0150c12a10342"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ef9c376884f404b4436b86f2ddb6c6b8fdd6dd4f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                break"},{"line_number":116,"context_line":"            fi"},{"line_number":117,"context_line":"        done"},{"line_number":118,"context_line":"        if [ \"$_is_ovs_installed\" \u003d true ]; then"},{"line_number":119,"context_line":"            cleanup_ovs"},{"line_number":120,"context_line":"            stop_ovs"},{"line_number":121,"context_line":"            uninstall_ovs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a89bdaa_79599d34","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":10},"in_reply_to":"9a89bdaa_442077f7","updated":"2016-09-08 06:32:41.000000000","message":"I am not a master of shell script. But, to be honest, I don\u0027t think so. The for block and the if block here are both for the same functionality, they should not be separated.","commit_id":"ae74df5331c017d128a5149ecef0150c12a10342"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"f9ed49e6f017df00c7d6b2ff415916d368eef904","unresolved":false,"context_lines":[{"line_number":234,"context_line":"         sudo ovs-dpctl del-dp $dp"},{"line_number":235,"context_line":"    fi"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    for module in vport_geneve openvswitch; do"},{"line_number":238,"context_line":"        if [[ $(lsmod | grep $module) ]]; then"},{"line_number":239,"context_line":"            sudo rmmod $module"},{"line_number":240,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a89bdaa_9328fa9b","line":237,"range":{"start_line":237,"start_character":18,"end_line":237,"end_character":30},"updated":"2016-09-08 08:57:44.000000000","message":"what if someone set tunnel protocol to vxlan?","commit_id":"e9df649c2ae0128f6eca6b9f8522d359836a48dc"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"802dd3a3030dfedae3af62a5219734744c943cd8","unresolved":false,"context_lines":[{"line_number":234,"context_line":"         sudo ovs-dpctl del-dp $dp"},{"line_number":235,"context_line":"    fi"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    for module in vport_geneve openvswitch; do"},{"line_number":238,"context_line":"        if [[ $(lsmod | grep $module) ]]; then"},{"line_number":239,"context_line":"            sudo rmmod $module"},{"line_number":240,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a89bdaa_902f793d","line":237,"range":{"start_line":237,"start_character":18,"end_line":237,"end_character":30},"in_reply_to":"9a89bdaa_02fc953c","updated":"2016-09-12 09:32:40.000000000","message":"Get it, then we can submit another patch to manage other situations. By default, I\u0027m using vxlan :-)","commit_id":"e9df649c2ae0128f6eca6b9f8522d359836a48dc"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"46fab1ba62a64338195798e33b92bbbf862e894d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"         sudo ovs-dpctl del-dp $dp"},{"line_number":235,"context_line":"    fi"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    for module in vport_geneve openvswitch; do"},{"line_number":238,"context_line":"        if [[ $(lsmod | grep $module) ]]; then"},{"line_number":239,"context_line":"            sudo rmmod $module"},{"line_number":240,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a89bdaa_02fc953c","line":237,"range":{"start_line":237,"start_character":18,"end_line":237,"end_character":30},"in_reply_to":"9a89bdaa_9328fa9b","updated":"2016-09-08 09:28:29.000000000","message":"I have no idea about it. The code change here is just to make it pass the stack.sh. The functionality has not been changed here.","commit_id":"e9df649c2ae0128f6eca6b9f8522d359836a48dc"}]}